From d34cd0a1b88269a0e4c06d2e225fdd0fc85dd47a Mon Sep 17 00:00:00 2001 From: Tony Murray Date: Thu, 8 Apr 2021 04:17:53 -0500 Subject: [PATCH] Fix ports table when unpolled ports exist (#12722) * Fix ports table when unpolled ports exist * fix another divide by 0 --- includes/html/print-map.inc.php | 4 ++-- includes/html/table/ports.inc.php | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/html/print-map.inc.php b/includes/html/print-map.inc.php index f335cf82c0..fa93ce5896 100644 --- a/includes/html/print-map.inc.php +++ b/includes/html/print-map.inc.php @@ -270,8 +270,8 @@ foreach ($list as $items) { } else { $width = round(0.77 * pow($speed, 0.25)); } - $link_in_used = ($items['local_ifinoctets_rate'] * 8) / $items['local_ifspeed'] * 100; - $link_out_used = ($items['local_ifoutoctets_rate'] * 8) / $items['local_ifspeed'] * 100; + $link_in_used = $items['local_ifspeed'] ? (($items['local_ifinoctets_rate'] * 8) / $items['local_ifspeed'] * 100) : 0; + $link_out_used = $items['local_ifspeed'] ? (($items['local_ifoutoctets_rate'] * 8) / $items['local_ifspeed'] * 100) : 0; if ($link_in_used > $link_out_used) { $link_used = $link_in_used; } else { diff --git a/includes/html/table/ports.inc.php b/includes/html/table/ports.inc.php index 3d4fc858ec..eaaee25831 100644 --- a/includes/html/table/ports.inc.php +++ b/includes/html/table/ports.inc.php @@ -190,8 +190,8 @@ foreach (dbFetchRows($query, $param) as $port) { 'ifOutOctets_rate' => $port['ifOutOctets_rate'] * 8, 'ifInUcastPkts_rate' => $port['ifInUcastPkts_rate'], 'ifOutUcastPkts_rate' => $port['ifOutUcastPkts_rate'], - 'ifInErrors' => \LibreNMS\Util\Number::formatSi($port['ifInErrors_delta'] / $port['poll_period'], 2, 3, 'EPS'), - 'ifOutErrors' => \LibreNMS\Util\Number::formatSi($port['ifOutErrors_delta'] / $port['poll_period'], 2, 3, 'EPS'), + 'ifInErrors' => $port['poll_period'] ? \LibreNMS\Util\Number::formatSi($port['ifInErrors_delta'] / $port['poll_period'], 2, 3, 'EPS') : '', + 'ifOutErrors' => $port['poll_period'] ? \LibreNMS\Util\Number::formatSi($port['ifOutErrors_delta'] / $port['poll_period'], 2, 3, 'EPS') : '', 'ifType' => \LibreNMS\Util\Rewrite::normalizeIfType($port['ifType']), 'ifAlias' => $port['ifAlias'], 'actions' => $actions,