mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: Move install to php53 branch if running an unsupported version of PHP (#8042)

Browse Source 
* Move install to php53 branch if running an unsupport version of PHP

* Update validate

* Move PHP version check after update check.  This will prevent us from moving no update users to the php53 branch.

Hopefully if daily.php -f update fails it returns a non-zero and we can move them to the php53 branch still.

* Wiggle things around more.

* Also, send release installs to the php53 branch.

* Set notification error for old PHP version.
This commit is contained in:
Tony Murray
2018-01-10 08:40:58 -06:00
committed by Neil Lathwood
parent 2fb8dd7904
commit d515f5043e
5 changed files with 153 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
LibreNMS/Validations/Php.php
View File

@@ -53,7 +53,7 @@ class Php implements ValidationGroup
// if update is not set to false and version is min or newer
if (Config::get('update') && version_compare(PHP_VERSION, $min_version, '<')) {
$validator->warn('PHP version 5.6.4 will be the minimum supported version on January 10, 2018. We recommend you update to PHP a supported version of PHP (7.1 suggested) to continue to receive updates. If you do not update PHP, LibreNMS will continue to function but stop receiving bug fixes and updates.');
$validator->warn('PHP version 5.6.4 is the minimum supported version as of January 10, 2018. We recommend you update to PHP a supported version of PHP (7.1 suggested) to continue to receive updates. If you do not update PHP, LibreNMS will continue to function but stop receiving bug fixes and updates.');
}
}

15
LibreNMS/Validations/Updates.php
View File

@@ -62,10 +62,17 @@ class Updates implements ValidationGroup
}
if ($versions['local_branch'] != 'master') {
$validator->warn(
"Your local git branch is not master, this will prevent automatic updates.",
"You can switch back to master with git checkout master"
);
if ($versions['local_branch'] == 'php53') {
$validator->warn(
"You are on the PHP 5.3 support branch, this will prevent automatic updates.",
"Update to PHP 5.6.4 or newer (PHP 7.1 recommended) to continue to receive updates."
);
} else {
$validator->warn(
"Your local git branch is not master, this will prevent automatic updates.",
"You can switch back to master with git checkout master"
);
}
}
}