mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
Fix coding style part 2
This commit is contained in:
Job Snijders
@@ -1,225 +1,240 @@
|
||||
<?php
|
||||
|
||||
if ($_POST['editing'])
|
||||
{
|
||||
if ($_SESSION['userlevel'] > "7")
|
||||
{
|
||||
$community = mres($_POST['community']);
|
||||
$snmpver = mres($_POST['snmpver']);
|
||||
$transport = $_POST['transport'] ? mres($_POST['transport']) : $transport = "udp";
|
||||
$port = $_POST['port'] ? mres($_POST['port']) : $config['snmp']['port'];
|
||||
$timeout = mres($_POST['timeout']);
|
||||
$retries = mres($_POST['retries']);
|
||||
$poller_group = mres($_POST['poller_group']);
|
||||
$v3 = array (
|
||||
'authlevel' => mres($_POST['authlevel']),
|
||||
'authname' => mres($_POST['authname']),
|
||||
'authpass' => mres($_POST['authpass']),
|
||||
'authalgo' => mres($_POST['authalgo']),
|
||||
'cryptopass' => mres($_POST['cryptopass']),
|
||||
'cryptoalgo' => mres($_POST['cryptoalgo'])
|
||||
);
|
||||
if ($_POST['editing']) {
|
||||
if ($_SESSION['userlevel'] > '7') {
|
||||
$community = mres($_POST['community']);
|
||||
$snmpver = mres($_POST['snmpver']);
|
||||
$transport = $_POST['transport'] ? mres($_POST['transport']) : $transport = 'udp';
|
||||
$port = $_POST['port'] ? mres($_POST['port']) : $config['snmp']['port'];
|
||||
$timeout = mres($_POST['timeout']);
|
||||
$retries = mres($_POST['retries']);
|
||||
$poller_group = mres($_POST['poller_group']);
|
||||
$v3 = array(
|
||||
'authlevel' => mres($_POST['authlevel']),
|
||||
'authname' => mres($_POST['authname']),
|
||||
'authpass' => mres($_POST['authpass']),
|
||||
'authalgo' => mres($_POST['authalgo']),
|
||||
'cryptopass' => mres($_POST['cryptopass']),
|
||||
'cryptoalgo' => mres($_POST['cryptoalgo']),
|
||||
);
|
||||
|
||||
#FIXME needs better feedback
|
||||
$update = array(
|
||||
'community' => $community,
|
||||
'snmpver' => $snmpver,
|
||||
'port' => $port,
|
||||
'transport' => $transport,
|
||||
'poller_group' => $poller_group
|
||||
);
|
||||
// FIXME needs better feedback
|
||||
$update = array(
|
||||
'community' => $community,
|
||||
'snmpver' => $snmpver,
|
||||
'port' => $port,
|
||||
'transport' => $transport,
|
||||
'poller_group' => $poller_group,
|
||||
);
|
||||
|
||||
if ($_POST['timeout']) { $update['timeout'] = $timeout; }
|
||||
else { $update['timeout'] = array('NULL'); }
|
||||
if ($_POST['retries']) { $update['retries'] = $retries; }
|
||||
else { $update['retries'] = array('NULL'); }
|
||||
|
||||
$update = array_merge($update, $v3);
|
||||
|
||||
$device_tmp = deviceArray($device['hostname'], $community, $snmpver, $port, $transport, $v3);
|
||||
if (isSNMPable($device_tmp)) {
|
||||
$rows_updated = dbUpdate($update, 'devices', '`device_id` = ?',array($device['device_id']));
|
||||
|
||||
if ($rows_updated > 0) {
|
||||
$update_message = $rows_updated . " Device record updated.";
|
||||
$updated = 1;
|
||||
} elseif ($rows_updated = '-1') {
|
||||
$update_message = "Device record unchanged. No update necessary.";
|
||||
$updated = -1;
|
||||
} else {
|
||||
$update_message = "Device record update error.";
|
||||
$updated = 0;
|
||||
if ($_POST['timeout']) {
|
||||
$update['timeout'] = $timeout;
|
||||
}
|
||||
else {
|
||||
$update['timeout'] = array('NULL');
|
||||
}
|
||||
} else {
|
||||
$update_message = "Could not connect to device with new SNMP details";
|
||||
$updated = 0;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
$device = dbFetchRow("SELECT * FROM `devices` WHERE `device_id` = ?", array($device['device_id']));
|
||||
if ($_POST['retries']) {
|
||||
$update['retries'] = $retries;
|
||||
}
|
||||
else {
|
||||
$update['retries'] = array('NULL');
|
||||
}
|
||||
|
||||
$update = array_merge($update, $v3);
|
||||
|
||||
$device_tmp = deviceArray($device['hostname'], $community, $snmpver, $port, $transport, $v3);
|
||||
if (isSNMPable($device_tmp)) {
|
||||
$rows_updated = dbUpdate($update, 'devices', '`device_id` = ?', array($device['device_id']));
|
||||
|
||||
if ($rows_updated > 0) {
|
||||
$update_message = $rows_updated.' Device record updated.';
|
||||
$updated = 1;
|
||||
}
|
||||
else if ($rows_updated = '-1') {
|
||||
$update_message = 'Device record unchanged. No update necessary.';
|
||||
$updated = -1;
|
||||
}
|
||||
else {
|
||||
$update_message = 'Device record update error.';
|
||||
$updated = 0;
|
||||
}
|
||||
}
|
||||
else {
|
||||
$update_message = 'Could not connect to device with new SNMP details';
|
||||
$updated = 0;
|
||||
}
|
||||
}//end if
|
||||
}//end if
|
||||
|
||||
$device = dbFetchRow('SELECT * FROM `devices` WHERE `device_id` = ?', array($device['device_id']));
|
||||
$descr = $device['purpose'];
|
||||
|
||||
echo('<div class="row">
|
||||
<div class="col-sm-6">');
|
||||
if ($updated && $update_message)
|
||||
{
|
||||
print_message($update_message);
|
||||
} elseif ($update_message) {
|
||||
print_error($update_message);
|
||||
echo '<div class="row">
|
||||
<div class="col-sm-6">';
|
||||
if ($updated && $update_message) {
|
||||
print_message($update_message);
|
||||
}
|
||||
else if ($update_message) {
|
||||
print_error($update_message);
|
||||
}
|
||||
echo(' </div>
|
||||
</div>');
|
||||
|
||||
echo("
|
||||
<form id='edit' name='edit' method='post' action='' role='form' class='form-horizontal'>
|
||||
<input type=hidden name='editing' value='yes'>
|
||||
<div class='form-group'>
|
||||
echo ' </div>
|
||||
</div>';
|
||||
|
||||
echo "
|
||||
<form id='edit' name='edit' method='post' action='' role='form' class='form-horizontal'>
|
||||
<input type=hidden name='editing' value='yes'>
|
||||
<div class='form-group'>
|
||||
<label for='snmpver' class='col-sm-2 control-label'>SNMP Details</label>
|
||||
<div class='col-sm-1'>
|
||||
<select id='snmpver' name='snmpver' class='form-control input-sm' onChange='changeForm();'>
|
||||
<option value='v1'>v1</option>
|
||||
<option value='v2c' " . ($device['snmpver'] == 'v2c' ? 'selected' : '') . ">v2c</option>
|
||||
<option value='v3' " . ($device['snmpver'] == 'v3' ? 'selected' : '') . ">v3</option>
|
||||
</select>
|
||||
<select id='snmpver' name='snmpver' class='form-control input-sm' onChange='changeForm();'>
|
||||
<option value='v1'>v1</option>
|
||||
<option value='v2c' ".($device['snmpver'] == 'v2c' ? 'selected' : '').">v2c</option>
|
||||
<option value='v3' ".($device['snmpver'] == 'v3' ? 'selected' : '').">v3</option>
|
||||
</select>
|
||||
</div>
|
||||
<div class='col-sm-2'>
|
||||
<input type='text' name='port' placeholder='port' class='form-control input-sm'>
|
||||
<input type='text' name='port' placeholder='port' class='form-control input-sm'>
|
||||
</div>
|
||||
<div class='col-sm-1'>
|
||||
<select name='transport' id='transport' class='form-control input-sm'>");
|
||||
<select name='transport' id='transport' class='form-control input-sm'>";
|
||||
foreach ($config['snmp']['transports'] as $transport) {
|
||||
echo("<option value='".$transport."'");
|
||||
echo "<option value='".$transport."'";
|
||||
if ($transport == $device['transport']) {
|
||||
echo(" selected='selected'");
|
||||
echo " selected='selected'";
|
||||
}
|
||||
echo(">".$transport."</option>");
|
||||
|
||||
echo '>'.$transport.'</option>';
|
||||
}
|
||||
echo(" </select>
|
||||
|
||||
echo " </select>
|
||||
</div>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
<div class='col-sm-2'>
|
||||
</div>
|
||||
<div class='col-sm-1'>
|
||||
<input id='timeout' name='timeout' class='form-control input-sm' value='" . ($device['timeout'] ? $device['timeout'] : '') . "' placeholder='seconds' />
|
||||
<input id='timeout' name='timeout' class='form-control input-sm' value='".($device['timeout'] ? $device['timeout'] : '')."' placeholder='seconds' />
|
||||
</div>
|
||||
<div class='col-sm-1'>
|
||||
<input id='retries' name='retries' class='form-control input-sm' value='" . ($device['timeout'] ? $device['retries'] : '') . "' placeholder='retries' />
|
||||
<input id='retries' name='retries' class='form-control input-sm' value='".($device['timeout'] ? $device['retries'] : '')."' placeholder='retries' />
|
||||
</div>
|
||||
</div>
|
||||
<div id='snmpv1_2'>
|
||||
</div>
|
||||
<div id='snmpv1_2'>
|
||||
<div class='form-group'>
|
||||
<label class='col-sm-3 control-label text-left'><h4><strong>SNMPv1/v2c Configuration</strong></h4></label>
|
||||
<label class='col-sm-3 control-label text-left'><h4><strong>SNMPv1/v2c Configuration</strong></h4></label>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
<label for='community' class='col-sm-2 control-label'>SNMP Community</label>
|
||||
<div class='col-sm-4'>
|
||||
<input id='community' class='form-control' name='community' value='" . $device['community'] . "' />
|
||||
</div>
|
||||
<label for='community' class='col-sm-2 control-label'>SNMP Community</label>
|
||||
<div class='col-sm-4'>
|
||||
<input id='community' class='form-control' name='community' value='".$device['community']."' />
|
||||
</div>
|
||||
</div>
|
||||
<div id='snmpv3'>
|
||||
</div>
|
||||
</div>
|
||||
<div id='snmpv3'>
|
||||
<div class='form-group'>
|
||||
<label class='col-sm-3 control-label'><h4><strong>SNMPv3 Configuration</strong></h4></label>
|
||||
<label class='col-sm-3 control-label'><h4><strong>SNMPv3 Configuration</strong></h4></label>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
<label for='authlevel' class='col-sm-2 control-label'>Auth Level</label>
|
||||
<div class='col-sm-4'>
|
||||
<select id='authlevel' name='authlevel' class='form-control'>
|
||||
<option value='NoAuthNoPriv'>NoAuthNoPriv</option>
|
||||
<option value='AuthNoPriv' " . ($device['authlevel'] == "authNoPriv" ? 'selected' : '') . ">AuthNoPriv</option>
|
||||
<option value='AuthPriv' " . ($device['authlevel'] == "authPriv" ? 'selected' : '') . ">AuthPriv</option>
|
||||
</select>
|
||||
</div>
|
||||
<label for='authlevel' class='col-sm-2 control-label'>Auth Level</label>
|
||||
<div class='col-sm-4'>
|
||||
<select id='authlevel' name='authlevel' class='form-control'>
|
||||
<option value='NoAuthNoPriv'>NoAuthNoPriv</option>
|
||||
<option value='AuthNoPriv' ".($device['authlevel'] == 'authNoPriv' ? 'selected' : '').">AuthNoPriv</option>
|
||||
<option value='AuthPriv' ".($device['authlevel'] == 'authPriv' ? 'selected' : '').">AuthPriv</option>
|
||||
</select>
|
||||
</div>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
<label for='authname' class='col-sm-2 control-label'>Auth User Name</label>
|
||||
<div class='col-sm-4'>
|
||||
<input type='text' id='authname' name='authname' class='form-control' value='" . $device['authname'] . "'>
|
||||
</div>
|
||||
<label for='authname' class='col-sm-2 control-label'>Auth User Name</label>
|
||||
<div class='col-sm-4'>
|
||||
<input type='text' id='authname' name='authname' class='form-control' value='".$device['authname']."'>
|
||||
</div>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
<label for='authpass' class='col-sm-2 control-label'>Auth Password</label>
|
||||
<div class='col-sm-4'>
|
||||
<input type='password' id='authpass' name='authpass' class='form-control' value='" . $device['authpass'] . "'>
|
||||
</div>
|
||||
<label for='authpass' class='col-sm-2 control-label'>Auth Password</label>
|
||||
<div class='col-sm-4'>
|
||||
<input type='password' id='authpass' name='authpass' class='form-control' value='".$device['authpass']."'>
|
||||
</div>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
<label for='authalgo' class='col-sm-2 control-label'>Auth Algorithm</label>
|
||||
<div class='col-sm-4'>
|
||||
<select id='authalgo' name='authalgo' class='form-control'>
|
||||
<option value='MD5'>MD5</option>
|
||||
<option value='SHA' " . ($device['authalgo'] === "SHA" ? 'selected' : '') . ">SHA</option>
|
||||
</select>
|
||||
</div>
|
||||
<label for='authalgo' class='col-sm-2 control-label'>Auth Algorithm</label>
|
||||
<div class='col-sm-4'>
|
||||
<select id='authalgo' name='authalgo' class='form-control'>
|
||||
<option value='MD5'>MD5</option>
|
||||
<option value='SHA' ".($device['authalgo'] === 'SHA' ? 'selected' : '').">SHA</option>
|
||||
</select>
|
||||
</div>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
<label for='cryptopass' class='col-sm-2 control-label'>Crypto Password</label>
|
||||
<div class='col-sm-4'>
|
||||
<input type='password' id='cryptopass' name='cryptopass' class='form-control' value='" . $device['cryptopass'] . "'>
|
||||
</div>
|
||||
<label for='cryptopass' class='col-sm-2 control-label'>Crypto Password</label>
|
||||
<div class='col-sm-4'>
|
||||
<input type='password' id='cryptopass' name='cryptopass' class='form-control' value='".$device['cryptopass']."'>
|
||||
</div>
|
||||
</div>
|
||||
<div class='form-group'>
|
||||
<label for='cryptoalgo' class='col-sm-2 control-label'>Crypto Algorithm</label>
|
||||
<div class='col-sm-4'>
|
||||
<select id='cryptoalgo' name='cryptoalgo' class='form-control'>
|
||||
<option value='AES'>AES</option>
|
||||
<option value='DES' " . ($device['cryptoalgo'] === "DES" ? 'selected' : '') . ">DES</option>
|
||||
</select>
|
||||
</div>
|
||||
<label for='cryptoalgo' class='col-sm-2 control-label'>Crypto Algorithm</label>
|
||||
<div class='col-sm-4'>
|
||||
<select id='cryptoalgo' name='cryptoalgo' class='form-control'>
|
||||
<option value='AES'>AES</option>
|
||||
<option value='DES' ".($device['cryptoalgo'] === 'DES' ? 'selected' : '').'>DES</option>
|
||||
</select>
|
||||
</div>
|
||||
</div>");
|
||||
</div>
|
||||
</div>';
|
||||
|
||||
if ($config['distributed_poller'] === TRUE) {
|
||||
echo('
|
||||
<div class="form-group">
|
||||
<label for="poller_group" class="col-sm-2 control-label">Poller Group</label>
|
||||
<div class="col-sm-4">
|
||||
<select name="poller_group" id="poller_group" class="form-control input-sm">
|
||||
<option value="0"> Default poller group</option>
|
||||
');
|
||||
if ($config['distributed_poller'] === true) {
|
||||
echo '
|
||||
<div class="form-group">
|
||||
<label for="poller_group" class="col-sm-2 control-label">Poller Group</label>
|
||||
<div class="col-sm-4">
|
||||
<select name="poller_group" id="poller_group" class="form-control input-sm">
|
||||
<option value="0"> Default poller group</option>
|
||||
';
|
||||
|
||||
foreach (dbFetchRows("SELECT `id`,`group_name` FROM `poller_groups`") as $group) {
|
||||
echo '<option value="' . $group['id'] . '"';
|
||||
foreach (dbFetchRows('SELECT `id`,`group_name` FROM `poller_groups`') as $group) {
|
||||
echo '<option value="'.$group['id'].'"';
|
||||
if ($device['poller_group'] == $group['id']) {
|
||||
echo ' selected';
|
||||
}
|
||||
echo '>' . $group['group_name'] . '</option>';
|
||||
|
||||
echo '>'.$group['group_name'].'</option>';
|
||||
}
|
||||
|
||||
echo('
|
||||
</select>
|
||||
</div>
|
||||
</div>
|
||||
');
|
||||
}
|
||||
echo '
|
||||
</select>
|
||||
</div>
|
||||
</div>
|
||||
';
|
||||
}//end if
|
||||
|
||||
|
||||
echo('
|
||||
<button type="submit" name="Submit" class="btn btn-default">Save</button>
|
||||
</form>
|
||||
');
|
||||
echo '
|
||||
<button type="submit" name="Submit" class="btn btn-default">Save</button>
|
||||
</form>
|
||||
';
|
||||
|
||||
?>
|
||||
<script>
|
||||
function changeForm() {
|
||||
snmpVersion = $("#snmpver").val();
|
||||
if(snmpVersion == 'v1' || snmpVersion == 'v2c') {
|
||||
$('#snmpv1_2').show();
|
||||
$('#snmpv3').hide();
|
||||
} else if(snmpVersion == 'v3') {
|
||||
$('#snmpv1_2').hide();
|
||||
$('#snmpv3').show();
|
||||
}
|
||||
function changeForm() {
|
||||
snmpVersion = $("#snmpver").val();
|
||||
if(snmpVersion == 'v1' || snmpVersion == 'v2c') {
|
||||
$('#snmpv1_2').show();
|
||||
$('#snmpv3').hide();
|
||||
}
|
||||
else if(snmpVersion == 'v3') {
|
||||
$('#snmpv1_2').hide();
|
||||
$('#snmpv3').show();
|
||||
}
|
||||
}
|
||||
<?php
|
||||
|
||||
if($snmpver == 'v3' || $device['snmpver'] == 'v3') {
|
||||
echo("$('#snmpv1_2').toggle();");
|
||||
} else {
|
||||
echo("$('#snmpv3').toggle();");
|
||||
}
|
||||
if ($snmpver == 'v3' || $device['snmpver'] == 'v3') {
|
||||
echo "$('#snmpv1_2').toggle();";
|
||||
}
|
||||
else {
|
||||
echo "$('#snmpv3').toggle();";
|
||||
}
|
||||
|
||||
?>
|
||||
</script>
|
||||
|
||||
Reference in New Issue
Block a user