mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: validate suid is set for fping (#5474)

Browse Source
This commit is contained in:
Tony Murray
2017-01-16 13:19:23 -06:00
committed by Neil Lathwood
parent 408babb88d
commit dc4747e853
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
validate.php
View File

@@ -213,10 +213,14 @@ if ($space_check < 1) {
}
// Check programs
$bins = array('fping','rrdtool','snmpwalk','snmpget','snmpbulkwalk');
$bins = array('fping','fping6','rrdtool','snmpwalk','snmpget','snmpbulkwalk');
$suid_bins = array('fping', 'fping6');
foreach ($bins as $bin) {
if (!is_file($config[$bin])) {
$cmd = rtrim(shell_exec("which {$config[$bin]} 2>/dev/null"));
if (!$cmd) {
print_fail("$bin location is incorrect or bin not installed");
} elseif (in_array($bin, $suid_bins) && !(fileperms($cmd) & 2048)) {
print_fail("$bin should be suid, please chmod u+s $cmd");
}
}