mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

snmp_walk remove multiple No more variables (#8050)

Browse Source 
Optimize code so it is a faster when no more variables is not present.
Only saving 10s of microseconds, but better than an increase.
This commit is contained in:
Tony Murray
2018-01-10 15:30:19 -06:00
committed by GitHub
parent d515f5043e
commit e11e84f2ee
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
includes/snmp.inc.php
View File

@@ -381,11 +381,9 @@ function snmp_walk($device, $oid, $options = null, $mib = null, $mibdir = null)
if (is_string($data) && (preg_match('/No Such (Object|Instance)/i', $data))) {
$data = false;
} else {
if (preg_match('/No more variables left in this MIB View \(It is past the end of the MIB tree\)$/', $data)) {
// Bit ugly :-(
$d_ex = explode("\n", $data);
unset($d_ex[(count($d_ex) - 1)]);
$data = implode("\n", $d_ex);
if (ends_with($data, '(It is past the end of the MIB tree)')) {
$no_more_pattern = '/.*No more variables left in this MIB View \(It is past the end of the MIB tree\)[\n]?/';
$data = preg_replace($no_more_pattern, '', $data);
}
}