Refactor datastores to classes (#9179)

* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues
This commit is contained in:
Tony Murray
2020-03-10 19:08:00 -05:00
committed by GitHub
parent cc53801e22
commit e5dad7a64e
51 changed files with 2523 additions and 1007 deletions

View File

@@ -13,31 +13,19 @@
* the source code distribution for details.
*/
use LibreNMS\Data\Store\Datastore;
$init_modules = array();
require __DIR__ . '/includes/init.php';
$options = getopt('d::h:f:;');
$options = getopt('drfpgh:');
if (set_debug(isset($options['d']))) {
echo "DEBUG!\n";
}
if (isset($options['f'])) {
\LibreNMS\Config::set('noinfluxdb', true);
}
if (isset($options['p'])) {
$prometheus = false;
}
if (\LibreNMS\Config::get('noinfluxdb') !== true && \LibreNMS\Config::get('influxdb.enable') === true) {
$influxdb = influxdb_connect();
} else {
$influxdb = false;
}
$poller_start = microtime(true);
rrdtool_initialize();
$datastore = Datastore::init($options);
echo "Starting service polling run:\n\n";
$polled_services = 0;
@@ -96,4 +84,4 @@ $string = $argv[0] . " " . date(\LibreNMS\Config::get('dateformat.compact'))
." - $polled_services services polled in $poller_time secs";
d_echo("$string\n");
rrdtool_close();
Datastore::terminate();