mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

additional os discovery yaml tests (#7669)

Browse Source
This commit is contained in:
Tony Murray
2017-11-07 14:24:22 -06:00
committed by Neil Lathwood
parent 597af28093
commit e5f6742cc3
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/YamlTest.php
View File

@@ -32,8 +32,7 @@ use Symfony\Component\Yaml\Yaml;
class YamlTest extends \PHPUnit_Framework_TestCase class YamlTest extends \PHPUnit_Framework_TestCase
{ {
private $valid_os_discovery_keys = array(
private $valid_keys = array(
'sysDescr', 'sysDescr',
'sysDescr_except', 'sysDescr_except',
'sysObjectId', 'sysObjectId',
@@ -87,8 +86,16 @@ class YamlTest extends \PHPUnit_Framework_TestCase
// test discovery keys // test discovery keys
if (isset($data['discovery'])) { if (isset($data['discovery'])) {
foreach ((array)$data['discovery'] as $group) { foreach ((array)$data['discovery'] as $group) {
// make sure we have at least one valid discovery key
$keys = array_keys($group);
$this->assertNotEmpty($keys, "$file: contains no os discovery keys");
$this->assertNotEmpty(
array_intersect($keys, $this->valid_os_discovery_keys),
"$file: contains no valid os discovery keys: " . var_export($keys, true)
);
foreach ((array)$group as $key => $item) { foreach ((array)$group as $key => $item) {
$this->assertContains($key, $this->valid_keys, "$file: invalid discovery type $key"); $this->assertContains($key, $this->valid_os_discovery_keys, "$file: invalid discovery type $key");
if (starts_with($key, 'snmpget')) { if (starts_with($key, 'snmpget')) {
foreach ($item as $get_key => $get_val) { foreach ($item as $get_key => $get_val) {