mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove $_SESSION usage, except install (#10745)

Browse Source 
* Remove $_SESSION usage, except install
Fixes issue with device debug capture
Removes secure_cookies setting, use the .env variable SESSION_SECURE_COOKIE instead.  Reminder secure cookies requires cookies are transported over https, if everything is already transported via https, the setting won't make a difference.

* Fix availability map controls
This commit is contained in:
Tony Murray
2019-10-26 00:29:12 +00:00
committed by GitHub
parent d72c722075
commit e6423852ef
15 changed files with 78 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
LibreNMS/Config.php
View File

@@ -408,7 +408,6 @@ class Config
// If we're on SSL, let's properly detect it
if (isset($_SERVER['HTTPS'])) {
self::set('base_url', preg_replace('/^http:/', 'https:', self::get('base_url')));
self::set('secure_cookies', true);
}
// If we're on SSL, let's properly detect it
@@ -416,10 +415,6 @@ class Config
self::set('base_url', preg_replace('/^http:/', 'https:', self::get('base_url')));
}
if (self::get('secure_cookies')) {
ini_set('session.cookie_secure', 1);
}
if (!self::get('email_from')) {
self::set('email_from', '"' . self::get('project_name') . '" <' . self::get('email_user') . '@' . php_uname('n') . '>');
}