mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

RRDtool dual process (remote creation/check) (#4104)

Browse Source 
* Prepare for dual rrdtool processes
Disabled at this time
Split out rrdtool version checks into rrdtool_create_command()
Tests for rrdtool_create_command()
Fixes a few small issues.

* Enable dual process and remote rrd check/creation

* remove full path for remote commands

* Doc updates
minor fix to rrdtool_tune()

* Set up bootstrap for phpunit
Fix issues with FileExistsException

* Attempt to fix phpunit

* Fix classloader and bootstrap to use full paths only (not depending on $config)

* Fix phpunit tests, config.php does not exist.
This commit is contained in:
Tony Murray
2016-08-22 10:32:05 -05:00
committed by Neil Lathwood
parent 27c1c72b19
commit e80a385b7f
11 changed files with 400 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/RrdtoolTest.php
+101
View File
@@ -0,0 +1,101 @@
<?php
/**
* RrdtoolTest.php
*
* Tests functionality of our rrdtool wrapper
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
* @package LibreNMS
* @link http://librenms.org
* @copyright 2016 Tony Murray
* @author Tony Murray <murraytony@gmail.com>
*/
namespace LibreNMS\Tests;
class RrdtoolTest extends \PHPUnit_Framework_TestCase
{
public function testBuildCommandLocal()
{
global $config;
$config['rrdcached'] = '';
$config['rrdtool_version'] = '1.4';
$config['rrd_dir'] = '/opt/librenms/rrd';
$cmd = rrdtool_build_command('create', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('create /opt/librenms/rrd/f o', $cmd);
$cmd = rrdtool_build_command('tune', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('tune /opt/librenms/rrd/f o', $cmd);
$cmd = rrdtool_build_command('update', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('update /opt/librenms/rrd/f o', $cmd);
$config['rrdtool_version'] = '1.6';
$cmd = rrdtool_build_command('create', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('create /opt/librenms/rrd/f o -O', $cmd);
$cmd = rrdtool_build_command('tune', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('tune /opt/librenms/rrd/f o', $cmd);
$cmd = rrdtool_build_command('update', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('update /opt/librenms/rrd/f o', $cmd);
}
public function testBuildCommandRemote()
{
global $config;
$config['rrdcached'] = 'server:42217';
$config['rrdtool_version'] = '1.4';
$config['rrd_dir'] = '/opt/librenms/rrd';
$cmd = rrdtool_build_command('create', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('create /opt/librenms/rrd/f o', $cmd);
$cmd = rrdtool_build_command('tune', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('tune /opt/librenms/rrd/f o', $cmd);
$cmd = rrdtool_build_command('update', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('update f o --daemon server:42217', $cmd);
$config['rrdtool_version'] = '1.6';
$cmd = rrdtool_build_command('create', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('create f o -O --daemon server:42217', $cmd);
$cmd = rrdtool_build_command('tune', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('tune f o --daemon server:42217', $cmd);
$cmd = rrdtool_build_command('update', '/opt/librenms/rrd/f', 'o');
$this->assertEquals('update f o --daemon server:42217', $cmd);
}
public function testBuildCommandException()
{
global $config;
$config['rrdcached'] = '';
$config['rrdtool_version'] = '1.4';
$this->setExpectedException('LibreNMS\Exceptions\FileExistsException');
// use this file, since it is guaranteed to exist
rrdtool_build_command('create', __FILE__, 'o');
}
}