mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Re-throw exceptions if we're in CI (#14890)

Browse Source 
Else they are not shown during tests
This commit is contained in:
Jellyfrog
2023-03-10 15:00:03 +01:00
committed by GitHub
parent f111ac22fe
commit e9f8e64506
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
includes/discovery/functions.inc.php
View File

@@ -157,6 +157,11 @@ function discover_device(&$device, $force_module = false)
Log::error("%rError discovering $module module for {$device['hostname']}.%n $e", ['color' => true]); Log::error("%rError discovering $module module for {$device['hostname']}.%n $e", ['color' => true]);
\App\Models\Eventlog::log("Error discovering $module module. Check log file for more details.", $device['device_id'], 'discovery', Alert::ERROR); \App\Models\Eventlog::log("Error discovering $module module. Check log file for more details.", $device['device_id'], 'discovery', Alert::ERROR);
report($e); report($e);
// Re-throw exception if we're in CI
if (getenv('CI') == true) {
throw $e;
}
} }
$module_time = microtime(true) - $module_start; $module_time = microtime(true) - $module_start;

5
includes/polling/functions.inc.php
View File

@@ -342,6 +342,11 @@ function poll_device($device, $force_module = false)
Log::error("%rError polling $module module for {$device['hostname']}.%n $e", ['color' => true]); Log::error("%rError polling $module module for {$device['hostname']}.%n $e", ['color' => true]);
\App\Models\Eventlog::log("Error polling $module module. Check log file for more details.", $device['device_id'], 'poller', Alert::ERROR); \App\Models\Eventlog::log("Error polling $module module. Check log file for more details.", $device['device_id'], 'poller', Alert::ERROR);
report($e); report($e);
// Re-throw exception if we're in CI
if (getenv('CI') == true) {
throw $e;
}
} }
$module_time = microtime(true) - $module_start; $module_time = microtime(true) - $module_start;