Better services graphing support (#10185)

* Move services graph code from device to service and remove unused code

* Add proper support for services to dashboard graph weidget

* Fix phpdoc in ServiceController still pointing to MuninPluginController

includes/html/graphs/service/auth.inc.php

@@ -10,7 +10,7 @@ if (is_numeric($vars['id'])) {
         $rrd_filename = rrd_name($device['hostname'], array('service', $service['service_type'], $service['service_id']));
 
         $title  = generate_device_link($device);
-        $title .= ' :: Service :: '.htmlentities($service['service_type']);
+        $title .= ' :: Service :: '.htmlentities($service['service_type']).' - '.htmlentities($service['service_desc']);
         $auth   = true;
     }
 }

includes/html/graphs/service/availability.inc.php

@@ -1,21 +0,0 @@
-<?php
-
-$scale_min = '0';
-$scale_max = '1';
-
-require 'includes/html/graphs/common.inc.php';
-
-$service_text = substr(str_pad($service['service_type'], 28), 0, 28);
-
-$rrd_options .= " COMMENT:'                                Cur    Avail\\n'";
-$rrd_options .= " DEF:status=$rrd_filename:status:AVERAGE";
-$rrd_options .= ' CDEF:percent=status,100,*';
-$rrd_options .= ' CDEF:down=status,1,LT,status,UNKN,IF';
-$rrd_options .= ' CDEF:percentdown=down,100,*';
-$rrd_options .= ' AREA:percent#CCFFCC';
-$rrd_options .= ' AREA:percentdown#FFCCCC';
-$rrd_options .= " LINE1.5:percent#009900:'".$service_text."'";
-// Ugly hack :(
-$rrd_options .= ' LINE1.5:percentdown#cc0000';
-$rrd_options .= ' GPRINT:status:LAST:%3.0lf';
-$rrd_options .= ' GPRINT:percent:AVERAGE:%3.5lf%%\l';

includes/html/graphs/service/graph.inc.php

@@ -0,0 +1,100 @@
+<?php
+/*
+ * LibreNMS module to display graphing for Nagios Service
+ *
+ * Copyright (c) 2016 Aaron Daniels <aaron@daniels.id.au>
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation, either version 3 of the License, or (at your
+ * option) any later version.  Please see LICENSE.txt at the top level of
+ * the source code distribution for details.
+ */
+
+// Get a list of all services for this device.
+require_once 'includes/services.inc.php';
+$services = service_get($device['device_id']);
+
+// Determine which key is the service we want to show.
+if (isset($vars['id'])) {
+    // Service is set, find its key.
+    foreach ($services as $key => $service) {
+        if ($service['service_id'] == $vars['id']) {
+            // We have found the service we want.
+            $vars['service'] = $key;
+        }
+    }
+} else {
+    // No service set, set the first one.
+    if (isset($services[0])) {
+        $vars['service'] = 0;
+    }
+}
+
+// We know our service. build the filename.
+$rrd_filename = rrd_name($device['hostname'], array('services', $services[$vars['service']]['service_id']));
+
+// if we have a script for this check, use it.
+$check_script = $config['install_dir'].'/includes/services/check_'.strtolower($services[$vars['service']]['service_type']).'.inc.php';
+if (is_file($check_script)) {
+    include $check_script;
+
+    // If we have a replacement DS use it.
+    if (isset($check_ds)) {
+        $services[$vars['service']]['service_ds'] = $check_ds;
+    }
+}
+
+include "includes/html/graphs/common.inc.php";
+$rrd_options .= " -l 0 -E ";
+$rrd_options .= " COMMENT:'                      Now     Avg      Max\\n'";
+$rrd_additions = "";
+
+// Remove encoded characters
+$services[$vars['service']]['service_ds'] = htmlspecialchars_decode($services[$vars['service']]['service_ds']);
+
+if ($services[$vars['service']]['service_ds'] != "") {
+    $graphinfo = json_decode($services[$vars['service']]['service_ds'], true);
+
+    // Do we have a DS set
+    if (!isset($graphinfo[$vars['ds']])) {
+        foreach ($graphinfo as $k => $v) {
+            // Select a DS to display.
+            $vars['ds'] = $k;
+        }
+    }
+
+    // Need: DS name, Label
+    $ds = $vars['ds'];
+    $label = $graphinfo[$vars['ds']];
+
+    if (rrdtool_check_rrd_exists($rrd_filename)) {
+        if (isset($check_graph)) {
+            // We have a graph definition, use it.
+            $rrd_additions .= $check_graph[$ds];
+        } else {
+            // Build the graph ourselves
+            if (preg_match('/loss/i', $ds)) {
+                $tint = "pinks";
+            } else {
+                $tint = "blues";
+            }
+            $color_avg = $config['graph_colours'][$tint][2];
+            $color_max = $config['graph_colours'][$tint][0];
+
+            $rrd_additions .= " DEF:DS=" . $rrd_filename . ":".$ds.":AVERAGE ";
+            $rrd_additions .= " DEF:DS_MAX=" . $rrd_filename . ":".$ds.":MAX ";
+            $rrd_additions .= " AREA:DS_MAX#" . $color_max . ":";
+            $rrd_additions .= " AREA:DS#" . $color_avg . ":'" . str_pad(substr(ucfirst($ds)." (".$label.")", 0, 15), 15) . "' ";
+            $rrd_additions .= " GPRINT:DS:LAST:%5.2lf%s ";
+            $rrd_additions .= " GPRINT:DS:AVERAGE:%5.2lf%s ";
+            $rrd_additions .= " GPRINT:DS_MAX:MAX:%5.2lf%s\\l ";
+        }
+    }
+}
+
+if ($rrd_additions == "") {
+    // We didn't add any data points.
+} else {
+    $rrd_options .= $rrd_additions;
+}