mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use Config helper (#10339)

Browse Source 
remove usage of global variable
This commit is contained in:
Tony Murray
2019-06-23 00:29:12 -05:00
committed by GitHub
parent 342acf50f1
commit f3ba8947f7
367 changed files with 1589 additions and 1857 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
includes/html/pages/device/edit/snmp.inc.php
View File

@@ -1,6 +1,7 @@
<?php
use LibreNMS\Authentication\LegacyAuth;
use LibreNMS\Config;
if ($_POST['editing']) {
if (LegacyAuth::user()->hasGlobalAdmin()) {
@@ -11,7 +12,7 @@ if ($_POST['editing']) {
$community = clean($_POST['community']);
$snmpver = clean($_POST['snmpver']);
$transport = $_POST['transport'] ? clean($_POST['transport']) : $transport = 'udp';
$port = $_POST['port'] ? clean($_POST['port']) : $config['snmp']['port'];
$port = $_POST['port'] ? clean($_POST['port']) : Config::get('snmp.port');
$timeout = clean($_POST['timeout']);
$retries = clean($_POST['retries']);
$port_assoc_mode = clean($_POST['port_assoc_mode']);
@@ -138,7 +139,7 @@ echo "
<div class='form-group'>
<label for='os' class='col-sm-2 control-label'>OS (optional)</label>
<div class='col-sm-4'>
<input id='os' class='form-control' name='os' value='".$config['os'][$device['os']]['text']."'/>
<input id='os' class='form-control' name='os' value='" . Config::get("os.{$device['os']}.text") . "'/>
<input type='hidden' id='os_id' class='form-control' name='os_id' value='".$device['os']."'/>
</div>
</div>
@@ -155,11 +156,11 @@ echo "
</select>
</div>
<div class='col-sm-2'>
<input type='text' name='port' placeholder='port' class='form-control input-sm' value='".($device['port'] == $config['snmp']['port'] ? "" : $device['port'])."'>
<input type='text' name='port' placeholder='port' class='form-control input-sm' value='" . ($device['port'] == Config::get('snmp.port') ? "" : $device['port']) . "'>
</div>
<div class='col-sm-1'>
<select name='transport' id='transport' class='form-control input-sm'>";
foreach ($config['snmp']['transports'] as $transport) {
foreach (Config::get('snmp.transports') as $transport) {
echo "<option value='".$transport."'";
if ($transport == $device['transport']) {
echo " selected='selected'";
@@ -288,7 +289,7 @@ echo " </select>
</div>
<?php
if ($config['distributed_poller'] === true) {
if (Config::get('distributed_poller') === true) {
echo '
<div class="form-group">
<label for="poller_group" class="col-sm-2 control-label">Poller Group</label>