Fix invalid test data (#9099)

* Fix invalid test data
and add test for it

* fix bgp

* add missing comma back
This commit is contained in:
Tony Murray
2018-08-28 14:18:59 -05:00
committed by GitHub
parent 31a21ba2bc
commit f73f7ec5ce
5 changed files with 136 additions and 118 deletions

View File

@@ -226,6 +226,7 @@ class ModuleTestHelper
*
* @param array $modules
* @return array
* @throws InvalidModuleException
*/
public static function findOsWithData($modules = [])
{
@@ -253,11 +254,15 @@ class ModuleTestHelper
continue; // no test data for selected modules
}
$os_list[$base_name] = [
$os,
$variant,
self::resolveModuleDependencies($valid_modules),
];
try {
$os_list[$base_name] = [
$os,
$variant,
self::resolveModuleDependencies($valid_modules),
];
} catch (InvalidModuleException $e) {
throw new InvalidModuleException("Invalid module " . $e->getMessage() . " in $os $variant");
}
}
return $os_list;