mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix invalid test data (#9099)

Browse Source 
* Fix invalid test data
and add test for it

* fix bgp

* add missing comma back
This commit is contained in:
Tony Murray
2018-08-28 14:18:59 -05:00
committed by GitHub
parent 31a21ba2bc
commit f73f7ec5ce
5 changed files with 136 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/OSModulesTest.php
View File

@@ -31,6 +31,22 @@ use LibreNMS\Util\ModuleTestHelper;
class OSModulesTest extends DBTestCase
{
/**
* Test all modules for a particular OS
*
* @group os
* @dataProvider dumpedDataProvider
*/
public function testDataIsValid($os, $variant, $modules)
{
// special case if data provider throws exception
if ($os === false) {
$this->fail($modules);
}
$this->assertNotEmpty($modules, "No modules to test for $os $variant");
}
/**
* Test all modules for a particular OS
*
@@ -105,6 +121,11 @@ class OSModulesTest extends DBTestCase
$modules = explode(',', getenv('TEST_MODULES'));
}
return ModuleTestHelper::findOsWithData($modules);
try {
return ModuleTestHelper::findOsWithData($modules);
} catch (InvalidModuleException $e) {
// special case for exception
return [[false, false, $e->getMessage()]];
}
}
}