From f77d294b6c8b2a100d1c72cb695588ee7a5bfa38 Mon Sep 17 00:00:00 2001
From: Adam Amstrong <adama@localhost>
Date: Sat, 22 Mar 2008 15:18:15 +0000
Subject: [PATCH] hostadding stuff

git-svn-id: http://www.observium.org/svn/observer/trunk@187 61d68cd4-352d-0410-923a-c4978735b2b8
---
 addhost.php            | 3 ++-
 includes/functions.php | 7 ++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/addhost.php b/addhost.php
index f830cca8bc..fc82c38c98 100755
--- a/addhost.php
+++ b/addhost.php
@@ -14,7 +14,8 @@ if($argv[1] && $argv[2] && $argv[3]) {
       if ( mysql_result(mysql_query("SELECT COUNT(*) FROM `devices` WHERE `hostname` = '$host'"), 0) == '0' ) {
         $snmphost = trim(`snmpget -Oqv -$snmpver -c $community $host sysName.0 | sed s/\"//g`);
         if ($snmphost == $host || $hostshort = $host) {
-          createHost ($host, $community, $snmpver);
+          $return = createHost ($host, $community, $snmpver);
+	  if($return) { echo($return . "\n"); } else { echo("Adding $host failed\n"); }
         } else { echo("Given hostname does not match SNMP-read hostname!\n"); }
       } else { echo("Already got host $host\n"); }
     } else { echo("Could not ping $host\n"); }
diff --git a/includes/functions.php b/includes/functions.php
index d1367aa55e..55fff820d4 100755
--- a/includes/functions.php
+++ b/includes/functions.php
@@ -14,7 +14,6 @@ include("cisco-entities.php");
 function rrdtool_update($rrdfile, $rrdupdate) {
   global $rrdtool;
   return `$rrdtool update $rrdfile $rrdupdate`;
-
 }
 
 function getHostOS($hostname, $community, $snmpver) {
@@ -551,9 +550,11 @@ function createHost ($host, $community, $snmpver){
         $host_os = getHostOS($host, $community, $snmpver); 
         if($host_os) {
            $sql = mysql_query("INSERT INTO `devices` (`hostname`, `community`, `os`, `status`) VALUES ('$host', '$community', '$host_os', '1')");
-           return("Created host : $host ($host_os)");
+           if(mysql_affected_rows()) {
+             return("Created host : $host ($host_os)");
+           } else { return FALSE; }
         } else {
-	   return("Not added bad host : $host");
+	   return FALSE;
 	}
 }