Fully convert core to a modern module (#13347)

* Core module WIP

* update OS::make()

* core WIP

* try to finish up

* switch all core do os Model

* Mock WIP

* Working tests

* cleanup

* phpstan fixes

* style fixes

* fix agent

* trim space too
and a couple of cleanups

* corrected ios test data

* missed space

* update test data

* put escapes back

* another net-snmp difference

* Fix class description

* revert snmp.inc.php change, that can be a different PR

* revert snmp.inc.php change, that can be a different PR

app/Models/Device.php

@@ -37,34 +37,36 @@ class Device extends BaseModel
     public $timestamps = false;
     protected $primaryKey = 'device_id';
     protected $fillable = [
-        'hostname',
-        'ip',
-        'status',
-        'status_reason',
-        'sysName',
-        'sysDescr',
-        'sysObjectID',
-        'hardware',
-        'version',
-        'features',
-        'serial',
-        'icon',
-        'overwrite_ip',
-        'os',
-        'community',
-        'port',
-        'transport',
-        'snmpver',
-        'poller_group',
-        'port_association_mode',
-        'snmp_disable',
-        // ---- snmpV3 fields ----
+        'authalgo',
         'authlevel',
         'authname',
         'authpass',
-        'authalgo',
-        'cryptopass',
+        'community',
         'cryptoalgo',
+        'cryptopass',
+        'features',
+        'hardware',
+        'hostname',
+        'icon',
+        'ip',
+        'os',
+        'overwrite_ip',
+        'poller_group',
+        'port',
+        'port_association_mode',
+        'retries',
+        'serial',
+        'snmp_disable',
+        'snmp_max_repeaters',
+        'snmpver',
+        'status',
+        'status_reason',
+        'sysDescr',
+        'sysName',
+        'sysObjectID',
+        'timeout',
+        'transport',
+        'version',
     ];
 
     protected $casts = [