feature: Allow customisation of rrd step/heartbeat when creating new rrd files (#5947)

* feature: Allow customisation of rrd step/heartbeat when creating new rrd files

* revert defaults

* added docs + webui config option

* Move RrdDefinition to an Object to make them easier to create and remove the possibility of typos.

* Fix style/lint issues and missing use statements

* 3 more missing use statements

* updated doc + moved schema file

tests/RrdDefinitionTest.php

@@ -0,0 +1,66 @@
+<?php
+/**
+ * RrdDefinitonTest.php
+ *
+ * -Description-
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2017 Tony Murray
+ * @author     Tony Murray <murraytony@gmail.com>
+ */
+
+namespace LibreNMS\Tests;
+
+use LibreNMS\RRD\RrdDefinition;
+
+class RrdDefinitionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testEmpty()
+    {
+
+        $this->assertEmpty((string)new RrdDefinition());
+    }
+
+    /**
+     * @expectedException \LibreNMS\Exceptions\InvalidRrdTypeException
+     */
+    public function testWrongType()
+    {
+        $def = new RrdDefinition();
+        $def->addDataset('badtype', 'Something unexpected');
+    }
+
+    public function testNameEscaping()
+    {
+        $expected = 'DS:bad_name-is_too_lon:GAUGE:600:0:100 ';
+        $def = RrdDefinition::make()->addDataset('b a%d$_n:a^me-is_too_lon%g.', 'GAUGE', 0, 100, 600);
+
+        $this->assertEquals($expected, (string)$def);
+    }
+
+    public function testCreation()
+    {
+        $expected = 'DS:pos:COUNTER:600:0:125000000000 ' .
+                    'DS:unbound:DERIVE:600:U:U ';
+
+        $def = new RrdDefinition();
+        $def->addDataset('pos', 'COUNTER', 0, 125000000000);
+        $def->addDataset('unbound', 'DERIVE');
+
+        $this->assertEquals($expected, $def);
+    }
+}