mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Module status cleanups (#15461)

Browse Source 
* Module status helper

* Correct reference

* Rename function to make it more explicit

* Same for exists checks, normalize argument names

* Use new functions
This commit is contained in:
Tony Murray
2023-10-16 05:03:32 -07:00
committed by GitHub
parent abf4fa0004
commit fb59cfec1c
16 changed files with 60 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
LibreNMS/Modules/Slas.php
View File

@@ -46,7 +46,7 @@ class Slas implements Module
public function shouldDiscover(OS $os, ModuleStatus $status): bool
{
return $status->isEnabled() && ! $os->getDevice()->snmp_disable && $os->getDevice()->status && $os instanceof SlaDiscovery;
return $status->isEnabledAndDeviceUp($os->getDevice()) && $os instanceof SlaDiscovery;
}
/**
@@ -66,7 +66,7 @@ class Slas implements Module
public function shouldPoll(OS $os, ModuleStatus $status): bool
{
return $status->isEnabled() && ! $os->getDevice()->snmp_disable && $os->getDevice()->status && $os instanceof SlaPolling;
return $status->isEnabledAndDeviceUp($os->getDevice()) && $os instanceof SlaPolling;
}
/**