346 Commits

Author SHA1 Message Date
Jellyfrog 6bea59b8a0 Fix SQL injections in ajax_table.php (#11920)
* Fix SQL injections via searchPhrase parameter

* Fix SQL injections via address parameter

* Fix sort injection

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-07-10 14:53:08 -05:00
Tony Murray 8f3a29cde5 Fix sql injection (#11923)
in custom oid code

Thanks to loginsoft p.v.t l.t.d india for the report!
Website: https://www.loginsoft.com/
2020-07-10 14:52:58 -05:00
Jellyfrog 1bb6bd8405 Sanitize graph title input (#11919) 2020-07-09 13:15:19 -05:00
Andreas e2294b57ad Fix graphing with generic_v3_multiline_float (#11916)
#11853 introduced a bug which broke graphing (e.g. for the pi-hole app)
2020-07-09 13:15:11 -05:00
Tony Murray a312436bca Edit maintenance schedule, handle timezone properly (#11889)
Was not properly formatting to user's timezone
Also handle the case where the browser and server timezone don't match
don't show incorrect values in dialog then pop to the correct ones.
Update title on modal to be appropriate
2020-07-02 17:46:16 -05:00
Tony Murray 98502325db fix devices missing from graph view (#11886)
devices without a location were not showing
2020-07-01 17:47:23 +02:00
Tony Murray a5fbf853c9 validation fixes 2020-06-27 07:47:08 -05:00
Tony Murray 5f0388f0e3 Remove DB credentials from config.php
Better validation when config.php does not exist

Update docs and quote password

only populate legacy vars in config_to_json
drop .travis.yml config copy
remove credentials from config.php.default

Check for existance of .env instead of config.php in python scripts

legacy credential cleanup

tiny cleanups

consistent env for artisan server and artisan dusk
2020-06-27 07:47:08 -05:00
Tony Murray ad2da9fcdb Install to Laravel WIP 2020-06-27 07:47:07 -05:00
Tony Murray 92153e1307 Merge pull request #11863 from murrant/fix-recurring-days
Fix recurring maintenance days
2020-06-26 07:57:20 -05:00
Tony Murray 04251cdc94 Fix recurring maintenance days 2020-06-25 22:12:21 -05:00
SourceDoctor ed70b2636a RRD Float Precision Customization (#11853) 2020-06-25 21:51:55 +02:00
SourceDoctor ea58060b16 Hotfix CustomOID visibility (#11861) 2020-06-25 20:53:21 +02:00
SourceDoctor 08b849d999 round for tab availability showing 2020-06-23 20:00:40 +02:00
SourceDoctor 4e6a7291a2 Device Availability Calculation (#11784)
* Device Availability Calculation

* Travis fix

* .

* schema corrections

* flexible duration

* travis

* .

* .

* .

* .

* remove not needed code

* line Text to RRD

* update humantime

* .

* only set up again if device was marked as down

* set RRD area transparency

* save uptime also, to keep last availability as good as possible

* file description correction

* look for outages even if uptime > duration
2020-06-22 22:57:30 +02:00
Tony Murray fa024e3e4e Merge pull request #11839 from murrant/fix-c6kxbar-overview
Fix Cisco Crossbar overview missing
2020-06-21 21:19:31 -05:00
Tony Murray 9372074b6d Merge pull request #11728 from yac01/master
Feature: F5 LTM bandwidth controller
2020-06-19 13:39:36 -05:00
Tony Murray 372db457bd Change tab order 2020-06-19 12:21:18 -05:00
SourceDoctor 8e60f8f56f Application Puppet Agent RRD Runtime Graph fix (#11837) 2020-06-18 18:15:52 +02:00
Tony Murray 3a1992d481 Fix Cisco Crossbar overview
It relied on a global variable that wasn't set anymore.
2020-06-18 09:10:28 -05:00
SourceDoctor 62f850aef9 Cleanup functions.inc.php (#11835) 2020-06-17 14:00:18 +02:00
Tony Murray 867aa132c1 Merge pull request #11661 from SourceDoctor/app_dhcp_enhancement
Application DHCP Upgrade
2020-06-16 17:03:45 -05:00
SourceDoctor e911eef0c8 remove unecessary function 2020-06-16 21:13:56 +02:00
SourceDoctor 6a0366c1e8 Device Maintenance configurable duration (#11821)
* Device Maintenance configurable duration

* increase hour range

* positionize button

* remove wrench icon
2020-06-16 14:13:19 +02:00
Anael Mobilia 22916afb9e Apps - backupninja (#11010)
* GUI - graphs

* GUI - Apps

* Polling

* GUI - apps

* Add backupninja to documentation

* Apps - backupninja : add link to librenmsagent script

* Add backupninja snmprec file

* Delete backupninja.snmprec

No Regression tests on apps (yet), only on devices.

* Remove old debug

* Update language : FR -> EN

* Add debug informations

* File path moved to /etc/snmp/

* Python script now use json

* Update following example on puppet script

* Update installation instructions following puppet example

* Update apps.inc.php

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: SourceDoctor <sourcehhdoctor@gmail.com>
2020-06-16 01:04:30 +02:00
louis-oui 80aca5eec9 Fix availability map downtime (#11638)
* fix

* fix widget

* fix widget

* fix widget

* fix

* last_polled fix

* factorize down / up time device

* factorize down / up time device

* factorize down / up time device

* factorize down / up time device

* factorize down / up time device
2020-06-15 23:53:48 +02:00
Tony Murray 67e637e4ca Maintenance Windows: recurring now works overnight (#11389)
* Alert Rules use Carbon
Use carbon for time queries, need to be careful of timezone quirks.  Timestamps won't have that issue

* Convert existing schedules to UTC

* we only need start end... we already have start/end

* Make AlertSchedule::isActive work

* Table display working (and using Eloquent)

* Schedule creation updated

* WIP

* use Eloquent mutators/accessors

* recurring_day mutator/accessor

* WIP UI

* Fix SQL to handle outside times

* fix up some ui issues

* Convert alert-schedule to new style
Improved sorting customization

* fix whitespace

* support sqlite

* Fix schedule creation missing id

* Fix Device::isUnderMaintenance() add location relation
2020-06-14 16:35:50 -05:00
Tony Murray eb6370acd4 Fix schedule creation missing id 2020-06-14 12:12:13 -05:00
SourceDoctor f9b746577e Webui - Poller Log Link Overlib (#11819) 2020-06-13 16:18:38 +02:00
Tony Murray 13ade9ab6c Merge branch 'master' into alerts-carbon 2020-06-12 07:48:51 -05:00
SourceDoctor 21cea61e37 rewrite Device Group Tab (#11808)
* rewrite Device Group Tab

* travis
2020-06-11 11:12:16 +02:00
Negatifff 4c9a83cd55 Add device groups in overview tab little fix (#11806)
* little title fix

* Update dev-groups-overview-data.inc.php

* Update dev-groups-overview-data.inc.php

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-06-10 17:41:19 +02:00
Negatifff ff55be7d7a Add device groups in overview tab (#11796)
* Added Device Groups panel on Overview tab

* spaces and commas fix

* added color in group name

* spaces and commas fix2

* fix3

* fix attempt 4

* change text color to preexisting class

* change text color to preexisting class v2

* rename title

* capitalize

* rename title again

* title, title... again
2020-06-10 12:38:33 +02:00
arrmo ba1302805f Change Units on Noise Floor (#11790)
* Change Units on Noise Floor

I may be wrong, but I think this should just be dBm (i.e. integrated over the carrier bandwidth). The numbers look much too high to me to be on a per Hz basis.

If I am correct here, this should also be updated in the web interface.

Thanks!

* Update php, correct units for Wireless noise-floor

* Wireless Frequency, don't format_si, to avoid kMHz units

* Update Wireless noise-floor units, in RRD plots
2020-06-10 10:41:36 +02:00
SourceDoctor 213a11eb98 Merge remote-tracking branch 'upstream/master' into app_dhcp_enhancement 2020-06-09 20:37:30 +02:00
dupondje 4611b19ae5 Fix Rancid GIT (#11795) 2020-06-09 09:01:44 -05:00
Tony Murray 28ee0f1823 fix typo (#11798) 2020-06-09 08:05:04 -05:00
SourceDoctor 1093315700 Merge branch 'master' into app_dhcp_enhancement 2020-06-08 20:51:41 +02:00
cjwbath aa51e46350 Don't call clean() on the inputs to the SNMP settings form (#11709)
* Don't call clean() on the inputs to the SNMP settings form, it'll call
strip_tags() and break values with angle brackets in.

* Call htmlspecialchars when outputting DB values to HTML instead

* Escape other stuff that should have been validated elsewhere, just in case
2020-06-08 08:16:40 -05:00
SourceDoctor 7b93b386a3 Alert Template - sort Alert Rules alphabetic (#11786) 2020-06-07 14:46:33 +02:00
SourceDoctor 9836aab818 Show full description text on Asterisk RRDs (#11742) 2020-06-04 23:14:15 -05:00
SourceDoctor 4977394a1e Fixing API Creation Error Message (#11745) 2020-05-30 18:26:02 -05:00
PelliX 5f3b82de6f Added discovery and graphing for JunOS (SRX) RPM probes (#11187)
* Added discovery and graphing for JunOS (SRX) RPM probes

* Proposed changes for a percent based sensor type

* Fixed missing MIB declaration in JunOS YAML discovery file

* Updated Health-information.md to reflect the new percentage value type

* Added separate test data for junos_rpm type

* Update sensors.php

* Update sensors.php

* Update functions.inc.php

* test re-run

* Update junos_rpm.json

* percentage -> loss

* add ifSpeed prev test data

* mis-merge

* update sensors

* and bgp...

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-30 18:24:43 -05:00
SourceDoctor 6b7b143cbb Show full description text on MySQL RRDs (#11738)
* Show full description text on MySQL Connections

* further adjustments
2020-05-30 11:46:58 -05:00
Yacine BENAMSILI 1a152edc67 feature: F5 LTM bandwidth controller 2020-05-29 03:00:42 +02:00
Yacine BENAMSILI fa52264de2 Fix: F5 LTM bandwidth controller 2020-05-28 23:15:35 +02:00
hachpai 4bb064c7ad Enabling general search for ports, devices, and more (#11571)
* Search engine for device, through API

* reviewed port search through API

* fixed die

* Update api_functions.inc.php

* Update api_functions.inc.php

* Update api_functions.inc.php

* Update api_functions.inc.php

* Update api.php

* Update api.php

* Update Ports.md

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-24 17:16:07 -05:00
SourceDoctor cbe572f959 Application DHCP Upgrade 2020-05-22 23:02:19 +02:00
SourceDoctor 5927983c50 Maintenance Mode via Device Settings (#11649) 2020-05-22 15:14:03 +02:00
Facundo Caselles 2f86c66afa WebUI - Improved "dark" theme (#11417)
* -Real dark mode, (themed bootstrap)
-removed inverted colors in navbar

* Test data

* FIX: navbar in mono theme.

* Dark mode rrdtool

* Changed background on gridster to match background of the dark theme

* - Icons and links now are grey
- Modernized tabs style into pills,
- button pagemenu-selected fixed

* Improvements:
- bootgrid-th, are now visible (dark mode to the table headings)
- Changed line color of poller and ping in rrdtool

* Fix some codeclimate errors

* Fix airos.snmprec, reverted to original file
2020-05-21 19:04:54 -05:00