Commit Graph
2746 Commits
Author SHA1 Message Date
JellyfrogandGitHub 71d740770b Remove Log::event (#14526)
* Remove Log::event

Use the Eventlog class directly instead

* wip

* wip

* wip

* Apply fixes from StyleCI

* Update Eventlog.php
2022-11-09 09:47:19 +01:00
Zane C. Bowers-HadleyandGitHub 8511611f64 add HV Monitor, a generic means for monitoring hypvervisors (#14218)
* add HV::Monitor support

* document hv monitor

* add HV Monitor tests

* style cleanup

* fix a few missed style items

* test fix

* more test cleanup

* more minor test tweaks

* more test cleanup

* more test tweaking

* test ordering fix all done... hopefully

* more test cleanup

* minor formatting change
2022-11-07 13:35:48 -06:00
PipoCanajaandGitHub 70524b1e9d fix array (#14564) 2022-11-07 07:10:20 -06:00
Tony MurrayandGitHub 126696e26b Fix APC current divide by zero (#14578) 2022-11-04 11:18:29 -05:00
PipoCanajaandGitHub ce6eaadc2a More Replacement Capabilities for sensor index computation (#14522)
* More Replacement Cap.

style

* more compact

* fix mni.yaml

* too compact, revert

* quantastor

* str_replace was never matched
2022-11-02 16:54:40 -05:00
b6620746c5 Miscellaneous cleanup - part 5 (#14502)
* Miscellaneous cleanup - part 5

* Update includes/discovery/sensors/pre-cache/ipoman.inc.php

Co-authored-by: Tony Murray <[email protected]>

* Update ipoman.inc.php

* string for trim()

* Update ciscosb.inc.php

Co-authored-by: Tony Murray <[email protected]>
2022-10-25 19:27:28 +02:00
PipoCanajaandGitHub 8e3fe223ef Sensors - Allow changing RRD type in YAML and PHP sensor discovery (#14208)
* new row variant

* syntax

* syntax

* DB

* syntax

* schema

* test

* allAdvaTests

* Tests

* Tests

* Tests

* missingMigration

* missingMigration

* Tests

* Tests

* Tests

* Tests

* tests

* tests

* tests

* tests

* tests

* test

* fix_Aos7

* fix snmprec arista

* fix snmprec arista

* fix snmprec arista

* tests

* merge_fix

* aos7 backslash

* aos7

* more

* more

* defaultValue

* arista

* typehint

* tests

* tests

* voss

* aos7

* aos7

* aos7

* testWithoutarista-mos_metamux48-c-0-16.json

* tests

* ciscosb

* new tests with 2004 and only sensors module

* adding wireless module again

* adding wireless module again (cont)

* airos

* aos7

* arista

* arista

* bdcom

* fortigate

* fortigate

* fortigate

* ftos

* ftos

* tests on 1804

* tests once more

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* more

* bdcom

* comware

* edgeosolt

* enexus

* arista-mos

* removeAristaAgain

* ies500_manual_edit

* ies500_manual_edit

* mni

* volius

* zywal

* manually imported arista-mos

* manually imported arista-mos

* arista-mos test is triggering something ...

* restoreArista

* tests

* tests

* aristamos

* ies52xxM_4206.json

* revert linux_supermicro.json

* revert linux_supermicro.json

* benuos

* fortiadc

* rnx-updu
2022-10-25 08:31:02 -05:00
JellyfrogandGitHub 9422b34294 RFC1628: Correct upsBypassVoltage oid (#14488)
* RFC1628: Correct upsBypassVoltage oid

* Update istars.json
2022-10-22 11:46:51 +02:00
JellyfrogandGitHub 19cff69c28 Liebert: use correct description oid (#14489)
* Update liebert.json

* Update liebert.inc.php
2022-10-22 11:46:34 +02:00
JellyfrogandGitHub 3848941d55 hpe ilo: fix filesystem type regex (#14485)
* Update hpe-ilo.inc.php

* Update hpe-ilo_4_with_bat_checks.json

* Update hpe-ilo_5_with_bat_checks.json
2022-10-20 22:50:00 +02:00
JellyfrogandGitHub 56d0c7af19 intelliflash: correct variable typo (#14486)
* intelliflash: correct variable typo

* Update intelliflash.json
2022-10-20 22:49:46 +02:00
JellyfrogandGitHub b18ba17af0 Miscellaneous cleanup - part 4 (#14452)
* Miscellaneous cleanup - part 4

* wip

* wip
2022-10-19 01:33:06 +02:00
JellyfrogandGitHub 31a237b114 Miscellaneous cleanup - part 3 (#14450)
* Miscellaneous cleanup - part 3

* Apply fixes from StyleCI
2022-10-19 00:34:19 +02:00
JellyfrogandGitHub 34a58c3f9f Miscellaneous cleanup, mostly undefined variables - part2 (#14445)
* Miscellaneous cleanup, mostly undefined variables - part2

* wip

* Update Number.php

* Update BridgeMib.php

* Update Xdsl.php

* Update cisco.inc.php

* Update Cisco.php

* Update entity-sensor.inc.php

* Update entity-sensor.inc.php

* Update entity-sensor.inc.php

* Update avtech.inc.php

* Update functions.inc.php

* Update HostResources.php

* Update ports.inc.php

* Update route.inc.php

* Update cisco.inc.php

* Update Cisco.php
2022-10-18 13:30:42 +02:00
JellyfrogandGitHub 1c9234adf1 Hikvision: Dont include empty storage sensor (#14453) 2022-10-18 12:33:41 +02:00
JellyfrogandGitHub 2e187d82b2 Benuos: Remove undefined sensors (#14449) 2022-10-18 12:33:19 +02:00
JellyfrogandGitHub 2ca4596594 Drac: use correct low warn limit variable (#14447) 2022-10-18 12:32:10 +02:00
1fd915c8a3 Fix VRP duplicate BGP Peers (#14431)
* fix VRP not cleaning BGP peers properly

* fix missing field in BgpPeer model

* Update includes/discovery/bgp-peers/vrp.inc.php

Co-authored-by: Tony Murray <[email protected]>
2022-10-11 20:26:56 +02:00
JellyfrogandGitHub 7207614437 Trim whitespaces from device data (#14429)
* Trim whitespace from sensor and ports data

* Update arista_eos_vrf.json

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Update Os.php

* wip

* wip

* wip

* Update querybuilder.json
2022-10-11 12:50:38 -05:00
JellyfrogandGitHub bc9228ca8d snmpwalk functions: dont include invalid data (#14438)
* snmpwalk functions dont include invalid data

* wip

* wip
2022-10-11 09:03:08 -05:00
JellyfrogandGitHub be1a2cec50 Miscellaneous fixes, mostly undefined variables (#14432)
* Miscellaneous fixes, mostly undefined variables

* Update phpstan-baseline.neon
2022-10-11 11:30:00 +02:00
9d00b0c12c Run CI on ubuntu 22.04 (#14379)
* Run CI on ubuntu 20.04

* wip

* wip

* wip

* Update all test data

* remove slashes

* wip

* wip

* wip

* wip

* wip

* wip

* iwp

* wip

* wip

* wip

* wip

* wip

* wip

* wip

Co-authored-by: Tony Murray <[email protected]>
2022-10-10 16:44:11 +02:00
19540900a3 Added support for Ubiquiti UFiber OLT (#14256)
* Added support for Ubiquiti UFiber OLT

* Fixed php files with port detection

* Added missing MIB file

* Fixed test data

* Fixed php script to detect ports compatible with php 8.1

* Fix styleci

* Enforcement of new control styleci

* Apply fixes from StyleCI

* Port detection override

* Changed all "Entry" to "Table".

Co-authored-by: StyleCI Bot <[email protected]>
2022-10-07 22:42:03 +02:00
3b5e93242a Skip empty drac state sensors (#14409)
* Newer iDrac includes empty dimm slots in the memoryDeviceTable
creating ', 0 MB' state sensors. Work around this by not discovering
entities that don't have descr_oid.

* Create drac_3.json

Co-authored-by: PipoCanaja <[email protected]>
2022-10-02 20:00:42 +02:00
daa8c757f6 Fix a few Db* to Eloquent requests (#14278)
* Eloquent for 2 requests

* Eloquent for 1 request

* a few in Dell

* Model

* and more with timos

* and more with timos

* and firebrick

* firebrick

* one query instead of many

* Should use collection get

* Update timos.inc.php

* Update dell-os10.inc.php

* avoid changing timos as it breaks something

* new try with timos

* deps for BGP

* revert deps for BGP

* style

* style

* deps for BGP, 2nd try

* typo

* revert aos7

* fix create

* firebricktests

* firebrick

* firebrick

* cipsec-fix

* cipsec

* timos fix 100th time :)

* ./scripts/save-test-data.php -m os,ports,processors,mempools,vrf,sensors,bgp-peers,mpls,ospf  -o timos -v 7705

* remove timos from this PR

Co-authored-by: Tony Murray <[email protected]>
2022-10-02 16:04:08 +02:00
Tony MurrayandGitHub 59f9d90559 Fix rpi codec state sensor (#14400) 2022-09-27 14:44:01 -05:00
Tony MurrayandGitHub 14f449e567 Fix libvirt count() uncountable error (#14398) 2022-09-27 09:43:27 -05:00
Tony MurrayandGitHub 467cb0ab6b Fix Firebrick local ASN (#14397) 2022-09-27 07:45:51 -05:00
Tony MurrayandGitHub 5b432ddc05 Fix ups nut PHP 8.1 issue (#14392)
https://community.librenms.org/t/sensors-initialisation-fails-with-php-8-1/19697
2022-09-26 12:02:42 -05:00
JellyfrogandGitHub a5b1ef61bc Check dot1dBasePortIfIndex exists before using it (#14337)
* Check dot1dBasePortIfIndex exists before using it

Fixes: array_flip(): Can only flip STRING and INTEGER values!

* Update vlans.inc.php

* Update vlans.inc.php
2022-09-12 15:18:43 +02:00
JellyfrogandGitHub 8692abb830 Prevent errors when hrStorageTable doesn't exist (#14327)
Prevents Illegal string offset 'hrStorageDescr'
2022-09-08 21:52:33 -05:00
53bfb24ef9 Migrate xDSL code to module, and add support for VDSL2 MIB (#14207)
* use component to discover if xDSL polling is needed

use component to discover if xDSL polling is needed

* Components OK, Polling in correct files, no DB for VDSL

* GUI

GUI_suite

* per port as well

* rename

* interface listing

* draytek_snmpsim

* fix arraymerge

fix names and max value

* schema

schema

style

* remove one dbFetchRows

remove 2x dbFetchCell

style

style

remove Legacy dbFetchRow

tests

tests

eloquent

more eloquent

more eloquent

one more gone

* fix properties access

eloquent_insert_update

style

tests

tests

tests

tests

* tests

tests

tests

* adslLineCoding

* Models

* fix not nullable cols in DB from code

default values

typo

rename

typo

schema

fix

fix

vdsl fix now

typo

typo

fix size

fix size

* Power values for VDSL

Power values for VDSL

Power values for VDSL

DB

* cleanup

* Rrd::checkRrdExists

* always enable DSL discovery

style

* xdsl module

* cleanup and move to Module

cleanup and move to Module

cleanup and move to Module

cleanup and move to Module

* Fix display

* fix polling and tenth

* remove legacy poller

* Style and Cosmetics

Cosmetics

Cleanup

* Translations

Translations

* exists

exists

* add test support for xdsl

* remove last component call

unused

* translations

* remove non standard onclick event on xdsl line

* Update Discovery Support.md

Update Poller Support.md

toner_gone

* Notification for removal of lnms config:set enable_ports_adsl true

* enable on devices with potential DSL interfaces

* tests are working now

fix teldat tests

* os_schema

* teldat

* move to new module structure

* move to new module structure

* wrong dump function

* wrong dump function

* laravel_through_key hidden

* Update notifications.rss

* Update notifications.rss

Co-authored-by: Tony Murray <[email protected]>
2022-09-07 19:29:17 -05:00
JellyfrogandGitHub 9e5ced28d4 Fix hrStorageType being undefined (#14260) 2022-09-05 22:34:59 +02:00
Tony MurrayandGitHub c2761b4e12 Remove unused function (#14283)
duplicates other functionality
2022-09-04 13:04:55 +03:00
JellyfrogandGitHub 3e2d7435af Fix more error exceptions (#14266) 2022-09-01 12:30:51 -05:00
Tony MurrayandGitHub a664d12eb7 Fix ipv6 hexdec error (#14254)
* Fix ipv6 hexdec error
convert to SnmpQuery and Ipv6 util

* Don't walk other oids if one fails.
2022-08-28 20:47:51 -05:00
Tony MurrayandGitHub cc787dbc28 Fix ciena-sds inventory bugs (#14252)
* Fix ciena-sds inventory bugs

* mib dir is extraneous
2022-08-26 09:25:51 -05:00
835eac1233 Fix some ErrorExceptions (#14241)
* Fix some ErrorExceptions

* Use Config::get default value

Co-authored-by: Tony Murray <[email protected]>
2022-08-25 10:03:06 +02:00
PipoCanajaandGitHub 2ae0e84091 Fix redeclare of function breaking tests in OS eltex-mes23xx (#14227)
* eltex
* function in Class file
* style
2022-08-24 23:05:38 +02:00
Tony MurrayandGitHub 603713e87c Juniper bgp-peers cleanup (#14236)
Also found a device bug.  Held off on refactoring everything...
2022-08-24 14:45:59 -05:00
Tony MurrayandGitHub db54161b10 Fix os_group unset errors (#14238)
Instead of requiring an isset check for os_group, just set it, but to null
valid isset checks will still work right since it is now set to null.
2022-08-24 14:45:43 -05:00
1dbab5ac7e Error reporting (#14190)
* Error reporting

* Move code to ErrorReportingProvider
Enable reporting of error (and warning) messages.
report module exceptions

* Restore flare key
Not needed to set late anymore.  We set up filtering before it is initialized.

* Remove unnecessary and maybe double Flare report

* lint

* Cannot use typed properties yet, use phpdoc

* fix handleError return type

* Filter both exceptions and reports (so we don't miss any)
Consolidate the check if reporting should be enabled

* Cache reportingEnabled check for the runtime

* Split out middleware to improve readability
Logging of why reporting is disabled
Fix reportingEnabled cache

* Style

* Return some user data

* Change to class based middleware, it looks nicer

* Fix error page error id report, add url.

* also rewrite intended url

* remove link

* Move ignition to production and update flare-client

Co-authored-by: Tony Murray <[email protected]>
2022-08-24 00:33:28 +02:00
b643a5033f Add Cisco Flash storage support (#14219)
* Add Cisco flash storage discovery

* Add Cisco flash storage polling

* LibreNMS indentation

* Move file to storage module

* move file to storage module

* Rename and check

Rename the file and add a check only against Cisco devices

* Rename file

* Change parameter from mib name to file name

Co-authored-by: Tony Murray <[email protected]>

* Add a first test file for review - Nexus C9340 NXOS ver 10.2.2

* Add first device test files for review - Nexus 9340 ver 10.2.2

* Add Cisco IOS 15.2.7 on C2960X snmprec file

* Add Cisco IOS 15.2.7 on C2960X test data file

* Create nxos_n5548-7.3.3.snmprec

* Create nxos_n5548-7.3.3.json

* Update nxos_n5548-7.3.3.snmprec

* Update nxos_n9340-10.2.2.snmprec

* Update ios_c2960x-15.2.7.snmprec

* Update nxos_n5548-7.3.3.json

* Update nxos_n9340-10.2.2.json

* Update ios_c2960x-15.2.7.json

* Update cisco-flash.inc.php

Co-authored-by: Tony Murray <[email protected]>
2022-08-23 11:31:47 +02:00
Tony MurrayandGitHub 465fa3986a Fix Undefined variable/key warnings (#14134)
* Fix Undefined variable/key warnings

* massage for test data

* restore set_numeric, only generates noise

* Fix ucd storage used (apparently free is not stored in discovery...)
2022-08-21 16:23:43 -05:00
59fc562d99 autodiscovery fix (#14213)
* autodiscovery fix

* much simpler approach

* murrant suggestion

* Simplify even more

* Use nullable operator

Co-authored-by: Tony Murray <[email protected]>
2022-08-18 20:30:57 -05:00
Zane C. Bowers-HadleyandGitHub b827e2bbbd add support for Sagan (#14070)
* add sagan instance fetch function

* add sagan discovery

* add sagan poller

* add sagan graphs

* add graph sources

* add sagan to apps page

* remove alert

* more app graph work

* polling fix

* re-order keys and add alert key

* correct field key usage

* add alert and fix a missing unit

* more unit fixes

* add alert status

* add alert rules for sagan

* fix a missing : after S while I am here in the json stat tool helper... also add tests

* now add the tests

* add docs

* point php-cs-fixer at two files

* remove-unneeded sagan instance fetch function

* convert to use app_data

* style fix

* apply bennet-esyoil's suggestions here as well

* update for the new app model

* convert poller to the new method

* convert the sagan device app page

* convert sagan

* doc cleanup
2022-08-04 18:12:34 -05:00
O PalivanandGitHub 06e699d5e8 Fix unnecessary Updates of DB when values are equal (#14179)
* Fix unnecessary Updates of DB when values are equal

* Fix unnecessary Updates of DB when values are equal (style)
2022-08-04 18:01:51 -05:00
Tony MurrayandGitHub 52f0dab2f8 Sensors, convert hex to strings (#14121)
* Sensors, convert hex to strings

* Fix clickshare, it actually was returning hex

* update hpe-mapdu

* skip ict-mps sensors without valid values
2022-07-22 07:59:41 -05:00
PedroChapsandGitHub 07f052738d Added aos6 vlan discovery file (#14107) 2022-07-21 10:56:56 -05:00
PipoCanajaandGitHub 1a211fb636 Revert "Add APC battery operation time polling, including display in WebUI (#14058)" (#14068)
This reverts commit 654f97c302.
2022-06-24 16:58:54 +03:00