2881 Commits

Author SHA1 Message Date
Neil Lathwood 8c6964adf9 Fixed sensor discovery issue for serverscheck os (#16499) 2024-10-06 00:04:38 -05:00
Neil Lathwood 205c104f8e Updated Serverscheck temp sensor discovery (#16488) 2024-10-05 00:43:50 +02:00
Steve Calvário c7e0a14489 Avoid DivisionByZeroError (#16464)
* Avoid DivisionByZeroError

* Use match for entPhySensorPrecision

* Fix style

* Add zepto

* Update match condition
2024-10-01 10:51:40 -05:00
Tony Murray 2531c8d314 FS centec switch transceiver temperature not showing (#16469)
Fix transceiver temperature discovery so it shows up with the transceiver
2024-10-01 01:39:15 +02:00
Tony Murray 2726787f94 OcNOS transceiver tx not visible (#16468)
* OcNOS transceiver tx not visible

* add test data

* isset already checked
2024-09-30 19:32:24 +02:00
Tony Murray dbfb0a6535 OcNOS transceiver temperature display fix (#16460)
* OcNOS transceiver temperature display fix
Temperatures were not displayed in the transceiver area.  Update the group to fix that issue.

* Update test data
2024-09-29 19:18:17 -05:00
Tony Murray e08571c38c Transceiver Support (#16165)
* Add transceivers module

Move os specific code to OS

Fix errors and updated connector names

Add RouterOS, a lot less data there.

Add Comware

Add Exa, required a transformer function (mw to dBm)

Add Junos, revision was too short

Just starting on ui

Graphs, and more ui
some polling fixes

collapse header for small screens

refactor a bit

Missed graphs

Transceivers icon inline

Use @once on popup javascript

update db_schema.yaml

Don't show transceivers in basic view
basic view could use a review

Apply fixes from StyleCI

API functions

Comware don't fail if port is missing

Apply fixes from StyleCI

Add alert rules to collection

Device Overview

Attempt to fix bad alert rule, probably needs more

Fix up Comware and remove old sensors

Mark transceiver metrics without thresholds as Unknown

Routeros cleanup

Exa cleanup

Handle missing port

Graph allow filter by channel

More translations

Add transceiver graphs to port graphs

Add Cisco support, use entPhyscial module data if available

Fix OcNos divisors

Labels on transceiver page

Show encoding if available

Hacky OcNos port mapping

Fix up Junos optics and remove old sensors

FS switch support
Metric casts to prevent thrashing
Extra transform_function support

Add link to transceivers page from overview

Change default sort to group by type, then channel
move some code out of overview blade template
Fix bad type ocnos

Apply fixes from StyleCI

Add scales to graphs

Add some test data

Default sort order for metrcis in SQL applied by default

Transceiver metrics threshold manual settings via WebUI and API

Fixes to channels verbiage

Fix severity calculations

Add cable field for SM/MM/Copper

Apply fixes from StyleCI

update test data

Show DDM

Update DB schema file

Extend serial field to 32, even though devices shouldn't be able to have one longer than 16

Missing import

Add status field to database, that way we can support snmp implementations that only return an enum

Add missing files

Fix db_schema

Fix style

Fixes

Style fix

Work around phpstan issue

Update transceivers.blade.php

Missed getStatus() call

Prevent extra dots when channels are not changed

Update module to match upstream

Save ocnos metrics as sensors

Move to regular sensors

add entity physical index

Update UI to sensors WIP

Apply fixes from StyleCI

Forgot one change

Update ui to use sensors

Remove transceiver metrics

Remove metric os discover code
fs-switch pending

Remove transceiver metrics for fs-centec

Exa link up

Revert all test data

Fix up transceiver module interface

Remove unused Convert class

comware cache and transceiver type

Fix some transceiver metrics filtering and formatting issues

Consolidate display formatting

Coalesce commare hh3cTransceiverTable walks to prevent double walk

Use group to identify transceiver sensors

Fixup routeros

Fix up cisco

update db_schema

Small addition to docs

Improve overview layout and add graph popup

Update Junos

update css files

ddm should be nullable

Increase the field length for type and model

Cisco Improve detection when there is an intermediary container

Add transceiver test data

Apply fixes from StyleCI

Fix incorrect test data

Improve display formatting

Fix test data

Apply fixes from StyleCI

Fix up more data

Fix up more data

Fix incorrect return type in routeros

Update ocnos data

* Remove some remaining references to transceiver_metrics table
2024-09-29 11:05:44 -05:00
PipoCanaja ce89f5b410 APC - runtime discovery, apply divisor (#16441)
* fix for discovery

* snmpsim for sensors after #16435

* and tests

* fix RuntimeBattery
2024-09-28 11:05:44 -05:00
Luis Wolfarth a6c195ee90 LLDP Discovery - LldpRemPortId convert to string when in HEX (#16438)
* Update discovery-protocols.inc.php

When using the LLDP-V2-MIB, the device may reply with lldpV2RemPortId as hexadecimal. To convert it to a string, this update checks if the lldpV2RemPortIdSubtype is '5' = "interfaceName(5)"; if so, the code removes the character ":" from the value of lldpV2RemPortId and tests if it is hexadecimal. If the test is positive, it translates it into a string.

* Update discovery-protocols.inc.php
Added lines 342 to 345 to convert the lldpRemPortId when is hex and lldpRemPortIdSutype is 5.

* Update discovery-protocols.inc.php
Importing lib StringHelpers.

* tabs + tests PANOS

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-26 20:39:25 +02:00
Neil Lathwood 9cddd7fd21 Fixed the issues with JetStream lldp discovery (#16414)
* Fixed the issues with JetStream lldp discovery

* Added is_array() check
2024-09-25 14:43:24 +02:00
Tony Murray 0a5c174f4f Fix test regressions introduced while tests were broken (#16399)
* AuthSSOTest: clear roles cache

* PollingJob: When a poller module doesn't exist, return null instead of false.  Skip all other checks and disable polling in that case.

* Sensors: Guess high and low limits separately as needed

* Sensors: drac test psu current data was wrong, referencing the snmprec, 8 / 10 and 0 / 10 should be the values
NOTE: drac is messed up and runs a billion snmp queriess for no reason

* please phpstan

* Sensors: limits reference old code
move to "creating"

* Fix gw-eydfa accidental assignment

* Fix ies5000 test data now that the bad state is removed

* Fix ies5000 test data part 2

* Move sensor discovery reset into discover_device()

* infinera remove duplicate sensor (also a lot of trailing whitespace apparently)

* Fix innovaphone bad yaml discovery

* module tests should be using null when test data doesn't exist, not an empty array

* When discovery or polling is not supported, dump null instead of an array.
Account for nulls in testing

* update ISE serial

* Janitza was seemingly wrong before

* Remove some private data

* bgp-peers requires ipv4-addresses and ipv6-addresses for bgpPeerIface

* fix polycomLens broken state sensor discovery

* Raritan pdu and pdu2 test data was combined in one test file, split it out

* scs-ks duplicate temperature sensor indexes

* sentry3 someone tried to avoid breaking stuff but just broke things more

* smartos-dcp-m fix incorrect numeric oids

* ssu2000 apparently test data was wrong, must have fixed a bug in the code.

* timos remove duplicate dbm sensor definitions

* bgpPeerIface is working in tests now

* Fix moxa-etherdevice when mibs are a bit different

* xw_to_dbm negative values should return null

* Update cisco test data due previous fixes/changes

* One more bgpPeerIface

* Add orderBy to ospf module db dumps

* Remove links test data for now

* Improve handling of bad data in ipv6-addresses module
2024-09-23 10:11:05 -05:00
Tony Murray a0587154c4 Sensors move can skip and output into singleton (#16392)
* Sensors move can skip and output into singleton

* style

* rrd_type

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-13 10:23:17 -05:00
Shane Mc Cormack 5e9e1e9c95 Fix detecting stacks in unstacked switches. (#16384)
Fix #16374
2024-09-10 21:54:52 +02:00
Tony Murray f54e38f4fe More cisco state fixes (#16369)
* More cisco state fixes
Turns out it was fetching values as strings.  Swap to SnmpQuery and fetch the data numeric as expected

* Apply fixes from StyleCI

* update MIB too

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-06 18:49:55 -05:00
Tony Murray 0b9312a77a Fix some issues with cisco entity sensors (#16365) 2024-09-06 10:46:52 -05:00
Tony Murray f15f8fa63a Sensors remove reliance on global variable (#16344)
* Sensors remove reliance on global variable

* Apply fixes from StyleCI

* Clear the instance instead of reset.
Remove $valid['sensors'] from docs

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-03 21:04:34 -05:00
makriska 4efad1ae69 Fix handling of zero value for entSensorThresholdValue for dbm cisco sensor (#16336)
* add handling of zero value for entSensorThresholdValue for dbm sensor type

this addresses https://github.com/librenms/librenms/issues/16335
* Update cisco-entity-sensor.inc.php
* safe check for $key['entSensorThresholdValue']
* style
---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-03 21:39:05 +02:00
Tony Murray 03d3660dfa Fix Cisco entity-sensor (#16351)
* Fix Cisco entity-sensor
make mw_to_dbm and uw_to_dbm handle negative numbers

* fixes and update test data
2024-09-03 09:02:02 -05:00
Tony Murray d8097b0c21 awplus sensor fixes (#16348)
* awplus sensor fixes

* Update test data
2024-09-02 22:26:02 -05:00
Tony Murray 64c0d6ff7f Ignore entity-sensor invalid values (#16347) 2024-09-02 21:44:29 -05:00
Tony Murray 9d35fbc6a7 Entity Physical discovery: Rewrite to modern style (#16289)
* Initial entity-physical code

* Split out Entity-MIB trait

* Cisco Cellular inventory

* Fix bad test data

* alfo80hd - we now include all entPhysical entries

* Correct aos7 test data

* Add entPhysicalClass as last resort for label in ui

* aos add previously filtered data

* Fixup arista-eos data

* Update ariast_eos data

* Arris, clean garbage in Rev fields

* Aruba Instant custom inventory ported

* ArubaOS CX add vendor type mib

* aviat-wtm test data refresh

* axos add shelf fix data fields a bit

* ciena-rls

* ciena-sds

* Skip cimc for now... no test data

* Cisco updates

* Comware data update

* Update dnos

* Clean Edgeos garbage, make code from Arris shareable

* Relaxed ifIndex match, some devices cheat and send back static strings instead of formatted OIDs

* Regex refinement and updated edgeos with new clean data

* Update edgeswitch data

* Update eltex-mes21xx data

* eltex-mes23xx

* Guess at eltex-mes24xx since there is no test data

* Update eurostor, fix firmware version

* Apply fixes from StyleCI

* fixes

* Update fortigate data

* Update fortiweb, ftd, and fusion

* Update linux LSI

* Fix hexToAscii null removal with different seperator handling

* icotera add final snmprec data to avoid snmpsim bug

* Update IOS data

* Update mrv-od

* Add junos translation

* Generic data updates n-r

* ruijie workaround snmpsim bug

* Port saf-cfm

* Recode Schleifenbauer, and fix entPhysicalIndex values

* SmartAX fixes

* sm-os and tait-infra93

* timos inventory was not right, fix it up

* ubiquoss-pon

* VRP, has custom data collection on top of normal
adapt port ifIndex lookup to handle it

* VRP exceeded the string length specified in ENTITY-MIB...

* data updates

* Final data update and code cleanup

* Apply fixes from StyleCI

* Lint fixes

* Add missing SnmpResponse->pluck() code

* Update db_schema.yaml

* Fix bad test data

* Another instant-on update

* oops

* Remove some unused code

# Conflicts:
#	includes/html/pages/device/overview.inc.php

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-21 01:12:09 -05:00
PipoCanaja d1ee543b6b bug - Fixing 'cisco-pw' cpwVcMplsPeerLdpID (#16268)
* fix for cpwVcMplsPeerLdpID in IP form

* tests
2024-08-03 12:57:33 -05:00
Ferris-0815 520e44b0ed F5-Loadbalancer module to support an expiration check of the installed certificates (#16217)
* On branch f5-cert-expiration-check
Changes to be committed:
	modified:   app/Http/Controllers/Device/Tabs/LoadBalancerController.php
	modified:   includes/discovery/loadbalancers/f5-ltm.inc.php
	modified:   includes/html/pages/device/loadbalancer.inc.php
	new file:   includes/html/pages/device/loadbalancer/f5-cert.inc.php
	modified:   includes/polling/loadbalancers/f5-ltm.inc.php

These patches extend the F5-Loadbalancer module to support an expiration check of
the installed certificates.

* some minor corrections to (hopefully) pass the style-check

* a few more impovements to pass the style-chek

 On branch f5-cert-expiration-check
 Your branch is up to date with 'origin/f5-cert-expiration-check'.

 Changes to be committed:
	modified:   includes/discovery/loadbalancers/f5-ltm.inc.php
	modified:   includes/polling/loadbalancers/f5-ltm.inc.php

* more style-check adaptions...
2024-07-29 14:57:37 -05:00
Tony Murray b41d1b7ffb Fix Port Channels take 2 (#16246)
* Resubmit of #16227

* Add missing new files
2024-07-26 08:45:34 -05:00
Jellyfrog e45dd59f77 Revert "Fix Port Channel (#16227)" (#16245)
This reverts commit 0d201c44c9.
2024-07-26 15:26:04 +02:00
Tony Murray 0d201c44c9 Fix Port Channel (#16227)
* Fix expandable sizing

* Temp fix: port_id_{low,high} is actually ifIndex

* new PortsStack discovery module, store actual port_ids

* Show 4 rows of ports by default

* Add test data

* Fix up the single port view too

* Apply fixes from StyleCI

* Update db_schema.yaml

* Update base migration because sqlite cannot add primary keys

* Fix phpstan failures

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-07-25 23:39:36 -05:00
PipoCanaja 97a13f6fe8 discovery - LLDPv2 support extension, and discovery-protocols tests (#16113)
* LLDPv2

* style

* styleAgain

* LLDPv2Tests

* discovery_module_tests

* VRP links tests

* tests

* AOS

* DLINK

* CISCOSB

* AOS

* AOS7

* ARUBA

* ZYNOS

* DLINK

* fix orderby

* edgecos

* boss

* edgeswitch

* voss

* eltex-mes23xx

* fs-switch

* ciena-sds

* cisco

* procurve

* tests/data/moxa-etherdevice

* junos

* mypoweros

* fixTestsArubaOS_orderby

* tests/data/bti800.json

* tests/data/scalance_xc206-2sfp.json

* ciena-sds

* aruba-cx

* orderby remote_port as well

* vrp

* force test rerun
2024-07-17 16:07:57 -05:00
Tozz 22a8a237e8 Add value 0 to HP Physical Drive Status (meaning no disk is inserted) (#16211)
* Add value 0 to HP Physical Drive Status (meaning no disk is inserted)

* Updated test data

* Updated test data

* Update hp.inc.php
2024-07-17 17:42:08 +02:00
Tozz 9abfa7b0e6 Fix FortiGate Cluster Sync status (#16206)
* Fix FortiGate Cluster Sync status

* Update fortigate.inc.php

* StyleCI

* Tests

* Update fortigate.inc.php

* Add files via upload

* Delete tests/data/fortigate_500d.json

Weird unrelated OSPF test failure

* Re-add fortigate_500d.json

* Fix author/copyright

* Update fortigate.inc.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-07-17 01:19:08 -05:00
Tozz b0c7fe8c8d Revert "Fix Fortinet HA-status polling state translations (#14921)" (#16202)
This reverts commit 531009983c.
2024-07-14 17:30:30 -05:00
Frederik Kriewitz 5e3cfd879d nut-ups: adjust Line Nominal limits (#16180) 2024-07-07 12:57:20 +02:00
Frederik Kriewitz 273226bb5f Add support for Fiberstore branded BDCOM switches (#16162)
* Add support for Fiberstore branded BDCOM switches

* Move mibs into sub-dirrectory

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-07-04 15:22:37 -05:00
Nicolas Berens 137bd231f9 Update axis detection (#16130)
* add PTZ and Dome Cameras

* remove default temperature limits

* set temperature limit per device type

* fix linting

* add test data

* set original limits as default and use integers instead of strings
2024-06-24 19:50:05 -05:00
Tony Murray 04a70d2fda Update Dell MIBs (#16120)
* Update Dell MIBs
tidy up some related code a bit too to make it more readable

* handle extra data correctly (discard it)
2024-06-14 22:33:51 -05:00
Frederik Kriewitz 273253f9d9 fix bdcom/pbn neighbour discovery (#15935)
* fix bdcom/pbn neighbour discovery

* add BDCOM S2900-24S8C4X test data
2024-06-09 19:51:10 -05:00
Peca Nesovanovic b2f23d04ea [vlans] Add VLANs information to Huawei VRP os (#16089)
* [vlans] Add VLANs information to Huawei VRP os

Signed-off-by: Peca Nesovanovic <peca.nesovanovic@sattrakt.com>

* ci

* test data

---------

Signed-off-by: Peca Nesovanovic <peca.nesovanovic@sattrakt.com>
2024-06-09 19:46:45 -05:00
jthiltges 3f4bd69718 Correct swapped SET and WHERE parameters in bgp-peers/dell-os10.inc.php (#15983)
When the code was refactored in daa8c757f6, the selectors and updated columns were reversed.
2024-04-26 08:48:47 -05:00
Holger Hees 9df48647bb fix malformed snmp data parsing (#15931) 2024-04-10 15:40:22 +02:00
Heath Barnhart d457f92f22 devices - Ciena RLS 6500 (#15909)
* rls definition
* Adding discovery
* Temp Sensor Discovery
* files for discovery
* Adding and updating MIBS
* Add snmpsim
* Modified yaml for unit test
* phpfmt format
* ci changes
* fixing temp sensor
* fix json
* db schema out of date causing bad snmpsim json
* changed temperature discovery to php
* With updated snmpsim data
* index_string restored, YAML for temperature
* style
* Fixed index_string usage in JUNOS files
* Update YamlDiscovery.php
Allow filtering on "index" in skip_values
* Move DBM to YAML as well
* style
* schema update
* Slot XX Yyyyyy
remove unwanted dot
* matching tests
* schema, round 2
* states in YAML
* put temp sensor back in yaml
* enable default poll and discovery modules
---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-04-01 18:52:03 +02:00
Guy Lowe 3f6958706d Move sentry3 current/voltage/power sensors to YAML (#15715)
* Move sentry3 current and voltage sensors to YAML, add power to YAML, fix voltage for three-phase

* Sentry3: add systemTotalPower and systemPowerFactor

* sentry3: note that voltage and power factor are configured, not measured

* sentry3: group names to indicate sensors which are configured, rather than measured; prefix current index with infeedID to match previous PHP discovery

* sentry3: add ouprefix to outlet current to match previous PHP discovery index

* sentry3: restrict to recording voltage to only the first feed of each tower, to match previous indices

* sentry3: add snmprec from 3-phase CS-24V4-P32MA

* sentry3: attempt to fall back to Infeed

* sentry3: laravel blade fallback fix

* update tests instead of trying to fall back to old-style descriptions

* sentry3: update expected voltage in test, too

* typo

* fix test

* fix outlet OIDs ; update snmp test data with missing names ; regenerate test output

* add missing num_oids for power

* num_oid requires index, even for system-wide values
2024-03-24 16:47:42 +01:00
AdamB d90a704fcb bug - Fix OSes 'Junos' and 'Hirschmann' misuse of entPhysicalIndex (#15886)
* Increase the column width of entPhysicalIndex and entPhysicalIndex_measured
* Update schema
* Remove unchanged change
* Update test data
* Remove migration and update test data
* Fix hirschmann and junos
* One too many
* Potentially incorrect usage
* Another potentially incorrect usage
* Revert changes to cisco and dell
* Test data changes for loop-telecom and ups-nut
2024-03-12 08:15:15 +01:00
PipoCanaja 4975a984b6 bug - fix unexisting fields in DB entry create/update (#15883) 2024-03-07 18:59:22 +01:00
Tozz 718abd47de Fix for FortiSwitch RPM/percentage fans (#15829)
* Update entity-sensor.inc.php

* FSW Test data

* FSW Test data JSON

* StyleCI

* Update fortiswitch.yaml - Correct state sensor index

* Update fortiswitch.yaml

* Add files via upload

* Fix sensor value at discovery
2024-03-05 00:11:04 +01:00
Rafael Pardim 10c3f7ae94 F5 BIG-IP state and count sensors (#15865)
* F5 BIG-IP state and count sensors

* F5 BIG-IP state and count sensors
2024-03-03 22:48:21 +01:00
Peca Nesovanovic 05ad1fd242 [ipv4] fix /32 addresses discovery (#15863) 2024-03-01 00:27:32 +01:00
Tozz d456e78109 YAMLized version of previous PR for Ericsson SSR 80xx routers (#15834)
* Ericsson IPOS Yaml

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Ericsson IPOS MIBs

* Ericsson IPOS - Serial & Hardware detection

* Ericsson IPOS - Remove mempool from overview

* SSR8020 SNMPrec

* Ericsson IPOS SSR 8020 Test

* Delete tests/snmpsim/ericsson-ipos_ssr8020.snmpwalk

* SSR8020 SNMPrec

* Add storage to overview

* Move to new SnmpQuery

* SnmpQuery() instead of snmp_*

* Delete mibs/ericsson directory

* Create ERICSSON-TOP-MIB

* Add files via upload
2024-02-28 14:42:50 -06:00
Peca Nesovanovic eb6006248f Rewrite ups-nut discovery to SnmpQuery:: (#15850)
* modernize and move ups-nut to unix

* fix test data (group and invalid runtime)

* add Battery Temperature to test data

* lnms dev:check style
2024-02-26 17:48:40 +01:00
Peca Nesovanovic a9befd3b98 fix tp-link jetstream FDB discovery (#14321)
* jetstream fdb discovery

* ci
2024-02-21 12:29:43 -06:00
Peca Nesovanovic 8f2444f782 Rewrite lmsensors discovery to SnmpQuery:: (#15833)
* rewrite lmsensors discovery to SnmpQuery::

* change group name to lowercase (lmsensors)
2024-02-21 12:15:14 -06:00
Peca Nesovanovic bfdc2c472f Rewrite ipv4 address discovery to Eloquent (#15830)
* rewrite ipv4 discovery to Eloquent

* style ci
2024-02-21 12:10:00 -06:00