21010 Commits

Author SHA1 Message Date
Tony Murray
613fd18511 packet_loss macros quick fix (#15961)
* packet_loss macros quick fix
Due to device_perf table going away, this macro no longer functions as it did.
Use device status to make it somewhat functional until a better solution can be found.

* remove space
24.4.1
2024-04-20 09:26:51 -05:00
Tony Murray
9088a34299 Bump version to 24.4.0 24.4.0 2024-04-19 20:52:35 -05:00
Tony Murray
e1c6c54dbd Changelog for 24.4.0 2024-04-19 20:52:34 -05:00
Joe Clarke
018597e7bb Add support for a maintenance boolean in API results. (#15904)
* Add support for a maintenance boolean in API results.

If a device is under maintenance, it would be nice to see that from the
API. This can help drive other automation workflows where LibreNMS forms
a cornerstone in the management source of truth.

* Revert changes made by VSCode formatting.

* Revert two more formatting changes.

* Create a new API endpoint for GETing maintenance status.

This uses the same endpoint name as for setting a device to maintenance
but with a GET verb.

---------

Co-authored-by: Joe Clarke <jclarke@cisco.com>
2024-04-19 19:52:22 -05:00
Tony Murray
1911dcb11f Skip rrd sources that do not exist (#15959)
* Skip rrd sources that do not exist

* Log message will be too noisy, remove it.

* style fix
2024-04-19 15:54:27 -05:00
Alexander Moisseev
7e33e09146 Add missing p5-File-Slurp dependency (#15955) 2024-04-19 21:11:04 +02:00
Tony Murray
36d14480f9 Fix Graph date selector (#15956)
It did not handle strings like now and -2d
2024-04-19 10:22:06 -05:00
Zane C. Bowers-Hadley
03e9b52295 only call stripslashes if it is not compressed, compressed is already protected against munging by snmpd (#15953) 2024-04-19 08:03:34 -05:00
Tony Murray
19344f0584 Fix JS injection in Service Templates (#15954)
You can't put user data in any "onwhatever" attributes, there is no way to sanitize it there.
Use data attributes instead.
2024-04-18 21:45:30 -05:00
Tony Murray
49f8269262 Improved Latency graph (#15940)
* Improved Latency graph
Store loss+jitter info in rrd instead of database
New graph icmp_perf (legacy ping_perf still valid referencing part of the newer data)
Delete device_perf table

* Change loss to an area so it is more visible

* Style fixes

* Cleanups from phpstan & tests

* exit_code fix

* Remove alert usage of device_perf

* Don't use magic __get

* Add test for bulkPing
Add host to previous tests

* style fixes

* Fix issue fping error responses
2024-04-18 09:57:01 -05:00
Tarek
4cce4f082e Fix typ (#15952)
Fixed a typo `Backlog Lenght` -> `Backlog Length`
2024-04-18 14:15:31 +02:00
Tony Murray
d29201fce1 Fix SQL injection issues in packages search (#15950)
https://github.com/librenms/librenms/security/advisories/GHSA-cwx6-cx7x-4q34
2024-04-17 02:32:35 +02:00
Joe Clarke
d7737b9889 Pretty up Slack formatting. (#15898)
* Pretty up Slack formatting.

* Normalize spaces by turning every instance of two or more spaces into
  one space.
* Allow for custom URL links even when strip_tags() is in effect by
  transformaing "standard" markdown syntax into Slack link markdown
  after strip_tags() is run.

* Document the changes to the Slack transport.

While here, flesh out the Slack docs to match the configuration options
one currently sees in the transport.

* Use backticks to escape things from markdown rendering.

* We don't need this other escaping now.

* Fix custom link due to line break.

* Fix spelling typo.

---------

Co-authored-by: Joe Clarke <jclarke@cisco.com>
2024-04-16 11:28:10 -05:00
Jellyfrog
83fe4b10c4 Improve order validation in list_devices function to prevent SQL injection (#15885) 2024-04-16 10:38:17 -05:00
Melhuig
36dc9d3c05 Update Network-Map.md (#15949)
Fix "lnms config:set" command syntax
2024-04-16 09:23:35 -05:00
dependabot[bot]
54e07d0b57 Bump tecnickcom/tcpdf from 6.6.5 to 6.7.4 (#15948)
Bumps [tecnickcom/tcpdf](https://github.com/tecnickcom/TCPDF) from 6.6.5 to 6.7.4.
- [Changelog](https://github.com/tecnickcom/TCPDF/blob/main/CHANGELOG.TXT)
- [Commits](https://github.com/tecnickcom/TCPDF/commits/6.7.4)

---
updated-dependencies:
- dependency-name: tecnickcom/tcpdf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-15 21:25:08 +02:00
Tony Murray
1c4d92341f fix null in services (#15945) 2024-04-14 16:48:13 -05:00
Tony Murray
5828907b23 Fix graph selection when to/from missing from url (#15946)
* Fix graph selection when to/from missing from url
fixes #15840

* Update js cache value
2024-04-14 16:48:01 -05:00
Tony Murray
3d810970fb Fix PDNS recursor error (#15942) 2024-04-14 18:43:35 +02:00
PipoCanaja
e19861c770 bug - Cisco NAC key error (#15934)
* fix https://github.com/librenms/librenms/issues/15933

fixing https://github.com/librenms/librenms/issues/15933

* nullables are now null
2024-04-11 20:59:05 -05:00
mr_lollbrant
5db5435cc3 Update Graylog.md (#15938)
I am using LibreNMS and graylog and it always bugged me that the api user have to be admin in graylog.
So i found out how you fix that :)
2024-04-11 20:51:59 -05:00
CTV
73d8e2cc79 Documentation - opcache issue on Debian 12 (#15870)
* Update Performance.md

Documentation : Opcache issue on Debian 12 with default php stable version (8.2.7)

* Update Performance.md

* Update Performance.md

Typo
2024-04-10 15:43:33 -05:00
PipoCanaja
2bee88da84 tests (#15936) 2024-04-10 21:14:52 +02:00
OSIRIS-REx
393e954664 Added support for new device OS Westermo WeOS (#15674)
* Added support for new device OS Westermo WeOS

updated high limits

* Removed config regarding discovery and polling modules

* First test with moving sensor discovery to YAML

* Updates to discovery snr sensor, new test data, deleted sensors written in php

* Fix for SNR discovery sensor descr

* Removed shdsl from bad_iftype

---------

Co-authored-by: OSIRIS-REx <sphinxes@protonmail.com>
2024-04-10 18:14:11 +02:00
voileux
8d99014948 add type property to Device class (#15930) 2024-04-10 15:40:43 +02:00
Holger Hees
9df48647bb fix malformed snmp data parsing (#15931) 2024-04-10 15:40:22 +02:00
Hidde
f1070108e8 Add Fortigate HA state sensor definition (#15924)
* Add Fortigate HA state sensor definition

* Add SNMP test data to test FortiGate HA state sensor
2024-04-04 14:33:27 +02:00
PipoCanaja
6b2be73a33 fix disabled radio returning 255, overloading tinyint signed (#15917) 2024-04-02 14:06:25 +02:00
PipoCanaja
84e11bcdfe typo for request rate + sanity on numerical not_null values (#15919) 2024-04-02 12:45:32 +02:00
Jason Cheng
06ef3d3552 Fix wrong terminology (#15920) 2024-04-02 12:44:46 +02:00
Félix Bouynot
c220adce28 Cumulus mellanox discovery (#15732)
* Update cumulus.yaml
* Create cumulus_melanox.snmprec
* Update cumulus_cumulus.json
* Update cumulus_edgecore-as4610-54p.json
* Test file cumulus_melanox.json
* Rename cumulus_melanox.json to cumulus_mellanox.json
* Rename cumulus_melanox.snmprec to cumulus_mellanox.snmprec
* Fix cumulus_cumulus.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-04-02 01:00:54 +02:00
Heath Barnhart
d457f92f22 devices - Ciena RLS 6500 (#15909)
* rls definition
* Adding discovery
* Temp Sensor Discovery
* files for discovery
* Adding and updating MIBS
* Add snmpsim
* Modified yaml for unit test
* phpfmt format
* ci changes
* fixing temp sensor
* fix json
* db schema out of date causing bad snmpsim json
* changed temperature discovery to php
* With updated snmpsim data
* index_string restored, YAML for temperature
* style
* Fixed index_string usage in JUNOS files
* Update YamlDiscovery.php
Allow filtering on "index" in skip_values
* Move DBM to YAML as well
* style
* schema update
* Slot XX Yyyyyy
remove unwanted dot
* matching tests
* schema, round 2
* states in YAML
* put temp sensor back in yaml
* enable default poll and discovery modules
---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-04-01 18:52:03 +02:00
Tony Murray
af2f953c7f Bump version to 24.3.0 24.3.0 2024-04-01 10:18:44 -05:00
Tony Murray
d8769760a2 Changelog for 24.3.0 2024-04-01 10:18:43 -05:00
d-k-7
dd6ac92f18 fix catos discovery (#15915) 2024-03-29 10:30:17 +01:00
Justin Lentz
4ddbf8baad Fix Vrf Table (#15912)
* Update vrf.inc.php

* Update vrf.inc.php
2024-03-28 22:50:12 +01:00
dependabot[bot]
cbcfb75003 Bump express from 4.18.2 to 4.19.2 (#15913)
Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.19.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-28 19:29:08 +01:00
Tony Murray
05f06bafc1 OcNOS: add health sensors (#15910)
* OcNOS: add health sensors
Add Health Sensors
Update MIBs
Break out current sensors due to missing thresholds on _IIN sensors

* Add test data

* Wrong processors data
2024-03-27 12:23:44 -05:00
czarnian
f6d67c1cd8 Add support for Huawei YunShan OS (#15903)
* Update Huawei MIBs

* Add YunShan OS definition and discovery

* Add YunShan OS snmpsim and test data

* Update discovery according to newer MIBs

* OS test data update

* OS test data update

* OS test data update
2024-03-25 17:17:53 +01:00
dependabot[bot]
ec174e7f9b Bump webpack-dev-middleware from 5.3.3 to 5.3.4 (#15907)
Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](https://github.com/webpack/webpack-dev-middleware/compare/v5.3.3...v5.3.4)

---
updated-dependencies:
- dependency-name: webpack-dev-middleware
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-24 19:02:11 +01:00
Guy Lowe
3f6958706d Move sentry3 current/voltage/power sensors to YAML (#15715)
* Move sentry3 current and voltage sensors to YAML, add power to YAML, fix voltage for three-phase

* Sentry3: add systemTotalPower and systemPowerFactor

* sentry3: note that voltage and power factor are configured, not measured

* sentry3: group names to indicate sensors which are configured, rather than measured; prefix current index with infeedID to match previous PHP discovery

* sentry3: add ouprefix to outlet current to match previous PHP discovery index

* sentry3: restrict to recording voltage to only the first feed of each tower, to match previous indices

* sentry3: add snmprec from 3-phase CS-24V4-P32MA

* sentry3: attempt to fall back to Infeed

* sentry3: laravel blade fallback fix

* update tests instead of trying to fall back to old-style descriptions

* sentry3: update expected voltage in test, too

* typo

* fix test

* fix outlet OIDs ; update snmp test data with missing names ; regenerate test output

* add missing num_oids for power

* num_oid requires index, even for system-wide values
2024-03-24 16:47:42 +01:00
PipoCanaja
8c4205c614 refactor - remove unused entPhysicalIndex_measured (#15892)
* remove unused entPhysicalIndex_measured
* tests
* tests
* doc
* entPhysicalIndex_measured must be ports OR null currently
* Should not pass tests
* tests
* back to normal
2024-03-19 10:24:07 +01:00
Vadim Rõbalko
8aee02e03f Add support for Ubiquiti Unifi USP-RPS device (#15900) 2024-03-18 15:29:54 -05:00
Vadim Rybalko
418e860485 Add support for Ubiquiti Unifi LTE devices. (#15899) 2024-03-18 13:27:25 -05:00
dependabot[bot]
91b1142f3b Bump follow-redirects from 1.15.4 to 1.15.6 (#15897)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.15.4...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-17 22:03:46 +01:00
Justin Lentz
10f4024d6a Update config_definitions.json (#15895) 2024-03-14 01:35:38 +01:00
Justin Lentz
c3a95cdda9 Revert "Fixed interfaces descriptions for multiport_bits_separate graphs type…" (#15894)
This reverts commit 2928b51c3d.
2024-03-13 00:06:26 +01:00
AdamB
d90a704fcb bug - Fix OSes 'Junos' and 'Hirschmann' misuse of entPhysicalIndex (#15886)
* Increase the column width of entPhysicalIndex and entPhysicalIndex_measured
* Update schema
* Remove unchanged change
* Update test data
* Remove migration and update test data
* Fix hirschmann and junos
* One too many
* Potentially incorrect usage
* Another potentially incorrect usage
* Revert changes to cisco and dell
* Test data changes for loop-telecom and ups-nut
2024-03-12 08:15:15 +01:00
dmbokhan
2928b51c3d Fixed interfaces descriptions for multiport_bits_separate graphs type (#15893) 2024-03-11 16:52:29 -05:00
pjordanovic
d3f4fcfd30 device - EPSON DS-860 + Network Interface Unit DSBXNW1 (#15420)
* Create epson-scanner.yaml

add support for epson network scanner

* Create epson-scanner.yaml

add discovery info

* Add files via upload

epson_scanner_ds-860.snmprec

* Update epson-scanner.yaml

added snmp_bulk: false

* Update epson-scanner.yaml

* Update epson_scanner_ds-860.snmprec

change from snmbulkwalk to snmpwalk

* fix epson_scanner_ds-860.snmprec

* Rename epson_scanner_ds-860.snmprec to epson-scanner_ds-860.snmprec

* Create epson-scanner_ds-860.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-03-11 22:49:06 +01:00