Commit Graph

1428 Commits

Author SHA1 Message Date
Gerald VINCENT
11903150c8 Zyxel AP wireless client discovery enhancement (#14704)
* Update Zyxelnwa.php

Discovering wireless clients on all bands

* Update ZYXEL-ES-WIRELESS

Replace '_' by '-' as it is a bad practice to use underscores in values

* Update Zyxelnwa.php

* Update ZYXEL-ES-WIRELESS

* Update zyxelnwa.snmprec

* Create zyxelnwa.json

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update ZYXEL-ES-WIRELESS

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update Zyxelnwa.php

* Update Zyxelnwa.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-06 00:43:59 -06:00
Tony Murray
1dd1ddc2ca Prometheus on failure, disable for rest of run (#15546) 2023-11-05 18:29:25 -06:00
Janno Schouwenburg
5b63f109c6 Dantherm hostname (#14223)
* Support for configured hostname to override sysName

* Update and add test data

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 19:25:56 -05:00
Tony Murray
4622742629 Misc device column cleanups (#15518)
* Misc device column cleanups
Update last_ping on poll

* Revert inserted change for now
2023-11-02 01:51:52 -05:00
Tim de Boer
d5c6d0aaf4 Fixed BGP Remote peer link and graph in Routing Overview, or just static text when not a device in LibreNMS (#15535)
* Fixed BGP Remote peer link and graph in Routing Overview, or just static text when not a device in LibreNMS

* Added extra space

* Reverted back to overlibLink (due to BGP update graphs on hover)

* Added extra space

* Remove graph for remote peer, as it is falsely (showed earlier the Updates Graph for local peer)

* Removed unnecessary/unused code

* Remove graph for remote peer, as it is falsely (showed earlier the Updates Graph for local peer), replaced with just a DeviceLinks

* Change Url::deviceLink to return $text if the device doesn't exist.  Default to ''
Import some of the things to improve readability.

* update phpdoc

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 00:41:19 -05:00
Peter Childs
828be4bb52 add auth_ldap_cacertfile and auth_ldap_ignorecert options (#15526)
* add auth_ldap_cacertfile and auth_ldap_ignorecert options

* style-ci
2023-11-01 20:48:44 -05:00
Tony Murray
183f9559f4 New command: lnms report:devices (#15539)
* New report:devices command
Print out a list of devices with user specified fields, optionally in csv format

* Polish

* Apply fixes from StyleCI

* Use spaces instead of tab for none type

* Fix method call

* other commands use whereDeviceSpec

* Apply fixes from StyleCI

* update command help and back to tab for separator

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-01 13:52:21 -05:00
Tony Murray
44521ab2f1 UCD buffers and cache discovered with inverted free/used values (#15538)
* UCD buffers and cache discovered with inverted free/used values
(polling was correct)

* UCD Discovery was also double calculating "available"

* update test data

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-01 11:22:04 -05:00
Tony Murray
b9881bbf36 Cisco WLC: fetch LWAPP SSIDs for client counts (#15531)
* Cisco WLC: fetch LWAPP SSIDs

* Apply fixes from StyleCI

* no need to check twice

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-01 11:21:11 -05:00
PipoCanaja
63f33642b8 string VS array (#15533) 2023-10-31 15:22:18 -05:00
Tony Murray
e1f6b77204 Fix Ciscowlc error when bsnApIfNoOfUsers is not present (#15529)
fixes #15517
2023-10-31 08:25:35 -05:00
Tony Murray
7c542d70af SnmpQuery runtime cache (#15512)
* SnmpQuery runtime cache
Optionally cache the SnmpResponse from queries for the rest of the runtime.
It would be nice to have cache hits for these to help prevent wasting memory caching data that is only used once.
Key data must match: device, context, options, oids

* Apply fixes from StyleCI

* Add command to the cache key

* Caching in the wrong spot, cache individual commands...

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-29 22:46:04 -05:00
Tony Murray
c22b74d46b Bump version to 23.10.0 2023-10-26 22:47:36 -05:00
Tony Murray
db17036f5d Ospf metrics fix (#15508)
* Ospf metrics fix
If the device gave an invalid IP for metrics, it would fail.
Fix this issue, and optimize the sql queries so less are needed.

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-26 11:21:08 -05:00
Tony Murray
7e0b41a05a IP::fromHexString handle ascii (#15504)
* IP::fromHexString handle ascii
Some bad MIBs convert the hex to ascii on display.
Attempt to decode that if the situation is detected.

fixes #15501

* add ascii tests
2023-10-26 10:03:03 -05:00
Tony Murray
811416eec4 Fix poller perf graph time (#15500) 2023-10-24 07:16:23 -05:00
Tony Murray
98992345fa Do not update device IP when DNS resolution fails (#15499) 2023-10-23 20:09:55 -05:00
Tony Murray
79cc5c9114 IS-IS polling handle missing data (#15491)
fixes #15489
2023-10-23 11:02:17 +02:00
Félix Bouynot
6ce43a300b Fix regression causing wall of ping latency (#15486)
Fix https://github.com/librenms/librenms/issues/15382
2023-10-20 07:30:51 -05:00
Tony Murray
f0aa80e73d ports ifPhysAddress use MAC helper (#15478)
* Ports min polled period of 1
Prevent divide by 0
Use Mac utility

* fix bad snmprec for airos-af-ltu

* Update a large amount of invalid mac addresses
either the script is capturing them wrong or users are mangling them

* More updated test data

* Update test data with bad input

* Fix ones using encoded <private> and attempt to fix capture

* Update awplus data

* restore missing data

* update other DNOS

* Fix ones using encoded <private> and attempt to fix capture

* Fix ones using encoded <private> and attempt to fix capture

* fix typo

* Update some data

* update data

* update ruijie
2023-10-19 20:10:52 +02:00
metrojworthington
7bd1a57c3e Mcc valere (#14753)
* modifications needed for update of VALERE-DC-POWER-MIB with new file ELTEK-BC2000-DC-POWER-MIB

* add test results for BC2000 post update

* updated test file data

* re-upload of updated files

* reverted valere.json to defaults and recreated with proper varient .json

* replace vpwrShelfIndex with vpwrBayIndex

* updated test data

* Update test data

* try again valere_bc2000.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-19 07:22:46 -05:00
Tony Murray
8f91fb3877 Fix polling down retry (and other items) (#15483)
* Only update last_polled if polled
Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled

* Tally results and act accordingly

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-19 06:55:41 -05:00
Wade Fitzpatrick
27ef398907 Add alert transport for Grafana Oncall (#15330)
* Add alert transport for Grafana Oncall

* Add doc for Grafana Oncall

* Fix lint

* Fix comment lint
2023-10-18 22:24:40 -05:00
Tony Murray
921872369d Fix rrd exists check (#15466)
Filename incorrect for test
2023-10-16 12:48:01 -05:00
Tony Murray
fb59cfec1c Module status cleanups (#15461)
* Module status helper

* Correct reference

* Rename function to make it more explicit

* Same for exists checks, normalize argument names

* Use new functions
2023-10-16 07:03:32 -05:00
Tony Murray
abf4fa0004 Exclude availability module from default testing (#15462) 2023-10-16 07:02:35 -05:00
Tony Murray
7a8e479b61 Unix Agent and Application fixes (#15460)
* Unix Agent and Application fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-16 03:40:40 -05:00
Tony Murray
fcfaded91f Always create rrd folder on localhost (#15457)
for some reason rrdcached cannot create folders when it is running on localhost
Always create directories on the local poller in case rrdcached is running on the same machine
A few small changes to checkRrdExists() too
2023-10-14 15:29:13 -05:00
bnerickson
78a4bfb9d9 Adding Socket Statistic Application Support (#15307) 2023-10-13 22:45:03 -05:00
Tony Murray
5b77dfc75c Huawei VRP AP controller fixes (#15450) 2023-10-13 22:26:33 -05:00
SourceDoctor
0f0f49697f muteabel acknowledged alert notifications (#15456) 2023-10-13 22:20:51 -05:00
Tony Murray
1caa2dec42 Send event log when alert rule fails (#15440)
Instead of breaking all following alerts when one has an error, just skip that one alert rule and send and eventlog detailing the error.
2023-10-12 19:31:53 -05:00
Tony Murray
afc78d7890 Timos MPLS nullables round 2 (#15448) 2023-10-12 18:53:05 -05:00
Tony Murray
a5198d7d57 Remove some lightly used or unused dbFacile functions (#15418)
* Remove some lightly used or unused dbFacile functions
['NULL'] legacy behavior seems unsupported, replace with actual nulls

* Fix refactor mishap

* another

* update baseline

* these were very wrong... what happened?
2023-10-12 09:15:03 -05:00
Tony Murray
2f33421aed Stop libvirt ssh attempts (#15438)
If enable_libvirt is not enabled, do not attempt to ssh to the target device.
2023-10-11 18:49:16 -05:00
Tony Murray
b7ab5be347 Fix VRP polling (#15428)
Was using deprecated database functions.
Use current methods
2023-10-11 18:36:35 -05:00
Tony Murray
e6be5f777b Use modern device attrib handling (#15429)
* Use modern attrib handling
Remove device attribs array.

fixes #15422

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 18:29:47 -05:00
Tony Murray
6e3261f801 Fix timos mpls, add checks (#15430) 2023-10-11 09:56:09 -05:00
Tony Murray
14d9d66529 Agent: Packages fixes (+pacman) (#15415)
* Agent: Packages fixes
Don't try to save invalid packages, probably due to script failure on device.
Add pacman support

* Apply fixes from StyleCI

* Add version

* cast to number

* Update includes/polling/unix-agent/packages.inc.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2023-10-08 18:37:33 -05:00
Tony Murray
685d11d4f1 Misc fixes 42 (#15413)
* Misc Fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 21:39:16 -05:00
Tony Murray
6848527753 Fix availability graphs (#15414) 2023-10-07 20:12:17 -05:00
Tony Murray
5386b24888 Type safety check (#15409)
* Type safety check
now fails silently, we already have schema validation to check it is a string, but... people find a way.

* Fixup
2023-10-07 18:45:30 -05:00
Tony Murray
e53436b6a3 Calculate downtime from device_outages table (#15397)
* Calculate downtime from device_outages table

* refactor
2023-10-06 20:37:23 -05:00
Tony Murray
072d52e9fd Fix typo (#15406) 2023-10-06 07:51:51 -05:00
Tony Murray
6948b59c11 Add rewrites include for legacy modules (#15405) 2023-10-06 07:39:17 -05:00
Tony Murray
d8c372bbf4 Refactor MAC utilities into a single class (#15379)
* Refactor MAC utils to a new utility class

* Apply fixes from StyleCI

* Inline functions
Add tests
Handle bridgeid format

* Apply fixes from StyleCI

* Dedicated code path for stp bridge parsing, and improve STP output a bit

* Correctly parse dot1dBaseBridgeAddress and don't store int in bool field

* trim any unexpected character from bridge addresses, add extra test data.

* better comment

* barsBridge can handle dot1dBaseBridgeAddress correctly now

* parseBridge, check for properly formatted mac first.

* update test data, empty data = empty mac

* Fix new usage after rebase

* import

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-06 07:34:14 -05:00
Tony Murray
86793653b3 Validate secure cookies (#15401)
* Validate secure session cookies if HTTPS
When HTTPS is available, secure session cookies should be enabled
SESSION_SECURE_COOKIE=true

* Apply fixes from StyleCI

* Note config:cache

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 22:18:49 -05:00
Tony Murray
cc98089af1 Revert "Fix last polled (#15396)" (#15400)
This reverts commit 313e9a48e1.
2023-10-05 21:49:44 -05:00
Tony Murray
313e9a48e1 Fix last polled (#15396)
* Only update last_polled if polled
Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 21:27:57 -05:00
Tony Murray
05c30b6001 Fix last polled in wrong column (#15398)
fixes #15382
2023-10-05 20:58:03 -05:00