Commit Graph

20397 Commits

Author SHA1 Message Date
Tony Murray
2c5960631c Fix injection vulnerability in fdb search page (#15315)
unescaped search output
reported by: https://huntr.dev/users/hainguyen0207
2023-09-14 00:22:42 -05:00
Tony Murray
cfd642be6a Fix injection vulnerability in ports pages (#15314)
* Fix injection vulnerability in ports pages
Unescaped output
reported by: https://huntr.dev/users/hainguyen0207

* fix style
2023-09-14 00:19:12 -05:00
Tony Murray
03c4da62c8 Fix another addcslashes incorrect escape in eventlog (#15313)
and many more
reported by: https://huntr.dev/users/hainguyen0207
2023-09-14 00:07:08 -05:00
Tony Murray
e4c46a4536 Fix another injection in ipv4 search page (#15312)
Reported by: https://huntr.dev/users/trunggg02
2023-09-13 23:48:24 -05:00
Tony Murray
1194934d31 Fix injection in search pages ipv4, etc (#15311)
Reported by: https://huntr.dev/users/hainguyen0207
2023-09-13 23:35:49 -05:00
Tony Murray
49d66fa31b Fix improperly escaped output in outages page (#15310)
Fixes XSS reported by https://huntr.dev/users/hainguyen0207
2023-09-13 23:10:37 -05:00
Justin Lentz
a1eb90fe69 Fix smartos-dcp-m.yaml (#15295)
* Update smartos-dcp-m.yaml

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Remove bogus 0 values

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update DCP-INTERFACE-MIB

* Update SO-TC-MIB

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Test data update

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Remove Grouping

* Update Test
2023-09-12 10:05:08 +02:00
Tony Murray
28603f2a63 Fix error when mail-contact is missing (#15305) 2023-09-11 21:23:26 -05:00
Tony Murray
0f7a066f3a Fix issue with rrdcached with bad input (#15301)
fixes #15299
2023-09-11 01:18:28 +02:00
Tony Murray
74ed7aa703 Fix typo in install docs 2023-09-08 16:48:27 -05:00
Tony Murray
0f8fb0aea3 RouterOS: use mtxrGaugeTable instead of mtxrHealthGroup (#15289)
* RouterOS: use mtxrGaugeTable instead of mtxrHealthGroup
Should now exactly match System > Health
Historical data will be lost

* fix yaml

* Fix numeric oid

* Update test data, add table to crs317

* Add groups and cleanup yaml

* revert state_name as it is used in the rrd file name

* Except the gauge table state sensor

* Group Health -> System

* update json

* update json
2023-09-08 13:55:51 -05:00
Tony Murray
8466d537c6 Additional contact options for email transports (#15266)
* Additional options for email transports
Similar system email options will be deprecated

* Fix lint and style issues
2023-09-08 09:27:23 -05:00
Tony Murray
e978025553 Fix typo in default mibs for SnmpQuery (#15297) 2023-09-08 08:32:01 -05:00
Tony Murray
f670a8074a Fix .env quoting issue (#15298)
Triggered when password contains # and .env file uses windows line returns.

Friends don't let friends use windows line returns
2023-09-08 08:31:41 -05:00
Tony Murray
4dc2ae9d44 Timezone, fix user set no timezone (#15296)
fixes #15277
2023-09-08 07:48:16 -05:00
Slashdoom
e141ee8b8c Update customoid.inc.php (#15260)
include descr and unit in tags
2023-09-08 07:44:19 -05:00
Tony Murray
b51ae39e71 Radius enforce roles (#15294)
Add new setting to specify if user roles will be set at login or not.
Without this setting enabled, roles are only set when the user is first created and never after that. If roles set via Filter-ID attribute or radius.default_roles change, they will never be reflected on existing users.
For that reason, the default is set to enabled.  Historically, radius did not enforce roles.
2023-09-07 11:28:35 -05:00
Zane C. Bowers-Hadley
2618a99be5 Application Soft Delete (#15270)
* add the softdeletes migrations for applications

* add working migration file

* add deleted_at to db schema.yaml for applications

* update includes/html/forms/application-update.inc.php to work with softdeletes

* update includes/html/pages/device/edit/apps.inc.php for softdelete

* update includes/discovery/applications.inc.php to work with softdelete

* minor updates to application-update.inc.php for disabling

* style cleanup

* set discovered when running discovery

* update application tests to include deleted_at

* add deleted_at to a missed test

* a few more tweaks for opensips

* add a missing deleted_at for linux_suricata_extract-v1

* fix fillable for Application model

* massive cleanup of the application update widget thingy

* improve the code for discovery and using Laravel

* add a missing line to app/Models/Application

* add a missing include to app/Models/Application.php

* record includes for Application model

* remove apps from the applications table when a device is deleted

* revert to using upcert and where for discovery to fix CI

* make discovered fillable and set it when running discovery... convert back to firstOrNew

* clean up application discovery a bit and use observer

* style fix

* spelling fix... disablaed -> disabled

* rever removal to just use where

* cleanup app removal on delete

* add restored to ModuleModelObserver

* delete -> forcedelete fix

* apply the suggested changes

* use murrants other suggestion

* style fix
2023-09-06 16:34:39 -05:00
SourceDoctor
013096c092 readd missing key (#15291)
* readd missing key

* .
2023-09-06 16:08:07 -05:00
Pelt10
6d4e1f8d93 Return an 5XX error when an exception is raise (#15285) 2023-09-06 13:41:13 -05:00
SourceDoctor
d991a4b505 fix missing keys for new status (#15284) 2023-09-05 16:08:15 -05:00
SourceDoctor
35ff23b39f show ignored device up when up (#15283)
* show ignored device up when up

* change status string
2023-09-05 11:04:16 -05:00
Tony Murray
6d1b1ac1fa Fix port ifAlias polling (#15279)
Fixes static ifAlias as well.
2023-09-03 22:47:23 -05:00
Wheel
a6ccb596df Custom ssh,telnet port with oxidized (#15255)
* Custom ssh,telnet,http port with oxidized

* Lint fixes

* copy paste minors
2023-09-03 20:15:51 -05:00
Skylark
2b10956f0b Hide token, keys and possword in Transports (#15274)
I've gone over all the Transporters adn changed all 'text' fields for token, keys and passwords to 'password' so the no longer show up as clear text in the GUI
2023-09-01 15:07:39 -05:00
Zane C. Bowers-Hadley
6dbfbe99bc for the applications table set the defaults for app_instance and app_instance to '' (#15278)
* add migration file for new defaults for applications table

* update the db_schema yaml and tweak the migration so it does not change the varchar size for app_status
2023-09-01 15:01:12 -05:00
PipoCanaja
8eeb83928f Add global NAC page and refactor the per-device one (#15228)
* Adding a NAC global port page

* style

* filter_menu_entry

* typo

* ->when()

* device_id always returned

* use request

* laravel conversion, let see how it goes

* styleci

* ->with('device') to avoid 1 query per item processed

* and rewrote on @murrant advice

* any -> get

Suggested by @murrant

Co-authored-by: Tony Murray <murraytony@gmail.com>

* @push('scripts')

* style

* @endpush

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-08-31 20:25:24 -05:00
eskyuu
298d217a8b Added support for Nutanix VM count, disk state, CPU usage and RAM usage (#15252)
* Added support for Nutanix VM count, disk state, CPU usage and RAM usage

* Added num_oid values required for pull request

* Fixes for Nutanix AOS graphs
2023-08-30 21:11:04 +02:00
Tony Murray
30b5c40961 Add ui description for reporting dump_errors (#15264)
* Add ui description for reporting dump_errors
People were enabling this setting and breaking their installs for some reason.
Hopefully, this makes them think a little before enabling this setting.
It is intended for debugging purposes only.

* Fix style
2023-08-30 19:33:39 +02:00
Tony Murray
9c6fc31113 Fix LDAP Authorization Authorizer (#15267)
https://community.librenms.org/t/8-28-sudden-ldap-authentication-issues/22176/10
2023-08-30 19:33:13 +02:00
Tony Murray
976cb53ead Fix install failing this migration (#15262)
Unsure if this the correct fix or if it even fixes the issue :D
https://community.librenms.org/t/install-fails/22181
2023-08-29 08:00:17 -05:00
Tony Murray
bbe835b5f9 Radius update roles correctly (#15261)
Needs a re-write so semantics line up with Laravel auth better, but this is the quick/safe fix.
2023-08-28 23:38:09 -05:00
Tony Murray
b889e218dc LDAP Authorizer hand count entry (#15259) 2023-08-28 14:06:33 -05:00
Tony Murray
f622a96c70 Fix mysql auth removing roles upon login (#15258) 2023-08-28 11:00:18 -05:00
Tony Murray
c737788727 Roles user add fix (#15257)
* Fix user add command doesn't allow roles

* update baseline
2023-08-28 10:27:56 -05:00
Tony Murray
744ff7543e Fix missing roles (#15256) 2023-08-28 09:39:03 -05:00
Tony Murray
2cd207028a Implement RBAC (only built in roles) (#15212)
* Install bouncer

* Seeder and level migration

* Display and edit roles

* remove unused deluser page

* Update Radius and SSO to assign roles

* update AlertUtil direct level check to use roles instead

* rewrite ircbot auth handling

* Remove legacy auth getUserlist and getUserlevel methods, add getRoles
Set roles in LegacyUserProvider

* Small cleanups

* centralize role sync code
show roles on user preferences page

* VueSelect component WIP and a little docs

* WIP

* SelectControllers id and text fields.

* LibrenmsSelect component extracted from SettingSelectDynamic

* Handle multiple selections

* allow type coercion

* full width settings

* final style adjustments

* Final compiled assets update

* Style fixes

* Fix SSO tests

* Lint cleanups

* small style fix

* don't use json yet

* Update baseline for usptream package issues

* Change schema, not 100% sure it is correct
not sure why xor doesn't work
2023-08-28 00:13:40 -05:00
Hans Erasmus
4fc27d98e9 Another OR statement in GrayLog API (#15246)
* Another OR statement in GL-api

* try again to fix linting issue

* yet more linting issues

* Cannot fix me being an idiot
2023-08-25 07:56:29 -05:00
Félix Bouynot
93d7286381 Initial support for f5os (#15241)
* Create F5-COMMON-SMI-MIB

* Create F5-PLATFORM-STATS-MIB

* Create f5os.yaml

* Create f5os.yaml

* Create f5os_f5os.snmprec

* Create f5os_f5os.json

* Remove remaining test line

* Add mandatory num_oid

* Add num_oid for fanspeed

* Force use of index for fanspeed

* Force index for temperature + add snmp_flags to make it work

* Update test data

* Update test data
2023-08-25 01:53:21 +02:00
fbourqui
c3d0426311 WebUI Services, generate more compact table (#15243)
Fix edit, delete button on top of each other,
2023-08-25 01:51:01 +02:00
adamsweet
373a286f83 Update seveity colours in SNMP-Traps.md (#15244) 2023-08-25 01:49:22 +02:00
Zane C. Bowers-Hadley
97f38579a2 note the package install command for dhcpd-pools for FreeBSD (#15247) 2023-08-25 01:46:07 +02:00
Tony Murray
d7ae34d390 Fix API availability graph duration (#15250)
Add default duration
2023-08-24 14:40:33 -05:00
Tony Murray
cfc9aca6a4 Revert "Added empty string check (#15235)" (#15249)
This reverts commit cbe2ba55ce.
2023-08-24 10:09:50 -05:00
Tony Murray
723600751c Dispatcher option to log output (#15230)
* Dispatcher option to log output
-o --log-output Log output into various files in the log directory
wire up -d option to be passed into scheduled commands
Caution, can fill your disk.

* style fixes

* more silly style fixes (and a typo accidentally added)

* final lint maybe?

* more lint...

* believe it or not, more lint
2023-08-21 18:28:07 -05:00
eskyuu
7d950825a1 Make the service template controller re-evaluate dynamic membership when apply all button is pushed (#15214) 2023-08-21 18:27:54 -05:00
PipoCanaja
99cfbf1d63 Use full name for vendor_oui (#15234)
* Use full name for vendor_oui

* trimmed

* typo

* more spaces to remove

* don't set $short_vendor

* keep line return

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-08-21 16:13:28 -05:00
Tony Murray
3b7185d825 Fix manual port speed storage (#15238)
* Fix port speed setting
Due to a bug all manually configured port speeds were lost and will need to be reconfigured.
This allows them to work in a way that will prevent that issue in the future by storing the speed with the override.
Includes notification.

* Fix date

* Add URL

* Spelling fix
23.8.2
2023-08-21 10:48:13 -05:00
Tony Murray
b04e31710d Fix ifSpeed override not being applied (#15237) 23.8.1 2023-08-21 00:31:19 -05:00
Fehler12
cbe2ba55ce Added empty string check (#15235)
* Added empty string check

* replaced tabs with spaces

replaced tabs with spaces

* Removed '(', ')' and enlarged if clause

* Added one space and removed an empty row

* removed is_null

Removed is_null check as static code analysis says that this variable cannot be null at this time

* compact form

* handle spaces

In case the sysName is " " (one space). Good to trim anyway.

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-08-21 00:17:25 +02:00