80 Commits

Author SHA1 Message Date
Tony Murray 1d777693e1 feature: New IP parsing classes. Removes usage of Pear Net_IPv4 and Net_IPv6. (#7106)
* Refactor remove use of pear Net_IPv4 and Net_IPv6

Caution, I added tests to test the functionality of the new functions, but I'm not 100% certain the replaced usages match 100%.  Please test.

Left usage in generate-iplist.php because I'm not sure the use of that script, so I didn't want to implement additional functionality to support it.

Add support for ipv6 fo ipInNetwork() function

Add phpdocs to functions
Remove accidental inclusion

Use binary operations instead of string for networKFromIp()
Tidy up binary operations in ipInNetwork()

tidy parsing cidr network

Change to a class based implementation.

Update phpdocs.
Fully catch exceptions for hex parsing.

Fix mistake.

support older phpunit versions

Fix php shifting to negative with php 5

* Fix graph authorization. Uncaught exception and checking an ipv4 against an ipv6 network == fail.

* Also remove colons from hex strings.

* Fix typo in bgp polling
Two passes of removing invalid characters from hex strings. (That way we don't mangle valid IPs)
2017-08-08 14:14:58 -05:00
Ben Klang b7f1e09be5 webui: Updated bgp table to use bootstrap properly (#6406)
* Apply Bootstrap table spacing to BGP session list

* I  agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md
2017-04-12 22:30:01 +01:00
Neil Lathwood 1bbbaff58b refactor: Moved ifLabel -> cleanPort and updated the usage (#6288)
* refactor: Moved ifLabel -> cleanPort and updated the usage

* added list of tags allowed

* few updates as per comments from @murrant

* Added simple unit tests

* double display for javascript popover

* Remove ifNameDescr() function
Fix realtime port page

* remove accidental temp code

* Remove double display calls in ajax tables
2017-04-04 08:08:23 +01:00
Neil Lathwood 38cebc5fd7 feature: Added better BGP support for Arista (#6046)
* feature: Added better BGP support for Arista
2017-03-11 23:16:49 +00:00
Tony Murray 20ae9e2ecd webui: Improve device header layout (#5990)
* webui: Improve device header layout

* Update css style version to break caches
Remove unused css.
2017-02-24 09:59:30 +00:00
Tony Murray cbaab1462f Change the size of the bgp updates arrows. (#5913) 2017-02-15 23:16:03 +00:00
Richard Mayhew 6a1fd3ec05 webui: Additional Font Awesome icons (#5572) 2017-01-25 17:42:26 +00:00
Neil Lathwood da5783d917 feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY (#5327)
* feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY

* fix all schema errors and update system
2017-01-07 11:32:38 -06:00
Neil Lathwood 9b9c10e204 fix: Cleanup printing ifAlias (#4874) 2016-12-12 14:25:48 +00:00
Tony Murray a83e126b40 refactor: Remove inappropriate usages of truncate() (#5028)
Where truncate() is used as substr(), replace with substr()
2016-11-20 11:12:25 +00:00
Søren Rosiak 0bb7bfde9e feature: Added CEF Display page (#3978) 2016-10-11 07:20:59 +01:00
Bennett Blodinger 07574b27d8 Move to Font Awesome
Keeps the look more in line with the navigation bar icons.
In the future with Bootstrap 4, Glyphicons will not be included, so this
starts the transistions away.
2016-09-22 10:44:17 -04:00
Tony Murray b8e9b2d917 Implement an autoloader (#4140)
* Implement an autoloader

When cleaning up classes for psr2, things got a bit unwieldy, so I implemented a class autoloader.
I created a PSR-0 compliant LibreNMS directory and moved all classes there that made sense.
Implemented LibreNMS\ClassLoader which supports adding manual class mappings

This reduces the file includes needed and only loads classes when needed.

* Add teh autoloader to graph.php

* Add a small bit of docs
Fix incomplete class in includes/discovery/functions.inc.php
2016-08-21 14:07:14 +01:00
Tony Murray 8c639aa5a4 PSR2 Cleanup: /html edition
Travis tests for code conformance. Ignore warnings for now.
Fixed all errors, left most warnings.
2016-08-18 21:29:30 -05:00
Neil Lathwood e09f5c552c Merge pull request #3800 from murrant/rrd-create-remote
RRD Cleanup: centralize rrd_exists check, utilize data_update() and rrd_name()
2016-08-10 18:44:45 +01:00
laf d56ff8b87f More updates for junos bgp polling 2016-08-03 16:49:41 +01:00
Tony Murray 97daf3dd54 Merge remote-tracking branch 'upstream/master' into rrd-create-remote 2016-08-01 10:18:28 -05:00
Rosiak 1bad01fbc1 OSPF Display Update 2016-07-31 01:05:02 +02:00
Tony Murray 2c98fd7426 Merge remote-tracking branch 'upstream/master' into rrd-create-remote 2016-07-26 19:29:11 -05:00
Aaron Daniels 52455e1128 Component Update - Status
- Align the component status field with the Nagios standard
  0=ok, 1=warning, 2=critical
- Modify existing modules to report these status' (Cisco-OTV)
- Add/Modify Alerting Macros to use these status'
- Add the a component status widget
- update edit page to report these status'
2016-07-11 16:51:01 +10:00
Tony Murray 57650e4ffc Remove nfs requirement for distributed poller (with rrdtool 1.5+)
Use data_update instead of rrd_update/rrd_create and influx_update
Centralize rrd file check so we can check against a remote rrdcached server too
Use rrd_name() to generate rrd file names
2016-07-07 21:10:06 -05:00
laf f3ee9dcc2e Fixed php short tags 2016-05-02 18:43:06 +00:00
Daniel Preussker 975ddbc517 Revert "Fixed php short tags :/" 2016-05-02 20:19:18 +02:00
laf a14ae0bc18 Fixed php short tags :/ 2016-05-02 18:09:58 +00:00
Daniel Preussker 731e43bc66 Revert "[WIP] Sanity!" 2016-02-17 13:59:58 +00:00
Neil Lathwood 633ac101eb Merge pull request #2979 from f0o/sanity
[WIP] Sanity!
2016-02-16 21:44:10 +00:00
Neil Lathwood fa783dc07e Merge pull request #2841 from adaniels21487/issue-2665
Cisco OTV
2016-02-10 19:49:59 +00:00
f0o c767a26732 more bulk sanity 2016-02-10 16:02:13 +00:00
Aaron Daniels 4ebc2b1f33 - Modified code to use graph generation functions instead of calling overlib directly.
The graph generation functions check for the status of 'web_mouseover'.
2016-02-03 06:41:20 +10:00
Aaron Daniels 8f4dbb5338 Cisco OTV
Implements the CISCO-OTV-MIB to retrieve OTV counters from Cisco devices.
This collects information on the configured Overlays and Adjacencies

Statistics are collected for the amount of VLAN's on each overlay and the amount of MAC addresses available over each OTV endpoint.
OTV alerts are collected and generated if the appropriate alerting rules exist.

Data is displayed under routing at both the global and device level.

Includes function snmpwalk_array_num, which performs a numeric SNMPWalk and returns an array containing $count indexes
One Index:
 From: 1.3.6.1.4.1.9.9.166.1.15.1.1.27.18.655360 = 0
 To: $array['1.3.6.1.4.1.9.9.166.1.15.1.1.27.18']['655360'] = 0
Two Indexes:
 From: 1.3.6.1.4.1.9.9.166.1.15.1.1.27.18.655360 = 0
 To: $array['1.3.6.1.4.1.9.9.166.1.15.1.1.27']['18']['655360'] = 0
And so on...
2016-01-21 22:04:20 +10:00
Mike Rostermund 91bb7b9c1f Fixed background color to white in a few overlib graphs 2015-11-27 08:31:08 -08:00
Job Snijders d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
Job Snijders ebd0f6fc35 Apply "Squiz" code style on old (pre-2014) files 2015-07-11 16:12:35 +02:00
laf 88c838ca23 Added running status for bgp peers 2015-07-08 00:07:39 +01:00
laf cc40aaeca6 Mainly for a scrut run 2015-06-09 23:39:05 +01:00
laf d24a79f2ba Webui updates for BGP 2015-06-09 14:30:31 +01:00
laf 77b9adabc2 More updates to bgp polling/disco and webui 2015-06-09 14:30:19 +01:00
Mike Rostermund def585b784 Fixed typo in UI 2015-02-21 04:51:53 -08:00
Paul Gear b1ab8a7d32 Rename function to indicate purpose better 2013-11-26 07:51:39 +10:00
Adam Amstrong b273e04241 /// -> //
git-svn-id: http://www.observium.org/svn/observer/trunk@3240 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 12:24:34 +00:00
Adam Amstrong cacf913a55 # -> / for phpdoc
git-svn-id: http://www.observium.org/svn/observer/trunk@3239 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 11:29:53 +00:00
Adam Amstrong 4db1454e92 move from port_id to interface_id. make ports discovery only discover. add some cleaner functions. add a tiny bit of alerting infrastructure.
git-svn-id: http://www.observium.org/svn/observer/trunk@3195 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-16 13:25:50 +00:00
Tom Laermans 8df2b9b3f5 remove legacy variables, hopefully i didn't mess anything up
git-svn-id: http://www.observium.org/svn/observer/trunk@3134 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-06 18:38:11 +00:00
Adam Amstrong a12c71df4e quadgraphs -> graphrow
git-svn-id: http://www.observium.org/svn/observer/trunk@3093 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-26 16:49:38 +00:00
Tom Laermans ebc03a87b2 change more tables to css colouring, some more to do but not for now...
git-svn-id: http://www.observium.org/svn/observer/trunk@3020 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-10 17:21:49 +00:00
Tom Laermans 2667649d3c syntaxer run
git-svn-id: http://www.observium.org/svn/observer/trunk@2970 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-06 13:56:23 +00:00
Tom Laermans bfdd6e5e58 revamped/optimized vrf display page, patch by gl-
git-svn-id: http://www.observium.org/svn/observer/trunk@2944 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-02 17:28:54 +00:00
Adam Amstrong 6a6ee9cb7f fixes to graph widths
git-svn-id: http://www.observium.org/svn/observer/trunk@2874 61d68cd4-352d-0410-923a-c4978735b2b8
2012-02-17 00:19:18 +00:00
Adam Amstrong 5dbfd5c855 remove shutdown sessions from alerted bgp session list
git-svn-id: http://www.observium.org/svn/observer/trunk@2872 61d68cd4-352d-0410-923a-c4978735b2b8
2012-02-16 17:34:28 +00:00
Adam Amstrong 726df0ca5f fixes to BGP global page
git-svn-id: http://www.observium.org/svn/observer/trunk@2871 61d68cd4-352d-0410-923a-c4978735b2b8
2012-02-16 16:43:11 +00:00