14 Commits

Author SHA1 Message Date
Tony Murray fad0bffc43 Escape SNMP & IPMI shell commands (#9537)
hopefully doesn't break anything
Mostly issues with snmp oids and options containing spaces.  Try to remove all of those.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-12-16 13:42:50 +00:00
mattie47 71b44407b9 Improve legacy Allied Telesis hardware support (#8071)
* devices: Improved Legacy Allied Telesis hardware support #8071

This  patch covers:

Improved SNMPrec test coverage for Allied telesis devices

allied.yaml
	- Increased device exception OID list.
		-  This list of devices are running RADLAN OS, and should not be triggered by allied.yaml
	- Minor bug fixes

allied.inc.php
	- Added updated support for Alliedware devices
		-  Version
		-  Features
		-  Hardware
		-  Serial
	- Added support for Allied Telesis Websmart switches
		-  Version
		-  Hardware
	- Added support for Alliedware Plus version 2 OS devices
		-  Hardware
		-  Version
		-  Serial
	- Simplified polling to use snmp_get_multi_oid
	- Minor bug fixes

radlan.yaml
	- Updated device support for 8000S and 8000GS.
		-  Specified device object IDs
			-  Added an exclusion also for OIDs in allied.yaml
		-  Changed icon and group to alliedtelesis

radlan.inc.php
	- Updated support for devices identifying as radlan OS.

awplus.yaml
	- Added comment to remove the sysObjectID_except list.
	- Minor bug fixes

* added json test data to be used for unit test

* re-saved allied websmart test data
2018-01-20 20:30:53 -06:00
Neil Lathwood 42e5819130 refactor: Updated discovery/poller to use numeric sysObjectID (#7922)
* refactor: Updated discovery to use a core module for sysDescr/sysObjectID use

* final update hopefully

* revert changes

* more changes + docs

* migrated poller to use numerical sysObjectID

* more updates for sysObjectID

* update any alert rules which might have enterprises. in

* moved schema file

* small updates

* updated getHostOS()

* scrut fixes

* updated sysObjectId -> sysObjectID

* updated sysObjectId -> sysObjectID

* updated remainder of sysObjectId -> sysObjectID

* another sysObjectId -> sysObjectID

* fixed secureplatform test data

* Fix tests: $device is not pulled from the database before polling
Also, update the db in the core discovery module.
2018-01-06 23:00:47 -06:00
mattie47 3206447326 device: Improve Allied Telesis support within LibreNMS (#7670)
* Add support for Allied Telesis AlliedWare Plus products

- Uses mibs from 5.4.7-2.1 for AlliedWare Plus products
- Updates Legacy AlliedWare mibs
- Added Allied Telesis svg

* Remove unnecessary "trim" from snmpget

* Add new line to end of file

* Minor fixes for commit
2017-11-28 20:18:39 -06:00
Job Snijders ebd0f6fc35 Apply "Squiz" code style on old (pre-2014) files 2015-07-11 16:12:35 +02:00
Adam Amstrong b273e04241 /// -> //
git-svn-id: http://www.observium.org/svn/observer/trunk@3240 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 12:24:34 +00:00
Adam Amstrong cacf913a55 # -> / for phpdoc
git-svn-id: http://www.observium.org/svn/observer/trunk@3239 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 11:29:53 +00:00
Tom Laermans 752bbc2af8 array keys are strings, duh
git-svn-id: http://www.observium.org/svn/observer/trunk@2863 61d68cd4-352d-0410-923a-c4978735b2b8
2012-02-14 19:01:23 +00:00
Adam Amstrong 00121fd3f8 fixes to new poller
git-svn-id: http://www.observium.org/svn/observer/trunk@2233 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-03 21:46:25 +00:00
Tom Laermans 722d912aa1 cleanup OS polling
git-svn-id: http://www.observium.org/svn/observer/trunk@1841 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-15 11:59:47 +00:00
Adam Amstrong de0b283b7a increase mempool_index size to accomodate larger indexes
git-svn-id: http://www.observium.org/svn/observer/trunk@1646 61d68cd4-352d-0410-923a-c4978735b2b8
2010-08-04 17:17:00 +00:00
Adam Amstrong f29e7b755b redesigned graph defining system (still seems a bit batshit, but nevermind). lots of improvements to various pollers, only writing RRDs if valid data is returned, etc.
git-svn-id: http://www.observium.org/svn/observer/trunk@1506 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-28 19:43:02 +00:00
Tom Laermans 63956f5f1b more polling fixes
git-svn-id: http://www.observium.org/svn/observer/trunk@1450 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-21 00:11:33 +00:00
Adam Amstrong 15cdf5c9fa add force10 mibs and os type detection. move per-os polling scripts from includes/polling/device-* to includes/polling/os/*
git-svn-id: http://www.observium.org/svn/observer/trunk@1442 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-20 13:49:36 +00:00