Commit Graph

602 Commits

Author SHA1 Message Date
Tony Murray 8cc988a162 Fix plugins menu (#10222)
* Merge pull request #54 from librenms-plugins/revert-52-PluginNamespaceCorrection

Revert "Adding namespace LibreNMS\Plugins;"
Fix plugins menu

* Only use scrollable where needed
2019-05-13 14:53:29 -05:00
Timothy Willey 0d656590ec NEW OS Aruba Instant (#9954)
* New OS: Aruba Instant

* New OS: Aruba Instant

* recreate test data

* remove aruba_instant test data

* remove empty file includes/definitions/discovery/aruba-instant.yaml

* fix state sensor discovery

* remove minor changes to includes/polling/functions.inc.phpwq

* move mac helper functions to Rewrite class

* simplify snmpwalk_group usage, general code cleanup

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* recreate test data for 105 variant

* Add Client sensors for 8.4.0.0+

* begin stream-lining discovery and polling. separating discovery functions

* update test data

* update test data

* update test data

* improve mempool discovery/polling, clean up os polling, improve state discovery, improve os definition, misc fixes to wireless sensors module

* attempt to implement custom AP and client discovery and polling

* code fixes

* re-add ap count top graph

* more fixes

* more fixes

* more fixes

* more fixes

* remove some debugging, update test data

* code cleanup

* code cleanup

* address some scrutinizer warnings
2019-05-13 10:06:12 -05:00
Heath Barnhart 2187967854 Modified BGP4 handler to write to db (#10180) 2019-05-12 23:44:14 -05:00
CirnoT ef90da2a31 Better services graphing support (#10185)
* Move services graph code from device to service and remove unused code

* Add proper support for services to dashboard graph weidget

* Fix phpdoc in ServiceController still pointing to MuninPluginController
2019-05-12 23:40:27 -05:00
Tony Murray 9ede688d13 Replace legacy menu with new Blade generated one (#10173)
* Remove legacy index php file

* fix routing page missing data

* WIP

* fix $navbar global usage

* remove global use of $locations

* ObjectCache again...

* move vars.inc.php to init.php for legacy ajax

* navbar is more local than I thought before.  Fix it.

* Fix some sensors tables escaping

* restore custom menu functionality, but with blade
and docs

* cleanup

* tidy menu @if checks

* Fix up the rest of the global variables and remove print-menubar.php

* consolidate some counting in the menu

* filter out empty custom port descr types

* Fix up custom port groups

* Fix up apps menu

* Fix services menu when all are ok

* Limit cached data to the user it is for

* Fix style

* A few clean ups

* fix pseudowire bug
2019-05-10 11:02:39 -05:00
CirnoT f63c7e3508 Update bridge STP trap handlers to log events under stp type (#10192) 2019-05-09 21:45:21 -05:00
Tyler Christiansen 89197581d2 Cast alert ID to string for PagerDuty API (#10186) 2019-05-04 00:05:47 +02:00
CirnoT eb8600e1fd Added additional generic SNMP trap handlers (#10177)
* Add more generic SNMP trap handlers

* Sort snmptraps config alphabetically
2019-05-02 21:50:18 +01:00
h-barnhart 554e22d927 Juniper SNMP Trap Handlers (#10136)
* initial commit of junos handlers

* added DOM alarm test, refactored handlers for DOM alarms

* fixed some formating issues with last commit

* Created DOM alarm handlers and unit tests

* Made tests for LSP Down handler

* Added trap tests for JnxVpnSes*, JnxVpnIf*, JnxVpnPw*

* Added BGP4 trap handlers and tests

* Fixed some variable names for codeclimate

* Simplified JnxBGPM2* handlers

* updated unit tests
2019-05-01 11:12:51 -05:00
CirnoT 9950ae3f47 Add failed user login trap for Netgear switches (#10161)
* Add failed user login trap for Netgear managed switches

* Add failed user login trap for Netgear smart switches

* Add tests

* Remove unused $ipv4 from tests
2019-04-30 07:52:27 -05:00
CirnoT ca18cf4176 Support for APC PDU Outlet traps (#10162)
* Support for APC PDU Outlet traps

* Add tests

* Remove unused $ipv4 from tests
2019-04-29 21:40:09 -05:00
Tony Murray 5c6a9ab623 Bump version to 1.51 2019-04-29 16:36:21 -05:00
PipoCanaja a3263b802b Added packetlight support (#10131)
* MIBS

* logos
sensors
user_func
cleaning

* tests

* Switch to Packetlight class, and use is_callable instead of function_exists

* tests

* CodeClimate

* Rename functions
2019-04-29 09:46:53 -05:00
h-barnhart 5115fa9ca0 Adva SNMP Trap Handlers (#10094)
* Added SNMP Trap Handlers for Adva Ethernet devices

* Fixed formatting.

* Fixed errors from previous commit.

* Refactored AdvaAttributeChange.php

* Updated a few handlers, added test script.

* Added changes to snmptraps.php to make handlers active

* Fixed issues found by travisci

* Missed two mistakes in travisci, fixed. Should be ready for human eyes.

* Added SNMP Trap Handlers for Adva Ethernet devices

* Fixed formatting.

* Fixed errors from previous commit.

* Refactored AdvaAttributeChange.php

* Updated a few handlers, added test script.

* Added changes to snmptraps.php to make handlers active

* Fixed issues found by travisci

* Missed two mistakes in travisci, fixed. Should be ready for human eyes.

* Added two tests.

* fixed error

* Updated handlers with changes introduced in 1.50

* Refactored and added a few tests

* Added test for StateChangeTraps

* Added AdvaObjectDeletionTest, still wip as I need to recapture flow del.

* Added Network Element Alarm Trap Test

* Added more tests, but they are wip.

* Finished traps handler tests, few handler refoactors.

* fixed style errors and refactored as requested

* made requested changes to threshold trap handlers

* removed a test script

* modified adva port threshold handler

* Update AdvaAccThresholdCrossingAlert.php

* Update AdvaNetThresholdCrossingAlert.php

* removed static method

* fixed mistake in AdvaNetThresholdCrossingAlert.php
2019-04-29 08:39:20 -05:00
Tony Murray 9a00092388 Fixed debug output when fetching version (#10155)
in some cases
2019-04-27 23:09:10 +02:00
h-barnhart 27ff49fb1d Added Fortinet SNMP Trap handlers (#10148) 2019-04-27 20:34:15 +02:00
Mihai Petracovici 2df2956817 Improved option naming & validation for smseagle (#10141)
* Relax validation for smseagle hostname
* Update property description and documentation
2019-04-27 09:08:16 +02:00
Neil Lathwood d31a551464 Removed legacy code from transports (#10081) 2019-04-12 12:33:10 -05:00
Tony Murray 36431dd296 Security fix: unauthorized access (#10091)
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
2019-04-11 23:26:42 -05:00
Tony Murray 9661e6b9b3 Bump version to 1.50 2019-03-31 22:44:01 -05:00
Tony Murray 4e4ceffc0a Work around issue with Weathermaps (#10033) 2019-03-27 16:34:24 -05:00
Tony Murray ac1cd1296b Fix transport options when edited on Windows (#10001)
Windows puts line returns as \r\n, when parsing LibreNMS previously left the \r, which could cause issues
Centralize the code so we just have one place to fix.
Try to fix SMSEagle, it had the options wrong (copied from another transport)
2019-03-27 07:18:02 -05:00
Tony Murray 3a275e5807 Fix bill permissions (#10005) 2019-03-20 09:23:06 -05:00
Tony Murray 666c909ca6 Fix permissions issues (#10004)
Handle numbers passed as strings
2019-03-20 08:33:47 -05:00
Spencer Butler 62113ebde4 Added Med(5m) and High(15m) Utilization sensors for Cambium APs (os: pmp) (#9995)
* Added Med(5m) and High(15m) Utilization sensors for Cambium based (os: pmp) APs

* update the variants
2019-03-19 08:23:08 -05:00
Tony Murray 00a1185980 New permissions code (#9986)
* Initial permissions

* initial tests

* updates

* finish tests, other tweaks

* update legacy permissions checks
remove global :D

* missed facade extend

* Update eloquent permissions to use the new facade and drop joins

* method descriptions

* more docs

* fix style
2019-03-19 08:14:01 -05:00
Tony Murray 1111f0a027 Fix mysql table engine validation (#9989)
It would never show because the schema was checked first and it would always be wrong if the table engine was myisam.
2019-03-18 21:26:49 -05:00
PipoCanaja a2d378e0be Display Up/Down time in Device List (#9951)
* First attempt of Up/Down time

* First attempt of Up/Down time

* Moved to Time::formatInterval()

* cleaning

* last polled in casts

* Cleaning the variants of formatUptime()

* Cleaning in ./html/includes/dev-overview-data.inc.php

* Cleaning in ./html/includes/dev-overview-data.inc.php

* Cleaning in ./html/includes/dev-overview-data.inc.php

* updated includes/polling/core.inc.php

* updated includes/alerts.inc.php

* clean accessors
2019-03-17 21:09:58 -05:00
Tony Murray 1cfe4ea5fd Don't enable secure cookies when they won't work (#9971)
* Ignore session.cookie_secure errors
They happen if the session is already started.

* Don't allow secure cookies to be enabled when not accessing via https

* Completely remove the setting
2019-03-17 16:25:59 -05:00
Tony Murray cd1015992c Fix install not connecting to DB (#9984) 2019-03-17 16:25:38 -05:00
Tony Murray 3825133602 Fix device missing from traps/new Log::event() (#9963)
* Fix device missing from traps/new Log::event()
2019-03-16 09:24:59 +01:00
djamp42 0b2fbceedd Add Device Arris DSR-4410MD Sat Receiver (#9943)
* arris dsr4410md

* update sensor names

* code climate fixes

* Add blank line at EOF
2019-03-13 21:39:29 -05:00
PipoCanaja 0b4c7b584a remove calls to unavailable {{ $variable }} from YAML discovery (#9864)
* remove calls to unavailable {{ $variable }} from YAML discovery

* tests

* Add a warning for debugging purposes
2019-03-13 21:04:50 -05:00
Tony Murray 78ae084157 Fix Aruba Instant wireless sensors (#9936)
* fix Aruba Instant wireless sensors

* add tests
2019-03-12 23:59:40 -05:00
Tony Murray cb005210d2 Resubmit #9608 (#9941)
* Reorganize trap tests

* Testing db DRIVER to prevent .env from interfering

* New code to detect if Laravel is booted.  Hopefully more reliable.

* WIP external test process

* revert module test helper

* Use .env in Eloquent::boot()

* Fix test database settings loading

* fix undefined classes
(didn't find the one I needed)

* Fix incorrect Config usages
And RrdDefinition return type

* fix .env loading

* use the right DB

* slightly more accurate isConnected

* Move db_name to DBSetupTest specifically

* restore $_SERVER in AuthSSOTest

* missed item

* WIP

* tear down in the correct order.

* some testing cleanups

* remove check for duplicate event listener, it's not working right

* Don't need this change anymore

* Implement Log::event to replace legacy function log_event()

* fix port tests

* fix up tests

* remove pointless TrapTestCase class

* fix style

* Fix db config not being merged...

* skip env check for tests

* defer database operations until after Laravel is booted.

* don't include dbFaciale...

* redundant use
2019-03-12 23:59:03 -05:00
Tony Murray eb648a1d6f Revert "Changes to improve testing (#9608)" (#9937)
This reverts commit d1a0ccda46.
2019-03-12 00:49:14 -05:00
Tony Murray d1a0ccda46 Changes to improve testing (#9608)
* Reorganize trap tests

* Testing db DRIVER to prevent .env from interfering

* New code to detect if Laravel is booted.  Hopefully more reliable.

* WIP external test process

* revert module test helper

* Use .env in Eloquent::boot()

* Fix test database settings loading

* fix undefined classes
(didn't find the one I needed)

* Fix incorrect Config usages
And RrdDefinition return type

* fix .env loading

* use the right DB

* slightly more accurate isConnected

* Move db_name to DBSetupTest specifically

* restore $_SERVER in AuthSSOTest

* missed item

* WIP

* tear down in the correct order.

* some testing cleanups

* remove check for duplicate event listener, it's not working right

* Don't need this change anymore

* Implement Log::event to replace legacy function log_event()

* fix port tests

* fix up tests

* remove pointless TrapTestCase class

* fix style
2019-03-11 22:59:39 -05:00
David 569b1f0fb2 Fix database validation for MySQL 8 (#9923) 2019-03-09 14:15:03 -06:00
tarik e3e3de1442 Printer paper tray status and error states (#9859)
* adding paper tray status and error states

* adding paper tray test data

* Create jetdirect_papertray.json

* Store printer supply type

* Update json data

* fix style
2019-03-06 18:58:14 -06:00
Tony Murray 0aded95985 Fix ldap/ad auth anon-bind (#9905) 2019-03-05 12:14:21 -06:00
Tony Murray f4a33c1a34 Prevent credentials from being leaked in backtrace in some instances (#9817)
* Prevent credentials from being leak in backtrace in some instances
Particularly before the user is authenticated

* fix test
2019-03-05 00:24:14 -06:00
PipoCanaja 4599b36b25 Access to "sub" index (when OID has multiple indexes) (#9893)
* accessing in YAML each part of the index in case oid has more than one

* accessing in YAML each part of the index in case oid has more than one

* accessing in YAML each part of the index in case oid has more than one

* accessing in YAML each part of the index in case oid has more than one

* accessing in YAML each part of the index in case oid has more than one

* accessing in YAML each part of the index in case oid has more than one

* accessing in YAML each part of the index in case oid has more than one

* Codeclimate

* Initialisation + comments

* Like this
2019-03-04 21:17:14 -06:00
Tony Murray b402e859fd Fix Cisco Sat style (#9902)
* Fix Cisco Sat style

* update index
2019-03-04 21:12:12 -06:00
djamp42 8c5f86f32d Add Device - Cisco Sat Receivers (#9899)
* Cisco Sat Receiver

* Formatting Fixes

* Code Climate Fixes

* Add $entry field in the last array.

* Formatting Fixes

* Updated to correct S/N was grabbing wrong OID.

* Update test data for missing serial #

* Updated Serial # test data
2019-03-04 16:08:11 -06:00
Tony Murray 411f36a9a1 Bump version to 1.49 2019-03-03 21:37:13 -06:00
angryp 15aee15388 Alertmanager fix 2 (#9860)
* Improved Alertmanager transport

* Typo fix

* Fix according to Travis fail
2019-03-01 23:09:25 -06:00
Tony Murray e677d4b63e Fix incorrect icon sometimes (#9887)
* Fix icon finding
Also fix os suggest not loading all OS.

* Fix os that would have missing icon under the new code (and one under the old code)

* forgot icon
2019-03-01 23:06:01 -06:00
Tony Murray 7c4a0c7244 Try to fix some of the Component code (#9888)
https://community.librenms.org/t/devices-list-stuck-at-loading/7396
2019-03-01 08:13:32 -06:00
Vitali Kari 49f01970c5 add support for sagemcom (#9835)
* adds support for sagemcom

* requested changes

* delete unused variable

* logos

* modules fine tuning

* code style

* Update sagemcom.svg

* Update sagemcom.svg
2019-03-01 08:08:04 -06:00
Paul Parsons fd2bd62f57 fix: removed curly bracket from end of the command 2019-02-24 21:20:17 +00:00