Commit Graph
6546 Commits
Author SHA1 Message Date
Tony MurrayandGitHub 6e6e54cb98 New User Management (#9348)
* Rewrite user management.

Error management

Revert edituser legacy page

Connect user permissions button to legacy page for now.

Implement user creation
Refine form

Remove PingCheck.php accidental add :)

Fixes for redirection and deletion

More fixes: realname accidental validation setting, hide can modify for read-only auths

Use a panel to improve style

Add icon to panel-title

Not allowed to delete own user (at least via the click of a button)

Use request validation to reduce complexity of controller.
Improve protection against users doing things they should not.

Switch to horizontal form and not nearly as wide of layout :)

delete without refresh.
Fix for buttons

Include all users (not just from this auth)
Hide the auth column if there is only one auth type

Show username if real name isn't set

Don't allow creation of demo users via the webui

a fix to the lnms user:add command, it didn't set auth_id

update edituser.inc.php to current
just redirect to users page

* Remove TwoFactorTest for now

* Update edituser.inc.php

* Update .env.dusk.testing

* Enable 2fa for 2fa test...
2019-04-22 19:01:39 -05:00
Tony MurrayandGitHub d901d308d2 fix call to isUnderMaintenance() on null (#10090)
Not sure how people managed to trigger that one...
2019-04-18 10:14:17 -05:00
PipoCanajaandTony Murray a08b8333cc Bug - Nasty user_func vs divisor-multiplier issue (#10122)
* Nasty user_func vs divisor-multiplier issue

* tests
2019-04-17 20:15:31 -05:00
PipoCanajaandTheGreatDoc 5b6bf35d7a Display number of connections for ASA on over (#10106) 2019-04-17 08:14:45 +02:00
Derek JohnsonandPipoCanaja d069d0fd46 Disable snmpbulkwalk for cyberpower os (#10109) 2019-04-15 20:00:10 +02:00
Spencer ButlerandTony Murray c76115bf46 Added support dellNet devices (#10016)
* Added support DELL-NETWORKING-PRODUCTS-MIB (os: dell-net)

* dell-net - created mempool, removed flash (not enough data points)

* dell-net - updated yaml sysObjectIDs

* dell-net - added sensors, fixed sensors

* clean up

* dell-net added Tx/Rx indicators

* dell-net - regroup Lanes

* dell-net remove Lane quotes, removed random files

* dell-net - updated Model description per requester

* added rules to ignore 0 values

* restricted discovery match

* merge dellNet into os: dnos

* typo

* remove dell-net test files
2019-04-12 00:49:35 -05:00
Tony MurrayandGitHub 36431dd296 Security fix: unauthorized access (#10091)
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
2019-04-11 23:26:42 -05:00
SlushnasandNeil Lathwood b81af32ed2 Fixed display minimum values in uptime graphs. (#10078)
Fixes an issue with several uptime graphs using the average value when it should be using the minimum value.

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-11 23:05:18 +01:00
PipoCanajaandNeil Lathwood 36e709ebab Improved Linksys support, including POE (#10075)
Fixes #9718 

This PR adds POE graphs, even if not all the values that are polled on other OSes are available on this one.  

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 10075`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 20:32:57 +01:00
PipoCanajaandNeil Lathwood 5697d24869 Added Cisco Small business bootloader + HW version (#10043)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 20:03:07 +01:00
Neil LathwoodandPipoCanaja 0a7b0d4086 Added detection for ESW 5xx series of Cisco SB devices (#10077)
* Added detection for ESW 5xx series of Cisco SB devices

* Added test files

* Fixed the regex

* Updated definitions

* Final fix hopefully
2019-04-09 18:45:43 +02:00
Tim de BoerandNeil Lathwood 91ca7b37fe Refactored Nvidia Application (#10037)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 14:47:43 +01:00
PipoCanajaandNeil Lathwood 780ee36b10 Updated support for adva_fsp150 devices (#10049)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 13:59:08 +01:00
Alexander TsyganovandNeil Lathwood 943dbe4ff1 Updated RegEx string for correct definitions for Proxmox 4.x nodes (#10048) 2019-04-09 13:55:50 +01:00
PipoCanajaandNeil Lathwood e285a9268e Improve Huawei BGP polling + BGP webui & graphs patches (#10010)
* basic adress family for VRP

* Improve BGP prefixes display

* Improve BGP prefixes display

* Improve BGP prefixes display

* climate
2019-04-09 13:44:48 +01:00
tomarchandPipoCanaja e7ba1b195f Added initial support for teltonika (#10059)
* initial support for teltonika
* fix sensors
* fix mibs name
* add rutos.json
* Update rutos.json
2019-04-08 08:54:17 +02:00
Spencer ButlerandTheGreatDoc 47e0ee1d04 Added support for Liebert PDUs (#10062)
* Added support for Liebert PDUs
2019-04-07 21:19:08 +02:00
Spencer ButlerandTony Murray e1df2a3dd9 Added support for TP-LINK T1600G-52TS (#9983)
* Normalizing support for TP-Link Jetstream switches

* WIP - playing with MIB Modules

* removed comments

* reset discovery yaml
2019-04-07 08:55:52 -05:00
Timothy WilleyandTony Murray adaf08b1bf fix aruba-controller polling (#10071) 2019-04-07 08:26:55 -05:00
Tony MurrayandGitHub 1b46d87b0a Fix fail2ban jails eventlog spam (#10066)
The previous sort preserved keys, which we don't want
2019-04-03 21:49:15 -05:00
Tony MurrayandNeil Lathwood c305d2b520 Fixed fail2ban jails eventlog spam (#10061)
Sort the jails before saving so it always matches.
Not sure why it would be different order, but this fixes the spam in any case.
2019-04-03 23:21:27 +01:00
djamp42andTheGreatDoc c1fab98cc3 Added device WISI Tangram (#10039)
* Added device WISI Tangram
2019-04-03 06:43:39 +02:00
Timothy WilleyandPipoCanaja 311d24c3b3 Cleaning in function poll_device(#10015) 2019-04-03 00:51:41 +02:00
Neszt TiborandPipoCanaja f30d5afa35 Added PPPoE Sessions Graph for Mikrotik (#10056) 2019-04-02 22:35:37 +02:00
Tony MurrayandGitHub a3ef7c3d4a fix style issues (#10057) 2019-04-01 20:03:54 -05:00
Tony MurrayandGitHub c7c14ae809 Fix gw-eydfa (#10052) 2019-04-01 12:23:17 -05:00
priiduonuandPipoCanaja 5fc2f18af1 Added support for IONODES video encoders (#10031)
* Added support for IONODES video encoders

* fixed expected number instead of string value error when running tests

* removed extra colon

* added mibs_dir for ionodes

* removed IF-MIB from ionodes.yaml
2019-04-01 09:25:32 +02:00
Chi Hang LongandPipoCanaja 2eb5e30aa7 Modify to fix neighbours on EXOS switch problem (#10013)
https://community.librenms.org/t/modify-discovery-protocols-inc-php-to-fix-neighbours-problem-on-extreme-networks-exos-switch/7797

The bug is caused by SNMP polling switch-1 with ifIndex to DB (associate
ifIndex when adding switch), the port “1” is “1001”. Another switch-2
discover the switch-1 port “1” by LLDP is “1” (after LiberNMS get this
information). Two values are not equal (“1001” != “1”). If I change to
use ifName associate when adding device, because ifName is “1:1”, so it
can not equal to LLDP too (“1:1” != “1”).
2019-04-01 09:24:58 +02:00
Spencer ButlerandPipoCanaja 6b4f2476a6 Added support for DELLEMC-OS10-PRODUCTS-MIB (os: dell-os10) (#10011)
* Added support for DELLEMC-OS10-PRODUCTS-MIB (os: dell-os10)

* added info comment

* added group: dell
2019-04-01 09:23:31 +02:00
Tony MurrayandGitHub 4e4ceffc0a Work around issue with Weathermaps (#10033) 2019-03-27 16:34:24 -05:00
Spencer ButlerandTony Murray 7bfe0bc831 Added support for HikVision-DS Cameras (#9980)
* Added support for HikVision-DS Cameras

clean up

removed pointless file, cleaned up code

fixed failing unit tests, a bit of cleanup

WIP - will rebase

split hikvision into hikvision-nvr an hikvision-cam

* removed unneeded comment and rec file
2019-03-27 15:38:35 -05:00
jozefrebjakandTony Murray 54893b9c4e Added support for EDFA (#9912)
* Create edfa.yaml

* Create edfa.inc.php

* Create NSCRTV-ROOT

* Create edfa.yaml

* Add files via upload

* Add files via upload
2019-03-27 15:37:23 -05:00
Tony MurrayandGitHub f55302d0c5 Eltek Valere: group by shelf (#10040) 2019-03-27 15:33:22 -05:00
PipoCanajaandTony Murray 7fd7ba5a84 Added support for Orvaldi UPS (#10021)
* ovaldi UPS support

* ovaldi UPS tests

* serial + model + version inc tests

* update of the code using details from requester

* update of the code using details from requester

* update of the tests

* forgot discovery yaml ...
2019-03-27 07:21:35 -05:00
PipoCanajaandTheGreatDoc 743b76ea9c Typo in routeros YAML discovery (#9903)
Typo in routeros YAML discovery (#9903)
2019-03-27 07:15:51 +01:00
Spencer ButlerandPipoCanaja 2ad13f1836 Added support for Ruijie Networks (#10026)
* Added support for Ruijie Networks

* Extend discovery

Let's extend to all the products from this brand, at least until we have more detailed discovery
2019-03-26 20:38:28 +01:00
TheGreatDocandTony Murray 5535768d25 New Device: ATS - Automatic Transfer Switch (#9889)
* New Device: ATS - Automatic Transfer Switch

* Small fixes

* Fixed test data

* More fixes, again

* Moved temp to php to retrieve limits from device

* Fixed perms again...

* Final test file. Or I hope so...
2019-03-24 18:48:55 -05:00
PipoCanajaandTony Murray 546849f326 Added Panduit Eagle-I (was Sinetica) (#10014)
* Panduit eagle-I

* tests

* mibfile

* over update

* tests redone with dynamic sensors
2019-03-24 18:45:50 -05:00
PipoCanajaandTony Murray c7a9e8db5d extend support for all emerson products (#10018) 2019-03-24 18:43:49 -05:00
VVeloxandTony Murray bc2a0e6c42 check if the proper variable is empty (#10017) 2019-03-24 18:40:37 -05:00
Tony MurrayandGitHub 7c86234815 fix an issue with bills with no data (#10009)
Still gets a an error message when graphing, but it better relates to what the issue is.
2019-03-22 19:36:50 -05:00
KodApa85andPipoCanaja 8ec2476036 Added support for APC AP9810 zone contacts (#9967)
* device: Added support for APC AP9810 zone contacts

* fix: disconnected sensors been detected. And iemConfigProbesTable certainly does get used and it reference

* fix: load is VA, not to be confused with watts. This could be different per device though...
Apparent Power unit = VA
Real Power unit = Watts

And Keeping codeclimate happy

* feature: updated APC MIB

* feature: added test data for APC Smart UPS SMX750i and AP9810 with contact switches
2019-03-22 00:10:20 +01:00
djamp42andPipoCanaja fbfed49082 Add Device Arris Apex (#10006)
* device arris-apex

* Code Climate Fixes
2019-03-21 08:51:14 +01:00
Tony MurrayandGitHub 00a1185980 New permissions code (#9986)
* Initial permissions

* initial tests

* updates

* finish tests, other tweaks

* update legacy permissions checks
remove global :D

* missed facade extend

* Update eloquent permissions to use the new facade and drop joins

* method descriptions

* more docs

* fix style
2019-03-19 08:14:01 -05:00
Yann GauteronandTony Murray bafc195ae3 Fix cisco temperature limit (#9985)
* The SNMP value ciscoEnvMonTemperatureThreshold is now stored as high limit (and no more as high warning limit)

* Updating misc/notifications.rss to make the user aware of the behavioral change

* Addition of missing </description> in the misc/notifications.rss
2019-03-19 08:12:54 -05:00
Tony MurrayandGitHub 05186d4b50 Fix device group queries again (#10000) 2019-03-19 07:29:29 -05:00
Spencer ButlerandPipoCanaja 1ae3a7fa58 Removed an errant character, cambium graphs (#9996) 2019-03-19 01:37:37 +01:00
PipoCanajaandTony Murray 16f7e6c697 Riello UPS os definition with RFC 1628 support (#9962)
* Riello RFC 1628

* tests + logo

* private mibs

* private mibs
2019-03-17 21:54:19 -05:00
PipoCanajaandTony Murray 70437ae42b Dantel Webmon Improvement (#9977)
* Generic polling for webmon

* Tests update

* clean

* tests and count sensor

* typo + tests

* update user friendly OS

* style
2019-03-17 21:42:47 -05:00
dracmicandTony Murray fffd45a7fd Patch fix sql error on gengroupsql (#9929)
* Patch fix sql error on gengroupsql

* Update device-groups.inc.php

* Update device-groups.inc.php

* Update device-groups.inc.php

* Update device-groups.inc.php
2019-03-17 21:12:11 -05:00