Commit Graph
6546 Commits
Author SHA1 Message Date
PipoCanaja b29103441e Use format_hostname in dependencies list (#11333) 2020-03-23 19:39:46 +01:00
SourceDoctor 9802179030 Alert Rule - add Operator 'in' and 'not in' (#11327)
* Alert Rule - add Operator 'in' and 'not in'

* .
2020-03-23 08:36:44 -05:00
Mathieu Poussin e320fdf1cc Better map link scaling algorithm (#11329) 2020-03-23 11:42:18 +01:00
Dan Langille 5c163a4a2f Stop using {} for arrays (#11319)
This avoids this message in ./validate.php - line numbers differ because I'm on 1.61

PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /usr/local/www/librenms/includes/functions.php on line 1833
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /usr/local/www/librenms/includes/functions.php on line 2336
2020-03-21 14:49:15 -05:00
Urth 3aa5c15f6f Fix bills api output for period=previous (#11295)
Include static fields from the bills table in the previous period output.
Check lowercase(bill_type) because the history table uses CDR and Quota.
Update SQL IF() because the bills table always uses lowercase.

Because of these changes the calculation of the fields allowed, used,
percent and overuse for period=previous is now enabled.
2020-03-20 16:21:23 -05:00
SourceDoctor 9092988f7b Fallback to default Poller Group on delete (#11278)
* Fallback to default Poller Group on delete

* rewrite to eloquent

* replace column remove with page reload (refresh everything)

* change access verification check method

* .

* Update PollerGroups.php

Co-authored-by: Tony Murray <[email protected]>
2020-03-20 10:16:49 +01:00
Tony Murray 0658b56c77 Fix get_rrd_dir() function (#11310)
Thanks to @n0cturnal and @doGus on Discord for fixing this!
2020-03-19 22:08:42 -05:00
pobradovic08 8fb902e4d3 Fix RRD DS name (#11304) 2020-03-19 20:16:29 -05:00
Tony Murray 6c4d53d5e5 Fix previous with rrdgraph_real_percentile (#11306)
start and end only work with DEF (and are already devined for inoctetsX and outoctetsX.
2020-03-19 20:12:29 -05:00
Tony Murray 22e8b16530 Fix show rrdtool command (#11305) 2020-03-19 10:12:00 -05:00
Eldon Koyle da7f0299ad Fix custom oids not being added to RRD after other RRD cleanups (#11300) 2020-03-18 00:32:05 -05:00
Dag Bakke f75c543e43 Fixed issue with reporting of Cisco ASA Remote Sessions. rev2 (#11286) 2020-03-16 23:48:32 -05:00
Tony Murray df16de9d2f Refactor Datastores to allow future improvements. OpenTSDB Tags. (#11283)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues

* Make sure port data is stored the same way as before for Graphite and OpenTSDB
Add ifIndex tag to all to be compatible

* Missed rrdtool_tune() call

* Test update WIP

* OpenTSDB now includes tags

* fix style
2020-03-16 09:17:58 -05:00
SourceDoctor 4e349efd11 Rewrite Poller Management to Blade/Eloquent (#11277)
* Rewrite Poller Management to Blade/Eloquent

* remove further no more needed file

* Code Climate

* Code Climate

* hardcode tabs

* change URL style

* change prefix from poller-groups to poller

* .

* parameter fix

* Refactor to use more direct routing.
remove switch statement.

Co-authored-by: Tony Murray <[email protected]>
2020-03-13 20:58:37 +01:00
Danislav 75f741ca09 form csrf missing (#11282)
The csrf field is missing and you can not list all custom oids if there are more than 10 because the form fails.
How to reproduce:
Create more than 10 custom oids and then try to go to page 2 or change the total showed on the page to more than 10.
2020-03-13 20:30:05 +01:00
Mathieu Poussin 1cf7e206e5 Geographical map: Show network links between locations (#11269)
* Geographical map: Show links between locations

* Fix manifest after merge conflict
2020-03-13 11:22:32 +01:00
crcro 2ee2862357 app: mailcow-dockerized postfix stats (#11058)
* app-mailcow-dockerized-postfix

* fix docs

* updated niceCase

* test-data

* snmprec upload

* new test data

* new test data
2020-03-13 10:16:03 +01:00
Brock Richards 36e2dc4bdc Updated OS for Cisco FirePOWER devices (#11276)
* Added additional Cisco FirePOWER device ID's for 2100 series

* Fixed spacing, my msitake

* Added support for FTD Virtual and FTD 4110 modules
2020-03-11 23:54:58 +01:00
Tony Murray 746112acc4 Update Sophos detection (#11275) 2020-03-11 15:50:27 +01:00
Chewza c69187ef5c Add support for Cisco SX350X-24 (#11272)
This is a simple OID addition for the Cisco SX350X-24.
2020-03-11 14:39:31 +01:00
Tony Murray 7fe895bd08 Revert "Refactor datastores to classes (#9179)" (#11273)
This reverts commit e5dad7a64e.
2020-03-11 07:52:52 -05:00
Tony Murray e5dad7a64e Refactor datastores to classes (#9179)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues
2020-03-10 19:08:00 -05:00
SourceDoctor cc53801e22 Define Poller Duration precision to 2 (#11271) 2020-03-10 23:14:43 +01:00
Jay Shepherd 34924f6ad3 Add device support for SilverPeak (#11270)
* Add Silver Peak VXOA Device

Rename MIB Files
Update to use snmp_get_multi

* Add test data for Silverpeak
2020-03-10 22:48:20 +01:00
Brock Richards 063cee7b4a Added additional Cisco FirePOWER device ID's for 2100 series (#11260)
* Added additional Cisco FirePOWER device ID's for 2100 series

* Fixed spacing, my msitake
2020-03-09 22:53:38 +01:00
FingerlessGlov3s dcc6b9ac0b Update OPNsense definition due to incorrect OID on second detection method (#11265)
* Update OPNsense snmprec, with real data

Update OPNsense snmprec, with real data.

Data from OPNsense 20.1.2 (Latest release at time of commit)

* Update OPNsense definition due to incorrect OID

sysObjectID is incorrect for OPNsense should be .1.3.6.1.4.1.8072.3.2.8.  for this snmpget detection to work.
This has been tested in my environment with 2 OPNsense Firewalls.
2020-03-09 20:45:47 +01:00
PipoCanaja c4eb412e2e Collect average server CPU usage on Huawei RH servers (IBMC) (#11236)
* add average server main CPU(s) usage

* tests
2020-03-08 17:30:14 +01:00
cjwbath c6f06ceb92 Show the plugin's name in the title rather than just "Plugin" (#11258) 2020-03-07 11:21:17 +01:00
Kevin Zink 3567386c48 Add Device: Innovaphone (#11225)
* Add Device: Innovaphone

* fix typo

* Move mib to subdir and Refresh testdata

* Fix typo

* Fix discovery index

* force test re-run

* Cleanup

* image

* Update innovaphone.yaml

* Update innovaphone.json

Co-authored-by: PipoCanaja <[email protected]>
2020-03-06 23:33:31 +01:00
PipoCanaja 5628b60f2c Extra VLAN mapping in bridge FDB module to fix HP ProCurve (#11230)
* Extra mapping for dot1qVlanFdbId to allow FDB VLANs to work on ProCurve
* Test data from joseUPV for ProCurve FDB VLANs
2020-03-05 17:52:01 +01:00
PipoCanaja 6d56b9699b Fix autodiscovery vs discovery on LLDP/xDP links (#11189)
* Fix xdp autodiscovery consistency (discovery vs autodiscovery)

* Update documentation related to xDP autodiscovery
2020-03-05 13:27:20 +01:00
SourceDoctor 2cfc7c6f14 Extended unbound monitoring (#11255) 2020-03-05 11:35:23 +01:00
PipoCanaja baee55a248 Fix "inteno" and "quanta" OS collision (#11238)
* fix quanta collision

* CLA broken again
2020-03-03 23:13:15 +01:00
SourceDoctor d32273decd Graph CPU Steal and IO Wait (#11235) 2020-03-03 13:17:42 +01:00
PipoCanaja 6a3f321b69 Added support for Inteno devices (#11229)
* MIB

* fixMib

* sensors

* sensors

* cleaning

* tests
2020-03-03 09:45:22 +01:00
Joseph Tingiris 83b1374ce7 remove dbDelete() for alert_schedule_items (#11232)
* the table named alert_schedule_items was renamed to alert_schedulables
* see migration 277
2020-03-02 20:26:39 -06:00
PipoCanaja 269f64084a Store OLD-CISCO-xxx-MIB files in their directory (#11228)
* Old Cisco Mibs

* Cisco MIB Cleaning

* dummy commit to force CLA to run again
2020-03-02 09:10:06 -06:00
SourceDoctor d2247ebda3 Running Alerts colorized depending on to their severity (#11210)
* Running Alerts colorized depending on to their severity

* extra alert styling to generic function

* .

* link from table alerts to alert_layout function

* info icon for information alert severity
2020-03-01 15:50:45 +01:00
SourceDoctor 335a238349 Open Links to external Urls (Docs) in new tab (#11227)
* Open Links to external Urls (Docs) in new tab
2020-02-29 22:53:17 +01:00
Kevin Zink 7254f13b26 Aruba cluster userfriendly read (#11217)
* Aruba-Instant: Include hostnames as a better identifier for mesh members sensors

* Refresh testdata
2020-02-27 15:35:28 -06:00
pepperoni-pi c25551ac98 IOSXE ignore macSecControlledIF and macSecUncontrolledIF ifTypes (#11214)
* Added bad_iftype to iosxe.yaml definition

* Update Configuration.md

Updated file location from includes/defaults.inc.php to misc/config_definitions.json and added an example of OS specific bad_iftype entries.

* Added OS Specific example for ignoring interfaces and updated file location.

* Updated bad_if selection documentation
2020-02-27 14:50:36 -06:00
Neil Lathwood e8f252de95 Added support for VLANs and FDB in AOS (#11145)
* Draft of Aos Script

* Changing to independant script

* Adding Aos6 vlan_dict and port_dict

* Adding Aos7 vlans module

* Adding Aos7 vlans module script

* Added Test data
2020-02-27 10:31:11 +00:00
Heath Barnhart e83583f6f4 Adva FSP150cc Health Sensors (#11168)
* initial commit adding sensors

* changed dbm logic for port exclusions

* update mib, added xg116 support, update disc logic

* sfp health appears on ports page

* added sfp temps

* updated mib file names

* updated mib file names

* removed .mib extension

* replace ADVA-MIB

* Add test data

Co-authored-by: Tony Murray <[email protected]>
2020-02-26 12:00:48 -06:00
SourceDoctor e7f587e9f0 Copy existing Alert Rule (#11195) 2020-02-26 15:07:48 +01:00
Mathieu Poussin baf2f9a4ce BGP API: Add filter by remote ASN (#11204)
* BGP API: Add filter by remote ASN

* Fix blocked merge
2020-02-26 14:29:44 +01:00
gabrielRojasNew 6d22a885af Created add, edit, remove location and edit, remove services to the API (#11080)
* Created add, edit, remove location and edit, remove services to the v0 API and added their corresponding routes

* Changed repeating code by adding a function that checks for missing parameters

* Reduced the lines of add_service_for_host, modified a little more the missing fields function

* Changed True and False to true and false, erased an unused var called $missing

* Solved merged confict

Deleted duplicate functions generated when solving merge conflicts

* fixed more conficts

Deleting duplicate entries produced by trying to solve a merge conflict

* fixing more duplicate functions

This merge conflict created more duplicates

* Update api_functions.inc.php

* Update api_functions.inc.php
2020-02-26 11:12:36 +01:00
FingerlessGlov3s fe9deb9b9c Additional Open Sense detection (#11196)
* Update opnsense.yaml - too add discovery method

Update opnsense.yaml for new OPNsense OID called version.
This will help with detection after the user turns on "Display Verion in OID" within OPNsense

* Re-order to reduce snmp-scan.py time

First, check sysDescr for OPNsense.  Then if sysObjectID is 1.3.6.1.4.1.12325.1.1.2.1.1, run an snmpget

* Create opnsense_1.snmprec

Make up test file since data was not supplied

Co-authored-by: Tony Murray <[email protected]>
2020-02-25 20:28:22 -06:00
Kevin Zink 3ce8ae5bad Aruba-Instant: Add the serial to aruba-instant devices (#11184)
* Add the serial to aruba-instant devices

* add test data

* add test for 105
2020-02-25 19:35:49 -06:00
PipoCanaja 3742e4f7ac Add basic support for PICA8 devices (#11185)
* mib

* os_support

* polling

* tests

* codeclimate
2020-02-26 01:28:56 +01:00
PipoCanaja 13e6a38ee4 Added Cambium PTP670 (#11186)
* cambium PTP670

* Wireless data

* space

* space
2020-02-26 01:28:40 +01:00