This is to fix an off by one error.
The ERS reports VLAN membership using a bitmask, but the MSB is always 0.
So using the `q_bridge_bits2indices` function results in the reported ports membership being +1 wrong.
The best fix for this would be to create a new function exactly the same as `q_bridge_bits2indices` which subtracts the 1 before returning the array.
I tried this, but it broke my install :)
Not sure how to add to the `functions.inc.php` file without breaking it.
Avaya do not use the Q-Bridge MIB for Vlans.
They also store untagged vlan info in 2 seperate ways:
rcVlanPortDefaultVlanId stores the actual native VLAN or PVID per switch port.
rcVlanPortPerformTagging tells us the ports tagging mode, this can be true (all tagged or trunk), false (no tagging or access), 3 (only tag the PVID) or 4 (untag the PVID and tag everything else).
Due to how these bits of information are presented, for each VLAN ID we then need to loop through all the ports checking if their PVID matches the VLAN ID and if the tagging mode is false or 4. If both are true we add that port to the list of untagged ports for that VLAN.
* Added mempool support for Avaya ERS 3500
* Added mempool support for Avaya ERS 3500
* removed check for firmware version
* removed check for switch model or firmware version
* removed check for switch model or firmware version
* removed check for switch model or firmware version
* adding @laf suggested changes
* made changes as suggested by @laf
* removed blank line
* removed blank line
* added the snmpwalk back
need this, or it's pointless
* added support for Avaya ERS 3500 switches
Tested and working with single 3500 and stack of 5 3500
* added support for ERS3500 switches
tested on ERS 3500, both single and stack of 5
* device: Improved HP ILO4 support
Added HP ILO4 temperature (HDD, motherboard), power, state (powersupply, HDD, Fans, memory slots) sensors support.
Tested with HP ProLiant ML350p Gen8-Gen9
* actual MIB file!
* Use the new locks for schema updates
* removed schema lock from discovery
* Add the ability to wait for a lock.
Add unit tests
* Add MysqlLock
Use that for the schema updates
Wait up to 30s for other schema updates to complete.
* Switch the schema lock back to a file lock for now.
Make FileLock support indefinite locking without polling.
Add a warning to MysqlLock for scenarios where it won't work.
* Delete MysqlLock.php
* Removed MySQL lock tests
Always output header (may be missing mysql data)
Improve version display, now looks like '1.28-129-g74e6c3edf' <tag>-<commits since tag>-<shortag>
Add mysqli to the list of required extensions, check extensions before init
Add dbIsConnected() function, used to check if we have db in version_info()
Do not die on IPv4 and IPv6 so validate can print errors.
Move git checks so they are output together
fix rrdtool 1.7.0 reports version as 1.7.01.7.0
* Return more descriptive error when adding duplicate devices on sysName
* clean up functions to make more clear and reduce duplication
* moved return to correct place
* Added detection for Hirschmann Railswitch
* Update AUTHORS.md
I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.
* Fixes for PR 6207 requested changes
* Fixes for PR 6207 requested changes
* Fixes for PR 6207 requested changes
* Fix for PR 6207 requested changes
* Fix for PR 6207 requested changes
* Synchro Fork
* Synchro Fork
* Added additional sensors for APC IRRP100 Air conditionner series
* Updated apc.yaml
@laf I modified the yaml file according to your comment. I forgot the index line in a few definitions...
* Rollback hirschmann.inc.php to original file
* Roolback to original hirschmann.inc.php file
* Updated apc.yaml file to include data section
* Update apc.yaml
* Update apc.yaml
* Updated apc.inc.php after @laf requests
Modified $current calculation, including $multiplier in place of static value and added 'PowerNet-MIB' as an argument of the snmp_get function (detached from OID writing)
* missing new line
* reverted hirschmann updates
* reverted hirschmann updates
Set default divisors for all devices and remove per-os overrides for them.
We should only use per-os overrides for non-standard behavior.
High possibility for breakage here if devices not listed here have non-standard behavior.
Tom SealeyandGitHub
Lorenzo ZafraandNeil Lathwood
Yacine BenamsiliandNeil Lathwood
Tony Murray
djamp42andNeil Lathwood
laf
FTBZandNeil Lathwood
Aldemir AkpinarandNeil Lathwood
network-guyandNeil Lathwood
Søren RosiakandNeil Lathwood
InfraTeamandNeil Lathwood
James AndrewarthaandNeil Lathwood