240 Commits

Author SHA1 Message Date
PipoCanaja 7239d4fc5f typo in bind application polling (#12276) 2020-10-29 15:32:41 +01:00
Clark Chen 2f61f505ca Fix typo cause empty data for NFS Server (#12223)
Typo causing NFS tab data aren't polling properly
2020-10-16 10:53:37 +02:00
Diego Canton de Brito 5b892dc4f8 Force lower case (#12178)
We force the strings returned from the "unbound-control stats" command to "lower case", avoiding problems with future changes to the unbound output in other variables.

All code must contain lower case letters in the $ unbound [] variable
2020-10-01 19:59:24 -05:00
hugalafutro 87538c4c4a Update unbound.inc.php (#12152) 2020-09-24 14:44:34 +02:00
Jellyfrog 29f45ca352 Apply fixes from StyleCI (#12124) 2020-09-21 15:59:34 +02:00
Jellyfrog 0d56bbd946 Apply fixes from StyleCI (#12123) 2020-09-21 15:51:53 +02:00
Jellyfrog 2fc3a21211 Apply fixes from StyleCI (#12121) 2020-09-21 15:43:38 +02:00
Avinash Kumar 78fa539628 Icecast, Opensips and Voip monitor Application (#12070)
* Icecast added

* Opensips added

* Voip Monitor added

* Icecast documentation

Icecast corrections

* Opensips documentation added

Opensips corrections

* Voip monitor documentation added

Voip monitor corrections

* Icecast corrections

* Opensips corrections

* Voip monitor corrections

* test data added for icecast

* test data added for opensips
2020-09-18 16:49:20 +02:00
SourceDoctor 8e60f8f56f Application Puppet Agent RRD Runtime Graph fix (#11837) 2020-06-18 18:15:52 +02:00
yon2004 953def1518 Added discovery for ups-nut status (#11606)
* Added UPS NUT state sensors

* Added UPS NUT state sensors

* Added UPS NUT state sensors

* Added UPS NUT state sensors

* Added UPS NUT state sensors

* Update linux_ups-nut.snmprec

* Fixed UPS states so making alerts easier.

* Fixed

* Actually Fixed it

* Added alert rules for UPS-NUT
2020-06-18 09:43:11 +02:00
Tony Murray 867aa132c1 Merge pull request #11661 from SourceDoctor/app_dhcp_enhancement
Application DHCP Upgrade
2020-06-16 17:03:45 -05:00
Anael Mobilia 22916afb9e Apps - backupninja (#11010)
* GUI - graphs

* GUI - Apps

* Polling

* GUI - apps

* Add backupninja to documentation

* Apps - backupninja : add link to librenmsagent script

* Add backupninja snmprec file

* Delete backupninja.snmprec

No Regression tests on apps (yet), only on devices.

* Remove old debug

* Update language : FR -> EN

* Add debug informations

* File path moved to /etc/snmp/

* Python script now use json

* Update following example on puppet script

* Update installation instructions following puppet example

* Update apps.inc.php

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: SourceDoctor <sourcehhdoctor@gmail.com>
2020-06-16 01:04:30 +02:00
SourceDoctor 529f364ada Ping Perf fix while running Squid (#11823)
* Ping Perf fix while running Squid

* Update squid.inc.php

rename variable
2020-06-14 13:04:33 +02:00
SourceDoctor 1093315700 Merge branch 'master' into app_dhcp_enhancement 2020-06-08 20:51:41 +02:00
SourceDoctor 4b52cab776 fix RRD in MySQL (#11740) 2020-05-30 17:43:41 -05:00
SourceDoctor cbe572f959 Application DHCP Upgrade 2020-05-22 23:02:19 +02:00
SourceDoctor 4edff1e88a Application - Redis (#11612)
* Application - Redis

* Travis fix
2020-05-15 22:05:40 +02:00
SourceDoctor d65aa52b4a Fix RRDCached Application Socket Address in Poller (#11525)
* Fix RRDCached Application Socket Address in Poller

* remove unnecessary socket open check
2020-05-08 01:51:30 -05:00
Hayden 8993817674 Fix memcached always reporting "ERROR" for app_state (#10739)
* perform json_encode() on memcached app $response data to match update_application() string parameter

* return raw snmp_get result for memcached response data during update_application()
2020-04-11 13:53:28 -05:00
Tony Murray 217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
Tony Murray 1445263290 Fix rrd format issues for asterisk and cipsec-tunnels (#11375) 2020-04-03 07:57:37 -05:00
SourceDoctor 83d980515c Rrdcached Socket Check fix (#11372)
* Global Settings - Alert Default Settings

* Revert "Global Settings - Alert Default Settings"

This reverts commit a1af62b146.

* RRDCached Socket Check fix
2020-04-02 20:50:39 -05:00
SourceDoctor 7b8ca66c67 Get configured Rrdcached Socket from config (#11351)
* Global Settings - Alert Default Settings

* Revert "Global Settings - Alert Default Settings"

This reverts commit a1af62b146.

* Get RRDCached Socket from Configuration

* socket check

* misstype fix

* travis fix

* .
2020-03-31 23:16:15 -05:00
Tony Murray df16de9d2f Refactor Datastores to allow future improvements. OpenTSDB Tags. (#11283)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues

* Make sure port data is stored the same way as before for Graphite and OpenTSDB
Add ifIndex tag to all to be compatible

* Missed rrdtool_tune() call

* Test update WIP

* OpenTSDB now includes tags

* fix style
2020-03-16 09:17:58 -05:00
crcro 2ee2862357 app: mailcow-dockerized postfix stats (#11058)
* app-mailcow-dockerized-postfix

* fix docs

* updated niceCase

* test-data

* snmprec upload

* new test data

* new test data
2020-03-13 10:16:03 +01:00
Tony Murray 7fe895bd08 Revert "Refactor datastores to classes (#9179)" (#11273)
This reverts commit e5dad7a64e.
2020-03-11 07:52:52 -05:00
Tony Murray e5dad7a64e Refactor datastores to classes (#9179)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues
2020-03-10 19:08:00 -05:00
SourceDoctor 2cfc7c6f14 Extended unbound monitoring (#11255) 2020-03-05 11:35:23 +01:00
SourceDoctor 53dc564ef5 Puppet Agent Monitoring (#10827)
* puppet agent monitoring

* change position of last run graph

* device overview panel

* updating documentation

* mouseover for Overview Dashboard

* adding blank line for code climate
2020-02-12 08:26:02 +01:00
Joseph Tingiris 02bc15c206 Asterisk app: add IAX2 peer graphs (#11078)
* Asterisk app: add IAX2 peer graphs

* It's an entirely new graph and will not break existing graphs.
* The asterisk extend script must be updated to provide the appropriate poller data.
* The PR for librenms-agent/snmp/asterisk is here: https://github.com/librenms/librenms-agent/pull/274

* code climate, round 1

* clarified unit text

* code climate, round 2

* changes needed to properly generate test data

* linux_asterisk-v1 test data
2020-02-03 18:47:27 +01:00
SourceDoctor 6ffde9ce2d PureFTPd Application (#11048)
* PureFTPd Application

* graphing connected Users
2020-01-21 18:50:11 -06:00
SourceDoctor 4d50feffb3 Added certificate file validity check for services (#10354)
* snmp extend for monitoring certificate file validity

* Update Applications.md

* Update Applications.md
2019-11-05 21:56:31 +00:00
SourceDoctor 8f1c77545d Added Seafile Server Monitoring (#10465)
* Seafile Monitoring

* generalized function for application with multiple similar entries

* adding snmprec file

* Create linux_seafile-v1.json

* Update linux_seafile-v1.snmprec

Updated linux_seafile-v1.snmprec to use 4x for encoding json data response

* Update Applications.md
2019-10-21 23:28:21 +01:00
Chuyen Vo 5a169fc85e Strip backslash return from snmp_get extend (#10724)
* Strip backslash return from snmp_get extend

* Update powerdns-recursor.inc.php

* Update powerdns-recursor.inc.php
2019-10-21 13:21:30 +00:00
SourceDoctor 932d338a83 smart application database update fix (#10378)
* fix database filling

* Update smart.inc.php

* Update smart.inc.php
2019-06-26 09:47:39 -05:00
VVelox ad6ac30528 fix an issue where the order may be random (#10375) 2019-06-26 09:45:40 -05:00
Tony Murray f3ba8947f7 Use Config helper (#10339)
remove usage of global variable
2019-06-23 00:29:12 -05:00
VVelox d071c8b403 sort arrays before storing them in a component (#10329) 2019-06-11 07:52:42 -05:00
SourceDoctor 349e102b73 enhance smart to show power_on_hours also (#10261) 2019-06-06 23:39:22 -05:00
Martin d68d8a81df Prevent fail2ban from filling eventlog on every poll (#10225)
Either the jails in the array or the respective indexes get rearranged on every poll. Adding only the values (jail names) without the indexes solves the issue. I tried also asort() which gives the same behavior.

Details: https://community.librenms.org/t/eventlog-filling-with-fail2ban-jail-component-logs-since-latest-stable-update/7902/10
2019-05-14 08:09:41 -05:00
SourceDoctor 96f7f142ba add mdadm support (#10159)
* add mdadm support

* Update mdadm.inc.php
2019-05-12 23:42:03 -05:00
Tim de Boer 91ca7b37fe Refactored Nvidia Application (#10037)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 14:47:43 +01:00
Tony Murray 1b46d87b0a Fix fail2ban jails eventlog spam (#10066)
The previous sort preserved keys, which we don't want
2019-04-03 21:49:15 -05:00
Tony Murray c305d2b520 Fixed fail2ban jails eventlog spam (#10061)
Sort the jails before saving so it always matches.
Not sure why it would be different order, but this fixes the spam in any case.
2019-04-03 23:21:27 +01:00
VVelox bc2a0e6c42 check if the proper variable is empty (#10017) 2019-03-24 18:40:37 -05:00
Tony Murray b1f9a2531d Prevent error with multiple proxmox
Duplicate function error
2019-02-01 09:03:16 -06:00
Tony Murray 74c57441e2 Powerdns app to json (#9680)
* Update powerdns app for json

* test data

* qsize-q is value

* add legacy test data

* docs

* Update linux_powerdns-v1.json
2019-01-17 11:43:43 -06:00
Tony Murray 6a00162648 fix constant as string (#9636)
update style and copyright
2019-01-10 06:42:25 -06:00
Mike Centola 98f75bd9ce Modify GPSD Application to support SNMP Extend. Update Docs (#9625)
* Modify GPSD Application to support SNMP Extend. Update Docs

* Fixed namespace and removed comments (#9625)
2019-01-09 23:36:37 -06:00
VVelox d3250b325a convert the FreeBSD NFS stuff over JSON (#9097)
* initial work done to FreeBSD NFS pollers for JSON support

* minor formatting cleanup and no longer pass update_application a array for the second argument

* add test data and snmprec(minus legacy)

* use variables from the data part of the JSON in the metrics

* add the legacy snmprec file for fbsdnfsserver

* add the most of the test stuff for FreeBSD NFS

* add the legacy SNMP data for FreeBSD NFS client

* add the missing "applications": {

* properly rename the tests to match the appname

* correct the appname stuff in the tests

* make a chunk of the json properly a array item

* correct this to the actual value

* change 0 to 0.0 for one and make quote data

* hmm...  RdirPlus is becoming Rdirplus

* whoops, revert that... should be RdirPlus as that is what is returned
2018-12-28 20:09:35 -06:00