111 Commits
Author SHA1 Message Date
JellyfrogandGitHub 3e2d7435af Fix more error exceptions (#14266) 2022-09-01 12:30:51 -05:00
Tony MurrayandGitHub 849fa21ea0 Revert "Fiberstore Network Management Unit (#13813)" (#13925)
This reverts commit c5502789b9.
2022-04-15 12:22:36 -05:00
c5502789b9 Fiberstore Network Management Unit (#13813)
* FS OAP OEO and EDFA mibs

* definitions and discovery yaml

* current dbm state temperature and voltage updates

* update on poller and discovery modules

* test data

* removing unneeded pollers and discovery modules as requested

* update to os test data

test data now reflects fs-nmu details instead of module details as module may not be present at previous oid or module may not be present at all in the device

* OS update and Test Date Updates

* channels numbers

* removal of default true poller and discovery modules

* reintroduced previous OEO module data

* StyleCI fixes

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

* Update fs-nmu.inc.php

Co-authored-by: Neil Lathwood <[email protected]>
2022-04-15 10:30:41 -05:00
eskyuuandGitHub c13975524c Fix an issue with the APC current discovery (#13837)
* Fix an issue with the APC current discovery

* Formatting fixes

* Formatting fixes

* Added test data for APC PDU sensors
2022-03-13 22:55:08 +01:00
64b0c3faa3 [comware] dropped dbfetch from discovery/sensors (#13796)
* [comware] dropped dbfetch from discovery/sensors

* ci

* DeviceCache::getPrimary

* remove unneeded model

* Update includes/discovery/sensors/temperature/comware.inc.php

Co-authored-by: Jellyfrog <[email protected]>

Co-authored-by: Jellyfrog <[email protected]>
2022-03-10 21:31:40 +01:00
Peca NesovanovicandGitHub 700c6ae9c3 [pbn] dropped dbfetch from discovery/sensors (#13789) 2022-02-15 22:39:23 +01:00
Peca NesovanovicandGitHub 8b831f5c6f [junos] dropped dbfetch from discovery/sensors (#13784)
* [junos] dropped dbfetch from discovery/sensors

* ci
2022-02-14 23:06:34 +01:00
Peca NesovanovicandGitHub fb90b1813f added new sensors to mes23xx (#13671)
* added new sensors to mes23xx

* ci

* copy/paste error

* ci

* cleanup + testdata

* yaml

* yamlnew

* added [no_bulk] for PoE discovery

* fully qualified OID name
2022-01-20 08:41:47 -06:00
Peca NesovanovicandGitHub 21edc086ca split Eltex-mes OS to mes21xx / mes23xx. + few improvements (#13544)
* split Eltex OS to 21xx and 23xx

* styleci & typo

* yaml cleanup

* removed MIBs from first release

* tidy up yaml

* test data
2021-11-24 21:34:48 +01:00
JellyfrogandGitHub 258505ed44 Apply fixes from StyleCI (#13224) 2021-09-10 20:09:53 +02:00
049b7af3d5 Allow stack index other than '1.' for CiscoSB (#13078)
* When in a stack, the index for each port is based on the unit number in the stack. The first unit
in the stack uses index '1.', the second uses index '2.', the third '3.' and so on. This change
allows for stack indexes greater than '1'

* Create ciscosb_cbs350-4x.snmprec

* Create ciscosb_cbs350-4x.json

Co-authored-by: Tony Murray <[email protected]>
2021-08-03 16:31:00 +02:00
3d0c1e63b7 Update Sensors for ADVA FSP150CC + discovery fix (#13020)
* Update YAML file for ADVA FSP150CC

Update for Adva FSP150CC
1. ERP State
2. Condition State

* Update Pre-Cache for ADVA FSP150CC

Update multiple devices and cache ERP objects.
1. XG116Pro (H)
2. XG120Pro
3. XG210
4. EG-X

* Update on Temperature Sensors for ADVA FSP150CC

Update multiple modules to support Adva FSP150CC Series.

* Update Voltage Sensors for ADVA FSP150CC

Update multiple modules for Adva FSP150CC Series.

* Create adva_fsp150_xg116proh.snmprec
* Create adva_fsp150_xg116proh.json
* Update adva_fsp150_xg116pro.snmprec
* Update adva_fsp150_xg116pro.json

Fix legacy ADVA discovery code

* Fix snmp-get and DB access
* style

Co-authored-by: PipoCanaja <[email protected]>
2021-07-17 01:01:45 +02:00
a6a00419e4 Inital support for Eltex-MES switches (#13036)
* Inital support for Eltex-MES switches

* Eltex-MES code cleanup & added mib files

* Eltex-MES mib files renamed

* Eltex-MES mib files renamed(v2)

* Eltex-MES added json test data

* Eltex-MES added bad_iftype in YAML

* Eltex-MES test data after adding bad_iftype in YAML

* Eltex-MES fixed YAML & new test data

* Undo module disabling

Co-authored-by: PipoCanaja <[email protected]>
2021-07-16 16:14:09 +02:00
d-k-7andGitHub fcac1239fc Improved raritan pdu support (#12937)
* return "Outlet " + index in event outlet description is empty

* update tests to account for blank outlet description

* add hardware, serial, and version detection for Raritan PDUs
2021-06-09 00:38:23 +02:00
dethmetaljeffandGitHub da19fc51f2 fix outlet sensor indexes overwriting each other when there's more than one infeed (#12763)
* fix outlet sensor indexes overwriting each other when there's more than one infeed

* adding test data for sentry3 switched pdu
2021-04-18 19:51:47 +02:00
Tony MurrayandGitHub 242b8747fb Fix AOS 7 sensors (#12599)
* AOS7 WIP

* Fix AOS 7 sensors

* TX Bias -> TX Power

* Fixes
2021-03-08 22:50:34 -06:00
JellyfrogandGitHub 20b4215204 Swich links to https (#12511)
* Switch librenms links to https

* Convert librenms links in comments

* Switch gnu.org url to https

* switch php urls to https
2021-02-09 00:29:04 +01:00
JellyfrogandGitHub 29f45ca352 Apply fixes from StyleCI (#12124) 2020-09-21 15:59:34 +02:00
JellyfrogandGitHub 0d56bbd946 Apply fixes from StyleCI (#12123) 2020-09-21 15:51:53 +02:00
JellyfrogandGitHub 82f43cb98d Apply fixes from StyleCI (#12120) 2020-09-21 15:40:17 +02:00
joseUPVandGitHub 9ac05f48b8 AOS Advanced Support. (#11500)
* Comes from PR11322.

* Code changes to solve github-apply warnings. Removed aos tests.

* Added new aos tests.
2020-05-18 07:50:13 -05:00
Jurrian van IerselandGitHub d61cfb5688 Added sensors for outlets on Schleifenbauer devices. (#10949)
* Added sensors for outlets on Schleifenbauer devices. Also use the outlet name when configured.

* Updated tests for Schleifenbauer

* Fixed on test for Schleifenbauer

* Optimized polling by retriving only outlets from the device with the network connection, not all devices on the data-bus.

* Fixed code styling

* Use shorthand comparisons for names

* Fix for conflicting $entPhysicalIndex
2020-04-27 00:35:00 +02:00
Tony MurrayandGitHub 217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
e83583f6f4 Adva FSP150cc Health Sensors (#11168)
* initial commit adding sensors

* changed dbm logic for port exclusions

* update mib, added xg116 support, update disc logic

* sfp health appears on ports page

* added sfp temps

* updated mib file names

* updated mib file names

* removed .mib extension

* replace ADVA-MIB

* Add test data

Co-authored-by: Tony Murray <[email protected]>
2020-02-26 12:00:48 -06:00
Tobias HeisterandTony Murray 728bc5f790 Improved RARITAN PDU/PDU2 MIB (current, power) and external env. sensors (#10616)
* added support for PDU/PDU2 MIB data (current, power) and added external sensor fpr humidity and temperature on PDU MIB

* added test data of 1 PDU-MIB device and 1 PDU2-MIB device

* Create raritan-pdu.json

* forgot to do save-data on last commit
2019-10-20 21:26:40 +00:00
ig0rbandTony Murray 3342210067 FS.net pdu (#10424)
* Added support for snmp monitored PDU from fs.com

* Added support for snmp monitored PDU from fs.com

* Fix sysObjectID 1.3.6.1.4.1.30966

* Create fs-net-pdu.json
2019-07-23 22:55:53 -05:00
Spencer ButlerandTony Murray 83522c6fef Added support for East iStars UPS (os: istars) (#10041)
* istars - Added support for East iStars UPS (os: istars)

* typo

* remove duplicate image

* refactored to use rfc1628

* added json

* update is_array to isset for bad rfc1628 implementation

* Update istars.inc.php

* revert rfc1628 changes

* update test data + PR 10240 patch

* update OIDs
2019-05-21 11:03:28 -05:00
PipoCanajaandNeil Lathwood 780ee36b10 Updated support for adva_fsp150 devices (#10049)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 13:59:08 +01:00
Spencer ButlerandTheGreatDoc 47e0ee1d04 Added support for Liebert PDUs (#10062)
* Added support for Liebert PDUs
2019-04-07 21:19:08 +02:00
KodApa85andTony Murray 7f104d4fd9 Advanced state sensors (#9881)
* refactor: advanced sensor states

mark create_state_index($state_name) as E_USER_DEPRECATED?

* fix: minor corrections

* fix: mib has partialSync(9) and incompatibleVersion(8)

* fix: corrected netagent2upsstate - Sleeping(5)

* fix: NetAgent2 upsThreePhaseUPSStatusInverterOperating correction

* refactor: array() be gone

* Refactoring includes/discovery/sensors/state/extendair.inc.php with arrays
And tidying up array formatting in other files

* fix: minor typo

* standardising array item names

removed redundant "if ($state_index_id !== null) {"

* workaround: procurve & serverscheck

a sensor is causing create_state_index($state) to return null.
The updated code doesn't allow for this and thus a hybrid is being used.

* standardised naming of state info. Caused a typo $state_name instead of $status_name
$state_name is the standard

* converted compas to square arrays

* Converted APC states using preg_match to new create_state_index() call

* Update boss.inc.php
2019-03-04 11:31:17 -06:00
KodApa85andPipoCanaja 3c0d0c9fba Added support for Alpha Comp@s (#9871)
* newdevice: Added support for Alpha Comp@s
http://www.alphainnovations.eu/compas

* fix: Updated state values
state values persist in database, even after deletion of devices.
Not a 100% how to purge them.
create_state_index($state_name, $states) doesn't update the database, if the states have changed

* refactor: comp@s OS state sensor now updated to latest format
2019-03-01 00:14:17 +01:00
Martijn SchmidtandTony Murray e0da083f5c New OS: Schleifenbauer, entity-physical improvements, various html page fixes (#9471)
* Fix some comment and documentation typos.

* Fix various entphysical page display issues.

- Resolve flickering during loading (missing liClosed for nested items).
- Clicking a sensor actually takes you to the matching graph now.

* Add a few nicecase() calls to clean up html page display.

* Create discover_entity_physical() function

- Add discover_entity_physical() function into includes/discovery/functions.inc.php
- This allows for an easy implementation of OS-specific entity-physical discovery.
- Update includes/discovery/entity-physical/entity-physical.inc.php to use the new function.

* Add power_consumed and power_factor sensors.

* Two new icons, make more entPhysical data visible.

* Pre-commit fix: blank line found at end of control structure.

* Add Schleifenbauer OS support.

* Now really fix the comment typo.

* Fix parsing mistakes.

* Add a generic count sensor.

* Make the Schleifenbauer discovery use count instead of state sensors.

* Don't place count sensor at the top, add sane limits for Schleifenbauer

* Finetuning the rrd_options, changing Schleifenbauer sensor names.

* Update schleifenbauer.svg

* optimize logo too

* add test data

* fix sensor value display (spaces break it)

* update entPhysicalIndex
2019-01-20 12:24:11 -06:00
tomarchandNeil Lathwood bdfea272be Check if value is valid for Linux servers (#8956)
Fix for issue #8950 


DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-13 22:40:54 +01:00
Tony MurrayandNeil Lathwood eeb3d58f5b Improved Logging and Debugging (#8870)
Use Log facility when Laravel is booted.
Update init.php so we can easily boot Laravel for CLI scripts. (and just Eloquent, but that may go away)
Move all debug setup into set_debug() function and use that across all scripts.
Log Laravel database queries.
Send debug output to librenms log file when enabling debug in the webui.
Allow for colorized Log CLI output. (currently will leave % tags in log file output)

** Needs testing and perhaps tweaking still.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-07-13 23:08:00 +01:00
angrypandNeil Lathwood 5af520a687 Fixed incorrect divisor procurve current sensor divisor (#8836)
This is a fix for #8746, which added support of SFP module discovery on Procurve devices. I noticed a lot of false positive alerts for current bias when we launched this in production, so looked once more through MIB/code. 

MIB data: 
hpicfXcvrBias - Tx bias current in microamps
hpicfXcvrBiasHiAlarm - Transceiver bias high alarm threshold limit in microamps
hpicfXcvrBiasLoAlarm - Transceiver bias low alarm threshold limit in microamps

Sensor discovery sample: 
hpicfXcvrBias.49 = 23254
hpicfXcvrBiasHiAlarm.49 = 100000
hpicfXcvrBiasLoAlarm.49 = 0
hpicfXcvrBiasHiWarn.49 = 90000
hpicfXcvrBiasLoWarn.49 = 100

So yes, my mistake was to use 10^-7 instead of 10^-6 divisor for these fields. Fix is in this pull request. Sorry for the inconveniences caused. 

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-06-21 23:00:56 +01:00
angrypandNeil Lathwood 1d4f662e02 device: Added SFP sensor discovery for Procurve devices (#8746)
* Added SFP sensor discovery for Procurve devices

* Added SFP sensor discovery for Procurve devices

* Added json test data
2018-05-24 21:30:36 +01:00
vivia11andNeil Lathwood 90bfce1193 Rename MIB files for ict devices (#8560) 2018-04-13 20:24:28 +01:00
Neil LathwoodandTony Murray 41dbc3547d device: Added detection for Raritan KVM and EMX devices (#8279) 2018-03-23 12:26:09 -05:00
Neil LathwoodandGitHub 1f03110b20 refactor: Moved routeros sensors to yaml + fixed divisors (#7946)
* move routeros fanspeed to yaml

* moved more routeros sensors to yaml

* reverted signal migration to yaml

* added routeros test data

* re-saved test data for routeros
2018-01-17 20:25:09 +00:00
Neil LathwoodandTony Murray 42e5819130 refactor: Updated discovery/poller to use numeric sysObjectID (#7922)
* refactor: Updated discovery to use a core module for sysDescr/sysObjectID use

* final update hopefully

* revert changes

* more changes + docs

* migrated poller to use numerical sysObjectID

* more updates for sysObjectID

* update any alert rules which might have enterprises. in

* moved schema file

* small updates

* updated getHostOS()

* scrut fixes

* updated sysObjectId -> sysObjectID

* updated sysObjectId -> sysObjectID

* updated remainder of sysObjectId -> sysObjectID

* another sysObjectId -> sysObjectID

* fixed secureplatform test data

* Fix tests: $device is not pulled from the database before polling
Also, update the db in the core discovery module.
2018-01-06 23:00:47 -06:00
Martin ZatloukalandNeil Lathwood e473b03697 Add Huawei VRP sensors to yaml and fix bug in functions.inc.php (#7918)
* Add Huawei sensors to yaml and fix bug in functions.inc.php

* Add Huawei sensors to yaml and fix bug in functions.inc.php
2017-12-16 22:26:43 +00:00
bergrothandTony Murray 84fdfdf542 Junos dwdm interface sensor support (#7714)
* Junos dwdm interface sensor support  …
  four new sensors
    Chromatic Dispersion ps/nm
    Delay s (seconds)
    Q_factor (dB)
    preFEC_BER (ratio)

  reuse of
    SNR, dbm, temperature, current

* new dwdm sensors more generic, ber and quality_factor

* new sensors updated

* renamed html graphs new sensors

*  fixed ber polling

* Change to base SI Hz and s.

* update sensor divisors to bigint

* rename sql-schema/216.sql to 218.sql

* YAML junos dwmd sensor definitions, except BER

* bigint divisor fixed

* deafult 1 divisior

* small fixes including schema change for another PR

* schema fix
2017-12-12 20:27:10 -06:00
Tony MurrayandNeil Lathwood b9dc7773d7 refactor: Don't do unneeded snmp queries (#7841)
* Don't do uneeded snmp queries
sensors discovery 26 -> 16
wrapped some poller modules in db checks.  The same could be done for some others, but more work is needed.

* travis fix
2017-12-02 23:18:45 +00:00
Tony MurrayandNeil Lathwood 76a35f2e14 device: Fix hpe-ipdu initial thresholds (#7694)
Convert to yaml
Set load thresholds from snmp
preserve existing indexes
2017-11-09 20:24:24 +00:00
Tony MurrayandNeil Lathwood 39804b047d refactor: rfc1628 sensor tidy up (#7341)
* refactor: rfc1628 tidy up
reduce the amount of snmp calls

* Did not finish re-writing rfc1628 load

* fix type in bypass power oid

* remove testing changes
2017-09-19 20:12:04 +01:00
Søren RosiakandTony Murray 701813f3ad fix: Comware dBm Limits && Comware Sensor Descr (#7216) 2017-08-24 15:08:42 -05:00
Søren RosiakandNeil Lathwood b19116abe6 newdevice: Added CiscoSB DOM Support (#7072) 2017-07-23 19:35:30 +01:00
Neil LathwoodandGitHub d1e8458b31 newdevice: Updated powerwalker sensor discovery to use custom mib (#7020) 2017-07-20 12:01:16 +01:00
Neil LathwoodandTony Murray afcc2b5e2d newdevice: Added more sensor support for raritan devices (#6929)
* newdevice: Added more sensor support for raritan devices

* Updated PDU-MIB

* Added more hover graphs to overview
2017-07-03 16:04:01 -05:00
Neil LathwoodandTony Murray aa64eb99ac fix: Fixed the index for sentry3 current + updated mibs (#6911) 2017-06-28 19:46:15 -05:00