34 Commits
Author SHA1 Message Date
Tony Murray fb489f61ed Fix cipsec-tunnels ftd bad data causes error (#14366)
fixes #12393
2022-09-18 12:15:38 +02:00
PipoCanaja 5b10d5a1ce Quick fix for cipsec-tunnels Cisco implementation (#14232)
* fix for cipsec
* style
2022-08-24 23:04:54 +02:00
cjsoftuk 43ea55bcf3 Better firebrick support (#12600)
* Add Firebrick MIBs, temperatures and voltages.

* Add missing $sysOid checks.

* Add fan speed for FB6000 series.

* Add sane limits.

* Update Firebrick MIBs.

* Make BGP peers work.

* Better support for Firebricks.

* Add more firebrick support.

* Add BGP Peer States.

* Fix fan speed divisor now that Cliff has fixed the code.

* Fixes for BGP and sensors.

* Add Firebrick IPSec module.

* Add IPSec Tunnels (Base).

* Sort out the IPSec states (although they're still green for no real reason).

* Code style fixes.

* Add missing config definition.

* Fix code style issues.

* Move bgp-peers to its own file.

* Do fan speeds with yaml, not PHP.

* Add Firebrick 6000 snmprec.

* Move Firebrick tests to be FB6000 tests.

* Revert "Move Firebrick tests to be FB6000 tests."

This reverts commit 426c1db980.

* Add tests for specific firebrick variants (2900, 6000) rather than generic.

* Add the firebrick-ipsec-tunnels poller config option.

* Switch to cipsec-tunnels for Firebrick.

* Unnecessary as it's now in cipsec-tunnels.

* Add extra MIB fields for Firebrick BGP MIB.

* Minor fix for AS text.

* Fix the tests.

* Exclude build timestamp from the version.

* Fix a couple of careless errors.

* Code style fix.

* Better version strings.

* Fixes for BGP, and add "Routing Table" support (VRF).

* Add more test data for BGP peers.

* Fix test data for BGP.

* Remove processors for now - as we can't get the data sensibly.

* Fix code style.

* Update firebrick.inc.php

Force tests re-run

Co-authored-by: PipoCanaja <[email protected]>
2021-04-04 16:17:49 +02:00
Jellyfrog 29f45ca352 Apply fixes from StyleCI (#12124) 2020-09-21 15:59:34 +02:00
Jellyfrog 2fc3a21211 Apply fixes from StyleCI (#12121) 2020-09-21 15:43:38 +02:00
Tony Murray 020c5fd7e1 Remove legacy code and fix missing device graphs (#11950)
* removing $graphs global

* remove unused things

* fix some additional graphs

* Fix graphs persisting too soon

* correct name for poller module performance graph

* only one type of graph is used here
2020-07-23 09:57:22 -05:00
Tony Murray 1445263290 Fix rrd format issues for asterisk and cipsec-tunnels (#11375) 2020-04-03 07:57:37 -05:00
Tony Murray e9ff8c48b6 Fixed IN db queries (#9077)
Most were fine as they hardcoded the in into the query.
Change them all to use PDO properly.
Did not fix IRCBot, they are are all hardcoded.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-26 13:42:21 +01:00
Tony Murray b9dc7773d7 refactor: Don't do unneeded snmp queries (#7841)
* Don't do uneeded snmp queries
sensors discovery 26 -> 16
wrapped some poller modules in db checks.  The same could be done for some others, but more work is needed.

* travis fix
2017-12-02 23:18:45 +00:00
Neil Lathwood fad5aca1b7 feature: Allow customisation of rrd step/heartbeat when creating new rrd files (#5947)
* feature: Allow customisation of rrd step/heartbeat when creating new rrd files

* revert defaults

* added docs + webui config option

* Move RrdDefinition to an Object to make them easier to create and remove the possibility of typos.

* Fix style/lint issues and missing use statements

* 3 more missing use statements

* updated doc + moved schema file
2017-02-23 22:45:50 +00:00
Neil Lathwood 21898a3c29 Disco / Poller tidy up + Added display of module mem usage (#5778)
* tidyup + added mem usage for poller modules

* tidied up discovery modules

* fix sensors
2017-02-07 22:54:30 -06:00
Neil Lathwood da5783d917 feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY (#5327)
* feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY

* fix all schema errors and update system
2017-01-07 11:32:38 -06:00
Tony Murray a83e126b40 refactor: Remove inappropriate usages of truncate() (#5028)
Where truncate() is used as substr(), replace with substr()
2016-11-20 11:12:25 +00:00
Tony Murray 83b11a372d fix: only poll cipsec for cisco devices. (#4819) 2016-10-19 22:51:09 +01:00
Tony Murray 9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
Tony Murray 97daf3dd54 Merge remote-tracking branch 'upstream/master' into rrd-create-remote 2016-08-01 10:18:28 -05:00
laf 307ea075c8 Erm, lol! 2016-07-31 16:14:01 +01:00
laf b5c33d6377 Syntax error fix 2016-07-30 14:33:57 +01:00
laf 371d3e555c Clear out stale ipsec tunnels 2016-07-30 14:18:12 +01:00
Tony Murray 57650e4ffc Remove nfs requirement for distributed poller (with rrdtool 1.5+)
Use data_update instead of rrd_update/rrd_create and influx_update
Centralize rrd file check so we can check against a remote rrdcached server too
Use rrd_name() to generate rrd file names
2016-07-07 21:10:06 -05:00
laf 433562d351 More updates for influx 2015-08-19 20:58:02 +00:00
laf 987634e463 Updated rrdtool_update() to use new array format 2015-08-18 16:26:55 +00:00
Job Snijders d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
laf 240b6c7598 Updated ipsec polling to clean up data and check before inserting 2015-03-29 20:43:35 +01:00
laf fe8bd8f2fd Unset variables which were bleeding into other polling runs 2014-07-03 14:45:47 +01:00
Adam Amstrong b273e04241 /// -> //
git-svn-id: http://www.observium.org/svn/observer/trunk@3240 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 12:24:34 +00:00
Adam Amstrong cacf913a55 # -> / for phpdoc
git-svn-id: http://www.observium.org/svn/observer/trunk@3239 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 11:29:53 +00:00
Adam Amstrong 62180e6146 add the ability to run poller without updating rrds. add --rigid to graphs.
git-svn-id: http://www.observium.org/svn/observer/trunk@3124 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-03 10:45:36 +00:00
Adam Amstrong 2b8178bb5b move all RRA decisions to config. switch mempool/storage to new rrds (sorry, data lost, the old rrds sucked). added some more apps pages.
git-svn-id: http://www.observium.org/svn/observer/trunk@3068 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-20 17:37:58 +00:00
Tom Laermans a369c442eb syntaxer run
git-svn-id: http://www.observium.org/svn/observer/trunk@2643 61d68cd4-352d-0410-923a-c4978735b2b8
2011-10-04 14:38:54 +00:00
Tom Laermans 2dc8b807e9 syntaxer run
git-svn-id: http://www.observium.org/svn/observer/trunk@2642 61d68cd4-352d-0410-923a-c4978735b2b8
2011-10-04 09:10:21 +00:00
Tom Laermans dc0ebc7343 more code cleanup
git-svn-id: http://www.observium.org/svn/observer/trunk@2517 61d68cd4-352d-0410-923a-c4978735b2b8
2011-09-20 14:22:34 +00:00
Tom Laermans d864ce234f kill a whole bunch of trailing spaces
git-svn-id: http://www.observium.org/svn/observer/trunk@2516 61d68cd4-352d-0410-923a-c4978735b2b8
2011-09-20 09:55:11 +00:00
Adam Amstrong 7c8f91e797 add graphing of ipsec tunnels on cisco kit
git-svn-id: http://www.observium.org/svn/observer/trunk@2450 61d68cd4-352d-0410-923a-c4978735b2b8
2011-09-12 13:53:37 +00:00