7594 Commits

Author SHA1 Message Date
lucalo72 43232f30e2 Add support for Riello NetMan 204 (#13878)
Added support to Riello device oid .1.3.6.1.4.1.5491.314 NetMan 204
2022-03-29 18:31:40 +02:00
Fehler12 cc7345d54a Fix usw flex switch hardware detection (#13877)
* Fixeed Hardware and Versiondetection for US-8 and USW-Switches with Version 5

It seems that the same model and same firmware version respond with different SNMP-records, depending on Hardware revision. This should be more general

* removed "linux" from version string in some cases

Changed regex for better version isolation and updated test data

* Update edgeswitch.yaml

Corrected the edgeswitch Test-Version detection. It seems that there are 4 cases :(:

USW GigaBit Ethernet Switch, firmware 5.76.7.13442
US-8, 5.76.7.13442, Linux 3.6.5
USW-Flex 5.76.7.13442
EdgeSwitch 24-Port 250W, 1.0.1.4720839, Linux 3.6.5-f4a26ed5

* Removed false change. Changed 8XP test data

Removed false change. Changed 8XP test data

* ' -> "

' -> "
2022-03-27 22:50:20 +02:00
Fehler12 9785522d13 Added Polycom Lens SNMP support. (#13876)
Added Polycom Lens SNMP support.
2022-03-25 23:54:06 +01:00
Jellyfrog 4df7968d81 Fix SQL injection in get-host-dependencies (#13868)
Thanks to raf at TNP Consultants for reporting it
2022-03-23 21:39:24 -05:00
PipoCanaja 69c1fde4c9 McAfee Proxy Sensor name update (#13853)
* fix RRD descriptions

* more

* FixTests
2022-03-18 14:19:48 +01:00
ospfbgp a8025240d3 Update voss.yaml (#13857)
Extreme changed the name on universal hardware(5520, 5420, 5320) when running VOSS 8.6 software or greater to FabricEngine for universal hardware only.  This change removed VOSS in system description and added the word FabricEngine.  So previous a switch with sysDescr of 5520-24X-VOSS became  5520-24X-FabricEngine.

General Info :

        SysDescr     : 5520-24X-FabricEngine (8.6.0.0)
        SysName      : 5520X-Traffic-VSP
        SysUpTime    : 0 day(s), 15:59:25
        SysContact   : http://www.extremenetworks.com/contact/
        SysLocation  : some location
2022-03-17 15:18:52 +01:00
Tony Murray 8df92a5f2b API: device_add support display field (#13846)
* API: device_add support display field
remove legacy code path
update docs
A few improvements to the new code too

* some fixes, port_association_mode was not available

* hand version -> snmpver translation
2022-03-15 06:54:02 -05:00
Neil Lathwood 369617ffa1 Fixed displaying hostname in create bill when port is passed (#13830) 2022-03-14 23:38:59 +00:00
PipoCanaja c28cb759aa Added WLD version 2 device support (#13849) 2022-03-14 21:33:10 +00:00
eskyuu c13975524c Fix an issue with the APC current discovery (#13837)
* Fix an issue with the APC current discovery

* Formatting fixes

* Formatting fixes

* Added test data for APC PDU sensors
2022-03-13 22:55:08 +01:00
Gene Dela Rosa 85b19ce99e Add configuration support for IPMIv2 Kg key (#13845)
* Add support for IPMIv2 Kg Key in device settings

Some devices require that the Kg key be specified. An example would be a server of mine, a Cisco C220 M3. 

Otherwise, it would error out with `Error: Unable to establish IPMI v2 / RMCP+ session`. 

With verbose output enabled, the connection attempt would stop at `RAKP 4 message has invalid integrity check value`.

* Add Kg key support in Poller

* Sanitize Kg key from debug output

* Added Kg key support for discovery process

And it seems to work like a charm. New fields, such as fan tachometers, were added in automatically.

* Applying StyleCI changes
2022-03-13 22:51:55 +01:00
Tony Murray 1bfd411995 New device:add code (#13842)
* New device:add code
pre-requisite for updating other code paths
includes option to set display name
separate validation code from device creation

* remove duplicate community and v3 creds

* style fixes

* some lint fixes

* fix phpstan

* Exception cleanup
improved messages and translations

* port association mode to enum
well, pseudo enum

* defaults and cleanups

* fixed/improved validation messages

* fix tests

* fix stupid ide refactor mistake

* lint fixes
2022-03-12 16:14:32 -06:00
Tony Murray 6d3bf03074 Display Name in availability map (#13841)
* Display Name option in availability map widget

* fix availability map page and shortDisplayName
2022-03-12 16:14:09 -06:00
Tony Murray 964cdfbbc3 Rewrite agent packages parsing code (#13840)
* Rewrite agent packages parsing code
but less crazy

* fixes

* remove commented code

* alphabetical

* Less code duplication

* fix style
2022-03-12 14:39:58 -06:00
Charly Forot e280ea1c8d [new OS] Alpine OptoElectronics TDCM-EDFA support (#13825)
* add alpine optoelectronics mibs for tcdm-edfa

* add alpine optoelectronics logo

* add alpine optoelectronics icon

* add inital detection

* add yaml discovery file

* improve yaml discovery for webUI

* rename os to alpineoe

* rename files

* replace svg logos by png

* add success tests

* Revert "replace svg logos by png"

This reverts commit 71f3dacef6.

* Revert "Revert "replace svg logos by png""

This reverts commit cd4f4cf5e0.

* Revert "add success tests"

This reverts commit 27bb3a96e4.

* add success tests with right icon

* Remove sysDecr not necessary for discovery
2022-03-11 09:48:30 +01:00
Josh Silvas a9e111f3eb Adds API call to update port notes on devices. (#13834)
* Adds API call to update port notes on devices.

* Lint fixes.

* Fixes file permissions to proper values.
2022-03-10 22:29:08 +01:00
Peca Nesovanovic 64b0c3faa3 [comware] dropped dbfetch from discovery/sensors (#13796)
* [comware] dropped dbfetch from discovery/sensors

* ci

* DeviceCache::getPrimary

* remove unneeded model

* Update includes/discovery/sensors/temperature/comware.inc.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2022-03-10 21:31:40 +01:00
martinberg 24857b98ce Add VS state for Gaia (#13831)
* Added VS state

* Better naming

* Updated test data
2022-03-10 21:24:56 +01:00
Charly Forot 48e68ec1dd Fix class error name (#13833)
Mistake on $class variable, value was 'er' instead of 'ber'.
This error prevented the ber graph located at Devices->Health->Overview
to correctly appear.
2022-03-09 00:06:19 +01:00
Loic pailhas a04f4bce50 fix db delete on cisco-vrf-lite discovery (#13823) 2022-03-08 07:18:45 -06:00
Simon Smith b8736fa758 Detect truenas scale (#13812)
detect truenas scale
2022-02-24 23:51:35 +01:00
Neil Lathwood 703745d0ed Resolved XSS issue from alert rule list modal (#13805) 2022-02-22 08:28:31 -06:00
Joel Wilson 2e5b343731 Add usage hints for Display Name placeholder usage (#13801) 2022-02-20 12:59:53 -06:00
Wolfgang Steudel 249e5e69b0 Correct divisor in discovery definition for Verity PDUs (#13768)
* Update vertiv-pdu.yaml

VERTIV-V5-MIB states UNITS "decivolts (rms)" for pduPhaseVoltage

* Update vertiv-pdu_mn03edr1.json

Updated test data

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-02-18 16:58:04 +00:00
Mark Westerterp 1df78d9503 UI: Fix second menu bar in Apps screens (#13800)
* Fix bug introduced in 2016
Introduced when changing over from tables to divs.
Caused by commit: https://github.com/librenms/librenms/commit/bda31d7152e78b8e484c7b16accdbf7edeaaf96f

* Apps: bring second menu bar in line with main menu
Scope limited to applications

* Style fixes
2022-02-18 09:19:36 -06:00
PipoCanaja 6ac13825ce Improved search results for port descriptions (#13787)
* restore pre Dec 6 2021 Description display

* restore full ifAlias

* patch from fbourqui to fix type display
2022-02-17 20:57:51 +00:00
Peca Nesovanovic 700c6ae9c3 [pbn] dropped dbfetch from discovery/sensors (#13789) 2022-02-15 22:39:23 +01:00
Peca Nesovanovic 8b831f5c6f [junos] dropped dbfetch from discovery/sensors (#13784)
* [junos] dropped dbfetch from discovery/sensors

* ci
2022-02-14 23:06:34 +01:00
PipoCanaja f24bb42cb2 Hide community and make it XSS safer (#13783)
* sanitize message display

* sanitize message display

* safe display of community, and community hidden until focus occurs
2022-02-14 13:03:01 +00:00
Guilherme Poletto 18ca4566eb New sensors for huawei vrp <tested on NE8000 platform> (#13352)
* Add EntityVoltage Sensors

* Add BoardPower Sensors

* Add Fanspeed Percent sensor

* Add Voltage_Status and Temperature_Status Normal|Minor|Major|Critical indicators, and internal Voltage and Temperature sensors

* set Minor alarm violations to warning status

* remove inconsistently applied empty lines between sections, and trailing newline that caused errors

* fetch thresholds for temperature.sensors and optical.RxPower from SNMP

* Added snmp testfiles for ne8000-m8 variant of VRP platform

* group sensors by card-identifier

* Regenerate testfiles for 5720-32x-ei

* Regenerate testfiles for the whole VRP family

* Optical Bias is reported as miliamps-mA, and not microamps-uA

* Implement divisor detection, VRP or NE8 prepended on sensor for debug-testing

* remove VRP or NE8 prependeds on sensors(put there for debug/testing only)

* use parent OIDs for walking and naming

* ignore per-slot power if unsupported

* regenerated snmp json testfiles

* sanitize bgp-peers value

* restore vrp.json test

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-02-14 10:05:18 +01:00
Neil Lathwood 95970af78e Moved some pages to be within admin route (#13782)
* Moved plugin admin pages to be within admin route
* Wrap html transports page in admin check
* Moved Port group controller to be admin protected
* fixed tests
2022-02-14 08:40:30 +01:00
PipoCanaja 4c9d4eefd8 XSS fixes (#13780) 2022-02-13 20:54:58 +00:00
PipoCanaja 41ddce6377 XSS fix, cont. again (#13778)
* XSS in alert template creation

* XSS in alert rule name

* XSS in service name & desc

* style

* strip_tags in alert_notes

* strip_tags in create_alert_item

* strip_tags in addsrv page
2022-02-13 20:23:07 +01:00
Peca Nesovanovic 0029e9f161 [refactor] Eloquent for includes/html/pages/device/health.inc.php (#13777)
* [rewrite] includes/html/pages/device/health.inc.php
* translate sensor names
* ci
2022-02-13 19:20:47 +01:00
PipoCanaja 4f86915866 XSS fix, cont. (#13776)
https://huntr.dev/bounties/13951f51-deed-4a3d-8275-52306cc5a87d/
2022-02-13 19:07:37 +01:00
PipoCanaja 135717a9a0 security - XSS Fix 01
fixing https://huntr.dev/bounties/114ba055-a2f0-4db9-aafb-95df944ba177/ (#13775)
2022-02-13 11:00:56 +01:00
Santiago Z 7d2ade71f1 [WebUI] Show selected selection option on graphs page (#13765) 2022-02-11 11:06:41 +01:00
Jellyfrog b9e55bc462 Upgrade to font awesome 5 (#13754)
* Upgrade to font awesome 5

* Update memory icon
2022-02-09 00:49:07 +01:00
Peca Nesovanovic ee00f59ce6 [terra] support for sdi410c / sdi480 (#13759)
* [terra] support for sdi410c / sdi480

* remove debug
2022-02-08 23:27:40 +01:00
Martin22 e88e53d1b0 Racom Ray: Added BER (#13758) 2022-02-08 11:32:49 +01:00
ilGino 58c88a6db3 [WebUI] Removing colon symbol from multiple dialogs (#13742)
* [WebUI] Removing the colon symbol from dialogs

In order to make multiple pages more visually consistent with other pages in the system, removed the colon simbol ":" to the very right of each control description, where present.

Regards
GG

* Update new_alert_rule.inc.php

* Update alert_schedule.inc.php

* Update alert_template.inc.php
2022-02-03 15:51:51 +01:00
Neil Lathwood e3bba1e53d Added system temperature support including state (#13743) 2022-02-03 11:29:34 +01:00
Tony Murray 2dcc70301c Fix < 0 exception in ports poller (#13732) 2022-02-02 17:31:54 +01:00
Fehler12 6263a15315 Lenovo think station Support (#13617)
* Add initial support for Lenovo ThinkStation server

* Initial Support for Lenovo ThinkStation Server - detection rules

* Lenovo ThinkStation MMIB Files

* Added test data for Lenovo ThinkStation

Model SR250

* trying unit test fix

trying to correct unit test failures

* Revert "trying unit test fix"

This reverts commit 7f44689e8a.

* Create lenovoXClarityIMPI_lenovoxcc.snmprec

Added snmprec

* Update lenovoXClarityIMPI.yaml

Removed Null-Value (over) in yaml

* Update lenovoXClarityIMPI.yaml

Fixed typo

* Update lenovoXClarityIMPI.yaml

Fixed another typo in os yaml

* Update lenovoXClarityIMPI.yaml

Added {{ $index }} and removed skip_values

* Update lenovoXClarityIMPI.yaml

Added index in yaml

* Update lenovoXClarityIMPI.yaml

* Update lenovoXClarityIMPI_lenovoxcc.json

* Update lenovoXClarityIMPI_lenovoxcc.json

* Updated detection rule

Removed N/A skip, removed unecessary state_name.

Removed $index in oid, because otherwise the detection fails for some reason
Excluded num_oid because otherwise the poller fails to detect the values.

* Code improvements and test data

I've implemented what I've learned from my Fujitsu pull:
- added test data
- corrected MIB file names and folder

* Code improvements

Removed an empty array and two empty lines.

* Code improvements

* Delete LENOVO-SMI-MIB DEFINITIONS

This file is named wrong and we already have `LENOVO-SMI-MIB` so looks to be duplicated

* Changed OS name

Changed OS name

* Fixed test data for os name change

* Update LENOVO-PRODUCTS-MIB

Reupdated Lenovo-Products-MIB to 2017er Version

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-02-02 07:53:32 -06:00
Santiago Z b93a892feb [WebUI] Added the word Actions in the header of the oxidized-nodes table (#13741) 2022-02-02 02:07:35 +01:00
Peca Nesovanovic a3bd1b9a69 [mikrotik] added ipv6 route discovery (#13737)
* [mikrotik] added ipv6 route discovery

* ci
2022-01-31 18:00:30 +01:00
Tony Murray 29bd6789cb Stp module rewrite (#13570)
* STP module rewrite WIP

* Finish rewrite

* Ignore disabled and log root/topology changes

* Remove interfaces for now

* fix style

* Lint fixes

* Document ResolvesPortIds and hide map functions

* whitespace fixes

* Revert to stpInstances in case someone writes mstp support

* missed one

* phpstan fixes

* Handle table and oids separately

* forgot to register observer

* Test data and correct non-table handling in SnmpResponse->table()

* update test

* test data

* revert aos7 silly things

* minimal polling

* Update test data

* order ports_ntp and rename new field to port_index

* forgot the db_schema

* revert ciena-sds port things

* MSTP support, maybe

* Adding test data

* Filter bad lines instead of discarding the entire snmp response
and capture fixes and test data

* fresh data

* add os data

* update data, ignore unfound ports, obviously bad device implementation.

* fixes

* Ignore context files in os detection test

* Remove empty table data

* add ciena-sds vlan

* designatedCost column is too small

* Update stp webui

* Refactor code to interfaces, to allow vendor mibs

* update schema

* fix issues added by abstraction

* STP fixes

* Default to no context for vlan 1

* never store vlan 1

* Update test data

* remove eltex brokenness

* fix style

* fix stan

* Fix Rewrite MAC to Hex padding with floats

* fix sqlite migration
2022-01-30 16:28:18 -06:00
Wheel 2dbfdda717 Ubiquiti Airfiber60 (#13680)
* Add ubiquiti Airfiber 60

* New AF60 data and MIB

* Stylci fix and small additions

* Update test data

* Stylefix

* Remove the weird ubiquity oids containing encoded mac addresses

* Updated test data

* Remove more complex sensors for now to be added after the conflict airos airos-af60 is solved

* Fix hardware and OS

* To be verified is this is the most practical / clean way of doing it

* Advanced wireless and MCS state sensor

* Fix link capacity multiplier and active link

* Test data update fix lint

* Maybe better
2022-01-29 21:10:45 -06:00
Tony Murray b6a8b602b8 Oxidized update and Device remove (#13730)
* Oxidized + Device remove
Was just working on oxidized, but then to properly update nodes after delete, updated delete_device()

* revert dumb style changes

* baseline update and no DI there...

* Fix OS first load and device deletion missing tables
2022-01-29 21:09:05 -06:00
Tony Murray 29ff20d7eb UBNT fixed airos temp in 8.7.7 (#13731)
* UBNT fixed airos temp in 8.7.7
restrict workaround to only versions 8.7.4-8.7.6
fixes: #13655

* remove extra character
2022-01-30 02:04:03 +01:00