Commit Graph
1832 Commits
Author SHA1 Message Date
Jellyfrog 21797c25bd fixes 2023-05-24 23:33:10 +02:00
Shift a9305bf42e Define test classes as final 2023-05-24 20:23:38 +00:00
Shift 66b4d9c4ce Add return types to test methods 2023-05-24 20:23:38 +00:00
Shift 5dd1380cac Declare data providers as static 2023-05-24 20:23:37 +00:00
Shift 90e1dc3e75 Adopt PHP attributes in test classes 2023-05-24 20:23:37 +00:00
Jellyfrog 2b3575a5e9 Laravel 10.x Shift (#14995)
* Apply code style

* Remove explicit call to register policies

* Shift core files

* Shift config files

* Default config files

In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.

* Bump Laravel dependencies

* Add type hints for Laravel 10

* Shift cleanup

* wip

* wip

* sync translation

* Sync back config

* Public Path Binding

* QueryException

* monolog

* db::raw

* monolog

* db::raw

* fix larastan collections

* fix phpstan bug looping forever

* larastan errors

* larastan: fix column type

* styleci

* initialize array

* fixes

* fixes

---------

Co-authored-by: Shift <[email protected]>
2023-05-24 22:21:54 +02:00
d-k-7 dd3ed41319 add sensor support for cefcModuleOperStatus (#15026)
* add sensor support for cefcModuleOperStatus

* add tests for cefcModuleOperStatus

* revert sensors/state/cisco.inc.php

* add sensor support for cefcModuleOperStatus using yaml

* update tests for cefcModuleOperStatus

* try adding tests again for cefcModuleOperStatus

* include CISCO-ENTITY-FRU-CONTROL mib for cefcModuleOperStatus sensor state discovery
2023-05-24 20:43:37 +02:00
Jellyfrog 153be4d583 Tests: Fix Dusk tests after 13626 (#15057) 2023-05-23 19:23:15 +02:00
Tony Murray 04bb75f5f3 Alert transport cleanup, no_proxy support and other proxy cleanups (#14763)
* Add no_proxy and other proxy related settings
Set user agent on all http client requests
Unify http client usage

* Style fixes

* Remove useless use statements

* Correct variable, good job phpstan

* Add tests
fix https_proxy bug
add tcp:// to the config settings format

* style and lint fixes

* Remove guzzle from the direct dependencies

* Use built in Laravel testing functionality

* update baseline
2023-05-23 09:25:17 -05:00
Nick Peelman da94ac5a85 Add RoomAlert 12E Switch Sensors, fix Humidity Sensor (#15049)
* Add RoomAlert 12E Switch Sensors, fix Humidity Sensor

* Fix per murrant

* Revert port data generated on older install

---------

Co-authored-by: Tony Murray <[email protected]>
2023-05-19 10:14:09 -05:00
Tony Murray 38c29e0222 Reduce OS module test noise (#15046)
* Reduce os module test noise
JSON stores 1.0 as 1, so format the actual data in the same way.
Add tests too to make sure this behavior doesn't break

* Only change floats
2023-05-19 09:57:39 -05:00
mtentilucci e55c4e9e1e Add support for Trellix NSP devices (#14964)
* Add support for Trellix NSP devices

- Add discovery for mlos NSP devices
- Monitor port statistics from non standard MIBs
- Add Trellix MIBs
- Add test data

* Fix StyleCI findings

* Rename MIB files to match MIB names, remove unused MIBs

* regenerate mlos-nsp_ns9500.json to account for changes from PR#14963
2023-05-16 17:25:29 -05:00
cjsoftuk 635acad7d6 Firebrick CPU Monitoring (#15030)
* Add FB CPU definition.

* Poll in the right OID.

* Add test data for FB CPUs.
2023-05-09 17:32:34 +02:00
bnerickson 56e9fa3742 Adding linux_config_files application support (#14776) 2023-05-09 10:23:49 -05:00
cjsoftuk 927446db7b Fix Firebrick mempool polling (#15022)
* Add support for Firebrick memory monitoring.

* Add mempool testing for Firebrick.

* We have to specify the OID by numeric, because otherwise it assumes it's some kind of indexed table.

* Specify by OID.

* Fix test result data for the FB mempools.x

* Firebrick reports in KB.

* Fix precision in the tests.
2023-05-02 14:02:50 -05:00
cjsoftuk bc310cffec WIP: Add support for memory monitoring on Firebrick platform (#15021)
* Add support for Firebrick memory monitoring.

* Add mempool testing for Firebrick.
2023-05-02 07:12:09 -05:00
Tony Murray 75f8fe214f Slightly better OS module test output (#15001)
* Slightly better OS module test output
Maybe faster
Remove forced --debug in phpunit

* No assertions is ok

* Use always true assert instead

* Restore route poller module skip

* Sneaky whitespace
2023-04-27 14:49:52 -05:00
Tony Murray 2f39917f3b Fix up icr-os outdated test data (#15006)
* Fix up icr-os outdated test data

* fix sensor data too
2023-04-25 20:53:17 -05:00
Mathias Bøhn Grytemark 204abe0cf2 add advantech icr-os for advantech routers (#14171) 2023-04-25 07:54:41 -05:00
ollb d40c3be75d Fix cisco dbm sensors port link on discovery (NCS55A2) (#13965)
* Fix cisco dbm sensors port link on discovery (NCS55A2)

dBm sensors were not linked to port on Cisco NCS55A2 platform (iosxr)
causing false alarms triggered by optical modules in administratively shut down ports.

* Delete iosxr_ncs55a2.json

* Create iosxr_ncs55a2.json

* Renew test/data/iosxr_ncs55a2.json

* Delete and recreate test/data/iosxr_ncs55a2.json

With command :

  ./scripts/save-test-data.php -o iosxr -v ncs55a2 -m os,ports,processors,mempools,sensors

---------

Co-authored-by: Tony Murray <[email protected]>
2023-04-17 11:08:52 -05:00
Jellyfrog 0a351b49fd Laravel 9.x Shift (#14504)
* Move `resources/lang` folder

* Shift registered middleware

* Remove `fruitcake/laravel-cors` dependency

* Streamline `$commands` property

* Upgrade to Flysystem 3.0

* Shift core files

* Convert `optional()` to nullsafe operator

* Remove unnecessary `$model` property

* Convert route options to fluent methods

Laravel 8 adopts the tuple syntax for controller actions. Since the old options array is incompatible with this syntax, Shift converted them to use modern, fluent methods.

* Convert deprecated `$dates` property to `$casts`

* Shift config files

* Default config files

In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.

* Bump Laravel dependencies

* Use `<env>` tags for configuration

`<env>` tags have a lower precedence than system environment variables making it easier to overwrite PHPUnit configuration values in additional environments, such a CI.

Review this blog post for more details on configuration precedence when testing Laravel: https://jasonmccreary.me/articles/laravel-testing-configuration-precedence/

* Fix error provider

* Match new symfony syntax

* Match upstream syntax

* Fix route syntax

* generate composer.lock

* Sync back configs

* routes

* composer

* Fix more flare

* fix cors

* sync lang

* Apply fixes from StyleCI (#14517)

Co-authored-by: StyleCI Bot <[email protected]>

* bump larastan

* update packages

* wip

* Temporarily lower phpstan level

* Update phpstan.neon

* wip

* wip

* wip

* Apply fixes from StyleCI (#14592)

Co-authored-by: StyleCI Bot <[email protected]>

* test

* Update CiHelper.php

* Update test.yml

* Update CiHelper.php

* Update CiHelper.php

* Apply fixes from StyleCI (#14616)

Co-authored-by: StyleCI Bot <[email protected]>

* test?

* fix phpstan problems

* dont run snmpsim on github ci

* Fix whitespace

* More whitespace

* More whitespace ???

* I think the space broke it

* fix the reset of the whitespace

* hard code auth guard

---------

Co-authored-by: Shift <[email protected]>
Co-authored-by: StyleCI Bot <[email protected]>
Co-authored-by: Tony Murray <[email protected]>
2023-04-17 06:51:35 -05:00
AdamB 519fc00367 Change ESXi port naming to be stable (#14639)
* Change ESXi port naming to be stable

Currently every time discovery runs against ESXi, the port names change generating a lot of log spam.

This is because ESXi uses this as the ifDescr:
```Device vmnic1000202 at 01:00.0 nmlx4_en```

The poller parses this, and extracts the interface name, whereas discovery does not, causing the interface names to flip every 6 hours.
https://github.com/librenms/librenms/blob/22.10.0/includes/polling/ports.inc.php#L578-L580

This change gives the discovery process the same behaviour, so the naming is now stable.

* Try to fix test data with a squash

* vcsa test data

* Synthesise VCSA ifName, use it in place of ifDescr

* Refresh test data

* Update ports.inc.php

---------

Co-authored-by: Tony Murray <[email protected]>
2023-04-16 12:58:38 -05:00
Tony Murray 52f5f10231 Fix some lint issues (#14962) 2023-04-15 09:02:41 -05:00
mtentilucci b6572e0acc Add support for Trellix ATD devices (#14965)
* Add support for Trellix ATD devices

- Add discovery for mlos ATD devices
- Monitor various OIDs related to ATD system health and status
- Add required MIBs
- Add test data

* add json test data

* Rename MCAFEE-SMI to MCAFEE-INTRUVERT-SMI

---------

Co-authored-by: Tony Murray <[email protected]>
2023-04-14 19:34:43 -05:00
Schylar Utley 056305c3c3 Add support for Alpha CXC HP Controller (#14829)
* add support for Alpha CXC HP Controller

* add num_oids, fix formatting

* fix typo

* Rename cxc_cxc.snmprec to cxc.snmprec

* Create ALPHA-RESOURCE-MIB

* Create ALPHA-RECTIFIER-SYS-MIB

* Create cxc.json

---------

Co-authored-by: Tony Murray <[email protected]>
2023-04-14 18:04:42 -05:00
Tony Murray 0cdda100e7 Fix Raisecom Processor (#14968)
* Fix Raisecom Processor
Had the same problem as ROS #14966

* Missed oid update
2023-04-14 17:12:35 -05:00
Tony Murray cafdec6285 Remove unused port fields (#14963)
* Remove unused port fields
(and set vlan to default to null)

* Update test data for deleted fields

* update vlan to null

* missed field removals

* More correct migration

* Update new data

* restore accidental deletions
2023-04-14 16:47:26 -05:00
Tony Murray 49056da4a0 Fix Raisecom ROS processor collection (#14966)
Was origionally intended to use the 1 minute values, but was discovering the one second value and polling the twoHour value
Was also restricted to only one CPU.
Now discovers and polls all CPUs at the oneMin avg
2023-04-14 15:22:55 -05:00
mtentilucci 04217269a4 Expand discovery of gigavue os (#14933)
* Expand discovery of gigavue os

- Expand discovery so all Gigamon products are discovered
- Query for hardware version using GIGAMON-SNMP-MIB::model.0 OID if present
- Add more Gigamon gigavue test data

* Create gigavue_hc2.json

Looks like there was no json file before...

* update gigavue_hc2.json

---------

Co-authored-by: Tony Murray <[email protected]>
2023-04-14 07:12:44 -05:00
JStandiford 3362e0ee7b fortivoice: add version, hardware and serial collection (#14956)
* Update fortivoice.yaml

Add in pulling in device hardware and software info

* Add files via upload

* Add files via upload

* merge test data

* Delete fortivoice_fortivoice.snmprec

* Update fortivoice.json

* Update fortivoice.json

---------

Co-authored-by: Tony Murray <[email protected]>
2023-04-12 10:11:49 -05:00
Tony Murray e9c08e21a5 Fix more divide by zero issues (#14954)
* Fix more divide by zero issues
fixes: 14932

* Round to the nearest integer, then cast

* Fix up dhcpatriot
2023-04-11 13:44:45 -05:00
pjroehl 2b1f6a743d Add discovery of NVT Phybridge FLEX24 (#14913)
* Add discovery of NVT Phybridge FLEX24

* Update phybridge-flex.yaml

Added FLEX-24 Switch under sysDescr

* Test Data phybridge-flex_flex-24 json and snmprec
2023-04-10 11:12:12 +02:00
mtentilucci b09f5f63e4 Add Nutanix AOS discovery (#14950)
* Add Nutanix AOS Discovery

- Add basic discovery configuration
- Add Nutanix .svg icon and logo
- Add test data

* fix yaml style nutanix-aos.yaml
2023-04-07 13:02:41 -05:00
mtentilucci 698b9ee48c Add Rubrik Discovery (#14951)
- Add basic discovery
- Add Rubrik .svg icon and logo
- Add test data
2023-04-07 13:01:30 -05:00
cjwbath bbe752b24a Add initial OS detection for LoadBalancer.org (#14902)
* Add initial OS detection for LoadBalancer.org

* Match on Linux sysObjectID first for efficiency

Co-authored-by: Tony Murray <[email protected]>

* Add test for loadbalancer OS detection

* Add test for loadbalancer OS detection - fix author

* Add test for loadbalancer OS detection

* Add test for loadbalancer OS detection - fix author

---------

Co-authored-by: Tony Murray <[email protected]>
Co-authored-by: Chris Ware <[email protected]>
2023-04-06 19:58:14 -05:00
Dan Baker a340672e86 Added graphing of DDoS-protection related OIDs for PAN-OS (#14847) 2023-04-06 19:11:16 -05:00
Dan Baker 7173205039 Added sensor support for older APC InfraStruXure PDUs (#14944) 2023-04-06 19:09:45 -05:00
RobJE 75033daaa8 add support for WTI console products (#14920)
* add support for WTI console products

* add test data
2023-04-04 13:21:10 +02:00
GeantRA ec9e77b665 Update junos discovery yaml to reference total memory instead of buff… (#14919)
* Update junos discovery yaml to reference total memory instead of buffer memory used

* Add FPC0 test data reference
2023-04-04 10:28:59 +03:00
jellejans ae429d987a Device - Add support for Scalance SC646-2C (#14835)
* Update scalance.yaml

Add support for Scalance SC646-2C

* add scalance_sc646.snmprec
2023-03-21 07:31:42 -05:00
Stef e1b2a42373 Device: Deltanet Lambdatrail LT2-S,HS (#14661)
* Deltanet Lambdatrail integration - first try

* add fan parameters

* ignore values

* lint

* over graphs and snmp fix

* definition for hs variant

* HS variant added

* mibs renamed

* add test data

* Deltanet Lambdatrail integration - first try

* add fan parameters

* ignore values

* lint

* over graphs and snmp fix

* definition for hs variant

* HS variant added

* mibs renamed

* add test data
2023-03-21 07:29:17 -05:00
Nick Peelman 7ccccdf914 Add Montclair EDFA Support (#14852)
* Add Montclair EDFA Support

* Fix detecton

Used explicit match regex

---------

Co-authored-by: Tony Murray <[email protected]>
2023-03-18 21:34:28 -05:00
mtentilucci d6d2827f97 Add support for Trellix FireEye OS (#14908) 2023-03-18 18:51:14 +01:00
electrocret 1173cf3161 Fix dbm calculation to return -60 instead of 0 (#14858)
* Fix calculation

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* rebuild using SNMPRec

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9010.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json
2023-03-15 08:07:46 -05:00
Jellyfrog 68e0b3df28 Apply fixes from StyleCI (#14899)
Co-authored-by: StyleCI Bot <[email protected]>
2023-03-13 22:32:22 +01:00
Jellyfrog f111ac22fe APC: Add support for Battery Recommended Days Remaining (#14653)
* APC: Add support for Battery Recommended Days Remaining

* Extract number from string later during polling
Odd that this is different from the discovery process

* wip

* wip

* Apply fixes from StyleCI

* wip

* wip

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <[email protected]>
2023-03-10 14:50:56 +01:00
mtentilucci 50540cc3e9 Update test data to account for new .svg icon (#14892) 2023-03-10 10:09:29 +01:00
mtentilucci 1e373dedc6 Add Avocent MergePoint Unity KVM Switch Support (#14874)
* Modify Avocent discovery so Avocent MergePoint Unity KVM switches are discovered

* Extract hardware model and version stored in sysDescr OID

* add avocent mpu snmprec

* add json dump test data

* update to not conflict with dell-rcs discovery

* fix styleci findings

* update Avocent.php

* update Avocent.php

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* cleanup

* fix os name typo

* Add support for Vertiv Avocent MergePoint Unity

- Remove unnecessary sysdescr_regex in discovery file
- Only show device_bits graph in device header bar
- Use Vertiv icon
- Replace .png Vertiv icon and logo with .svg
- Disable unnecessary discovery and poller modules
- Add more snmpsim test data

* Update avocent-mp.yaml

Only disable poller and discovery modules if they cause problems
2023-03-10 00:09:53 +01:00
electrocret d7a7e0c158 Improve Corero CMS support (#14876)
* MIBs

* Create cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Add files via upload

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Add files via upload

* Update cms.snmprec

* Update cms.json

* Update cms.json

* Update cms.json
2023-03-04 19:00:31 +01:00
electrocret b68aa04311 Add Fortigate Webfilter stats (#14873)
* Update fortigate.yaml

* Update fortigate.yaml

* Fix git-apply

* Create fortigate_webfilter.snmprec

* Update fortigate_webfilter.snmprec

* Create fortigate_webfilter.json
2023-03-03 18:22:58 +01:00