Commit Graph

11 Commits

Author SHA1 Message Date
VoipTelCH
e55e49ddf6 Fix discovery ignores custom ipmi port (#14660)
* Update ipmi.inc.php

* Update ipmi.inc.php

Fix use default port if not specified

* Update ipmi.inc.php

Fixed for more consistency with the rest of the file

* filter_var returns the value

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-11-22 09:41:51 -06:00
Gene Dela Rosa
85b19ce99e Add configuration support for IPMIv2 Kg key (#13845)
* Add support for IPMIv2 Kg Key in device settings

Some devices require that the Kg key be specified. An example would be a server of mine, a Cisco C220 M3. 

Otherwise, it would error out with `Error: Unable to establish IPMI v2 / RMCP+ session`. 

With verbose output enabled, the connection attempt would stop at `RAKP 4 message has invalid integrity check value`.

* Add Kg key support in Poller

* Sanitize Kg key from debug output

* Added Kg key support for discovery process

And it seems to work like a charm. New fields, such as fan tachometers, were added in automatically.

* Applying StyleCI changes
2022-03-13 22:51:55 +01:00
Simon Smith
f0bef36b16 fix adding discrete ipmi sensors (#12709) 2021-04-06 18:44:35 +02:00
Jellyfrog
82f43cb98d Apply fixes from StyleCI (#12120) 2020-09-21 15:40:17 +02:00
Tony Murray
1c08c11a77 Remove Laravel helpers (#11428)
* Remove Laravel helpers

* Replace qualifier with import
2020-04-18 00:37:56 +02:00
Tony Murray
fad0bffc43 Escape SNMP & IPMI shell commands (#9537)
hopefully doesn't break anything
Mostly issues with snmp oids and options containing spaces.  Try to remove all of those.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-12-16 13:42:50 +00:00
crcro
2a15da2228 fix: Ignore OEM ipmi sensors that returns unreadable values (#7518)
* fix for OEM ipmi server that doesn't return hreshold

* escape chars, typo
2017-10-20 16:43:27 +01:00
Tony Murray
b18c41b1a9 refactor: Use the Config class includes/discovery (#7299)
* refactor: use the Config class includes/discovery

* fix issue with $config variable not accessible in include-dir.inc.php

* improved whitespace

* Tidy up discovery_by_ip
2017-09-11 21:26:41 +01:00
Zaxmy
2b52977668 fix: Wrapped ipmi user / pass in quotes #4686 and #4702 2016-10-03 19:10:59 +01:00
Neil Lathwood
dc26f097b0 fix: Run cleanup for ipmi sensor discovery (#4582)
* fix: Run cleanup for ipmi sensor discovery

* Updated check_valid_sensors calls to use ipmi as sensor type
2016-09-26 16:34:54 -05:00
laf
b5d1155006 Updated discovery sensors module directory structure 2016-01-17 20:47:47 +00:00