Commit Graph

2623 Commits

Author SHA1 Message Date
PipoCanaja
05ce3d1858 Allow more compatibility in STP port discovery/polling (#13109)
* allow more variety in STP port discovery/polling

* style
2021-09-08 08:57:22 -05:00
SourceDoctor
1544eadd37 default port_group for new ports (#13166)
* default port_group for new ports

* .

* adding Docs, default Value, change keyname

* .

* Update Configuration.md

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-08-24 20:28:18 +02:00
Tony Murray
d8d0ccd03d Common contexts for polling (#13158)
* Common contexts for polling
Don't store contexts on the device array, use the device model
Also should be easier to add different contexts later.

* rename variables for consistency
2021-08-23 01:22:28 -05:00
dennypage
049b7af3d5 Allow stack index other than '1.' for CiscoSB (#13078)
* When in a stack, the index for each port is based on the unit number in the stack. The first unit
in the stack uses index '1.', the second uses index '2.', the third '3.' and so on. This change
allows for stack indexes greater than '1'

* Create ciscosb_cbs350-4x.snmprec

* Create ciscosb_cbs350-4x.json

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-08-03 16:31:00 +02:00
Peca Nesovanovic
9557cccb6a Jetsream: added/fixed LLDP discovery (#13082) 2021-07-31 18:26:57 +02:00
O Palivan
754276ba89 Extend REGEX filtering option by sensor_class (#13066) 2021-07-23 23:46:12 +02:00
Keryazmi
2ddf460283 ADVA - Typo in previous PR (#13064)
Replace string 'cmEthernetTrafficPortIfIndex' to 'cmEthernetNetPortIfIndex'.
And replace typo word.
2021-07-23 12:00:02 +02:00
Emmanuel Caillé
578602f8f9 Use non numeric snmpwalk for nxos fan trays (#13048)
* Use non numeric snmpwalk for nxos fan trays

* Update test data with now discovered fan data
2021-07-21 19:19:41 +02:00
Keryazmi
3d0c1e63b7 Update Sensors for ADVA FSP150CC + discovery fix (#13020)
* Update YAML file for ADVA FSP150CC

Update for Adva FSP150CC
1. ERP State
2. Condition State

* Update Pre-Cache for ADVA FSP150CC

Update multiple devices and cache ERP objects.
1. XG116Pro (H)
2. XG120Pro
3. XG210
4. EG-X

* Update on Temperature Sensors for ADVA FSP150CC

Update multiple modules to support Adva FSP150CC Series.

* Update Voltage Sensors for ADVA FSP150CC

Update multiple modules for Adva FSP150CC Series.

* Create adva_fsp150_xg116proh.snmprec
* Create adva_fsp150_xg116proh.json
* Update adva_fsp150_xg116pro.snmprec
* Update adva_fsp150_xg116pro.json

Fix legacy ADVA discovery code

* Fix snmp-get and DB access
* style

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2021-07-17 01:01:45 +02:00
Peca Nesovanovic
a6a00419e4 Inital support for Eltex-MES switches (#13036)
* Inital support for Eltex-MES switches

* Eltex-MES code cleanup & added mib files

* Eltex-MES mib files renamed

* Eltex-MES mib files renamed(v2)

* Eltex-MES added json test data

* Eltex-MES added bad_iftype in YAML

* Eltex-MES test data after adding bad_iftype in YAML

* Eltex-MES fixed YAML & new test data

* Undo module disabling

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2021-07-16 16:14:09 +02:00
Npeca75
1b68273b5d Added Vlan discovery on LAG ports, Jetstream OS (#13007)
* Added Vlan discovery on LAG ports, Jetstream OS

* Jetstream expand function rewriten

* Jetstream expand function rewriten

* Jetstream expand function rewriten (v2)

* Added snmprec

* Create jetstream_t1600g-28ts.json

* Combine Regex

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-07-11 12:21:19 -05:00
paulierco
bc5a62dcbd Alcatel-Lucent aos7 LLDP Neighbors (#12886)
* first commit

* fix style

* fix style

* fix style

* fix style

* fix style

* fix style

* fix style

* change local_port_id

* fix style

* fix style

* fix style
2021-07-03 15:23:58 +02:00
paulierco
c505040289 Alcatel-Lucent AOS6 to yaml (#12982)
* first

* add missing ifName

* oid for stacking and style

* add missing ifName

* revert stacking

* remove stacking mib

* remove PS-1
2021-06-28 12:42:34 +02:00
Kevin Zink
7ef302a8b9 EUROstor RAID (#12969)
* Proware Controller in EuroStore RAID Chassis

* fix style

* Eurostore

* renew testdata

* Fix style
2021-06-21 10:13:40 +02:00
cjsoftuk
b7d1420020 Firebrick: Fix an issue which led to duplication of BGP peers. (#12932)
* Firebrick: Fix an issue which led to duplication of BGP peers.

* Code style.

* Attempt to get some sanity with BGP Table 0.

* Attempt to make it so peers are not immediately added then deleted.

* Force vrfId to Null if empty.

* Another attempt at keeping the DB clean.

* Code style.

* Stop the dicovery deleting peers it just created.
2021-06-21 09:51:49 +02:00
Kevin Zink
4ec609bccf Add Serialnumber for some Dell ForceTen devices (#12960)
* Add Serialnumber for some Dell Force devices

* Also in entity-physical

* fix style

* fix style

* add testdata
2021-06-17 21:16:09 -05:00
PipoCanaja
53ce0e016f LLDP - Extend discovery lldp code to support different subtypes (#12901)
* extend lldp code to support different subtypes

* style
2021-06-17 00:42:28 +02:00
Kevin Zink
7edc302f34 2 more Rittal variants (#12953)
* 2 rittal variants

* fix style

* fix problem with missing entry["cmcIIIVarValueStr"]

* fix typo
2021-06-16 21:15:47 +02:00
paulierco
20c44b85c3 Alcatel-Lucent aos6 and aos7 fdb fix (#12945)
* first

* style
2021-06-12 09:32:34 +02:00
geg347
672fe61b5e New module add juniper rpm support + reimplementation of cisco-sla module (#12799)
* Definition of a new SLA module to migrate from old cisco-sla and support other devices : Juniper RPM and Huawei

* Change wrong description name of module SLA

* Re implementing Juniper RPM support in a new module Slas (Cisco SLA to be added)

* Added Graphs for Juniper RPM types

* Tried to make discover and poller generic : to handle Cisco SLA and Juniper RPM and others

* Reimplementing Cisco SLA in the new Sla module and adding condition to manage both SLA and RPM

* Definition of a new SLA module to migrate from old cisco-sla and support other devices : Juniper RPM and Huawei

* Change wrong description name of module SLA

* Re implementing Juniper RPM support in a new module Slas (Cisco SLA to be added)

* Added Graphs for Juniper RPM types

* Tried to make discover and poller generic : to handle Cisco SLA and Juniper RPM and others

* Reimplementing Cisco SLA in the new Sla module and adding condition to manage both SLA and RPM

* Fix some error due to Elequent object replacing SQL request

* Fixing indentation

* Fixed continuous integrations errors

* Fixed continuous integrations errors part 2

* Fixed continuous integrations errors part 3 : missing last new lines

* Fixed PHP Static Analysis checks

* Fixed continuous integrations errors part 4

* Fixed PHP Static Analysis checks part 2

* Trying to convert existing cisco-sla to new slas one

* Trying to add slas to fix test failure (I am pretty sure this is not enough but I don't know how to do it)

* Switching old cisco-sla module declaration to new slas module in concerned OS files

* Fixing wrong sla module name instead of slas in concerned OS files

* Fixing wrong module name sla changed to slas (as is it in power-supplies reimplementation)

* Fixing some warnings shown in the Inspection CI but skipping some that are already present

* Adding tests files from virtual Juniper VMX and adding slas modules in /tests/module_tables

* Adding missing SNMP data files

* Module Slas modifications to use inheritance

* Fix CI errors

* Fix CI errors part 2

* Fix CI errors part 3

* Fixing no value on RTT graphs

* Fixing only last SLA to be polled : problem with loops

* Fix CI errors part 4

* Optimizing a little the Juniper RPM poller part

I wanted to query only the required values but it is complicated to query a specific OID
as Cisco-SLA does because the owner and tag are hardcoded in ASCII decimal with strange values.
So I use the function snmp_walk which gets the whole OID values in text.
And I index the Juniper MIB (because we want multiple values). But I changed the DISMAN MIB
requests to get only what we want.

* Fix CI errors

* Fix CI errors part 2

* Fix CI errors part 3

* Fixing PHP Static Analysis error 2/4

* Fix CI errors

* Implementing Interfaces to fix some errors that occurs with inheritance

* Adding missing Interfaces files

* Moving generic Sla discovery code into Junos Class

* Fix CI errors

* Fix CI errors part 2

* Fixing missing definition of SlaDiscovery in Cisco shared Class

* Fixing missing import for Illuminate\Database\Eloquent\Collection

* Fix CI errors part 3

* Fix PHP Static Analysis error

* change type strings to use translations instead of config

* IOSXR test data

* remove test data garbage

* simplify discovery

* Fix style

* Updating test files to adapt mock sla_nr ID starting from 0 and not 1 : CI tests should pass

* clean up polling
add rtt field in the db
cisco icmpjitter seems to have confused a lot of values

* rtt on discovery

* use crc32 for consistent sla_nr values

* revert snmprec

* Fix style

* correct schema

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-06-11 13:48:33 -05:00
ottorei
69397ea70f ISIS-adjacency polling support (#12461)
* init

* Add adjacency polling support

* Format messages

* Fix prints

* Apply fixes from StyleCI

* Fix schema

* Schema fix

* Alert rule example

* Remove display format

* Change option order

* Add test data

* Add test data

* Test data

* Review fixes

* Remove duplicate MIB-file

* Add cleanup

* Fix

* Print fix

* Remove extra cleanup

* Revert "Remove duplicate MIB-file"

This reverts commit 4b3cf8127c.

* Remove unneeded MIB-files

* Add check for empty array

* Apply fixes from StyleCI

* Review fixes

* StyleCI

* StyleCI

* Apply fixes from StyleCI

* typo

* Update function calls on pages

* Linting fixes

* Apply fixes from StyleCI

* Discovery module

* Add discovery module

* Apply fixes from StyleCI

* Update example alert rule

Co-authored-by: ottorei <ottorei@users.noreply.github.com>
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2021-06-10 19:42:34 -05:00
Kevin Zink
84c6d215cf Add Epson Projector as new OS (#12928)
* Add Epson Projector as new OS

* Remove poller definitions

* Remove poller definitions

* convert os to epson-projector

* fix delete doc/Alerting/Transports.md
2021-06-10 22:22:19 +02:00
d-k-7
fcac1239fc Improved raritan pdu support (#12937)
* return "Outlet " + index in event outlet description is empty

* update tests to account for blank outlet description

* add hardware, serial, and version detection for Raritan PDUs
2021-06-09 00:38:23 +02:00
PipoCanaja
b55e44a2b4 xDP - ifAlias should be last checked in function find_port_id (#12904)
ifAlias should be last
2021-05-26 00:17:48 +02:00
Rafael Pardim
37ac9dffbe Fix for Gaia Storage duplicated (#12824)
* Fix for Gaia Storage duplicated

We are getting duplicate storage.
Since Checkpoint Gaia is a Linux-based operating system, the file “./includes/discovery/storage/ucd-dsktable.inc.php” has already discovered the storage, so I think the file “./includes/discovery/storage/gaia.inc.php” is not necessary.

* Delete gaia.inc.php

* Add files via upload

* Add files via upload

* Fix for Gaia Storage duplicated
2021-05-06 08:46:11 +02:00
Tony Murray
61c89794e4 Remove debug globals (#12811)
* Remove $debug global
and $vdebug global
makes these variables more accessible and protects from collisions.

* the on boot set sends application as the first parameter, just handle that

* Relocate other debug related functions

* Log debug to stdout

* Wrong output

* remove stupid constants

* Fix lint and style issues
2021-04-29 22:42:18 -05:00
Tony Murray
7510224ead Fix #12793 (#12798) 2021-04-26 20:59:21 -05:00
Tony Murray
e50590edc3 Firebrick sensor rework (#12783)
* WIP

* wrong test data, corrected.

* yaml and more broken stuff

* Add sensor gorupings

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2021-04-26 11:13:27 +02:00
Kevin Zink
39676fb932 Update functions.inc.php (#12793)
Eliminate discovery warning with PHP8

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-04-26 09:33:45 +02:00
Tony Murray
b0178932cf FabOS sensor fixes and add SFP dBm (#12777)
* FabOS module dBm
fixes #11597

* Fix polling and state sensor discovery value

* fix temperature and fanspeed checks.
Also, fanspeed was totally broken.

* port sensors to yaml, found more broken things in the process.
2021-04-23 00:20:13 +02:00
PipoCanaja
07900ccc08 Discovery - Refactor num_oid computing (#12576)
* Test the num_oid generation

* Refactor num_oid discovery

* cnt

* Cache the value to avoid unnecessary snmptranslate

* desc of function

* typo

* Negative caching as well

* Negative caching

* style

* Str::before

* Str::before

* Str::before

* Fix key,  and model Devices

* types

* types

* doc update

* re-run tests

* Use Cache class

* Simplify caching and do it into oidToNumeric

* Simplify caching and do it into oidToNumeric

* style

* Extend to 3 hours

* and not ->cache_time

* force re-run tests

* only one OID for num_oid test

* rerun tests

* typo in MD

* restore

* Exemple

* Exemple

* light change

* test

* test

* test

* back to PR

* phpstan + suggestions from Tony

* fix firebrick num_oid

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-04-22 14:40:45 -05:00
PipoCanaja
827721d43b vrp - Collect sticky mac addresses in fdb-table (#12774)
* collect sticky mac addresses as well

* style
2021-04-21 21:49:40 -05:00
thegreatecheese
d06be3f3f9 Pop returned value from snmpwalk_group for lldp on mikrotik routeros (#12768)
* Pop returned value from snmpwalk_group for lldp on mikrotik routeros

* Account for non-multiarray response then pull out the inner-array

* StyleCl suggested format

* Add comment

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-04-20 18:14:38 +02:00
dethmetaljeff
da19fc51f2 fix outlet sensor indexes overwriting each other when there's more than one infeed (#12763)
* fix outlet sensor indexes overwriting each other when there's more than one infeed

* adding test data for sentry3 switched pdu
2021-04-18 19:51:47 +02:00
martinberg
b17b3069c9 Added Liebert HPM support (#12747)
* Fixed problem where  was still set at next loop

* Added support for more sensors

* Added testdata

* nobulk because otherwise snmp timeouts
2021-04-14 15:39:16 +02:00
Tommy Andre Mikkelsen
8eda073da9 Corrected OID for c3GsmSimStatus (#12724)
* Update cisco.inc.php

Wrong OID used for c3GsmSimStatus

* add test data for iosxe

* Update ios_ir809.json

* Update iosxe_ir1101.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2021-04-08 18:53:07 +02:00
Jellyfrog
c147be4505 Revert "Remove snmp2ipv6 (#12683)" (#12725)
This reverts commit f5f72dd398.
2021-04-08 14:57:17 +02:00
Tony Murray
f5f72dd398 Remove snmp2ipv6 (#12683)
* Remove snmp2ipv6

* Fill in bgpPeerRemoteAddr too update test data
2021-04-07 16:57:57 -05:00
Simon Smith
f0bef36b16 fix adding discrete ipmi sensors (#12709) 2021-04-06 18:44:35 +02:00
O Palivan
cedb0570eb TAIT - Add entity physical support (#12703)
* Add entity discovery out of proprietary mibs
2021-04-04 17:13:11 +02:00
cjsoftuk
43ea55bcf3 Better firebrick support (#12600)
* Add Firebrick MIBs, temperatures and voltages.

* Add missing $sysOid checks.

* Add fan speed for FB6000 series.

* Add sane limits.

* Update Firebrick MIBs.

* Make BGP peers work.

* Better support for Firebricks.

* Add more firebrick support.

* Add BGP Peer States.

* Fix fan speed divisor now that Cliff has fixed the code.

* Fixes for BGP and sensors.

* Add Firebrick IPSec module.

* Add IPSec Tunnels (Base).

* Sort out the IPSec states (although they're still green for no real reason).

* Code style fixes.

* Add missing config definition.

* Fix code style issues.

* Move bgp-peers to its own file.

* Do fan speeds with yaml, not PHP.

* Add Firebrick 6000 snmprec.

* Move Firebrick tests to be FB6000 tests.

* Revert "Move Firebrick tests to be FB6000 tests."

This reverts commit 426c1db980.

* Add tests for specific firebrick variants (2900, 6000) rather than generic.

* Add the firebrick-ipsec-tunnels poller config option.

* Switch to cipsec-tunnels for Firebrick.

* Unnecessary as it's now in cipsec-tunnels.

* Add extra MIB fields for Firebrick BGP MIB.

* Minor fix for AS text.

* Fix the tests.

* Exclude build timestamp from the version.

* Fix a couple of careless errors.

* Code style fix.

* Better version strings.

* Fixes for BGP, and add "Routing Table" support (VRF).

* Add more test data for BGP peers.

* Fix test data for BGP.

* Remove processors for now - as we can't get the data sensibly.

* Fix code style.

* Update firebrick.inc.php

Force tests re-run

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2021-04-04 16:17:49 +02:00
PipoCanaja
90b43b3210 VRP - fix global VRF being NULL and not '' for cbgp, support for NetEngine devices (#12676)
* fix global VRF being NULL and not '' for cbgp

* continued

* clonky testfile

* fix regex
2021-03-30 19:02:00 -05:00
Tony Murray
1c379dcd05 Remove legacy function calls (#12651)
* massive inlines

* fix style and wtf

* remove rrdtool.inc.php include

* fix CommonFunctions namespace issues

* looking for missing class space, fix undefined class issues

* style fixes
2021-03-29 00:25:30 +02:00
Tony Murray
c0e144295b Fix undefined function in vrp peers (#12669)
* fix undefined function in vrp peers

* inverted the check
2021-03-28 21:17:48 +02:00
Tony Murray
646ec4d471 Fix service template discovery (#12662) 2021-03-27 17:39:40 +01:00
Jellyfrog
e00eba327d Re-implement Printer as a class based module (#12605)
* Re-implement Printer as a class based module

* Rename toner table

* wip

* wip

* Rename to printersupplies

* Fixes

* Rename

* wip

* wip
2021-03-27 10:09:14 -05:00
PipoCanaja
7dbb2e42b8 Huawei VRF BGP_Peers update (#12585)
* Mib update

* Fix update of peer + add PeerDescription

* tests

* force tests rerun
2021-03-26 16:36:42 -05:00
PipoCanaja
cac7bfc59c fix VRF name change not updated in DB (#12644) 2021-03-24 17:17:53 +01:00
William Irvine
d06c65a746 Fixed polling and health issues for 9001 and NCS devices, added suppo… (#12640)
* Fixed issues health and polling issues with 9001 and NCS devices, added support for 9901

* Update iosxr.inc.php

* Update iosxr.inc.php

* Update cisco-entity-sensor.inc.php

* remove polling file and adjust to user_func from disco

* fit formatting and remove echo

* fit formatting2

* fit formatting3

* Fix test files with no badif

* remove all exclusions so tests work

* recreate json test for 9010
2021-03-24 07:50:02 -05:00
Jellyfrog
d101834751 Correct sensor_id variable (#12633) 2021-03-22 10:41:20 -05:00