Commit Graph

1482 Commits

Author SHA1 Message Date
ottorei
07afbe8b7a Use null coalescing on Panos.php (#16019) 2024-05-06 19:56:24 -05:00
sonic45132
250c3e32c3 Fix for AD Lookup in our environment (#16001) 2024-05-01 06:56:47 -05:00
Heath Barnhart
11142d349b SNMP Traps - Ciena AAA (#15998)
* Ciena AAA snmp trap handler

* Removed IP from log message

* Added unit test

* Fixed unit test

* Removing reference from handler
2024-05-01 11:25:46 +02:00
Tony Murray
07655c24af Merge duplicate toBytes functions (#15994)
* Merge duplicate toBytes functions
Replace other duplicate code and add tests

* Allow space between similar to formatSI output

* Style fixes

* Match previous behavior in Docker app
2024-04-30 14:40:08 +02:00
Warren Ashcroft
1aa712e189 Fix graph_type variable (svg / png) (#15972) 2024-04-26 08:33:08 -05:00
Tony Murray
9088a34299 Bump version to 24.4.0 2024-04-19 20:52:35 -05:00
Tony Murray
1911dcb11f Skip rrd sources that do not exist (#15959)
* Skip rrd sources that do not exist

* Log message will be too noisy, remove it.

* style fix
2024-04-19 15:54:27 -05:00
Tony Murray
49f8269262 Improved Latency graph (#15940)
* Improved Latency graph
Store loss+jitter info in rrd instead of database
New graph icmp_perf (legacy ping_perf still valid referencing part of the newer data)
Delete device_perf table

* Change loss to an area so it is more visible

* Style fixes

* Cleanups from phpstan & tests

* exit_code fix

* Remove alert usage of device_perf

* Don't use magic __get

* Add test for bulkPing
Add host to previous tests

* style fixes

* Fix issue fping error responses
2024-04-18 09:57:01 -05:00
Joe Clarke
d7737b9889 Pretty up Slack formatting. (#15898)
* Pretty up Slack formatting.

* Normalize spaces by turning every instance of two or more spaces into
  one space.
* Allow for custom URL links even when strip_tags() is in effect by
  transformaing "standard" markdown syntax into Slack link markdown
  after strip_tags() is run.

* Document the changes to the Slack transport.

While here, flesh out the Slack docs to match the configuration options
one currently sees in the transport.

* Use backticks to escape things from markdown rendering.

* We don't need this other escaping now.

* Fix custom link due to line break.

* Fix spelling typo.

---------

Co-authored-by: Joe Clarke <jclarke@cisco.com>
2024-04-16 11:28:10 -05:00
PipoCanaja
e19861c770 bug - Cisco NAC key error (#15934)
* fix https://github.com/librenms/librenms/issues/15933

fixing https://github.com/librenms/librenms/issues/15933

* nullables are now null
2024-04-11 20:59:05 -05:00
PipoCanaja
6b2be73a33 fix disabled radio returning 255, overloading tinyint signed (#15917) 2024-04-02 14:06:25 +02:00
Heath Barnhart
d457f92f22 devices - Ciena RLS 6500 (#15909)
* rls definition
* Adding discovery
* Temp Sensor Discovery
* files for discovery
* Adding and updating MIBS
* Add snmpsim
* Modified yaml for unit test
* phpfmt format
* ci changes
* fixing temp sensor
* fix json
* db schema out of date causing bad snmpsim json
* changed temperature discovery to php
* With updated snmpsim data
* index_string restored, YAML for temperature
* style
* Fixed index_string usage in JUNOS files
* Update YamlDiscovery.php
Allow filtering on "index" in skip_values
* Move DBM to YAML as well
* style
* schema update
* Slot XX Yyyyyy
remove unwanted dot
* matching tests
* schema, round 2
* states in YAML
* put temp sensor back in yaml
* enable default poll and discovery modules
---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-04-01 18:52:03 +02:00
Tony Murray
af2f953c7f Bump version to 24.3.0 2024-04-01 10:18:44 -05:00
Walkablenormal
c855d6c2fe Support for InfluxDB V2 API (#15861)
* Addition of influxdb-client-php to Composer.

* Addtion of InfluxDBv2 support.

* Addition of front-end options.

* Addition of documentation.

* Addition of the acknowledgement of the PHP library used.

* Fixed a unneeded bracket.

* Addition of a basic datastore test.

* StyleCI fixes.

* StyleCI fixes.

* StyleCI fixes.

* Fixed exception class.

* Revert accidental change.

* Fix to composer lock to not update all packages.

* Fix to composer lock to not update all packages, but still include the new Influx lib.

* Another attempt at getting Composer to behave the way I think it should work.

* Fixed merge-conflict in Composer due to #15869.

* Update composer.json

* Update composer.lock

* Update composer.json

* Update composer.lock

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-03-07 12:26:21 -06:00
Jeff Engleman
c83d362e59 supermicro bmc updates (#15862)
* merge templates

* fix merge issues

* fix bad merge

* adding snmprec for x11 variant

* better description for psu and vbat sensors + update overview

* oid name

* adding snmp_bulk: false back in so as to not break older hardware

* make atenpdu more specific so it does not match supermicro-bmc devices

* update x10 variant json

* updated supermicro logo and fixed data json

* updated supermicro logo

* json and snmprec got out of sync somehow
2024-03-04 23:54:46 +01:00
Jellyfrog
4039d88b3b Update dependencies (#15869)
* Update dependencies

* fix new phpstan errors

* Update phpstan.neon
2024-03-03 22:45:09 +01:00
Tony Murray
f362746224 Bump version to 24.2.0 2024-02-27 12:54:10 -06:00
Peter Reinhold
a5fec082e7 Updated SLA poller for Cisco Nexus 9000 (#15855)
* Handled rttMonLatestJitterOperPacketOutOfSequence and rttMonLatestJitterOperPacketMIA not being present on Cisco Nexus9000 routers by defaulting to null value when not found.

Non-existance of OIDs confirmed here: https://cisco.github.io/cisco-mibs/supportlists/nexus9000/Nexus9000MIBSupportList.html

* Added snmp test data

* Removed superfluous comments

* Fixed sla number in test data

* Removed spacing

* Removed ?
2024-02-27 12:46:28 +01:00
Peca Nesovanovic
eb6006248f Rewrite ups-nut discovery to SnmpQuery:: (#15850)
* modernize and move ups-nut to unix

* fix test data (group and invalid runtime)

* add Battery Temperature to test data

* lnms dev:check style
2024-02-26 17:48:40 +01:00
Skylark
851f682155 Transport - Jira transport rewrite (#15561)
* Add custom Field to Jira Payload

Allmost every Jira setup is diffenerent and requires customise information to be added to the API post.

This change will allow you add a custom fields to the '"fields": {   }' using json format.
Examples: are provided in the TransportUI

* applying StyleCI fixes

* Updating Jira transport

* Updating Jira transport

* Updating Jira transport

* styleci fixes

* Renaming variables to align with existing conventions

* Fixing imput checks to make sure values are legit

* style

* Fix minor typo

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
2024-02-22 11:07:49 -06:00
PipoCanaja
36a3e39981 Fix for linkDown/linkUp ifOperStatus (#15835)
* linkDown

* LinkUp

* linkUp

* revert linkUp
2024-02-22 03:06:51 +01:00
Nick Hilliard
800053c7f7 Add support for Cadant E6000 (#15813) 2024-02-09 22:52:32 +01:00
Personwho
df54ff072c Remove dumpRawSql() function in AlertUtil.php (#15803)
It caused fail to execute alert/transports/{transport}/test
2024-02-05 14:13:27 +01:00
Ville Hukkamäki
e6a0006ed0 Add build 22631 as Windows 11 23H2. (#15800) 2024-02-05 00:22:06 +01:00
Joe Clarke
31e8557930 transport - enforcing Webex max message length. (#15789)
* Add support for Webex max message length.

Webex limits messages to just over 7 KB.  Some alerts might be longer
than this.  So truncate the message with ellipses.

While here switch to using the new API URL.

* Use spaces.

Formatting got messed up on the transfer from test to dev.

* Do the truncation after the message is massaged.

This may yield a few more allowed characters.

---------

Co-authored-by: Joe Clarke <jclarke@cisco.com>
2024-02-04 17:20:36 +01:00
Ville Hukkamäki
391a918e2e refactor - Use ->table(2) rather than ::pivotTable function. (#15796) 2024-02-03 22:32:07 +01:00
Ville Hukkamäki
0611f81b14 device - Add Procurve NAC support (#15794)
* Update to new HP-DOT1X-EXTENSIONS-MIB

* Add NAC support to Procurve OS

* Fix code style issues.

* Fix more code style issues.

* Fix code style issues. For real this time.

* Update HP-DOT1X-EXTENSIONS-MIB dependencies.

* use ::table(2) rather than reinventing the wheel.

* Fix the code style issues.
2024-02-03 20:42:12 +01:00
Tozz
7228dbfa23 Support for new Lancom devices (#15779)
* Lancom SNMPrec

* Lancom test data

* Lancom MIBS

* Lancom discovery

* Lancom LX/SX support

* Lancom

* Style CI

* Delete tests/snmpsim/lcossx_gs3510xp.snmprec

This device returns all possible vlans as interfaces, so we get roughly 4k interfaces. This makes the test file too big (>25M). Deleting this device as test data

* Update Lcossx.php

* New Lancom logo

* Remove height/width attribute

* SVG

* Add files via upload
2024-01-30 15:03:08 +01:00
Ville Hukkamäki
133cf294b4 Add NAC support for Powerconnect (#15778)
* Add NAC support for Powerconnect

* Fix code style issues

* Fix more code style issues

* Rename mibs
2024-01-27 19:10:12 +01:00
PipoCanaja
a7a6e67e87 NAC - Improve search in WebUI - Keep Historical data (#15629)
* search improvement for PortNac

* rename func

* style

* DB migration for timestamps

* style

* rules

* fix manually db_schema

* remove vlan only search for now

* add a bool column to ident historical nac entries

* add columns to the table

* queryByOui renamed everywhere

* age value instead of delete

* style

* style

* use Illuminate\Support\Facades\DB;

* tests fix

* module_tables.yaml

* dump model instead of tests/module_tables.yaml

* tests

* testVrp

* daily

* config

* display historical NAC entries in global view

* same for NAC device page

* nac tab on device/port view

* and display the tab link if necessary

* filter by port as well

* historical data in port tab

* formatters
2024-01-24 09:15:40 +01:00
Jellyfrog
b0bd0765ad Prevent ansi colors in key:generate output (#15773)
* Prevent ansi colors in key:generate output

* Apply fixes from StyleCI
2024-01-23 12:35:39 +01:00
PipoCanaja
f115de989e OSPF instances and missing mandatory fields fix attempt (#15712)
* dirty fix

* better fix

* more column checks

* double check not necessary

* get out of both loops
2024-01-15 22:45:59 +00:00
kakohegyi
4456640e51 Zyxel Wireless Controller OS ( Zyxel NXC series ) (#15694)
* zyxelwlc

* Zyxel Wireless Controller OS

* Zyxel Wireless Controller OS

* Update Zyxelwlc.php

* test data

* sensor count graph

* sensor count graph

* sensor count graph

* sensor count graph

* fix indent

* trailing CR

* Trailing CR

* fix count def

* Delete includes/html/graphs/device/sensor-count-zyxelwlc-sessions.inc.php

Not necessary

* Delete includes/html/pages/device/graphs/sensor-count-zyxelwlc-sessions.inc.php

Not necessary

* fix tests

* fix tests for real

* session graph in core section

* session graph in core section

* session graph in core section

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-01-14 14:02:28 +01:00
Gil Obradors
5856e2c6cd Rename JiraServiceManagement.php to Jiraservicemanagement.php (#15717)
* Rename JiraServiceManagement.php to Jiraservicemanagement.php

#15716 Filenames must not be PascalCase, only the first letter can be uppercase.

* Update Jiraservicemanagement.php

Following class name conventions

* Update Jiraservicemanagement.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-01-09 16:05:29 +01:00
Peter Reinhold
8fb94c07c4 Handle icmpjitter SLA parsing for iosxe (#15707)
* Added MIB file CISCO-RTTMON-ICMP-MIB to Cisco collection
Query rttMonLatestIcmpJitterOperTable when polling SLAs
Extended icmpJitter parsing to allow retrieval of jitter related data from multiple locations in MIB tree

Fixes #15658

* Appended snmprec data to testdata

* Update iosxe_c9300.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-01-08 18:42:00 +01:00
Hamza Khan
166026d251 Add JiraServiceManagement Transport (#15593) 2024-01-08 16:49:14 +01:00
Neil Lathwood
421f2c7d38 Bump version to 24.1.0 2024-01-07 15:49:52 +00:00
Jellyfrog
071ca9bc2a Apply fixes from StyleCI (#15698)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-01-04 22:39:12 -06:00
Tony Murray
6bea8cffa6 New utility Number::constrainInteger() (#15663)
* New utility Number::constrainInteger()
Fixes a bug with Number::unsignedAsSigned() and implements signed support as well.

* cleanup

* Apply fixes from StyleCI

* Remove default cases

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-12-20 09:21:40 -06:00
craig-nokia
c97fd4e6f5 bug - "null" checks for SAR 7705 release 8.X (#15657)
Added null for SAR 7705 release 8.X
2023-12-18 16:40:06 +01:00
PipoCanaja
b12ee04bda bug - timos MPLS - more poller fixes (#15624)
* fix 1, ErrorException: Undefined array key sdpFarEndInetAddress in /opt/librenms/LibreNMS/OS/Timos.php:584

* fix2: don't try mplsSdpBinds polling if prerequisites not met

* fix 3: ErrorException: Attempt to read property lsp_path_id on null in /opt/librenms/LibreNMS/OS/Timos.php:790

* style

* fix phpstan

* schema_update

* schema

* migration_style

* migration drops and recreate

* migration drops and recreate

* migration drops and recreate

* style
2023-12-17 20:15:46 -06:00
Brian Egge
470e2ae34f Update Pushover.php (#15652)
Entities are html encoded so this will cause them to be displayed correctly in pushover alerts

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-17 00:20:42 +01:00
PipoCanaja
648a5ea7d3 bug - XDSL adslAtucCurrOutputPwr exception (Cisco CSCvj53634) (#15614)
* Cisco CSCvj53634

tests

change RRD minimas to accept negative dbm output power

unnecessary tests

* unsignedAsSigned function

* use new function Number::unsignedAsSigned

* negative power for Vdsl as well

* style

* style

* Add types

* simplify and exception if over max value

* Add tests

* Style fixes

* Tell phpstan to shut up

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-12-15 10:06:52 -06:00
Adam James
66cc34dbd2 Add support for Fortinet FortiAPs (#15641) 2023-12-14 11:29:02 -06:00
PipoCanaja
c88fba0b64 bug - ADSL ifIndex to port error not handled (#15617)
* fix

* add an error message
2023-12-05 07:11:46 -06:00
PipoCanaja
b0a355e8ba ?? null (#15613) 2023-12-04 03:54:19 +01:00
Justin Lentz
d61c71bcbe Change default graph image to SVG (#15586)
* Update config_definitions.json

* Update Rrd.php
2023-11-27 18:43:15 -06:00
Tony Murray
54ff1d7e63 Bump version to 23.11.0 2023-11-16 20:57:41 -06:00
Tony Murray
2755676131 Fallback to default alert template and give reason (#15583)
* Fallback template, give reason
Print the error and notice of the fallback template being used.

* more strict typing
2023-11-16 15:18:12 +00:00
eskyuu
cc7e02cbcd Device links formatting changes (#15580)
Make the images inline so they appear side by side
Put newlines between the major device information sections (name, model/OS, location)
2023-11-16 08:54:29 -06:00