* Fix inventory page hostname and default behaviour on generate_device_link
* force test re-run
* space
* simplify
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* Change select order from id to name
* added example icmp/snmp down rules given by @kkrumm1
* Renovated Alert Rules
* Defaulted sort by name
* Moved top buttons and results selector outside of table and aligned them with pull-left and pull-right
* Collapsed '#' (ID) into 'Type' and added titles for the icons
* Added Devices and Transports columns for each rule
* Moved Extra column next to transports
* Added icons for Enabled when a user does not have global admin
* Changed row_# variable to rule_id_#
* Some 'else' cleanup
* Added various title tags for more information when hovering
* Moved pagination outside of table and align it with pull-left and added a bootgrid style summary pulled-right
* Added table & th tags for bootgrid (but didn't turn it on)
* code climate, round 1
* code climate, round 2
* add hrefs for device & device group edit
* added trailing slash for device-groups/../edit/
* prevent #name conflict with transport modal
* add hrefs for transport & transport group edit
* use popover consistently
* code climate, round 3
* removed unused variables
* code climate, round 4
* popover variables
* reload after successful delete
* more informative feedback
* use toastr, not #message, & don't reload
* added license header & fail faster if not admin
* use (more informative) ajax error message
* delete confirmation with alert name in the modal
* print each device per line
* add href for all devices
* refresh status & enabled data-content when/if a rule is turned on/off
* use DRY style per @SourceDoctor (& my) preference); codeclimate meh
* point devices popover to the right
* Migrate devices.inserted to allow null values and set existng row values to null
* Hide Device Added for devices that existed before https://github.com/librenms/librenms/pull/11104
* Don't display any date that stats with a zero
* make schema match migration
* Adding support for Cisco SB SX550X-24F switch
This pull request adds support for Cisco Small Business SX550X-24F switch by adding sysObjectID .1.3.6.1.4.1.9.6.1.1001 in the ciscosb discovery module.
* Added ciscosb_sx550x-24f.snmprec file
* Added ciscosb_sx550x-24f.json
* Updated ciscosb_sx550x-24f.json
* update ciscosb_sx550x-24f.snmprec
* Collected new ciscosb_sx550x-24f.snmprec file
* updated test data
* Add inserted column to devices table
* Added schema for devices.inserted
* Show when a device was added and last discovered
* Added collection rule for "Device added within the last 60 minutes"
* Added rittal-cmc (LCP Plus)
skip_values opperand 'not_in_array' returns an error in pre-commit but in principal it's running. Can someone help?
1) LibreNMS\Tests\YamlTest::testDiscoveryDefinitionSchema
rittal-cmc.yaml does not validate. Violations:
[modules.sensors.fanspeed.data[0].skip_values[0].value] Array value found, but an integer or a string is required
[modules.sensors.temperature.data[0].skip_values[0].value] Array value found, but an integer or a string is required
[modules.sensors.temperature.data[1].skip_values[0].value] Array value found, but an integer or a string is required
[modules.sensors.temperature.data[2].skip_values[0].value] Array value found, but an integer or a string is required
[modules.sensors.temperature.data[3].skip_values[0].value] Array value found, but an integer or a string is required
* fix Scrutinizer Inspection
* fix codeclimate
* fix typo
* Update discovery_schema.json
To allow arrays in comparisons
* Control structures
* fix the pre-fix issues
* Typo in copy/paste
* Update rittal-cmc.json
* Unit1,2,3,4 and new snmprec, json have not changed
* Update rittal-cmc.json
Correct JSON data
* typo copy paste
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* Asterisk app: add IAX2 peer graphs
* It's an entirely new graph and will not break existing graphs.
* The asterisk extend script must be updated to provide the appropriate poller data.
* The PR for librenms-agent/snmp/asterisk is here: https://github.com/librenms/librenms-agent/pull/274
* code climate, round 1
* clarified unit text
* code climate, round 2
* changes needed to properly generate test data
* linux_asterisk-v1 test data
* Added WUT 57606,57613,57720
* Added os wut-*
* fixed MIB Names and try to generalize wut
* more general sysObjectID mapping, and mib directory
* Delete WUT-57606-MIB
* Delete WUT-57613-MIB
* Delete WUT-57720-MIB
* Rename wut-57613.snmprec to wut_57613.snmprec
* Rename wut-57720.snmprec to wut_57720.snmprec
* Rename wut-57606.snmprec to wut_57606.snmprec
* Delete wut-57606.yaml
* Delete wut-57720.yaml
* Delete wut-57613.yaml
* Delete wut-57606.yaml
* Delete wut-57720.yaml
* Delete wut-57613.yaml
* Update wut.yaml
* Try to correct the Temperature part
This should work for temperature, according to MIB. Pressure and Humidity are not described in this mibfile, so we cannot poll them.
* change wut.yaml
* Add and fix wut_57720
* after ./scripts/save-test-data.php ?
* Add test data
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* Migrate ironware sensor discovery from php to yaml.
* More sensors, add grouping.
* dynamic_discovery_get_value() becomes getValueFromData()
* Target a specific index with skip_values.
* Improve Brocade BGP session discovery/polling
This commit allows for the correct discovery of BGP sessions
with 32-bit ASNs, IPv6 neighbors using the BGP4V2-MIB which is
based on draft-ietf-idr-bgp4-mibv2-11 and also polls for IPv4
unicast received routes through the FOUNDRY-SN-BGP4-GROUP-MIB.
Copied most of the code from PR#8877 by @Mikeburke14, cleaned
up the code a little bit to match the normal LibreNMS style,
and fixed bgpPeers_cbgp discovery as well as polling for the
ipv4.unicast neighbors.
Note that older Brocade IronWare firmware versions are known
to have multiple defects relating to the BGP4V2-MIB which
might result in certain missing non-established neighbors.
Related vendor defect numbers:
- DEFECT000633962
-- Symptom: The OID bgp4V2PeerAdminStatus does not return the
correct value
-- Reported: NI 05.7.00
-- Resolved: NI 05.8.00g
- DEFECT000583319
-- Symptom: SNMP polling on bgp4V2PeerTable (OID brcdIp.3.5.1.1.2)
does not display all the BGP entries
-- Reported: NI 05.6.00
-- Resolved: NI 05.8.00e
- DEFECT000550309
-- Symptom: SNMP polling on bgp4V2PeerTable (OID brcdIp.3.5.1.1.2)
does not display the full information
-- Reported: NI 05.7.00
-- Resolved: NI 05.8.00c
* Add ironware CER & ICX platform test data.
* Re-add ironware.json compatible with current master branch.
* Fix Air Fiber port stats
Define OS port polling includes in a standard way.
Move Air Fiber code to os port polling include.
* Update snmp data
* fix accidental change
* Some formatting fixes
* should be null
* BUG: From a device page, click Alerts and attempt to ACK or add a Note. Nothing happens because the modals are not on the page.
* This patch corrects pages/device/alert.inc.php to include both modal/alert_notes.inc.php and modal/alert_ack.inc.php
* Added definition and sensors for SIAE Alfoplus80HD
* updated the units for the wireless rate sensor
* Added test data
* regenerated test data as requested by PipoCanaja
* Don't overwrite real port ids with zeros in the FDB
* Remove space to make codeclimate happy
* Provide links to device config view for oxidized config search results
* Use a bootgrid for Oxidized nodes so we can sort, search etc.
* Add a space for codeclimate
* Fixed device SNMP edit form (and better feedback)
* snmp.inc.php: Fix SNMP Edit form (better feedback)
* The feedback for Max Repeaters and Max OIDs is much better. The constant false errors on save have been corrected. The are no longer applicable and muted when SNMP is turned off. Their feedback now clearly shows the user what has been done.
* Rename & relabel $no_checks as $force_save (Force Save) because that's simpler and more clearly defines what the code is doing when you turn it on.
* Reorder the Force Save checkbox to be right above the Save button so it's even more clear what it does. Force Save and Save are the only elements on the form that do *not* have a database setting. They're ephemeral and now grouped as such.
* Embedded comments about the use of === false as tests for setAttrib() and forgetAttrib()
* snmp.inc.php: code climate updates, round 1
* remove blank lines
* refactor duplicate code blocks
* remove join on string
* move print_messages to the bottom of the form
* snmp.inc.php: code climate, round 2
* avoid deeply nested control flow statements (8)
* snmp.inc.php: when to $force_save and $device_isssnmable
* move $force_save outside of if ($snmp_enabled) so it works properly
when snmp is disabled.
* only check isSNMPable() if snmp is enabled
* snmp.inc.php: move $device_snmp_details
* $device_snmp_details are only needed for isSNMPable(), so only call
them within the same contingency
* snmp.inc.php: cleanup & hardening
* add SNMP Settings header (to better mimic Device Settings, etc)
* use Toastr for feedback, rather than print_message & print_error
* after editing, always unset($_POST) and the other variables used for editing
* unless the save is forced, if !$device_issnpable then don't save *anything* in the database and revert *all* previous form settings (some already were being reverted & some weren't)
* more variables were ordered alphabetically, unused variables were and removed
* for snmpver, don't use .toggle(); use .hide() & .show() so the form reverts properly when it fails
* snmp.inc.php: clarify placeholder for max repeaters
* snmp.inc.php: code climate, round 3
* correct blank line found at the end of control structure (2)
* correct space before opening parenthesis of a function call prohibited (3)
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
* Update nios.yaml
I tried to pull them all in using {{ index }}, but it didn't actually work.....
This adds the DHCP, DNS and NTP service statuses.
* Dynamic service discovery
* typo
* Create nios_status.snmprec
* Create nios_status.json
* Array
* Typo, more
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* Fix Siklu Voltage
* Update tests
* Another test fix attempt
* Decimals..
* Ok, enough.
* Restore currently used index value and correctly push num_oid
* Update siklu.json
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* fix SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'port_id' cannot be null
* If $entry['port_id'] truly is null (on insert) then Illuminate throws a fatal error and all subsequent processing stops.
* Cisco ISO (and others) may have null ids. We still want them inserted as new
* strings work with DB::table->insert().
Avoid writing "0" as port id when the data came back incomplete from the snmp poll, and when the existing data in the DB already contains a port. Keep the existing port id instead.
