Commit Graph

154 Commits

Author SHA1 Message Date
SourceDoctor
213a11eb98 Merge remote-tracking branch 'upstream/master' into app_dhcp_enhancement 2020-06-09 20:37:30 +02:00
dupondje
4611b19ae5 Fix Rancid GIT (#11795) 2020-06-09 09:01:44 -05:00
Tony Murray
28ee0f1823 fix typo (#11798) 2020-06-09 08:05:04 -05:00
SourceDoctor
1093315700 Merge branch 'master' into app_dhcp_enhancement 2020-06-08 20:51:41 +02:00
cjwbath
aa51e46350 Don't call clean() on the inputs to the SNMP settings form (#11709)
* Don't call clean() on the inputs to the SNMP settings form, it'll call
strip_tags() and break values with angle brackets in.

* Call htmlspecialchars when outputting DB values to HTML instead

* Escape other stuff that should have been validated elsewhere, just in case
2020-06-08 08:16:40 -05:00
SourceDoctor
4977394a1e Fixing API Creation Error Message (#11745) 2020-05-30 18:26:02 -05:00
PelliX
5f3b82de6f Added discovery and graphing for JunOS (SRX) RPM probes (#11187)
* Added discovery and graphing for JunOS (SRX) RPM probes

* Proposed changes for a percent based sensor type

* Fixed missing MIB declaration in JunOS YAML discovery file

* Updated Health-information.md to reflect the new percentage value type

* Added separate test data for junos_rpm type

* Update sensors.php

* Update sensors.php

* Update functions.inc.php

* test re-run

* Update junos_rpm.json

* percentage -> loss

* add ifSpeed prev test data

* mis-merge

* update sensors

* and bgp...

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-30 18:24:43 -05:00
SourceDoctor
cbe572f959 Application DHCP Upgrade 2020-05-22 23:02:19 +02:00
SourceDoctor
5927983c50 Maintenance Mode via Device Settings (#11649) 2020-05-22 15:14:03 +02:00
SourceDoctor
b41d262537 Application State Icons (#11630) 2020-05-19 19:21:02 -05:00
Tony Murray
d5a52ca4eb Fix various issues with loading os definitions (#11640)
* Ping only device doesn't display
if os was set to something, ping os wasn't loaded and we try to get overview graphs from it.

* Fix snmp_disable device page load error
When other os is set.

* Revamp os setting loading
the only safe way to access is Config::getOsSetting()

* Remove getOsSetting fallback behavior
Most instances don't use it and it can have unexpected results Config::getOsSetting('blah', 'group') == 'librenms'

* refactor and remove unneeded load_os/loadOs calls now since getOsSetting automatically loads it.

* restore unix overview graphs, they are different
small cleanups

* fix
2020-05-19 14:35:32 -05:00
SourceDoctor
4edff1e88a Application - Redis (#11612)
* Application - Redis

* Travis fix
2020-05-15 22:05:40 +02:00
SourceDoctor
17698a36f0 Natural Sort Applications by Display Name (#11577)
* Natural Sort Applications by Display Name

* some optimizations

* .
2020-05-15 18:32:09 +02:00
SourceDoctor
e305a39d31 Sort Health table alphabetic (#11586) 2020-05-12 15:51:30 -05:00
Lars Elgtvedt Susaas
aca95b5554 bugfix: addhost (web) snmp v3 not used first (#11536)
* Update addhost.inc.php

bugfix: push snmp v3 user settings to the front of the config array and not the back.

To reproduce the bug:
Force add new snmp v3 device.
The v3 settings added to the database will not be the same as entered in the webpage

* Update addhost.inc.php

Minor change in order to trigger travis build
2020-05-12 15:49:39 -05:00
louis-oui
c9155bf5ea disable auto-refresh for notifications and alert history (#11589) 2020-05-11 23:07:14 +02:00
SourceDoctor
38abff264a Show Hardware Details on Network Adapters in Inventory (#11545) 2020-05-11 20:28:42 +02:00
SourceDoctor
8d3f39743a Application DisplayName in Overview Hover (#11576) 2020-05-09 20:34:14 +02:00
ospfbgp
05f3314061 Fix display of device modules (#11543) 2020-05-06 09:09:14 -05:00
Tony Murray
070cbc8d8e Fix apps overview link (#11535)
* Fix apps overview link
(easy way)

* more modern url
2020-05-03 12:57:51 +02:00
Arjit Chaudhary
7f8b660c05 Update Table UI (#11529)
* Update Cisco Meraki logo

* Update table UI

* Revert "Merge branch 'master' of https://github.com/arjitc/librenms"

This reverts commit 05e52d51c3, reversing
changes made to a48207d78f.

* Update sensors-common.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-02 17:52:17 -05:00
Vitali Kari
1108f7d530 MPLS updates and bugfixing (#11468)
* MPLS updates and bugfixing

* Tests

* tests

* code climate, tests

* tests

* tests

* remove nokiaIfName(), fetch ifName from the database instead

* restore from messed rebase

* tests

* btw, fix travis about the missing docs

* tests

* tests

* clean the messed up test data an generate new for timos

* rebase
2020-05-01 23:05:51 -05:00
Arjit Chaudhary
08a8f082ce sync bootstrapSwitch style with the other tabs (offColor danger) (#11513) 2020-05-01 14:13:31 +02:00
Arjit Chaudhary
e23329aa30 Limit port, seconds, retries, max repeats and max OIDs to numeric type (#11512) 2020-05-01 01:54:18 +02:00
Arjit Chaudhary
5eef90b9ad put all the stats into the optionbar (#11501)
* put all the stats into the optionbar

* display output in 1 line
2020-05-01 01:30:33 +02:00
Tony Murray
055abcf443 Device page dropdown hero button, Performance -> Latency (#11328)
* Throw some shit together, rough outline.

* Reorganize tabs, use tab controllers

* Implement performance (into the latency tab)

* Update resources/views/device/header.blade.php

Co-Authored-By: Jellyfrog <Jellyfrog@users.noreply.github.com>

* Add more tabs

* All controllers created

* Implement routes

* Implement smokeping

* routing and auth

* fix smokeping check

* Implement device dropdown menu

* Update deviceUrl to new style

* Use Gates

* Fix style

* use more appropriate gates

* add show-config gate
remove Laravel helper

* Only show vlan tab if VLANs exist for the device :D

* Fix rancid file check will return false

* revert over-zealous file name changes

* don't need to request the location parameter, just cast to string to avoid bugs when not found

* Move latency tab (ping/performance) to the position of performance instead of ping.

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2020-04-29 07:25:13 -05:00
Mathieu Poussin
fc391090e1 BGP Polling: Add error code management (#11424)
* BGP Polling: Add error code polling

* Rework describe_bgp_error_code and fix bgp error fields migration

* Add real test data for IOS-XR and Arista EOS
2020-04-24 22:47:20 -05:00
Tony Murray
e4b49f59f6 Delete ports via eloquent event (#11354)
* Delete ports via eloquent event
Chunk delete during purge all operations so we don't use too much memory.

* protect against missing device

* fix whitespace

* fetch less from the database when deleting a device's ports
fix output
2020-04-16 09:19:58 -05:00
Tom van Leeuwen
4a6a0af489 honoring config option force_ip_to_sysname in bill creation and editing (#10382)
* honoring config option `force_ip_to_sysname` in bill creation and editing

* refactored variable name to match it in edit.inc.php

* forgot one variable

* and one more :S

* Update new_bill.inc.php

* Update edit.inc.php

* Update new_bill.inc.php

* Update edit.inc.php

* Update edit.inc.php

* Update edit.inc.php

Co-authored-by: Neil Lathwood <gh+n@laf.io>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-04-11 19:10:45 -05:00
Tony Murray
76e58b6cb2 Clarify that you can use IP or hostname to add device (#11393)
Remove overwrite IP when adding devices, it is very rare this should be used and the setting is misleading.
2020-04-09 23:39:37 +02:00
Tony Murray
217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
Tony Murray
7d2a1ae799 Display custom types as in the config file (with ucwords) (#11367)
* Display custom types as in the config file (with ucwords)

* filter same line
2020-04-02 23:38:38 +02:00
Jellyfrog
daf451cef7 Convert overview page to laravel (#10757)
* Convert overview page to laravel

* Convert more pages

* More fixes
2020-03-31 23:03:02 -05:00
SourceDoctor
4e349efd11 Rewrite Poller Management to Blade/Eloquent (#11277)
* Rewrite Poller Management to Blade/Eloquent

* remove further no more needed file

* Code Climate

* Code Climate

* hardcode tabs

* change URL style

* change prefix from poller-groups to poller

* .

* parameter fix

* Refactor to use more direct routing.
remove switch statement.

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-13 20:58:37 +01:00
crcro
2ee2862357 app: mailcow-dockerized postfix stats (#11058)
* app-mailcow-dockerized-postfix

* fix docs

* updated niceCase

* test-data

* snmprec upload

* new test data

* new test data
2020-03-13 10:16:03 +01:00
cjwbath
c6f06ceb92 Show the plugin's name in the title rather than just "Plugin" (#11258) 2020-03-07 11:21:17 +01:00
SourceDoctor
2cfc7c6f14 Extended unbound monitoring (#11255) 2020-03-05 11:35:23 +01:00
Tony Murray
70fb8ef62b Remove csrf token from url when updating url in device page (#11180)
* Remove csrf token from url when updating

* oneline
2020-02-24 08:19:07 +00:00
Joseph Tingiris
481363194d Add Size column to edit Storage Settings table (#11164)
* add storage_size

* capitalize Settings to match Device Settings, SNMP Settings, etc.
2020-02-18 22:13:41 +01:00
SourceDoctor
3838d8e41f equalize default Poller Group Naming (#11156) 2020-02-18 13:26:12 +01:00
SourceDoctor
53dc564ef5 Puppet Agent Monitoring (#10827)
* puppet agent monitoring

* change position of last run graph

* device overview panel

* updating documentation

* mouseover for Overview Dashboard

* adding blank line for code climate
2020-02-12 08:26:02 +01:00
SourceDoctor
ffddfd0901 mark assigned default poller group (#11112) 2020-02-09 15:44:08 +01:00
Joseph Tingiris
02bc15c206 Asterisk app: add IAX2 peer graphs (#11078)
* Asterisk app: add IAX2 peer graphs

* It's an entirely new graph and will not break existing graphs.
* The asterisk extend script must be updated to provide the appropriate poller data.
* The PR for librenms-agent/snmp/asterisk is here: https://github.com/librenms/librenms-agent/pull/274

* code climate, round 1

* clarified unit text

* code climate, round 2

* changes needed to properly generate test data

* linux_asterisk-v1 test data
2020-02-03 18:47:27 +01:00
SourceDoctor
c07678d55f Mark Devices in Maintenance Mode (#11092)
* Mark Devices in Maintenance Mode

* code climate fix
2020-02-02 08:33:01 -06:00
SourceDoctor
7950893cd1 Alternate Poller IP instead of Hostname (#10981)
* optional alternative poller ip

* add missing schema update

* .

* enhance API Call 'add_device' with overwrite_ip key

* .

* .

* updating docs
2020-01-30 06:20:30 -06:00
Joseph Tingiris
3f53eed245 alert.inc.php: Fix missing ACK & Notes modals (#11076)
* BUG: From a device page, click Alerts and attempt to ACK or add a Note.  Nothing happens because the modals are not on the page.
* This patch corrects pages/device/alert.inc.php to include both modal/alert_notes.inc.php and modal/alert_ack.inc.php
2020-01-27 20:02:28 -06:00
SourceDoctor
e33518ada1 Change Poller Group on Device Settings (#11071)
* change Poller Group on Device

* code climate fix
2020-01-27 06:19:14 -06:00
SourceDoctor
27be237791 Order Poller Group by Name (#11072)
* order poller group by name

* sql query nicement
2020-01-27 06:18:31 -06:00
SourceDoctor
2bd19c655b enhance poller group management (#11073) 2020-01-27 06:17:52 -06:00
cjwbath
198e29c831 Oxidized GUI tweaks (#11066)
* Don't overwrite real port ids with zeros in the FDB

* Remove space to make codeclimate happy

* Provide links to device config view for oxidized config search results

* Use a bootgrid for Oxidized nodes so we can sort, search etc.

* Add a space for codeclimate
2020-01-27 05:31:43 -06:00