Commit Graph

877 Commits

Author SHA1 Message Date
Zane C. Bowers-Hadley
f99f92d911 fix display of graphs on the multi-server app page for Mojo CAPE Submit (#16094)
* rename the mojo cape submit graphs, changing - to _

* update graph names on the app page for it
2024-06-06 19:53:23 -05:00
Tony Murray
51c670f109 Fix typo in device edit page. (#16096) 2024-06-06 08:33:50 -05:00
Tony Murray
fa16c025ba Fix popup toast messages (Remove Flasher) (#16090)
* Remove flasher
Just use a bit of custom code to interface with toastr js
This is able to retain our custom theme and work properly

* Fix style issues

* Missed reference rename

* Remove test code :)

* Fix a missed rename

* Fix one more missed reference

* Fix typo
2024-06-05 08:07:42 -05:00
Zane C. Bowers-Hadley
fb7bc5dd5a two minor fixes for sagan (#16082)
* two minor fixes for sagan

* more tweaks

* change how instance handling is done
2024-06-04 11:08:20 +02:00
Zane C. Bowers-Hadley
d0ca744c8a handle $app_data['disks'] not being set for SMART app page display (#16087)
* handle $app_data['disks'] not being set for SMART app page display

* style fix
2024-06-04 11:05:30 +02:00
Tony Murray
54ec98cafb API: return error when no ports found (#16043)
When looking up device ports (get_port_graphs), return an error when no ports are found.

fixes #15964
2024-05-21 22:05:44 -05:00
Tony Murray
65d13a742e Fix icmp ping y-axis over 1000ms (#16039) 2024-05-18 18:32:14 -05:00
Tony Murray
0c35b7dc4f Device location map zoom out when location N/A (#16034) 2024-05-14 10:11:52 -05:00
Sarabveer Singh
b14a86ecf6 Fix systemd graphs using wrong rrd filename variable (#15988) 2024-04-27 13:47:41 +02:00
Tony Murray
1dc62454fc Show custom maps in device overview (#15985)
* Show custom maps in device overview

* remove extra line return

* Sort by name
2024-04-26 15:10:24 -05:00
Warren Ashcroft
1aa712e189 Fix graph_type variable (svg / png) (#15972) 2024-04-26 08:33:08 -05:00
Joe Clarke
018597e7bb Add support for a maintenance boolean in API results. (#15904)
* Add support for a maintenance boolean in API results.

If a device is under maintenance, it would be nice to see that from the
API. This can help drive other automation workflows where LibreNMS forms
a cornerstone in the management source of truth.

* Revert changes made by VSCode formatting.

* Revert two more formatting changes.

* Create a new API endpoint for GETing maintenance status.

This uses the same endpoint name as for setting a device to maintenance
but with a GET verb.

---------

Co-authored-by: Joe Clarke <jclarke@cisco.com>
2024-04-19 19:52:22 -05:00
Tony Murray
36d14480f9 Fix Graph date selector (#15956)
It did not handle strings like now and -2d
2024-04-19 10:22:06 -05:00
Tony Murray
49f8269262 Improved Latency graph (#15940)
* Improved Latency graph
Store loss+jitter info in rrd instead of database
New graph icmp_perf (legacy ping_perf still valid referencing part of the newer data)
Delete device_perf table

* Change loss to an area so it is more visible

* Style fixes

* Cleanups from phpstan & tests

* exit_code fix

* Remove alert usage of device_perf

* Don't use magic __get

* Add test for bulkPing
Add host to previous tests

* style fixes

* Fix issue fping error responses
2024-04-18 09:57:01 -05:00
Tarek
4cce4f082e Fix typ (#15952)
Fixed a typo `Backlog Lenght` -> `Backlog Length`
2024-04-18 14:15:31 +02:00
Tony Murray
d29201fce1 Fix SQL injection issues in packages search (#15950)
https://github.com/librenms/librenms/security/advisories/GHSA-cwx6-cx7x-4q34
2024-04-17 02:32:35 +02:00
Jellyfrog
83fe4b10c4 Improve order validation in list_devices function to prevent SQL injection (#15885) 2024-04-16 10:38:17 -05:00
Justin Lentz
4ddbf8baad Fix Vrf Table (#15912)
* Update vrf.inc.php

* Update vrf.inc.php
2024-03-28 22:50:12 +01:00
Justin Lentz
c3a95cdda9 Revert "Fixed interfaces descriptions for multiport_bits_separate graphs type…" (#15894)
This reverts commit 2928b51c3d.
2024-03-13 00:06:26 +01:00
dmbokhan
2928b51c3d Fixed interfaces descriptions for multiport_bits_separate graphs type (#15893) 2024-03-11 16:52:29 -05:00
bnerickson
d7c31e0ae3 Wireguard application graph cleanup and new wireguard interface/global metrics. (#15847) 2024-03-07 12:27:26 -06:00
bnerickson
0998592e1f Systemd Application Code Cleanup and new Systemd Unit State Metrics. (#15848) 2024-03-04 23:58:28 +01:00
Justin Lentz
80e0ee44f5 Update Port Real Time Graph error (#15846)
* Update graph-realtime.php

Fix Typo

* Update realtime.inc.php
2024-02-22 03:04:32 +01:00
Zane C. Bowers-Hadley
56471e63d7 add dhcp-stats tests and update for v3 of the extend (#15378)
* update dhcp polling for version 3 of the extend

* add initial lease display for dhcp

* note where I copied it from

* document the new ISC DHCP stuff

* add in displaying pool and subnet info

* finalize the docs the new dhcpd stuff

* rework the dhcp page to display more information in a cleaner manner

* now display port and device info if known for a lease

* minor comment cleanup for the dhcp page

* add tests

* do not display the optionbar if the extend is not 3+

* update dhcp-stats doc for -w

* poke includes/html/functions.inc.php with php-cs-fixer

* poke includes/html/pages/device/apps/dhcp-stats.inc.php with php-cs-fixer

* derp... add the tests and not the snmprec twice

* strftime -> date

* fix naming of the linux dhcp-stats test data files

* minor tweaks to the rest results

* test fix

* more test cleanup

* minor test fix

* set the data value for v3

* minor test tweak

* add sortable_table blade template

* no longer need render_table

* formatting fix

* add regexp to make sure the mac is sane

* style fix

* formatting cleanup

* some more formatting fixes
2024-02-21 21:33:17 +01:00
bnerickson
7c59e64b7a Socket Statistic Application cleanup and application page graph fixes. (#15845) 2024-02-21 21:31:51 +01:00
eskyuu
3d94c53438 Modify the date selector to use the session timezone (#15783)
* Modified the date selector to use the session timezone

* Set the timezone in the datetime picker and make sure it is always passed a moment date object, then altered the submit javascript function to use the existing moment object instead of creating its own

* Update the poll log to display in the correct timezone

* Fix the poll log to make the search work and be timezone aware

* Fix the displayed time on the device overview event log

* Style fixes
2024-02-21 11:45:12 -06:00
Dirk-Willem van Gulik
f0934b53c5 Add kelvin to celcius conversion; as (liquid gas) coolant monitors report in Kelvin. (#15836) 2024-02-18 17:30:42 +00:00
Justin Lentz
7ebc469e06 Stop Oxidized page from refreshing (#15831) 2024-02-17 15:32:21 +00:00
richard-ririe
08ae2fdbc0 Add API endpoints to update and delete Device Groups (#15774)
* API: Update device groups

* API: Delete device groups
2024-02-05 13:02:36 -06:00
SourceDoctor
11246ca8e1 option to ignore device status (#15697)
* option to ignore device status

* .

* .

* schema update
2024-01-31 13:18:34 -06:00
richard-ririe
4277c3387a API: Add/Remove devices from static devicegroups (#15775) 2024-01-31 13:09:14 -06:00
PipoCanaja
a7a6e67e87 NAC - Improve search in WebUI - Keep Historical data (#15629)
* search improvement for PortNac

* rename func

* style

* DB migration for timestamps

* style

* rules

* fix manually db_schema

* remove vlan only search for now

* add a bool column to ident historical nac entries

* add columns to the table

* queryByOui renamed everywhere

* age value instead of delete

* style

* style

* use Illuminate\Support\Facades\DB;

* tests fix

* module_tables.yaml

* dump model instead of tests/module_tables.yaml

* tests

* testVrp

* daily

* config

* display historical NAC entries in global view

* same for NAC device page

* nac tab on device/port view

* and display the tab link if necessary

* filter by port as well

* historical data in port tab

* formatters
2024-01-24 09:15:40 +01:00
Nick Lockhart
f3e0f3eb93 Add port description API endpoints and documentation (#15578)
* Add port description API endpoints and documentation

* Change "update_port_description" behaviour to mimic webUI behaviour

* Fix code style issue

* Fix another code style issue
2024-01-22 23:07:13 +00:00
Stef
5733942aa2 WebUI - Alert Rule Editor: new notes field (#15631)
* add a new notes field to the rule editor. use a bigger text field for sql queries to avoid mistakes...
* add api doc
* allow notes field from the collection
* add a sample notes to the collection
* lint and db schema
* unmix some schema changes from a nother PR
* unmix schema update No°2
* unmix schema update No°3 - silly me
* add strip_tags, minor optimisation, db default value
* apply linting
* db_schema empty '' as default
* update db_schema.yaml
* default value changed as 'BLOB, TEXT, GEOMETRY or JSON column 'notes' can't have a default value'
* better keep the migration in 2023...
* Update 2023_12_12_171400_alert_rule_note.php
* Update create-alert-item.inc.php

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-01-17 09:09:19 +01:00
SourceDoctor
ba48a17a45 Sort smart app disks by label (#15686)
* sort smart app disks by label

* .

* .
2024-01-15 23:05:10 +00:00
Justin Lentz
ee114218d4 Add PollerGroup as an option for OxidizedMap (#15696)
* Update SettingOxidizedMaps.vue

* Update api_functions.inc.php

* Update app.js

* Update app.js

* Style

* Update mix-manifest.json
2024-01-15 22:55:20 +00:00
Arjit Chaudhary
651be0c4e1 Switch bill notes to textarea (#15749) 2024-01-15 22:35:44 +00:00
Jellyfrog
4fa5cb5cfc Apply fixes from StyleCI (#15752)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-01-15 22:29:33 +01:00
Zane C. Bowers-Hadley
19e2062893 add BorgBackup monitoring support (#15591)
* add borgbackup poller

* add borgbackup app page

* add graphs for borg backup

* minor borgbackup graph fixes and cleanups

* don't use custom colors for borg backup

* add metrics

* add borgbackup to the apps page

* add borgbackup snmprec for v1

* add test file for borgbackup v1

* add borg backup docs

* various style fixes

* add a missing key to the test data

* $total_vars -> $to_total

* remove a accidentally added space to applications.md

* test tweaks

* add no_hourly option to generic_stats

* add some more options to generic stats and don't display hourly since it is not really useful for borg backup

* style fix
2024-01-15 15:39:49 +01:00
My Random Thoughts
a1582dd405 Added missing word (#15746)
Service will **be** modified for the specified Device
2024-01-15 10:11:19 +01:00
kakohegyi
4456640e51 Zyxel Wireless Controller OS ( Zyxel NXC series ) (#15694)
* zyxelwlc

* Zyxel Wireless Controller OS

* Zyxel Wireless Controller OS

* Update Zyxelwlc.php

* test data

* sensor count graph

* sensor count graph

* sensor count graph

* sensor count graph

* fix indent

* trailing CR

* Trailing CR

* fix count def

* Delete includes/html/graphs/device/sensor-count-zyxelwlc-sessions.inc.php

Not necessary

* Delete includes/html/pages/device/graphs/sensor-count-zyxelwlc-sessions.inc.php

Not necessary

* fix tests

* fix tests for real

* session graph in core section

* session graph in core section

* session graph in core section

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-01-14 14:02:28 +01:00
Jellyfrog
071ca9bc2a Apply fixes from StyleCI (#15698)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-01-04 22:39:12 -06:00
Ville Hukkamäki
2ed5afc826 Fix Rancid error messages (#15683)
* Fix Rancid error messages

* Fix code style issues.
2023-12-31 13:19:32 +01:00
Justin Lentz
8e62ad53b4 Clarify In/Out (#15680) 2023-12-30 18:48:22 +01:00
Garcia MICHEL
d8eec57690 Fix pagination in alert rules page (#15659) 2023-12-19 10:37:10 -06:00
PipoCanaja
759390ba4b WebUI - Filter FDB and ARP tabs in port page if empty (#15653)
Tested OK

---------

* filter FDB and ARP tabs in port page
* style
* Use relationships

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-12-18 08:08:56 +01:00
Tony Murray
e7114e33f9 API add_device: Add ping_ping fallback option (#15637)
* API add_device: Add ping_ping fallback option
improve docs a little

* More docs refinement
2023-12-17 18:08:37 +01:00
Neil Lathwood
3951bbb248 Update query to be more efficient (#15622) 2023-12-14 10:33:01 +01:00
Stef
ad805f4504 more filter options for the BGP peer API endpoint (#15599)
* Add more filter options for the BGP API endpoint. bgp_descr, bgp_state and bgp_adminstate

* typo and lint

* Adress family filter would also be helpful. casting AS1234 Like inputs to plain numbers

* linting again...
2023-11-29 21:58:30 +01:00
Justin Lentz
de793099e4 Add space to Oxidized error msg (#15603) 2023-11-29 21:53:39 +01:00