Commit Graph

7825 Commits

Author SHA1 Message Date
Tony Murray
2ddfba51dd Set ping_perf scale_min to 0 (#14989)
And allow scale_min, scale_max, and scale_rigid to be set via url parameter
2023-04-20 22:30:32 -05:00
ollb
d40c3be75d Fix cisco dbm sensors port link on discovery (NCS55A2) (#13965)
* Fix cisco dbm sensors port link on discovery (NCS55A2)

dBm sensors were not linked to port on Cisco NCS55A2 platform (iosxr)
causing false alarms triggered by optical modules in administratively shut down ports.

* Delete iosxr_ncs55a2.json

* Create iosxr_ncs55a2.json

* Renew test/data/iosxr_ncs55a2.json

* Delete and recreate test/data/iosxr_ncs55a2.json

With command :

  ./scripts/save-test-data.php -o iosxr -v ncs55a2 -m os,ports,processors,mempools,sensors

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-17 11:08:52 -05:00
Jellyfrog
0a351b49fd Laravel 9.x Shift (#14504)
* Move `resources/lang` folder

* Shift registered middleware

* Remove `fruitcake/laravel-cors` dependency

* Streamline `$commands` property

* Upgrade to Flysystem 3.0

* Shift core files

* Convert `optional()` to nullsafe operator

* Remove unnecessary `$model` property

* Convert route options to fluent methods

Laravel 8 adopts the tuple syntax for controller actions. Since the old options array is incompatible with this syntax, Shift converted them to use modern, fluent methods.

* Convert deprecated `$dates` property to `$casts`

* Shift config files

* Default config files

In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.

* Bump Laravel dependencies

* Use `<env>` tags for configuration

`<env>` tags have a lower precedence than system environment variables making it easier to overwrite PHPUnit configuration values in additional environments, such a CI.

Review this blog post for more details on configuration precedence when testing Laravel: https://jasonmccreary.me/articles/laravel-testing-configuration-precedence/

* Fix error provider

* Match new symfony syntax

* Match upstream syntax

* Fix route syntax

* generate composer.lock

* Sync back configs

* routes

* composer

* Fix more flare

* fix cors

* sync lang

* Apply fixes from StyleCI (#14517)

Co-authored-by: StyleCI Bot <bot@styleci.io>

* bump larastan

* update packages

* wip

* Temporarily lower phpstan level

* Update phpstan.neon

* wip

* wip

* wip

* Apply fixes from StyleCI (#14592)

Co-authored-by: StyleCI Bot <bot@styleci.io>

* test

* Update CiHelper.php

* Update test.yml

* Update CiHelper.php

* Update CiHelper.php

* Apply fixes from StyleCI (#14616)

Co-authored-by: StyleCI Bot <bot@styleci.io>

* test?

* fix phpstan problems

* dont run snmpsim on github ci

* Fix whitespace

* More whitespace

* More whitespace ???

* I think the space broke it

* fix the reset of the whitespace

* hard code auth guard

---------

Co-authored-by: Shift <shift@laravelshift.com>
Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-17 06:51:35 -05:00
AdamB
519fc00367 Change ESXi port naming to be stable (#14639)
* Change ESXi port naming to be stable

Currently every time discovery runs against ESXi, the port names change generating a lot of log spam.

This is because ESXi uses this as the ifDescr:
```Device vmnic1000202 at 01:00.0 nmlx4_en```

The poller parses this, and extracts the interface name, whereas discovery does not, causing the interface names to flip every 6 hours.
https://github.com/librenms/librenms/blob/22.10.0/includes/polling/ports.inc.php#L578-L580

This change gives the discovery process the same behaviour, so the naming is now stable.

* Try to fix test data with a squash

* vcsa test data

* Synthesise VCSA ifName, use it in place of ifDescr

* Refresh test data

* Update ports.inc.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-16 12:58:38 -05:00
Tony Murray
a70d10af19 Fix vsolution discovery yaml (#14970)
* Fix vsolution discovery yaml
Fetching too much data and incorrect config for scalar values.

* revert json changes

* one sensor_prev

* fix

* revert all changes
2023-04-14 23:11:01 -05:00
Stef
0430f6acb1 Cisco QFP polling fixes (#14961)
* fix cisco-qfp Division by zero

* fix percentage calc

* linting

* another zero in RRD. the (int) might be consequential errors and should hurt...

* no float for average_package

* Update includes/polling/cisco-qfp.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Add floor

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-14 22:11:36 -05:00
mtentilucci
b6572e0acc Add support for Trellix ATD devices (#14965)
* Add support for Trellix ATD devices

- Add discovery for mlos ATD devices
- Monitor various OIDs related to ATD system health and status
- Add required MIBs
- Add test data

* add json test data

* Rename MCAFEE-SMI to MCAFEE-INTRUVERT-SMI

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-14 19:34:43 -05:00
Tony Murray
6a769fc7a4 Fix Tait Tnadmin Processor discovery (#14969) 2023-04-14 18:26:38 -05:00
Schylar Utley
056305c3c3 Add support for Alpha CXC HP Controller (#14829)
* add support for Alpha CXC HP Controller

* add num_oids, fix formatting

* fix typo

* Rename cxc_cxc.snmprec to cxc.snmprec

* Create ALPHA-RESOURCE-MIB

* Create ALPHA-RECTIFIER-SYS-MIB

* Create cxc.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-14 18:04:42 -05:00
Kevin Zink
5d7b0e8dc8 Correct PowerConsumed SI Units in Overview (#14425)
* Correct PowerConsumed SI Units in Overview

Workaround to convert PowerConsumed SI Display Units from kkWh to MWh. Better way would be to directly save the data in Wh instead of kWh. But we don't know the impact jet.

* Fix style
2023-04-14 17:34:03 -05:00
Tony Murray
0cdda100e7 Fix Raisecom Processor (#14968)
* Fix Raisecom Processor
Had the same problem as ROS #14966

* Missed oid update
2023-04-14 17:12:35 -05:00
Justin Lentz
b9cc630dbc Stacked graphs on zoom to speed (#14928)
* Update generic_data.inc.php

* Update functions.inc.php

* Update generic_data.inc.php

* Update functions.inc.php

* Update functions.inc.php

* Update generic_data.inc.php

* Update graphs.inc.php

* Make Murrant Happy ;)

* Update generic_data.inc.php

* Update generic_data.inc.php

* Update graphs.inc.php

* Update graphs.inc.php
2023-04-14 16:48:30 -05:00
Tony Murray
cafdec6285 Remove unused port fields (#14963)
* Remove unused port fields
(and set vlan to default to null)

* Update test data for deleted fields

* update vlan to null

* missed field removals

* More correct migration

* Update new data

* restore accidental deletions
2023-04-14 16:47:26 -05:00
Tony Murray
49056da4a0 Fix Raisecom ROS processor collection (#14966)
Was origionally intended to use the 1 minute values, but was discovering the one second value and polling the twoHour value
Was also restricted to only one CPU.
Now discovers and polls all CPUs at the oneMin avg
2023-04-14 15:22:55 -05:00
mtentilucci
04217269a4 Expand discovery of gigavue os (#14933)
* Expand discovery of gigavue os

- Expand discovery so all Gigamon products are discovered
- Query for hardware version using GIGAMON-SNMP-MIB::model.0 OID if present
- Add more Gigamon gigavue test data

* Create gigavue_hc2.json

Looks like there was no json file before...

* update gigavue_hc2.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-14 07:12:44 -05:00
JStandiford
3362e0ee7b fortivoice: add version, hardware and serial collection (#14956)
* Update fortivoice.yaml

Add in pulling in device hardware and software info

* Add files via upload

* Add files via upload

* merge test data

* Delete fortivoice_fortivoice.snmprec

* Update fortivoice.json

* Update fortivoice.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-12 10:11:49 -05:00
Tony Murray
e9c08e21a5 Fix more divide by zero issues (#14954)
* Fix more divide by zero issues
fixes: 14932

* Round to the nearest integer, then cast

* Fix up dhcpatriot
2023-04-11 13:44:45 -05:00
pjroehl
2b1f6a743d Add discovery of NVT Phybridge FLEX24 (#14913)
* Add discovery of NVT Phybridge FLEX24

* Update phybridge-flex.yaml

Added FLEX-24 Switch under sysDescr

* Test Data phybridge-flex_flex-24 json and snmprec
2023-04-10 11:12:12 +02:00
PipoCanaja
228c4ca78d bug - wrong type in ports.inc.php (#14952)
Yet another of these :) 

```
[2023-04-07T19:55:28.777810+02:00] production.ERROR: Error polling ports module for xxxxxxxxxx. TypeError: Unsupported operand types: string - int in /opt/librenms/includes/polling/ports.inc.php:785
Stack trace:
#0 /opt/librenms/includes/polling/functions.inc.php(339): include()
#1 /opt/librenms/poller.php(126): poll_device(Array, false)
#2 {main}  
[2023-04-07T19:55:28.780705+02:00] production.ERROR: Unsupported operand types: string - int {"exception":"[object] (TypeError(code: 0): Unsupported operand types: string - int at /opt/librenms/includes/polling/ports.inc.php:785)"} 
```
2023-04-07 14:09:57 -05:00
Tony Murray
3380122733 Poller perf: add per device average (#14940)
* Poller perf: add per device
Fix min, avg, and current values

* Fix up previous

* Fix style

* Rename to device average, we don't calculate min and max, but rather the min/max of the average.
2023-04-07 13:27:12 -05:00
mtentilucci
b09f5f63e4 Add Nutanix AOS discovery (#14950)
* Add Nutanix AOS Discovery

- Add basic discovery configuration
- Add Nutanix .svg icon and logo
- Add test data

* fix yaml style nutanix-aos.yaml
2023-04-07 13:02:41 -05:00
mtentilucci
698b9ee48c Add Rubrik Discovery (#14951)
- Add basic discovery
- Add Rubrik .svg icon and logo
- Add test data
2023-04-07 13:01:30 -05:00
Tony Murray
8809779b82 RouterOS runtime quirk on first discovery (#14945)
(assume version is > 6.47 if it isn't fetched yet)

fixes #14935
2023-04-06 21:09:31 -05:00
Justin Lentz
df31be30c1 Cleanup enable bgp setting (#14931)
* remove logic in module

* remove enable_bgp logic

* remove enable_bgp logic

* remove enable_bgp logic

* remove enable_bgp logic

* remove enable_bgp definition

* remove enable_bgp logic

* Remove enable_bgp documentation

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI
2023-04-06 21:01:21 -05:00
cjwbath
bbe752b24a Add initial OS detection for LoadBalancer.org (#14902)
* Add initial OS detection for LoadBalancer.org

* Match on Linux sysObjectID first for efficiency

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Add test for loadbalancer OS detection

* Add test for loadbalancer OS detection - fix author

* Add test for loadbalancer OS detection

* Add test for loadbalancer OS detection - fix author

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: Chris Ware <cjw26@bath.ac.uk>
2023-04-06 19:58:14 -05:00
Dan Baker
a340672e86 Added graphing of DDoS-protection related OIDs for PAN-OS (#14847) 2023-04-06 19:11:16 -05:00
Dan Baker
7173205039 Added sensor support for older APC InfraStruXure PDUs (#14944) 2023-04-06 19:09:45 -05:00
torbeckattsp
13d8ac222d Update hikvision-cam.yaml (#14943)
Hikvision cameras model number does not forcibly starts with 'DS-' anymore.
Here is an sample of a OEM new model made by HIKVISION 
[
.1.3.6.1.4.1.39165.1.1.0 = STRING: "IPC7A27-ANPR"
.1.3.6.1.4.1.39165.1.2.0 = STRING: "0"
.1.3.6.1.4.1.39165.1.3.0 = STRING: "V5.7.80 build 220525"
.1.3.6.1.4.1.39165.1.4.0 = STRING: "98-f1-12-c7-0b-a2"
.1.3.6.1.4.1.39165.1.5.0 = STRING: "88"
.1.3.6.1.4.1.39165.1.6.0 = STRING: "IPcamera"
.1.3.6.1.4.1.39165.1.7.0 = STRING: "38 PERCENT"
...]
2023-04-05 21:05:59 -05:00
electrocret
8e5f26652e Indicator on Port Notes tab when Port has notes (#14923)
* Update port.inc.php

* Use Port Object
2023-04-05 15:52:13 -05:00
d-k-7
14f19eb6cf APC UPS UIO sensor discovery bug (#14942)
* only proceed if there are entries in the uio table

* only proceed if there are entries in the uio table
2023-04-05 22:48:23 +02:00
RobJE
75033daaa8 add support for WTI console products (#14920)
* add support for WTI console products

* add test data
2023-04-04 13:21:10 +02:00
GeantRA
ec9e77b665 Update junos discovery yaml to reference total memory instead of buff… (#14919)
* Update junos discovery yaml to reference total memory instead of buffer memory used

* Add FPC0 test data reference
2023-04-04 10:28:59 +03:00
mtentilucci
d508d2d6f3 reorder command to follow documented syntax (#14910) 2023-03-30 14:04:06 -05:00
kirk444
0a889ad363 Add additional 7130 devices (#14922)
Add additional sysObjectID for additional MOS / 7130 models.
2023-03-24 02:29:53 +01:00
jellejans
ae429d987a Device - Add support for Scalance SC646-2C (#14835)
* Update scalance.yaml

Add support for Scalance SC646-2C

* add scalance_sc646.snmprec
2023-03-21 07:31:42 -05:00
Stef
e1b2a42373 Device: Deltanet Lambdatrail LT2-S,HS (#14661)
* Deltanet Lambdatrail integration - first try

* add fan parameters

* ignore values

* lint

* over graphs and snmp fix

* definition for hs variant

* HS variant added

* mibs renamed

* add test data

* Deltanet Lambdatrail integration - first try

* add fan parameters

* ignore values

* lint

* over graphs and snmp fix

* definition for hs variant

* HS variant added

* mibs renamed

* add test data
2023-03-21 07:29:17 -05:00
Nick Peelman
7ccccdf914 Add Montclair EDFA Support (#14852)
* Add Montclair EDFA Support

* Fix detecton

Used explicit match regex

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-03-18 21:34:28 -05:00
pjroehl
bbabf4bf36 Added cisco FTD 1150 to ftd.yaml (#14907)
* added cisco FTD 1150 to ftd.yaml

* Added cisco FTD 1150 to ftd.yaml

* Added Cisco FTD 1150 to ftd.yaml
2023-03-18 18:54:06 +01:00
mtentilucci
d6d2827f97 Add support for Trellix FireEye OS (#14908) 2023-03-18 18:51:14 +01:00
Marek Wobst
cfb70f73d1 Add more OIDs for determining hardware and serial attributes correctly (#14904)
Some FTD systems like 4110 and 4120 (probably more) use different OIDs (not .1 or .4) for that, so these were added. The version extension is probably not helpful, as the result is an empty string … but at least that OID exists.
Not: without this change, hardware+serial fields will be empty after a (re)discovery.
2023-03-16 16:05:23 +01:00
Stef
82bd437e47 Syslog sink over http for logstash (or any json source) (#14424)
* inital commit of a new syslog sink over http

* cosmetics

* cosmetics fix...

* cosmetic fix again

* cosmetics fix again

* its nice now...

* add non blocking option

* Syslog Sink integrated as API PUT method

* lint fix

* Update includes/html/api_functions.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update includes/html/api_functions.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update includes/html/api_functions.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* change to POST, fix decoding issue and json exception

* logstash/json documentation added. syslog documentation a bit re-structured

* lint fix

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-03-15 08:14:38 -05:00
electrocret
1173cf3161 Fix dbm calculation to return -60 instead of 0 (#14858)
* Fix calculation

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* rebuild using SNMPRec

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9010.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json
2023-03-15 08:07:46 -05:00
Jellyfrog
68e0b3df28 Apply fixes from StyleCI (#14899)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-03-13 22:32:22 +01:00
Stef
0e322ae5d5 Pseudowires refresh (#14882)
* refresh the pseudowires

* linting
2023-03-13 10:19:23 -05:00
Tony Murray
d3f02e6bb7 SnmpQuery, respect snmp.max_oid (#14894)
Previously, the code would query all the oids it received. Now it will split it up into multiple queries if too many are sent.

Prevents some devices snmp service from crashing.
2023-03-13 10:17:34 -05:00
Jellyfrog
e9f8e64506 Re-throw exceptions if we're in CI (#14890)
Else they are not shown during tests
2023-03-10 15:00:03 +01:00
Jellyfrog
f111ac22fe APC: Add support for Battery Recommended Days Remaining (#14653)
* APC: Add support for Battery Recommended Days Remaining

* Extract number from string later during polling
Odd that this is different from the discovery process

* wip

* wip

* Apply fixes from StyleCI

* wip

* wip

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-03-10 14:50:56 +01:00
Marek Wobst
58acfe8f92 Add Cisco FTD Support for security appliances (#14893)
Models: 4110, 4120, 4125 (each with K9)
2023-03-10 14:47:37 +01:00
mtentilucci
1e373dedc6 Add Avocent MergePoint Unity KVM Switch Support (#14874)
* Modify Avocent discovery so Avocent MergePoint Unity KVM switches are discovered

* Extract hardware model and version stored in sysDescr OID

* add avocent mpu snmprec

* add json dump test data

* update to not conflict with dell-rcs discovery

* fix styleci findings

* update Avocent.php

* update Avocent.php

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* cleanup

* fix os name typo

* Add support for Vertiv Avocent MergePoint Unity

- Remove unnecessary sysdescr_regex in discovery file
- Only show device_bits graph in device header bar
- Use Vertiv icon
- Replace .png Vertiv icon and logo with .svg
- Disable unnecessary discovery and poller modules
- Add more snmpsim test data

* Update avocent-mp.yaml

Only disable poller and discovery modules if they cause problems
2023-03-10 00:09:53 +01:00
Zane C. Bowers-Hadley
cd82c72190 add graph_stat_percentile_disable config item to disable percentile lines/value printing (#14887)
* add the initial config items for graph_stat_percentile_disable

* update generic stats to use graph_stat_percentile_disable

* style fix
2023-03-09 17:24:32 +01:00