Commit Graph

8271 Commits

Author SHA1 Message Date
Tony Murray
f15f8fa63a Sensors remove reliance on global variable (#16344)
* Sensors remove reliance on global variable

* Apply fixes from StyleCI

* Clear the instance instead of reset.
Remove $valid['sensors'] from docs

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-03 21:04:34 -05:00
makriska
4efad1ae69 Fix handling of zero value for entSensorThresholdValue for dbm cisco sensor (#16336)
* add handling of zero value for entSensorThresholdValue for dbm sensor type

this addresses https://github.com/librenms/librenms/issues/16335
* Update cisco-entity-sensor.inc.php
* safe check for $key['entSensorThresholdValue']
* style
---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-09-03 21:39:05 +02:00
Tony Murray
cc22a74503 Remove global $var access functions (#16345)
* Proxmox remove global access functions

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-03 19:41:13 +02:00
Tony Murray
c6cac9d90b Fix bad health sensor labels in the ui (#16350) 2024-09-03 11:49:47 -05:00
Tony Murray
03d3660dfa Fix Cisco entity-sensor (#16351)
* Fix Cisco entity-sensor
make mw_to_dbm and uw_to_dbm handle negative numbers

* fixes and update test data
2024-09-03 09:02:02 -05:00
Tony Murray
d8097b0c21 awplus sensor fixes (#16348)
* awplus sensor fixes

* Update test data
2024-09-02 22:26:02 -05:00
Tony Murray
64c0d6ff7f Ignore entity-sensor invalid values (#16347) 2024-09-02 21:44:29 -05:00
Justin Lentz
cdc360dcdb Use Device Displayname for AlertRules (#16322)
* Use Displayname for AlertRules

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-08-28 21:35:20 +02:00
Tony Murray
9e4b2fa3a3 Reject API device_add that are missing snmp info (#16314) 2024-08-27 07:08:19 -05:00
Tony Murray
35967dc98d Remove CIMC custom inventory code (#16305)
No test data and it is too complex and strange to update without data.
If someone wants to update and re-submit it, they are welcome to.
2024-08-21 12:24:30 +02:00
Tony Murray
3c67de2311 Fix misc Cisco polling errors (#16307)
* Fix misc Cisco polling errors

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-21 12:22:37 +02:00
Simon Wüllhorst
d2df5ac9d7 Updated nvidia poller app: handle slightly changed nvidia-smi output formatting properly (#16158) 2024-08-21 01:28:18 -05:00
Zane C. Bowers-Hadley
7b98721e32 Poudriere support (#16229)
* add the poller

* save text status stuff

* add initial app page stuff

* add history table and start work on graphs

* checkpoint

* re-work the poudriere graph bits a bit more

* fix the poller and start work on the graphs

* polling fix

* more work on the poudriere stuff

* poke stuff with php-cs-fix

* add some more graphs

* more style fixes

* another style fix

* add more graphs

* add Poudriere docs

* add tests data

* some minor tests fixes

* a test tweak

* more test tweaks

* some more test tweaks

* tweak .data.build_info data .data.build_info to make the app data test saner

* derp... missed a item

* add app data
2024-08-21 01:27:26 -05:00
Tony Murray
9d35fbc6a7 Entity Physical discovery: Rewrite to modern style (#16289)
* Initial entity-physical code

* Split out Entity-MIB trait

* Cisco Cellular inventory

* Fix bad test data

* alfo80hd - we now include all entPhysical entries

* Correct aos7 test data

* Add entPhysicalClass as last resort for label in ui

* aos add previously filtered data

* Fixup arista-eos data

* Update ariast_eos data

* Arris, clean garbage in Rev fields

* Aruba Instant custom inventory ported

* ArubaOS CX add vendor type mib

* aviat-wtm test data refresh

* axos add shelf fix data fields a bit

* ciena-rls

* ciena-sds

* Skip cimc for now... no test data

* Cisco updates

* Comware data update

* Update dnos

* Clean Edgeos garbage, make code from Arris shareable

* Relaxed ifIndex match, some devices cheat and send back static strings instead of formatted OIDs

* Regex refinement and updated edgeos with new clean data

* Update edgeswitch data

* Update eltex-mes21xx data

* eltex-mes23xx

* Guess at eltex-mes24xx since there is no test data

* Update eurostor, fix firmware version

* Apply fixes from StyleCI

* fixes

* Update fortigate data

* Update fortiweb, ftd, and fusion

* Update linux LSI

* Fix hexToAscii null removal with different seperator handling

* icotera add final snmprec data to avoid snmpsim bug

* Update IOS data

* Update mrv-od

* Add junos translation

* Generic data updates n-r

* ruijie workaround snmpsim bug

* Port saf-cfm

* Recode Schleifenbauer, and fix entPhysicalIndex values

* SmartAX fixes

* sm-os and tait-infra93

* timos inventory was not right, fix it up

* ubiquoss-pon

* VRP, has custom data collection on top of normal
adapt port ifIndex lookup to handle it

* VRP exceeded the string length specified in ENTITY-MIB...

* data updates

* Final data update and code cleanup

* Apply fixes from StyleCI

* Lint fixes

* Add missing SnmpResponse->pluck() code

* Update db_schema.yaml

* Fix bad test data

* Another instant-on update

* oops

* Remove some unused code

# Conflicts:
#	includes/html/pages/device/overview.inc.php

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-08-21 01:12:09 -05:00
Tony Murray
343a979f5c Remove c3kxbar (#16304)
it is very old and there is no test data for it
Could be easily added back if someone still uses it
2024-08-20 09:01:07 -05:00
Tony Murray
70c2c543f3 Plugin Update (#16291)
* Plugin Update
Extract interfaces for use in plugin packages

# Conflicts:
#	composer.lock

* Fix some issues
settings_view -> content_view
2024-08-15 15:26:47 -05:00
Ervin S.
38e453fe71 device - Adding support to Infortrend DS3016 (#16070)
* Adding support to Infortrend DS3016
* Adding snmprec for Infortrend DS3016
* Delete tests/snmpsim/DS_3016.snmprec
* change of the infortrend logo
* add the infortrend logo
* Delete tests/snmpsim/infortrend_test.snmprec
* again another logo replacment
* update yaml file to display sensor state
* Delete includes/definitions/discovery/infortrend_orig
* typo missed the . at start of oid
* change logo based on req. from PipoCanaja
* on req of PipoCanaja to fix the structure of the folder
* replacing the logo as req. from PipoCanaja
* Fix infortrend.yaml
* Remove mibs/IFT-SNMP-MIB
* Create infortrend_infortrend.json
* Update infortrend_infortrend.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-08-15 11:06:13 +02:00
PipoCanaja
faac90fadc webui - More details for alerts concerning mempools and services (#16259)
Improve display of alerts_details with mempools. & servcices
* DescrForMempoolInAlerts
* more
* services
2024-08-15 10:43:48 +02:00
AdamB
c2770c6f19 Remove file differing by case only (#16280) 2024-08-12 11:24:02 -05:00
Tony Murray
f296464dae validate.php proper exit code (#16274)
some fixes around database & poller checks
2024-08-08 20:00:56 -05:00
PipoCanaja
b62a4bacd4 bug - Fix CISCO-BGP4-MIB logic (#16260)
* Fix CISCO-BGP4-MIB logic

* style

* tests

* tests suite
2024-08-06 21:19:50 -05:00
PipoCanaja
d1ee543b6b bug - Fixing 'cisco-pw' cpwVcMplsPeerLdpID (#16268)
* fix for cpwVcMplsPeerLdpID in IP form

* tests
2024-08-03 12:57:33 -05:00
Nicolas Berens
549741d31e fix splitting of perfdata (#16255) 2024-08-03 19:31:07 +02:00
Tony Murray
2d2ddddd5d Remove FILTER_SANITIZE_STRING (#16264)
It is deprecated, all the code using it is sus
2024-08-02 16:24:51 -05:00
Cody Harris
d67df039e3 device - Added Baicells Atom OD04 CPE support (#14838)
This adds a MIB from the Baicells website, lightly modified
(s/BAICELLS-MIB/BAICELLS-CPE-MIB), and yaml files for LibreNMS. Currently OS
detection works, but sensors are reporting '0'.

I can easily get the data with snmpget, so I know that part is working. The
issue I'm seeing looks like the {{ $index }} substitution in my sensor yaml
isn't being filled out. Here's some example output from poller.php that backs
this up:

```
.1.3.6.1.4.1.53058.2.2.7.: Unknown Object Identifier ()
.1.3.6.1.4.1.53058.2.2.8.: Unknown Object Identifier ()
.1.3.6.1.4.1.53058.2.2.12.: Unknown Object Identifier ()
.1.3.6.1.4.1.53058.2.2.13.: Unknown Object Identifier ()
```

* adjustments to baicells od04

* undo modification to mib

* add original unmodified mib, tweak yaml, add time conversion function

* added baicells od04 snmprec

* skip invalid values

* Rename baicells-od04.snmprec.txt to baicells-od04.snmprec

* Update and rename BaiCE-BM-2.5.23_SNMP_MIB-CAT4.txt to BAICELLS-MIB

* Update baicells-od04.yaml

* Create BaicellsOd04.php

* move userfunc into OS

* style

* squash php casting warning

* missing static

* style

* fix {{ $index }}

* Create baicells-od04.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-08-02 19:18:17 +02:00
Jellyfrog
624099cf9f Add support for GUDE Expert Sensor Box (#16257) 2024-08-01 22:34:28 +02:00
Ferris-0815
520e44b0ed F5-Loadbalancer module to support an expiration check of the installed certificates (#16217)
* On branch f5-cert-expiration-check
Changes to be committed:
	modified:   app/Http/Controllers/Device/Tabs/LoadBalancerController.php
	modified:   includes/discovery/loadbalancers/f5-ltm.inc.php
	modified:   includes/html/pages/device/loadbalancer.inc.php
	new file:   includes/html/pages/device/loadbalancer/f5-cert.inc.php
	modified:   includes/polling/loadbalancers/f5-ltm.inc.php

These patches extend the F5-Loadbalancer module to support an expiration check of
the installed certificates.

* some minor corrections to (hopefully) pass the style-check

* a few more impovements to pass the style-chek

 On branch f5-cert-expiration-check
 Your branch is up to date with 'origin/f5-cert-expiration-check'.

 Changes to be committed:
	modified:   includes/discovery/loadbalancers/f5-ltm.inc.php
	modified:   includes/polling/loadbalancers/f5-ltm.inc.php

* more style-check adaptions...
2024-07-29 14:57:37 -05:00
Jeff Engleman
903ed58fc3 add bgp peer description to alert_detail (#16233)
* add bgp peer description to alert_detail

* style

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-07-29 14:54:10 -05:00
Justin Lentz
03bbf5ed7a sensor - add skip_values to hsrp (#16251) 2024-07-29 21:53:24 +02:00
Justin Lentz
cc6b1acfc8 Add Servicename to Alert Detail (#16249)
* Update functions.inc.php

* spaces

* tweaks

* tweaks

* I need to wake up

* I Like the colons
2024-07-29 11:53:11 -05:00
Michael
9f4e6cbf01 add in/out erros to port table (#16073) 2024-07-26 09:09:38 -05:00
Tony Murray
b41d1b7ffb Fix Port Channels take 2 (#16246)
* Resubmit of #16227

* Add missing new files
2024-07-26 08:45:34 -05:00
Jellyfrog
e45dd59f77 Revert "Fix Port Channel (#16227)" (#16245)
This reverts commit 0d201c44c9.
2024-07-26 15:26:04 +02:00
Tony Murray
0d201c44c9 Fix Port Channel (#16227)
* Fix expandable sizing

* Temp fix: port_id_{low,high} is actually ifIndex

* new PortsStack discovery module, store actual port_ids

* Show 4 rows of ports by default

* Add test data

* Fix up the single port view too

* Apply fixes from StyleCI

* Update db_schema.yaml

* Update base migration because sqlite cannot add primary keys

* Fix phpstan failures

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-07-25 23:39:36 -05:00
Tony Murray
5737e8e277 Fix list_arp API (#16243)
Failed when IP or MAC was specified
2024-07-25 22:50:58 -05:00
Jeff Engleman
8866ab3119 Add link on alert-rules page to display active alerts for rule (#16232)
* Add link on alert-rules page to display active alerts for rule

* replace ? with / per convention

* make the alert icon clickable too

* Lower the brightness of the warning rows
2024-07-25 21:43:44 -05:00
Joe Clarke
aad110102f Fix error from MikroTik routers when updating BGP peer info (#16224)
* Create a case for routeros.

RouterOS doesn't support the bgpPeerInUpdateElapsedTime object, so when
LibreNMS does to insert a peer update into the database from a MikroTik
router, you see the following error:

SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect integer value: '' for column `librenms`.`bgpPeers`.`bgpPeerInUpdateElapsedTime` at row 2 (Connection: mysql, SQL: UPDATE `bgpPeers` set `bgpPeerAdminStatus`=start,`bgpPeerInUpdateElapsedTime`=...

To fix this, special-case routeros and note that the object is not yet
supported.

* Use spaces, not tabs.

* Use set_numeric() to ensure bgpPeerInUpdateElapsedTime is a number.

---------

Co-authored-by: Joe Clarke <jclarke@cisco.com>
2024-07-19 19:41:16 +02:00
Frederik Kriewitz
23965cee49 Add support for memory, power status and transceiver monitoring to Fiberstore S3900 series switches (#16225) 2024-07-19 19:39:39 +02:00
Tozz
090611f6c1 Add support for FortiNet FortiExtender (#16219)
* Add support for FortiExtender - Wireless Sensors

* Add support for FortiExtender - Discovery YAML

* Add support for FortiExtender - YAML Sensors

* FortiExtender 201E SNMPsim

* FortiExtender 201E - Test Data

* FortiExtender MIB

* StyleCI

* Fix StyleCI

* Better now?

* Whoops

* Update fortiextender_201e.json

* Update fortiextender_201e.json

* Add files via upload

* Delete mibs/fortinet/FORTINET-FORTIEXTENDER-MIB.mib
2024-07-18 22:47:40 +02:00
Nicolas Berens
512403a255 Tripplite console server (#16156)
* exclude triplite console servers

* add definition for tripplite console servers

* add test files

* renamed to lowercase

* add testdata

* add testdata

* disable poller and discery modules that do not apply to this device

* lo will always report empty values, so lets ignore it

* removed disabled poller modules
2024-07-17 18:15:03 -05:00
PipoCanaja
97a13f6fe8 discovery - LLDPv2 support extension, and discovery-protocols tests (#16113)
* LLDPv2

* style

* styleAgain

* LLDPv2Tests

* discovery_module_tests

* VRP links tests

* tests

* AOS

* DLINK

* CISCOSB

* AOS

* AOS7

* ARUBA

* ZYNOS

* DLINK

* fix orderby

* edgecos

* boss

* edgeswitch

* voss

* eltex-mes23xx

* fs-switch

* ciena-sds

* cisco

* procurve

* tests/data/moxa-etherdevice

* junos

* mypoweros

* fixTestsArubaOS_orderby

* tests/data/bti800.json

* tests/data/scalance_xc206-2sfp.json

* ciena-sds

* aruba-cx

* orderby remote_port as well

* vrp

* force test rerun
2024-07-17 16:07:57 -05:00
Tozz
22a8a237e8 Add value 0 to HP Physical Drive Status (meaning no disk is inserted) (#16211)
* Add value 0 to HP Physical Drive Status (meaning no disk is inserted)

* Updated test data

* Updated test data

* Update hp.inc.php
2024-07-17 17:42:08 +02:00
Tozz
9abfa7b0e6 Fix FortiGate Cluster Sync status (#16206)
* Fix FortiGate Cluster Sync status

* Update fortigate.inc.php

* StyleCI

* Tests

* Update fortigate.inc.php

* Add files via upload

* Delete tests/data/fortigate_500d.json

Weird unrelated OSPF test failure

* Re-add fortigate_500d.json

* Fix author/copyright

* Update fortigate.inc.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-07-17 01:19:08 -05:00
Frederik Kriewitz
5e69d89791 bdcom/fs-bdcom: add transceiver threshold support (#16203)
* update BDCOM NMS-IF-MIB

* bdcom/fs-bdcom: add transceiver threshold support
2024-07-15 23:51:34 +02:00
Zane C. Bowers-Hadley
8738e978ce extend update for wireguard, correct is_int to is_numeric for polling purposes, and clean up the app page (#16182)
* replace is_int with is_numeric

* update the docs for wireguard for the new extend

* relocate the app data bit

* update the data for the wireguard test

* start reworking the wg app page... details part done

* app page mostly done

* finish the wireguard app page

* style fix

* now sorted

* add additional info to the peer page

* style fixes

* a small fix for the links

* style fix

* make the pubkey column in details link to the peer page

* escape the pubkey
2024-07-14 22:58:41 -05:00
Tozz
b0c7fe8c8d Revert "Fix Fortinet HA-status polling state translations (#14921)" (#16202)
This reverts commit 531009983c.
2024-07-14 17:30:30 -05:00
Zane C. Bowers-Hadley
bc82473f8a add missing graphs for NFS app page (#16197) 2024-07-13 22:21:11 +02:00
Frederik Kriewitz
d1fd57a64a BDCOM: add transceiver monitoring (#16160) 2024-07-10 09:32:13 -05:00
Blair H
991424e543 Fix up the Siteboss571 discovery yaml to split pdnOutputCurrentValue and pdnMainCurrentValue indexes (#16181)
* Update siteboss571.yaml - Tidy up descriptions and fix current sensors

Fix issue with current sensors 1.1 and 200.1 - these were being overwritten with the per-module sensors due to overlapping IDs. insert extra index definition for each type. this is a breaking change that will cause new RRD files to be created for the current sensors with the new index names.

* Update siteboss571_siteboss571.snmprec

update test data

* Update siteboss571_siteboss571.json

* Revert "Update siteboss571_siteboss571.snmprec"

This reverts commit b767dbc91b.

* Revert "Update siteboss571_siteboss571.json"

This reverts commit a144078ed8.

* Create siteboss571_siteboss571-2.snmprec

* Remove Siteboss571 PHP detection, add new json test output

* Update siteboss571_siteboss571.json with new discovery

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-07-09 23:02:40 +02:00
Nicolas Berens
e083775e1d Add Hardware and frmware detection for moxa P510 (#16185)
* fix version and hardware oid for moxa p510
* update test
* Fix moxa-etherdevice_edsp510a8poe.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-07-08 14:17:43 +02:00