Commit Graph
36 Commits
Author SHA1 Message Date
Tony Murray 437a577dba allow -24h style to/from for graphs again (#10294) 2019-06-02 01:18:50 -05:00
Tony Murray 9faae11381 Sanitize graph input (#10276)
Could execute arbitrary rrdtool commands such as cd and ls.
2019-05-31 07:43:12 -05:00
CirnoT 241b07756f Don't show warning when ignored device is online (pingable) (#10286)
* Don't show warning when ignored device is online (pingable)

* Update logic for header on device page too

* Make codeclimate happy
2019-05-30 14:46:33 -05:00
Llarian 0e36e52a63 Fixed Quick Graphs bug w/ Aggregate 95th code (#10269)
* Added configuration options to aggregate input and output bits before making 95th percentile billing calculations

* Changed aggregate to per-bill instead of global.  Added config options for making aggregate the default selected option.  Refactored out mres() calls in touched files.  Changed to Config::get where appropriate.

* Fixed documentation typo

* Fixed scope of aggregate default config option to be under billing

* Fixed getRates issue in Quick Graphs section of 95th percentile bill

* Added configuration options to aggregate input and output bits before making 95th percentile billing calculations

* Changed aggregate to per-bill instead of global.  Added config options for making aggregate the default selected option.  Refactored out mres() calls in touched files.  Changed to Config::get where appropriate.

* Fixed documentation typo

* Fixed scope of aggregate default config option to be under billing

* Fixed getRates issue in Quick Graphs section of 95th percentile bill

* Fixed formatting
2019-05-28 23:39:31 -05:00
PipoCanaja 0ae1f30f7d Indent cleaning for bills (#10268)
* Correct indentation and empty lines

* Update new_bill.inc.php

* Update addoreditbill.inc.php
2019-05-28 07:08:24 -05:00
Llarian 9c837bee87 Added aggregate config option to Billing 95th percentile calculations (#10202)
* Added configuration options to aggregate input and output bits before making 95th percentile billing calculations

* Changed aggregate to per-bill instead of global.  Added config options for making aggregate the default selected option.  Refactored out mres() calls in touched files.  Changed to Config::get where appropriate.

* Fixed documentation typo

* Fixed scope of aggregate default config option to be under billing
2019-05-27 21:44:02 -05:00
Tony Murray 119c52fcb2 Fix can't set poller group on ping only device (#10260) 2019-05-24 07:35:33 -05:00
Tony Murray 90a67c2ece User configurable locale (language) (#10204)
* Support for system APP_LOCALE

* Start preferences re-write

* port 2fa form

* Working user preferences

* Language user preference

* Don't look up locale from the DB every request

* Device list working

* Deny demo user middleware

* Finish password changing

* remove used resource methods

* remove leftover use

* warn that translation is incomplete

* fix style
2019-05-23 10:05:45 -05:00
pobradovic08 90bb68f026 Netscaler vsvr - fixed wrong table colspan (#10246) 2019-05-23 10:04:35 -05:00
Tony Murray c99f6afa9b Fix device overview port counts (#10254) 2019-05-23 09:58:43 -05:00
Tony Murray c9748b166e More url helper fixes (#10241)
* More url helpers
graph links
ajax search

* Fix for non-Laravel pages using the url helper

* fix widget settings
2019-05-21 08:50:45 -05:00
Jozef Pivarník 2dc05ee501 Fixed Cisco MAC accounting discovery, polling and HTML templates. (#10158)
* Fix Cisco MAC acounting discovery, polling and HTML templates.

* Remove empty code.

* Provide test data for cisco-mac-accounting module.

* Added module test dependency.
2019-05-20 20:56:19 -05:00
Tony Murray e9ae08d5db Use Laravel url helpers to improve functionality without dns name (#10227)
* Use Laravel url helpers to improve functionality without dns name
Not exhaustive...

* Fix Url generated urls

* Bump js version
2019-05-20 11:47:34 -05:00
pobradovic08 1e76915af3 Netscaler vservers table update (#10103)
* webui: Netscaler Vservers add table header and vserver type

* webui: Netscaler Vserver sorting (name, traffic in/out)
2019-05-20 08:56:53 -05:00
PipoCanaja eecc5b36e0 Doc: Typo in oxidized.inc.php (#10236) 2019-05-19 22:51:00 +02:00
Tony Murray 8cc988a162 Fix plugins menu (#10222)
* Merge pull request #54 from librenms-plugins/revert-52-PluginNamespaceCorrection

Revert "Adding namespace LibreNMS\Plugins;"
Fix plugins menu

* Only use scrollable where needed
2019-05-13 14:53:29 -05:00
Tony Murray 882818d9f3 Fix location missing from API device list (#10215) 2019-05-13 09:45:19 -05:00
Tony Murray c097747d77 API Fix error when no fdb are found (#10125)
* Fix error when no fdb are found

* actually, it was totally broken...
fix untested

* missing device update

* cleanup

* Update api_functions.inc.php
2019-05-13 08:35:24 -05:00
SourceDoctor 96f7f142ba add mdadm support (#10159)
* add mdadm support

* Update mdadm.inc.php
2019-05-12 23:42:03 -05:00
CirnoT ef90da2a31 Better services graphing support (#10185)
* Move services graph code from device to service and remove unused code

* Add proper support for services to dashboard graph weidget

* Fix phpdoc in ServiceController still pointing to MuninPluginController
2019-05-12 23:40:27 -05:00
Dragan Savic 4313cbfd31 Improved OSPF device display (#10206)
- Fixed ospf port listing, as current query only returned ospf ports for last AreaID in area foreach loop.
- Added Area ID column to Ports table.
- Removed whitespaces.
2019-05-11 23:33:55 +02:00
sparkkraps 652a9f5486 Update legacy_api_v0.php (#10209) 2019-05-11 23:10:04 +02:00
Tony Murray 9ede688d13 Replace legacy menu with new Blade generated one (#10173)
* Remove legacy index php file

* fix routing page missing data

* WIP

* fix $navbar global usage

* remove global use of $locations

* ObjectCache again...

* move vars.inc.php to init.php for legacy ajax

* navbar is more local than I thought before.  Fix it.

* Fix some sensors tables escaping

* restore custom menu functionality, but with blade
and docs

* cleanup

* tidy menu @if checks

* Fix up the rest of the global variables and remove print-menubar.php

* consolidate some counting in the menu

* filter out empty custom port descr types

* Fix up custom port groups

* Fix up apps menu

* Fix services menu when all are ok

* Limit cached data to the user it is for

* Fix style

* A few clean ups

* fix pseudowire bug
2019-05-10 11:02:39 -05:00
CirnoT 4e43594df0 Fix state sensors on device health page showing always as OK (green) (#10200) 2019-05-09 06:41:12 -05:00
Anthony Ruhier 6e76f1d8e7 Specify graph format from GET param (#10118)
Allows to specify a graph format (svg or png) for the GET parameter
"graph_type"
2019-05-01 09:52:07 +01:00
CirnoT 97005c0b57 Fixed state sensors on global Health table always displayed as 'OK' (#10171) 2019-04-30 22:49:53 +02:00
CirnoT 33a51bc592 Store IPv4 networks as network address and fix address search page showing networks not addresses (#10144)
* Store IPv4 networks as network address, not device address

* Properly display addresses, not networks on address search page
2019-04-29 11:52:32 -05:00
CirnoT a7ef43359f Fix services with scripts inheriting DS from previous service on detail view (#10142)
Ensures check_ds variable is always null on each run of loop that displays services graphs. Fixes services that have script (like check_dns) but don't set check_dns on their own inheriting check_dns from previous service that ran (for example check_icmp) and displaying additional bogus graphs as result.
2019-04-28 10:27:36 +02:00
VVelox 7609253a13 Setting font colors for RRD graphs is now possible (#10083)
* easily setting font colors for RRD graphs is now possible

* add a comment explaining the variable
2019-04-28 10:19:35 +02:00
CirnoT df2930b671 Fixed filter by device and interface type on IP address search page (#10143) 2019-04-28 10:04:56 +02:00
Martijn Schmidt af5377e06c Handle health sensors with underscores in the name. (#10123) 2019-04-27 17:10:31 +02:00
pobradovic08 b8c4f38fb5 Added session graphs for Barracuda NGFW (#10102)
* devices: Corrected discovery object ID for Barracuda NGFW; Added fw session graphs
* device: Added test data
2019-04-27 15:33:55 +02:00
djamp42 ae1b5bbfc1 Allowed Add_Device API to set sysName (#10124)
sysName is a valid option via the WebGUI to set when SNMP is turned off. Currently you cannot set this via the API add device. This is to enable setting the sysName via the API.
2019-04-27 09:15:59 +02:00
Tony Murray 0a12ede577 Fixed api *log date format (#10133)
fixes #10089
2019-04-23 15:26:50 +02:00
Tony Murray 6e6e54cb98 New User Management (#9348)
* Rewrite user management.

Error management

Revert edituser legacy page

Connect user permissions button to legacy page for now.

Implement user creation
Refine form

Remove PingCheck.php accidental add :)

Fixes for redirection and deletion

More fixes: realname accidental validation setting, hide can modify for read-only auths

Use a panel to improve style

Add icon to panel-title

Not allowed to delete own user (at least via the click of a button)

Use request validation to reduce complexity of controller.
Improve protection against users doing things they should not.

Switch to horizontal form and not nearly as wide of layout :)

delete without refresh.
Fix for buttons

Include all users (not just from this auth)
Hide the auth column if there is only one auth type

Show username if real name isn't set

Don't allow creation of demo users via the webui

a fix to the lnms user:add command, it didn't set auth_id

update edituser.inc.php to current
just redirect to users page

* Remove TwoFactorTest for now

* Update edituser.inc.php

* Update .env.dusk.testing

* Enable 2fa for 2fa test...
2019-04-22 19:01:39 -05:00
Tony Murray 36431dd296 Security fix: unauthorized access (#10091)
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
2019-04-11 23:26:42 -05:00