Commit Graph

6024 Commits

Author SHA1 Message Date
CirnoT
4e43594df0 Fix state sensors on device health page showing always as OK (green) (#10200) 2019-05-09 06:41:12 -05:00
CirnoT
b4f03808db Ignore empty IPv4 addresses in discovery on buggy devices (#10198)
* Ignore empty IPv4 addresses in discovery on buggy devices

* Styling fixes for codeclimate

* Use try/catch block instead
2019-05-09 06:39:57 -05:00
David Nelson
223d3070d5 Fix MySQL error were prepared statement contains too many placeholders (#10153)
* Fixes a MySQL error were the prepared statement contains too many placeholders. Modifies dbBulkInsert to run array_chunk on incoming data and inserts those smaller chunks.

* Trying to address some automatic checks about blank lines.

* Trying to make Code Climate happy with reduced cognitive complexity.

* Trying to make Code Climate happy with reduced cognitive complexity.
2019-05-06 21:42:25 -05:00
Tony Murray
3e7970b814 Fixed Avtech discovery (#10163)
* Fix Avtech discovery
pre-cache stored the data incorrectly

* Fix RA-4E external sensors
sen1 had incorrect oids (duplicate of sen2)
Description oid from data doesn't match the mib, perhaps outdated MIB?

* add test data

* Updated 4E MIB
2019-05-02 21:37:00 +01:00
CirnoT
308145d2da Fixed Raspberry Pi sensors discovery (#10176)
* Fixed Raspberry Pi frequency, voltage and state sensors discovery
* Added tests
2019-05-02 08:10:20 +02:00
Anthony Ruhier
6e76f1d8e7 Specify graph format from GET param (#10118)
Allows to specify a graph format (svg or png) for the GET parameter
"graph_type"
2019-05-01 09:52:07 +01:00
CirnoT
9d5e780c59 Added support for APC PDU outlet state sensors (#10166)
* Add support for APC PDU outlet state sensors

* Update tests
2019-05-01 09:09:36 +01:00
CirnoT
97005c0b57 Fixed state sensors on global Health table always displayed as 'OK' (#10171) 2019-04-30 22:49:53 +02:00
h-barnhart
36134fd30f Adva port label uses ifname (#10165) 2019-04-30 19:05:54 +02:00
Tony Murray
f2b6aaeb11 Fix transition os (#10169) 2019-04-30 09:18:18 -05:00
JoshWeepie
4e62838cce Add support for Transition NIDs (#9729)
* Add support for Transition NIDs

* Upload Transition logo

* Create transition

* Add files via upload

* Add files via upload

* Delete transition

* Delete MEF-UNI-MIB.smi

* Delete PTP-MIB.smi

* Delete BRIDGE-MIB.smi

* Delete ENTITY-STATE-TC-MIB.smi

removed standard mibs

* remove extensions from mibs

* Create TN-AC-MIB

* Removed extensions from Transition MIBs

* Delete TN-AC-MIB

* Create transition.snmprec

Added test data

* Renamed some mibs + updated tests

* Update transition.json
2019-04-29 22:14:46 -05:00
PipoCanaja
30537361db LLDP Discovery by IP (#10130)
* add ip polling on LLDP devices

* ipv6 support

* formatting

* codeclimate
2019-04-29 21:56:03 -05:00
CirnoT
fb32536189 Serial number and more robust OS version for Netgear switches (#10164)
* Serial number and more robust OS version for Netgear switches

* Update netgear.inc.php

* Update netgear.inc.php
2019-04-29 22:24:20 +02:00
Vitali Kari
df2e80544c Extended sensors for Timos devices (#10160)
* additional sensors for timos
change to yaml discovery for sensors
remove obsolete tmnxChassisPowerSupplyTable

* inconsistent data in snmpsim

* fix snmpsim data

* fix snmpsim data

* fix snmpsim data
2019-04-29 20:48:37 +02:00
CirnoT
33a51bc592 Store IPv4 networks as network address and fix address search page showing networks not addresses (#10144)
* Store IPv4 networks as network address, not device address

* Properly display addresses, not networks on address search page
2019-04-29 11:52:32 -05:00
Spencer Butler
9cfa2aaf40 Added support for Zmtel greenpacket devices (os: zmtel) (#10067)
* Added support for Zmtel greenpacket devices (os: zmtel)

* added more sensors

* move count sensors to features

* rename MIB and move modulation scheme to state sensor

* added test data

* graph pCID
2019-04-29 09:53:35 -05:00
PipoCanaja
bfa7537d83 Get and display the image patch version on Huawei VRP devices (#10099)
* Try to find the patch applied to this device

* tests all
2019-04-29 09:50:40 -05:00
PipoCanaja
a3263b802b Added packetlight support (#10131)
* MIBS

* logos
sensors
user_func
cleaning

* tests

* Switch to Packetlight class, and use is_callable instead of function_exists

* tests

* CodeClimate

* Rename functions
2019-04-29 09:46:53 -05:00
CirnoT
a7ef43359f Fix services with scripts inheriting DS from previous service on detail view (#10142)
Ensures check_ds variable is always null on each run of loop that displays services graphs. Fixes services that have script (like check_dns) but don't set check_dns on their own inheriting check_dns from previous service that ran (for example check_icmp) and displaying additional bogus graphs as result.
2019-04-28 10:27:36 +02:00
VVelox
7609253a13 Setting font colors for RRD graphs is now possible (#10083)
* easily setting font colors for RRD graphs is now possible

* add a comment explaining the variable
2019-04-28 10:19:35 +02:00
CirnoT
df2930b671 Fixed filter by device and interface type on IP address search page (#10143) 2019-04-28 10:04:56 +02:00
kmpanilla
35b91e9d22 Updated Planetos support for additional models (#10149)
Add basic support for the IGS-10080MFT and IGS-10020MT (and probably other IGS-*) models.
2019-04-28 09:56:53 +02:00
CirnoT
272fabd8fc Added memory pool for Netgear switches (#10146) 2019-04-27 23:11:04 +02:00
CirnoT
b102cedc5c Added PSU state to Netgear discovery definition (#10150)
* Add PSU state to Netgear discovery definition

* Add tests for Netgear PSU
2019-04-27 20:06:22 +02:00
Martijn Schmidt
af5377e06c Handle health sensors with underscores in the name. (#10123) 2019-04-27 17:10:31 +02:00
pobradovic08
b8c4f38fb5 Added session graphs for Barracuda NGFW (#10102)
* devices: Corrected discovery object ID for Barracuda NGFW; Added fw session graphs
* device: Added test data
2019-04-27 15:33:55 +02:00
djamp42
ae1b5bbfc1 Allowed Add_Device API to set sysName (#10124)
sysName is a valid option via the WebGUI to set when SNMP is turned off. Currently you cannot set this via the API add device. This is to enable setting the sysName via the API.
2019-04-27 09:15:59 +02:00
Tony Murray
0a12ede577 Fixed api *log date format (#10133)
fixes #10089
2019-04-23 15:26:50 +02:00
Tony Murray
6e6e54cb98 New User Management (#9348)
* Rewrite user management.

Error management

Revert edituser legacy page

Connect user permissions button to legacy page for now.

Implement user creation
Refine form

Remove PingCheck.php accidental add :)

Fixes for redirection and deletion

More fixes: realname accidental validation setting, hide can modify for read-only auths

Use a panel to improve style

Add icon to panel-title

Not allowed to delete own user (at least via the click of a button)

Use request validation to reduce complexity of controller.
Improve protection against users doing things they should not.

Switch to horizontal form and not nearly as wide of layout :)

delete without refresh.
Fix for buttons

Include all users (not just from this auth)
Hide the auth column if there is only one auth type

Show username if real name isn't set

Don't allow creation of demo users via the webui

a fix to the lnms user:add command, it didn't set auth_id

update edituser.inc.php to current
just redirect to users page

* Remove TwoFactorTest for now

* Update edituser.inc.php

* Update .env.dusk.testing

* Enable 2fa for 2fa test...
2019-04-22 19:01:39 -05:00
Tony Murray
d901d308d2 fix call to isUnderMaintenance() on null (#10090)
Not sure how people managed to trigger that one...
2019-04-18 10:14:17 -05:00
PipoCanaja
a08b8333cc Bug - Nasty user_func vs divisor-multiplier issue (#10122)
* Nasty user_func vs divisor-multiplier issue

* tests
2019-04-17 20:15:31 -05:00
PipoCanaja
5b6bf35d7a Display number of connections for ASA on over (#10106) 2019-04-17 08:14:45 +02:00
Derek Johnson
d069d0fd46 Disable snmpbulkwalk for cyberpower os (#10109) 2019-04-15 20:00:10 +02:00
Spencer Butler
c76115bf46 Added support dellNet devices (#10016)
* Added support DELL-NETWORKING-PRODUCTS-MIB (os: dell-net)

* dell-net - created mempool, removed flash (not enough data points)

* dell-net - updated yaml sysObjectIDs

* dell-net - added sensors, fixed sensors

* clean up

* dell-net added Tx/Rx indicators

* dell-net - regroup Lanes

* dell-net remove Lane quotes, removed random files

* dell-net - updated Model description per requester

* added rules to ignore 0 values

* restricted discovery match

* merge dellNet into os: dnos

* typo

* remove dell-net test files
2019-04-12 00:49:35 -05:00
Tony Murray
36431dd296 Security fix: unauthorized access (#10091)
* Security fix: unauthorized access
Affects nginx users:
Moved php files outside of public html directory (Apache was protected by .htaccess)

Affects all users:
Some files did not check for authentication and could disclose some info.
Better checks before including files from user input

* git mv html/includes/ includes/html
git mv html/pages/ includes/html/
2019-04-11 23:26:42 -05:00
Slushnas
b81af32ed2 Fixed display minimum values in uptime graphs. (#10078)
Fixes an issue with several uptime graphs using the average value when it should be using the minimum value.

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-11 23:05:18 +01:00
PipoCanaja
36e709ebab Improved Linksys support, including POE (#10075)
Fixes #9718 

This PR adds POE graphs, even if not all the values that are polled on other OSes are available on this one.  

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 10075`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 20:32:57 +01:00
PipoCanaja
5697d24869 Added Cisco Small business bootloader + HW version (#10043)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 20:03:07 +01:00
Neil Lathwood
0a7b0d4086 Added detection for ESW 5xx series of Cisco SB devices (#10077)
* Added detection for ESW 5xx series of Cisco SB devices

* Added test files

* Fixed the regex

* Updated definitions

* Final fix hopefully
2019-04-09 18:45:43 +02:00
Tim de Boer
91ca7b37fe Refactored Nvidia Application (#10037)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 14:47:43 +01:00
PipoCanaja
780ee36b10 Updated support for adva_fsp150 devices (#10049)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 13:59:08 +01:00
Alexander Tsyganov
943dbe4ff1 Updated RegEx string for correct definitions for Proxmox 4.x nodes (#10048) 2019-04-09 13:55:50 +01:00
PipoCanaja
e285a9268e Improve Huawei BGP polling + BGP webui & graphs patches (#10010)
* basic adress family for VRP

* Improve BGP prefixes display

* Improve BGP prefixes display

* Improve BGP prefixes display

* climate
2019-04-09 13:44:48 +01:00
tomarch
e7ba1b195f Added initial support for teltonika (#10059)
* initial support for teltonika
* fix sensors
* fix mibs name
* add rutos.json
* Update rutos.json
2019-04-08 08:54:17 +02:00
Spencer Butler
47e0ee1d04 Added support for Liebert PDUs (#10062)
* Added support for Liebert PDUs
2019-04-07 21:19:08 +02:00
Spencer Butler
e1df2a3dd9 Added support for TP-LINK T1600G-52TS (#9983)
* Normalizing support for TP-Link Jetstream switches

* WIP - playing with MIB Modules

* removed comments

* reset discovery yaml
2019-04-07 08:55:52 -05:00
Timothy Willey
adaf08b1bf fix aruba-controller polling (#10071) 2019-04-07 08:26:55 -05:00
Tony Murray
1b46d87b0a Fix fail2ban jails eventlog spam (#10066)
The previous sort preserved keys, which we don't want
2019-04-03 21:49:15 -05:00
Tony Murray
c305d2b520 Fixed fail2ban jails eventlog spam (#10061)
Sort the jails before saving so it always matches.
Not sure why it would be different order, but this fixes the spam in any case.
2019-04-03 23:21:27 +01:00
djamp42
c1fab98cc3 Added device WISI Tangram (#10039)
* Added device WISI Tangram
2019-04-03 06:43:39 +02:00