Commit Graph

301 Commits

Author SHA1 Message Date
dupondje
4611b19ae5 Fix Rancid GIT (#11795) 2020-06-09 09:01:44 -05:00
Tony Murray
28ee0f1823 fix typo (#11798) 2020-06-09 08:05:04 -05:00
cjwbath
aa51e46350 Don't call clean() on the inputs to the SNMP settings form (#11709)
* Don't call clean() on the inputs to the SNMP settings form, it'll call
strip_tags() and break values with angle brackets in.

* Call htmlspecialchars when outputting DB values to HTML instead

* Escape other stuff that should have been validated elsewhere, just in case
2020-06-08 08:16:40 -05:00
SourceDoctor
7b93b386a3 Alert Template - sort Alert Rules alphabetic (#11786) 2020-06-07 14:46:33 +02:00
SourceDoctor
9836aab818 Show full description text on Asterisk RRDs (#11742) 2020-06-04 23:14:15 -05:00
SourceDoctor
4977394a1e Fixing API Creation Error Message (#11745) 2020-05-30 18:26:02 -05:00
PelliX
5f3b82de6f Added discovery and graphing for JunOS (SRX) RPM probes (#11187)
* Added discovery and graphing for JunOS (SRX) RPM probes

* Proposed changes for a percent based sensor type

* Fixed missing MIB declaration in JunOS YAML discovery file

* Updated Health-information.md to reflect the new percentage value type

* Added separate test data for junos_rpm type

* Update sensors.php

* Update sensors.php

* Update functions.inc.php

* test re-run

* Update junos_rpm.json

* percentage -> loss

* add ifSpeed prev test data

* mis-merge

* update sensors

* and bgp...

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-30 18:24:43 -05:00
SourceDoctor
6b7b143cbb Show full description text on MySQL RRDs (#11738)
* Show full description text on MySQL Connections

* further adjustments
2020-05-30 11:46:58 -05:00
hachpai
4bb064c7ad Enabling general search for ports, devices, and more (#11571)
* Search engine for device, through API

* reviewed port search through API

* fixed die

* Update api_functions.inc.php

* Update api_functions.inc.php

* Update api_functions.inc.php

* Update api_functions.inc.php

* Update api.php

* Update api.php

* Update Ports.md

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-24 17:16:07 -05:00
SourceDoctor
5927983c50 Maintenance Mode via Device Settings (#11649) 2020-05-22 15:14:03 +02:00
Facundo Caselles
2f86c66afa WebUI - Improved "dark" theme (#11417)
* -Real dark mode, (themed bootstrap)
-removed inverted colors in navbar

* Test data

* FIX: navbar in mono theme.

* Dark mode rrdtool

* Changed background on gridster to match background of the dark theme

* - Icons and links now are grey
- Modernized tabs style into pills,
- button pagemenu-selected fixed

* Improvements:
- bootgrid-th, are now visible (dark mode to the table headings)
- Changed line color of poller and ping in rrdtool

* Fix some codeclimate errors

* Fix airos.snmprec, reverted to original file
2020-05-21 19:04:54 -05:00
SourceDoctor
b41d262537 Application State Icons (#11630) 2020-05-19 19:21:02 -05:00
Tony Murray
d5a52ca4eb Fix various issues with loading os definitions (#11640)
* Ping only device doesn't display
if os was set to something, ping os wasn't loaded and we try to get overview graphs from it.

* Fix snmp_disable device page load error
When other os is set.

* Revamp os setting loading
the only safe way to access is Config::getOsSetting()

* Remove getOsSetting fallback behavior
Most instances don't use it and it can have unexpected results Config::getOsSetting('blah', 'group') == 'librenms'

* refactor and remove unneeded load_os/loadOs calls now since getOsSetting automatically loads it.

* restore unix overview graphs, they are different
small cleanups

* fix
2020-05-19 14:35:32 -05:00
SourceDoctor
4edff1e88a Application - Redis (#11612)
* Application - Redis

* Travis fix
2020-05-15 22:05:40 +02:00
SourceDoctor
17698a36f0 Natural Sort Applications by Display Name (#11577)
* Natural Sort Applications by Display Name

* some optimizations

* .
2020-05-15 18:32:09 +02:00
SourceDoctor
e305a39d31 Sort Health table alphabetic (#11586) 2020-05-12 15:51:30 -05:00
Lars Elgtvedt Susaas
aca95b5554 bugfix: addhost (web) snmp v3 not used first (#11536)
* Update addhost.inc.php

bugfix: push snmp v3 user settings to the front of the config array and not the back.

To reproduce the bug:
Force add new snmp v3 device.
The v3 settings added to the database will not be the same as entered in the webpage

* Update addhost.inc.php

Minor change in order to trigger travis build
2020-05-12 15:49:39 -05:00
louis-oui
c9155bf5ea disable auto-refresh for notifications and alert history (#11589) 2020-05-11 23:07:14 +02:00
SourceDoctor
38abff264a Show Hardware Details on Network Adapters in Inventory (#11545) 2020-05-11 20:28:42 +02:00
SourceDoctor
8d3f39743a Application DisplayName in Overview Hover (#11576) 2020-05-09 20:34:14 +02:00
Vitali Kari
918cf86eae Add acknowledgment notes to eventlog (#11575) 2020-05-09 20:33:50 +02:00
ospfbgp
05f3314061 Fix display of device modules (#11543) 2020-05-06 09:09:14 -05:00
SourceDoctor
d1f20bb045 Correct OS Overlib in Inventory (#11551) 2020-05-04 18:59:44 -05:00
Tony Murray
070cbc8d8e Fix apps overview link (#11535)
* Fix apps overview link
(easy way)

* more modern url
2020-05-03 12:57:51 +02:00
Arjit Chaudhary
7f8b660c05 Update Table UI (#11529)
* Update Cisco Meraki logo

* Update table UI

* Revert "Merge branch 'master' of https://github.com/arjitc/librenms"

This reverts commit 05e52d51c3, reversing
changes made to a48207d78f.

* Update sensors-common.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-02 17:52:17 -05:00
Vitali Kari
1108f7d530 MPLS updates and bugfixing (#11468)
* MPLS updates and bugfixing

* Tests

* tests

* code climate, tests

* tests

* tests

* remove nokiaIfName(), fetch ifName from the database instead

* restore from messed rebase

* tests

* btw, fix travis about the missing docs

* tests

* tests

* clean the messed up test data an generate new for timos

* rebase
2020-05-01 23:05:51 -05:00
Tony Murray
5ac05e9221 Fix new bill search input (#11524)
* Work around select2 in a modal

* Update select2
2020-05-01 21:49:36 -05:00
SourceDoctor
d941fbe91b Adjust RRDCached Event Graph Adjustment (#11528) 2020-05-01 21:46:58 -05:00
Arjit Chaudhary
08a8f082ce sync bootstrapSwitch style with the other tabs (offColor danger) (#11513) 2020-05-01 14:13:31 +02:00
Arjit Chaudhary
e23329aa30 Limit port, seconds, retries, max repeats and max OIDs to numeric type (#11512) 2020-05-01 01:54:18 +02:00
Arjit Chaudhary
5eef90b9ad put all the stats into the optionbar (#11501)
* put all the stats into the optionbar

* display output in 1 line
2020-05-01 01:30:33 +02:00
Tony Murray
055abcf443 Device page dropdown hero button, Performance -> Latency (#11328)
* Throw some shit together, rough outline.

* Reorganize tabs, use tab controllers

* Implement performance (into the latency tab)

* Update resources/views/device/header.blade.php

Co-Authored-By: Jellyfrog <Jellyfrog@users.noreply.github.com>

* Add more tabs

* All controllers created

* Implement routes

* Implement smokeping

* routing and auth

* fix smokeping check

* Implement device dropdown menu

* Update deviceUrl to new style

* Use Gates

* Fix style

* use more appropriate gates

* add show-config gate
remove Laravel helper

* Only show vlan tab if VLANs exist for the device :D

* Fix rancid file check will return false

* revert over-zealous file name changes

* don't need to request the location parameter, just cast to string to avoid bugs when not found

* Move latency tab (ping/performance) to the position of performance instead of ping.

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2020-04-29 07:25:13 -05:00
SourceDoctor
e28b86a295 Fix - Show OS specific mouseover (#11457) 2020-04-26 13:11:13 +02:00
Hans Erasmus
aa68be59a2 Fixed a small typo (#11487) 2020-04-26 12:52:43 +02:00
Johan "Zwixxel" Zaxmy
7bfc2f9f57 Fixes evaluation order so unathenticated access works (#11485) 2020-04-26 12:45:31 +02:00
Mathieu Poussin
fc391090e1 BGP Polling: Add error code management (#11424)
* BGP Polling: Add error code polling

* Rework describe_bgp_error_code and fix bgp error fields migration

* Add real test data for IOS-XR and Arista EOS
2020-04-24 22:47:20 -05:00
Tony Murray
52e1187314 Fix two more jpgraph (#11448)
* missed one jpgraph string

* missed one jpgraph string
2020-04-20 15:32:11 -05:00
Tony Murray
22dd4333d0 missed one jpgraph string (#11447) 2020-04-20 15:25:36 -05:00
SourceDoctor
d1bdbe2125 Alert rule in, not_in remove (#11437)
* Global Settings - Alert Default Settings

* Revert "Global Settings - Alert Default Settings"

This reverts commit a1af62b146.

* remove in, not_in cause of non functional
2020-04-19 12:23:44 +02:00
Tony Murray
1c08c11a77 Remove Laravel helpers (#11428)
* Remove Laravel helpers

* Replace qualifier with import
2020-04-18 00:37:56 +02:00
Tony Murray
e4b49f59f6 Delete ports via eloquent event (#11354)
* Delete ports via eloquent event
Chunk delete during purge all operations so we don't use too much memory.

* protect against missing device

* fix whitespace

* fetch less from the database when deleting a device's ports
fix output
2020-04-16 09:19:58 -05:00
Tony Murray
e2eea17ee8 Work around jpgraph bug (#11425)
apparently GD now returns false when getting the bounding box of empty strings, this causes jpgraph to throw an incorrect error.  Work around that by setting all possible text to a single space character.
2020-04-16 09:18:44 -05:00
Arjit Chaudhary
7dfc2263e5 Prevent breaking of interface name into 2 words/parts (#11420) 2020-04-14 21:46:20 +02:00
Tom van Leeuwen
4a6a0af489 honoring config option force_ip_to_sysname in bill creation and editing (#10382)
* honoring config option `force_ip_to_sysname` in bill creation and editing

* refactored variable name to match it in edit.inc.php

* forgot one variable

* and one more :S

* Update new_bill.inc.php

* Update edit.inc.php

* Update new_bill.inc.php

* Update edit.inc.php

* Update edit.inc.php

* Update edit.inc.php

Co-authored-by: Neil Lathwood <gh+n@laf.io>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-04-11 19:10:45 -05:00
Mathieu Poussin
909035b180 BGP API: fix search by ipv6 when using compressed addresses (#11394)
* BGP API: fix search by ipv6
* BGP API: Add error when giving a wrong IP as parameter
2020-04-12 01:11:57 +02:00
Tony Murray
76e58b6cb2 Clarify that you can use IP or hostname to add device (#11393)
Remove overwrite IP when adding devices, it is very rare this should be used and the setting is misleading.
2020-04-09 23:39:37 +02:00
Mathieu Poussin
29748fe306 BGP API: Allow to filter by local and remote peer address. (#11340) 2020-04-05 17:16:16 +02:00
Tony Murray
217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
Tony Murray
7d2a1ae799 Display custom types as in the config file (with ucwords) (#11367)
* Display custom types as in the config file (with ucwords)

* filter same line
2020-04-02 23:38:38 +02:00
Jellyfrog
69280b3501 Fix dashboard html escaping and javascript redirect (#11370) 2020-04-02 23:33:18 +02:00