* Don't call clean() on the inputs to the SNMP settings form, it'll call
strip_tags() and break values with angle brackets in.
* Call htmlspecialchars when outputting DB values to HTML instead
* Escape other stuff that should have been validated elsewhere, just in case
* Added discovery and graphing for JunOS (SRX) RPM probes
* Proposed changes for a percent based sensor type
* Fixed missing MIB declaration in JunOS YAML discovery file
* Updated Health-information.md to reflect the new percentage value type
* Added separate test data for junos_rpm type
* Update sensors.php
* Update sensors.php
* Update functions.inc.php
* test re-run
* Update junos_rpm.json
* percentage -> loss
* add ifSpeed prev test data
* mis-merge
* update sensors
* and bgp...
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
* MPLS updates and bugfixing
* Tests
* tests
* code climate, tests
* tests
* tests
* remove nokiaIfName(), fetch ifName from the database instead
* restore from messed rebase
* tests
* btw, fix travis about the missing docs
* tests
* tests
* clean the messed up test data an generate new for timos
* rebase
* Throw some shit together, rough outline.
* Reorganize tabs, use tab controllers
* Implement performance (into the latency tab)
* Update resources/views/device/header.blade.php
Co-Authored-By: Jellyfrog <Jellyfrog@users.noreply.github.com>
* Add more tabs
* All controllers created
* Implement routes
* Implement smokeping
* routing and auth
* fix smokeping check
* Implement device dropdown menu
* Update deviceUrl to new style
* Use Gates
* Fix style
* use more appropriate gates
* add show-config gate
remove Laravel helper
* Only show vlan tab if VLANs exist for the device :D
* Fix rancid file check will return false
* revert over-zealous file name changes
* don't need to request the location parameter, just cast to string to avoid bugs when not found
* Move latency tab (ping/performance) to the position of performance instead of ping.
Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
* BGP Polling: Add error code polling
* Rework describe_bgp_error_code and fix bgp error fields migration
* Add real test data for IOS-XR and Arista EOS
* puppet agent monitoring
* change position of last run graph
* device overview panel
* updating documentation
* mouseover for Overview Dashboard
* adding blank line for code climate
* Asterisk app: add IAX2 peer graphs
* It's an entirely new graph and will not break existing graphs.
* The asterisk extend script must be updated to provide the appropriate poller data.
* The PR for librenms-agent/snmp/asterisk is here: https://github.com/librenms/librenms-agent/pull/274
* code climate, round 1
* clarified unit text
* code climate, round 2
* changes needed to properly generate test data
* linux_asterisk-v1 test data
* BUG: From a device page, click Alerts and attempt to ACK or add a Note. Nothing happens because the modals are not on the page.
* This patch corrects pages/device/alert.inc.php to include both modal/alert_notes.inc.php and modal/alert_ack.inc.php
* Fixed device SNMP edit form (and better feedback)
* snmp.inc.php: Fix SNMP Edit form (better feedback)
* The feedback for Max Repeaters and Max OIDs is much better. The constant false errors on save have been corrected. The are no longer applicable and muted when SNMP is turned off. Their feedback now clearly shows the user what has been done.
* Rename & relabel $no_checks as $force_save (Force Save) because that's simpler and more clearly defines what the code is doing when you turn it on.
* Reorder the Force Save checkbox to be right above the Save button so it's even more clear what it does. Force Save and Save are the only elements on the form that do *not* have a database setting. They're ephemeral and now grouped as such.
* Embedded comments about the use of === false as tests for setAttrib() and forgetAttrib()
* snmp.inc.php: code climate updates, round 1
* remove blank lines
* refactor duplicate code blocks
* remove join on string
* move print_messages to the bottom of the form
* snmp.inc.php: code climate, round 2
* avoid deeply nested control flow statements (8)
* snmp.inc.php: when to $force_save and $device_isssnmable
* move $force_save outside of if ($snmp_enabled) so it works properly
when snmp is disabled.
* only check isSNMPable() if snmp is enabled
* snmp.inc.php: move $device_snmp_details
* $device_snmp_details are only needed for isSNMPable(), so only call
them within the same contingency
* snmp.inc.php: cleanup & hardening
* add SNMP Settings header (to better mimic Device Settings, etc)
* use Toastr for feedback, rather than print_message & print_error
* after editing, always unset($_POST) and the other variables used for editing
* unless the save is forced, if !$device_issnpable then don't save *anything* in the database and revert *all* previous form settings (some already were being reverted & some weren't)
* more variables were ordered alphabetically, unused variables were and removed
* for snmpver, don't use .toggle(); use .hide() & .show() so the form reverts properly when it fails
* snmp.inc.php: clarify placeholder for max repeaters
* snmp.inc.php: code climate, round 3
* correct blank line found at the end of control structure (2)
* correct space before opening parenthesis of a function call prohibited (3)
* extend FS switches support
* MIB compilation
* HW and Ver
* sensors and CPU
* tests
* correct version
* try to handle properly "down" as not up, for OperStat like lowerLayerDown
* try to handle properly "down" as not up, for OperStat like lowerLayerDown
* try to handle properly "down" as not up, for OperStat like lowerLayerDown
* try to replace "down" with "not up" :)
* fix other ifOperStatus checks
* Fix disable notify
* Fix disable notify
* Disable all alerting
* fix db migration
* fix db migration
* fix db migration
* Add autoclearing active alerts if disable alerting set
* Add autoclearing active alerts if disable alerting set
* fix check
* Device in gray if disable_notify is set - not ignore tag
* update nokia mibs
* database migrations
* add code
* html code
* update db schema
* add test data
* add FIXME
* move mibs/nokia/MPLS-TE-MIB to mibs/MPLS-TE-MIB
* Protocol filter for Routing Table View
* change protocol selector to listbox
* fix for issue with orWhere in RouteTablesController search
* renaming function updateTable()
The NVIDIA application obtains its metrics from nvidia-smi dmon. Its built-in help (nvidia-smi dmon --help) says that the pviol and tviol columns stand for "Power and Thermal Violations". Therefore the metric should not be called Thermal Violation Percentage, but Power Violation Percentage.
* Clean broken VRF lite code
* Change DB table for route discovery
* Add VRF simple support
* add port_id to db and discovery
* static-fy the translation arrays
* sort and search cleaning
* Sorting refactor and validation
* formatItem shortened
* Handle ifIndex==0 meaning no next hop defined (MPLS)
* Sync all create/updates
* purge in daily
* remove old route table
* get rid of inetCidrRouteNextHop_device_id
* fix wonky column orders
* add route snmprec
* fix sorting by interface
* Move to new config
* rename to route the new table
* Properly display ipv6 compressed addresses
* Translation before merge ./lnms translation:generate
* Update manifest
* Device Cache
also some additional device related models
* attribs from cache
* replace common attribute functions
* remove legacy cache usage
tidy up some collection manipulation
remove some unused or single use functions
* cleanup some items
* always return a device, to prevent bugs
* clear device cache when testing after each test
* fix double assignment
* Clean up function to take advantage of null object
* Corrected filtering of devices under maintenance
* Clarify wording of disable/alert device settings and dependency between the two settings
* Disable "Ignore alerts" checkbox according to initial setting of "Disable polling"
* Correct initial enabling/disabling of 'Ignore alerts'
* Remove not functional js code