Commit Graph

294 Commits

Author SHA1 Message Date
dupondje
4611b19ae5 Fix Rancid GIT (#11795) 2020-06-09 09:01:44 -05:00
Tony Murray
28ee0f1823 fix typo (#11798) 2020-06-09 08:05:04 -05:00
SourceDoctor
1093315700 Merge branch 'master' into app_dhcp_enhancement 2020-06-08 20:51:41 +02:00
cjwbath
aa51e46350 Don't call clean() on the inputs to the SNMP settings form (#11709)
* Don't call clean() on the inputs to the SNMP settings form, it'll call
strip_tags() and break values with angle brackets in.

* Call htmlspecialchars when outputting DB values to HTML instead

* Escape other stuff that should have been validated elsewhere, just in case
2020-06-08 08:16:40 -05:00
PelliX
5f3b82de6f Added discovery and graphing for JunOS (SRX) RPM probes (#11187)
* Added discovery and graphing for JunOS (SRX) RPM probes

* Proposed changes for a percent based sensor type

* Fixed missing MIB declaration in JunOS YAML discovery file

* Updated Health-information.md to reflect the new percentage value type

* Added separate test data for junos_rpm type

* Update sensors.php

* Update sensors.php

* Update functions.inc.php

* test re-run

* Update junos_rpm.json

* percentage -> loss

* add ifSpeed prev test data

* mis-merge

* update sensors

* and bgp...

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-30 18:24:43 -05:00
Yacine BENAMSILI
1a152edc67 feature: F5 LTM bandwidth controller 2020-05-29 03:00:42 +02:00
Yacine BENAMSILI
fa52264de2 Fix: F5 LTM bandwidth controller 2020-05-28 23:15:35 +02:00
SourceDoctor
cbe572f959 Application DHCP Upgrade 2020-05-22 23:02:19 +02:00
SourceDoctor
5927983c50 Maintenance Mode via Device Settings (#11649) 2020-05-22 15:14:03 +02:00
SourceDoctor
b41d262537 Application State Icons (#11630) 2020-05-19 19:21:02 -05:00
SourceDoctor
4edff1e88a Application - Redis (#11612)
* Application - Redis

* Travis fix
2020-05-15 22:05:40 +02:00
SourceDoctor
17698a36f0 Natural Sort Applications by Display Name (#11577)
* Natural Sort Applications by Display Name

* some optimizations

* .
2020-05-15 18:32:09 +02:00
SourceDoctor
e305a39d31 Sort Health table alphabetic (#11586) 2020-05-12 15:51:30 -05:00
SourceDoctor
38abff264a Show Hardware Details on Network Adapters in Inventory (#11545) 2020-05-11 20:28:42 +02:00
ospfbgp
05f3314061 Fix display of device modules (#11543) 2020-05-06 09:09:14 -05:00
Arjit Chaudhary
7f8b660c05 Update Table UI (#11529)
* Update Cisco Meraki logo

* Update table UI

* Revert "Merge branch 'master' of https://github.com/arjitc/librenms"

This reverts commit 05e52d51c3, reversing
changes made to a48207d78f.

* Update sensors-common.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-02 17:52:17 -05:00
Vitali Kari
1108f7d530 MPLS updates and bugfixing (#11468)
* MPLS updates and bugfixing

* Tests

* tests

* code climate, tests

* tests

* tests

* remove nokiaIfName(), fetch ifName from the database instead

* restore from messed rebase

* tests

* btw, fix travis about the missing docs

* tests

* tests

* clean the messed up test data an generate new for timos

* rebase
2020-05-01 23:05:51 -05:00
Arjit Chaudhary
08a8f082ce sync bootstrapSwitch style with the other tabs (offColor danger) (#11513) 2020-05-01 14:13:31 +02:00
Arjit Chaudhary
e23329aa30 Limit port, seconds, retries, max repeats and max OIDs to numeric type (#11512) 2020-05-01 01:54:18 +02:00
Arjit Chaudhary
5eef90b9ad put all the stats into the optionbar (#11501)
* put all the stats into the optionbar

* display output in 1 line
2020-05-01 01:30:33 +02:00
Tony Murray
055abcf443 Device page dropdown hero button, Performance -> Latency (#11328)
* Throw some shit together, rough outline.

* Reorganize tabs, use tab controllers

* Implement performance (into the latency tab)

* Update resources/views/device/header.blade.php

Co-Authored-By: Jellyfrog <Jellyfrog@users.noreply.github.com>

* Add more tabs

* All controllers created

* Implement routes

* Implement smokeping

* routing and auth

* fix smokeping check

* Implement device dropdown menu

* Update deviceUrl to new style

* Use Gates

* Fix style

* use more appropriate gates

* add show-config gate
remove Laravel helper

* Only show vlan tab if VLANs exist for the device :D

* Fix rancid file check will return false

* revert over-zealous file name changes

* don't need to request the location parameter, just cast to string to avoid bugs when not found

* Move latency tab (ping/performance) to the position of performance instead of ping.

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2020-04-29 07:25:13 -05:00
Mathieu Poussin
fc391090e1 BGP Polling: Add error code management (#11424)
* BGP Polling: Add error code polling

* Rework describe_bgp_error_code and fix bgp error fields migration

* Add real test data for IOS-XR and Arista EOS
2020-04-24 22:47:20 -05:00
Tony Murray
217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
crcro
2ee2862357 app: mailcow-dockerized postfix stats (#11058)
* app-mailcow-dockerized-postfix

* fix docs

* updated niceCase

* test-data

* snmprec upload

* new test data

* new test data
2020-03-13 10:16:03 +01:00
SourceDoctor
2cfc7c6f14 Extended unbound monitoring (#11255) 2020-03-05 11:35:23 +01:00
Joseph Tingiris
481363194d Add Size column to edit Storage Settings table (#11164)
* add storage_size

* capitalize Settings to match Device Settings, SNMP Settings, etc.
2020-02-18 22:13:41 +01:00
SourceDoctor
3838d8e41f equalize default Poller Group Naming (#11156) 2020-02-18 13:26:12 +01:00
SourceDoctor
53dc564ef5 Puppet Agent Monitoring (#10827)
* puppet agent monitoring

* change position of last run graph

* device overview panel

* updating documentation

* mouseover for Overview Dashboard

* adding blank line for code climate
2020-02-12 08:26:02 +01:00
Joseph Tingiris
02bc15c206 Asterisk app: add IAX2 peer graphs (#11078)
* Asterisk app: add IAX2 peer graphs

* It's an entirely new graph and will not break existing graphs.
* The asterisk extend script must be updated to provide the appropriate poller data.
* The PR for librenms-agent/snmp/asterisk is here: https://github.com/librenms/librenms-agent/pull/274

* code climate, round 1

* clarified unit text

* code climate, round 2

* changes needed to properly generate test data

* linux_asterisk-v1 test data
2020-02-03 18:47:27 +01:00
SourceDoctor
7950893cd1 Alternate Poller IP instead of Hostname (#10981)
* optional alternative poller ip

* add missing schema update

* .

* enhance API Call 'add_device' with overwrite_ip key

* .

* .

* updating docs
2020-01-30 06:20:30 -06:00
Joseph Tingiris
3f53eed245 alert.inc.php: Fix missing ACK & Notes modals (#11076)
* BUG: From a device page, click Alerts and attempt to ACK or add a Note.  Nothing happens because the modals are not on the page.
* This patch corrects pages/device/alert.inc.php to include both modal/alert_notes.inc.php and modal/alert_ack.inc.php
2020-01-27 20:02:28 -06:00
SourceDoctor
e33518ada1 Change Poller Group on Device Settings (#11071)
* change Poller Group on Device

* code climate fix
2020-01-27 06:19:14 -06:00
Joseph Tingiris
817cf42896 Fixed device SNMP edit form (and better feedback) (#11068)
* Fixed device SNMP edit form (and better feedback)

* snmp.inc.php: Fix SNMP Edit form (better feedback)
* The feedback for Max Repeaters and Max OIDs is much better.  The constant false errors on save have been corrected.  The are no longer applicable and muted when SNMP is turned off. Their feedback now clearly shows the user what has been done.
* Rename & relabel $no_checks as $force_save (Force Save) because that's simpler and more clearly defines what the code is doing when you turn it on.
* Reorder the Force Save checkbox to be right above the Save button so it's even more clear what it does.  Force Save and Save are the only elements on the form that do *not* have a database setting.  They're ephemeral and now grouped as such.
* Embedded comments about the use of === false as tests for setAttrib() and forgetAttrib()

* snmp.inc.php: code climate updates, round 1

* remove blank lines
* refactor duplicate code blocks
* remove join on string
* move print_messages to the bottom of the form

* snmp.inc.php: code climate, round 2

* avoid deeply nested control flow statements (8)

* snmp.inc.php: when to $force_save and $device_isssnmable

* move $force_save outside of if ($snmp_enabled) so it works properly
when snmp is disabled.
* only check isSNMPable() if snmp is enabled

* snmp.inc.php: move $device_snmp_details

* $device_snmp_details are only needed for isSNMPable(), so only call
them within the same contingency

* snmp.inc.php: cleanup & hardening

* add SNMP Settings header (to better mimic Device Settings, etc)
* use Toastr for feedback, rather than print_message & print_error
* after editing, always unset($_POST) and the other variables used for editing
* unless the save is forced, if !$device_issnpable then don't save *anything* in the database and revert *all* previous form settings (some already were being reverted & some weren't)
* more variables were ordered alphabetically, unused variables were and removed
* for snmpver, don't use .toggle(); use .hide() & .show() so the form reverts properly when it fails

* snmp.inc.php: clarify placeholder for max repeaters

* snmp.inc.php: code climate, round 3

* correct blank line found at the end of control structure (2)
* correct space before opening parenthesis of a function call prohibited (3)
2020-01-26 08:04:00 -06:00
SourceDoctor
5f3ad6465e Renice Device Module Naming like in global Settings (#11061) 2020-01-24 08:58:34 -06:00
SourceDoctor
6ffde9ce2d PureFTPd Application (#11048)
* PureFTPd Application

* graphing connected Users
2020-01-21 18:50:11 -06:00
PipoCanaja
ee8297df19 Extend FS switches support, handle lowerLayerDown ifOperStatus (#10904)
* extend FS switches support

* MIB compilation

* HW and Ver

* sensors and CPU

* tests

* correct version

* try to handle properly "down" as not up, for OperStat like lowerLayerDown

* try to handle properly "down" as not up, for OperStat like lowerLayerDown

* try to handle properly "down" as not up, for OperStat like lowerLayerDown

* try to replace "down" with "not up" :)

* fix other ifOperStatus checks
2020-01-15 08:28:36 -06:00
louis-oui
0e3c472018 "Disable alerting" on device disables alert rules check (not just alert transport) (#11015)
* Fix disable notify

* Fix disable notify

* Disable all alerting

* fix db migration

* fix db migration

* fix db migration

* Add autoclearing active alerts if disable alerting set

* Add autoclearing active alerts if disable alerting set

* fix check

* Device in gray if disable_notify is set - not ignore tag
2020-01-09 18:46:52 -06:00
louis-oui
063145ebf8 Clarify doc and webui for ignore tag on devices, ports, components and services (#11016) 2020-01-09 16:55:09 -06:00
louis-oui
c03c281b6c Clarify disable, ignore and disable all alerts in device edit section (#11011)
* Clarify disable, ignore tag and disable all alerts in device edit section

* remove alert settings section

* fix device attribs

* update doc

* update doc

* fix checks
2020-01-09 06:07:29 -06:00
Vitali Kari
532ab1127a Mpls Path Visualization (#10936)
* update nokia mibs

* database migrations

* add code

* html code

* update db schema

* add test data

* add FIXME

* move mibs/nokia/MPLS-TE-MIB to mibs/MPLS-TE-MIB
2020-01-01 23:45:06 +01:00
Dan Langille
c7d4de6e15 Capcity -> Capacity (#10974)
Correct spelling error
2019-12-25 11:06:45 +01:00
louis-oui
82bad5f701 Add alert history in device section (#10972)
* Alert log in device
2019-12-24 17:11:25 +01:00
louis-oui
934260cc75 Feature: Custom OID polling and graphing (#10945)
* merge

* fix db migration

* fix new auth

* fix new auth

* fix new auth

* fix new auth

* fix db schema tests

* fix polling customoid

* fix polling customoid

* fix graph

* fix graph

* fix graph

* fix CI

* fix CI

* always update prev value

* typo
2019-12-18 18:17:21 -06:00
SourceDoctor
e98dd35a9b Protocol filter for Routing Table View (#10933)
* Protocol filter for Routing Table View
* change protocol selector to listbox
* fix for issue with orWhere in RouteTablesController search
* renaming function updateTable()
2019-12-15 22:50:28 +01:00
Jurrian van Iersel
5bf56db50a Stop looping after the file is found, otherwise $config might contain another path then the one where te file is found. This causes problems when $config is used as working directory for fetching changes in git. (#10942)
Also, this is a small performance improvement.
2019-12-14 14:03:58 -06:00
SourceDoctor
175516f5f7 Show Date from last discovery and last poll (#10876)
* show date from last discovery and last poll

* .

* .
2019-12-02 06:15:12 -06:00
István Sárándi
c22fa10636 Fix name of an NVIDIA metric (#10837)
The NVIDIA application obtains its metrics from nvidia-smi dmon. Its built-in help (nvidia-smi dmon --help) says that the pviol and tviol columns stand for "Power and Thermal Violations". Therefore the metric should not be called Thermal Violation Percentage, but Power Violation Percentage.
2019-11-18 15:08:24 +01:00
PipoCanaja
bf181b9dc2 Added support for routing table collection in discovery (#10182)
* Clean broken VRF lite code
* Change DB table for route discovery
* Add VRF simple support
* add port_id to db and discovery
* static-fy the translation arrays
* sort and search cleaning
* Sorting refactor and validation
* formatItem shortened
* Handle ifIndex==0 meaning no next hop defined (MPLS)
* Sync all create/updates
* purge in daily
* remove old route table
* get rid of inetCidrRouteNextHop_device_id
* fix wonky column orders
* add route snmprec
* fix sorting by interface
* Move to new config
* rename to route the new table
* Properly display ipv6 compressed addresses
* Translation before merge ./lnms translation:generate
* Update manifest
2019-11-17 16:30:43 +01:00
Tony Murray
dec9a498ee Updated device cache support (#10795)
* Device Cache
also some additional device related models

* attribs from cache

* replace common attribute functions

* remove legacy cache usage
tidy up some collection manipulation
remove some unused or single use functions

* cleanup some items

* always return a device, to prevent bugs

* clear device cache when testing after each test

* fix double assignment

* Clean up function to take advantage of null object
2019-11-14 21:56:06 +00:00
Gilles Depeyrot
85532b8a58 Clarify wording of disable/alert device settings and dependency between the two settings (#10809)
* Corrected filtering of devices under maintenance

* Clarify wording of disable/alert device settings and dependency between the two settings

* Disable "Ignore alerts" checkbox according to initial setting of "Disable polling"

* Correct initial enabling/disabling of 'Ignore alerts'

* Remove not functional js code
2019-11-14 08:03:23 +01:00