Commit Graph

6487 Commits

Author SHA1 Message Date
Tom van Leeuwen
4a6a0af489 honoring config option force_ip_to_sysname in bill creation and editing (#10382)
* honoring config option `force_ip_to_sysname` in bill creation and editing

* refactored variable name to match it in edit.inc.php

* forgot one variable

* and one more :S

* Update new_bill.inc.php

* Update edit.inc.php

* Update new_bill.inc.php

* Update edit.inc.php

* Update edit.inc.php

* Update edit.inc.php

Co-authored-by: Neil Lathwood <gh+n@laf.io>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-04-11 19:10:45 -05:00
Mathieu Poussin
909035b180 BGP API: fix search by ipv6 when using compressed addresses (#11394)
* BGP API: fix search by ipv6
* BGP API: Add error when giving a wrong IP as parameter
2020-04-12 01:11:57 +02:00
That Guy --^
0e5a6f90ef update definition for devices running VyOS so they're discovered as Unix devices and can have sensors discovered (#11390) 2020-04-11 13:57:00 -05:00
PipoCanaja
e4fdac18e7 Split BGP-Peer for Timos in its own file (#11410)
* timos in its dedicated file

* timos in its dedicated file
2020-04-11 13:56:15 -05:00
Hayden
8993817674 Fix memcached always reporting "ERROR" for app_state (#10739)
* perform json_encode() on memcached app $response data to match update_application() string parameter

* return raw snmp_get result for memcached response data during update_application()
2020-04-11 13:53:28 -05:00
PipoCanaja
ae5da84d57 Typo in F5 serial detection 2020-04-10 20:10:34 +02:00
PipoCanaja
3fb46710a6 Added support for RIEDO data concentrator (#11237)
* Riedo E3Meter DataConcentrator

* Riedo E3Meter DataConcentrator Image

* logos

* name

* Freq + Power

* Power

* Tests + standalone riedo mib

* tests
2020-04-10 13:24:49 +02:00
PipoCanaja
ad1c7d0e19 IPv6 support for BGP peers in VRP devices (#11243)
* ipv6 support for BGP routes in VRP devices

* reverse bgpPeers array to allow VRF aware BGP

* codeclimate

* codeclimate

* codeclimate, finally

* Split VRP out of bgp-peers for readabilty

* Split VRP out of bgp-peers for readabilty

* tests

* CodeClimate

* improve function description

* improve function description

* v6data

* rebase

* space

* ipv6 support for BGP routes in VRP devices

* reverse bgpPeers array to allow VRF aware BGP

* codeclimate

* codeclimate

* codeclimate, finally

* Split VRP out of bgp-peers for readabilty

* Split VRP out of bgp-peers for readabilty

* tests

* CodeClimate

* improve function description

* improve function description

* v6data

* rebase

* space

* fixed corner case
2020-04-10 13:22:26 +02:00
PipoCanaja
07d4da21ca Add support for Ascom IPBS (#11308)
* ascom support

* tests

* typo

* Correct missing 'mpls' in misc/os_schema.json

* remove mpls for now

* tests

* Update ascom.svg

* Don't disable already disabled modules

As I usually state, not much gain in disabling these here.   Would be better to optimize the modules if you think they take too long on devices that don't have support.

* refactor polling code

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-04-10 13:21:25 +02:00
Tony Murray
76e58b6cb2 Clarify that you can use IP or hostname to add device (#11393)
Remove overwrite IP when adding devices, it is very rare this should be used and the setting is misleading.
2020-04-09 23:39:37 +02:00
SourceDoctor
fc921a143c Cleanup unused code (#11391)
* Global Settings - Alert Default Settings

* Revert "Global Settings - Alert Default Settings"

This reverts commit a1af62b146.

* remove not more used code

* Travis restart
2020-04-08 15:56:44 -05:00
Alexandre L
a4cf77b26b Fix device creation using overwrited ip (#11388)
* Fix device creation using overwrited ip

`deviceArray` was creating a device missing the `overwrite_ip` field, so it was not used by `isSNMPable`

* Fix device creation using overwrited ip

Part 2: Fix using not yet set variable

* Fix device creation using overwrited ip

Part 3: remove double space

* Useless commit to trigger Travis
2020-04-08 11:47:40 +02:00
Martin22
820a98bdcb Added skip values for older devices without temperature sensor support. (#11387) 2020-04-08 09:29:37 +02:00
Mathieu Poussin
29748fe306 BGP API: Allow to filter by local and remote peer address. (#11340) 2020-04-05 17:16:16 +02:00
Martin22
c379fee161 Add support Ray3 (#11374)
* Add support Ray3

* Create ray3.json

* Fixed copyrights, comments and move MIB file.

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-04-05 17:13:22 +02:00
Tony Murray
7688426c85 Fix adsl graphs (#11379)
disable name checking
2020-04-04 07:41:22 -05:00
TFujiwara
49afd24ed6 Patch unix agent (#11312)
* Fixed unix packages and polling

* Update packages.inc.php

* Update unix.inc.php

* Update packages.inc.php

* Update packages.inc.php

code guidelines

Co-authored-by: SourceDoctor <sourcehhdoctor@gmail.com>
2020-04-03 10:37:08 -05:00
Tony Murray
217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
Tony Murray
1445263290 Fix rrd format issues for asterisk and cipsec-tunnels (#11375) 2020-04-03 07:57:37 -05:00
SourceDoctor
83d980515c Rrdcached Socket Check fix (#11372)
* Global Settings - Alert Default Settings

* Revert "Global Settings - Alert Default Settings"

This reverts commit a1af62b146.

* RRDCached Socket Check fix
2020-04-02 20:50:39 -05:00
Tony Murray
7d2a1ae799 Display custom types as in the config file (with ucwords) (#11367)
* Display custom types as in the config file (with ucwords)

* filter same line
2020-04-02 23:38:38 +02:00
Jellyfrog
69280b3501 Fix dashboard html escaping and javascript redirect (#11370) 2020-04-02 23:33:18 +02:00
Hayden
7c770a99d8 Fix 10853 os specific syslocation (#11082)
* added functionality to set sysLocation override in $os.inc.php files

* php styling fixes

* updated docs for location override in $os.inc.php

* patch poweralert.inc.php to use $location override

* added location override for enexus (Eltek)

* update phpdoc for set_device_location()

* converged location code in core.inc.php to use set_device_location()

* added new snmprec test data for enexus os

* Travis test data

* remove enexus_smartpacks2 test data

* Revert "remove enexus_smartpacks2 test data"

This reverts commit 36c8fc7036.

* updated enexus_smartpacks2 test data with generic syslocation

* kick travis CI

* kick travis CI
2020-04-02 23:28:12 +02:00
Hayden
e469d15493 check if lat/long exist for each device with link (#11366) 2020-04-02 10:49:28 +02:00
Jozef Rebjak
ad58cc6db9 Added Support for AirConsole Servers (#11302) 2020-04-01 22:51:36 -05:00
Martin22
df95b771b2 Device: Added IMCO POWER (#11296)
* New device IMCO POWER

* Add other outputower sensors

* Fix description sensor battery voltage

* Fix num_oid load sensors

* Index added

* Added test data

* Fix svg file

* Change image svg to png

* Fix yaml and change image size

* Fix permission .gitignore file

* Fix permission

* Fix state
2020-04-01 20:22:14 +02:00
FingerlessGloves
f34f552c57 OPNsense poller better reporting of Version and Platform (#11350)
* OPNsense better reporting of Version and Platform

OPNsense can now report exact version and platform, if the settings in OPNsense is ticked "Display Verion in OID".

* OPNsense poller change to better type check

OPNsense poller change to better type check on $OIDVersionString, which returns false if not found but contains string if it is.

* Add missing bracket to if statement

Add missing bracket to if statement on $OIDVersionString

* OPNsense poll add required spaces to function call

OPNsense poller add required spaces to function call, for coding style checks to pass.

* OPNsense test data json files

OPNsense test data json files
2020-04-01 20:12:55 +02:00
SourceDoctor
7dfb4ef1df Adding Column ifSpeed_prev, ifHighSpeed_prev to Ports Table (#11348)
* adding Column ifSpeed_prev, ifHighSpeed_prev to Ports table

* grammar fix

* rename migration class

* tests

* .

* .
2020-04-01 10:50:33 +02:00
SourceDoctor
7b8ca66c67 Get configured Rrdcached Socket from config (#11351)
* Global Settings - Alert Default Settings

* Revert "Global Settings - Alert Default Settings"

This reverts commit a1af62b146.

* Get RRDCached Socket from Configuration

* socket check

* misstype fix

* travis fix

* .
2020-03-31 23:16:15 -05:00
Jellyfrog
daf451cef7 Convert overview page to laravel (#10757)
* Convert overview page to laravel

* Convert more pages

* More fixes
2020-03-31 23:03:02 -05:00
ospfbgp
d4aa45039c Add support for VOSS switches VSP-7400-48Y-8C and VSP-4900-48P (#11360)
* Update voss.yaml

* Update xos.yaml
2020-03-30 19:40:57 +02:00
Kevin Zink
b03c3bb996 Changed USV bypass state from alert to warning (#11356)
* Changed USV bypass state from alert to warning

* add /opt/librenms/tests/data/dell-ups_tower1000w.json

* add deltaups.json

* orvaldi-ups

* add generex-ups.json

* include two more generex-ups variants

* add eaton-mgeups_5px.json

* add tree more

* add istars.json

* restart hanging CI
2020-03-30 11:37:08 +02:00
Kevin Zink
ae4dae533f Cisco-Remote-Access-Monitor (#11355)
* Cisco-Remote-Access-Monitor

* add asa
2020-03-29 14:32:52 +02:00
Urth
8145e1c580 Fix bills api percentage calculation with cdr/quota of zero (#11352)
PHP allows division by zero but the api will fail when trying to encode
the response to json as reported at
https://github.com/librenms/librenms/pull/11295#issuecomment-604290389
2020-03-27 00:18:17 +01:00
Tony Murray
a59ab553be Don't show deleted ports in device overview (#11344) 2020-03-25 15:10:14 +01:00
chrisocalypse
906c337cb7 Added support for Cisco Firepower FTD 4140 (#11345) 2020-03-25 14:19:13 +01:00
cjwbath
a70313f3ee Sonus became Ribbon Communications - update logos (#11339)
* Sonus became Ribbon Communications - update logos

* minify

* Update ribbon.svg

* Create ribbon.svg

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 11:00:33 -05:00
Wheel
3e0e359f5b Ubiquiti Edgepower OS definition (#11315)
* Initial adding Ubiquiti EdgePower sensors

* Initial adding Ubiquiti EdgePower sensors

* Create airos-ep OS

* Added sensors

* Travis

* Added test / snmprec data

* Codeclimate

* minors

* Update ubnt.inc.php

* Update UBNT-EdgeMAX-MIB

* Update ubnt.inc.php

* Change Airos to EdgeOS

* Add forgotten files

* Test data

* Change os yaml

* Travis

* Update edgeos-ep.inc.php

* Create edgeos-ep.json

* Update edgeos-ep.yaml

* Update ubnt.inc.php

* Update airos.yaml

* Battery and PSU quantity not beeing displayed

* Rerun OS tests to generate json file

* Add high low temp values recommended by factory

* Add high low temp values recommended by factory

* Travis

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 09:13:04 -05:00
lucadefazio
1f37a07c36 Added cisco firepower threat defense 1120 (#11336)
added cisco firepower threat defense 1120
2020-03-24 12:53:24 +01:00
fusedsynapse
68f957e0bc Fix invalid paths introduced in librenms/librenms#9883 (#11337) 2020-03-24 12:48:18 +01:00
SourceDoctor
8263046c00 Builder View Fix for Collection Selector (#11290)
* Builder View Fix for Collection Selector

* change rule, to set priority on builder rule like in backend code

* builder key existance verification

* Update alert_rule_collection.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 12:11:12 +01:00
PipoCanaja
b29103441e Use format_hostname in dependencies list (#11333) 2020-03-23 19:39:46 +01:00
SourceDoctor
9802179030 Alert Rule - add Operator 'in' and 'not in' (#11327)
* Alert Rule - add Operator 'in' and 'not in'

* .
2020-03-23 08:36:44 -05:00
Mathieu Poussin
e320fdf1cc Better map link scaling algorithm (#11329) 2020-03-23 11:42:18 +01:00
Dan Langille
5c163a4a2f Stop using {} for arrays (#11319)
This avoids this message in ./validate.php - line numbers differ because I'm on 1.61

PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /usr/local/www/librenms/includes/functions.php on line 1833
PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /usr/local/www/librenms/includes/functions.php on line 2336
2020-03-21 14:49:15 -05:00
Urth
3aa5c15f6f Fix bills api output for period=previous (#11295)
Include static fields from the bills table in the previous period output.
Check lowercase(bill_type) because the history table uses CDR and Quota.
Update SQL IF() because the bills table always uses lowercase.

Because of these changes the calculation of the fields allowed, used,
percent and overuse for period=previous is now enabled.
2020-03-20 16:21:23 -05:00
SourceDoctor
9092988f7b Fallback to default Poller Group on delete (#11278)
* Fallback to default Poller Group on delete

* rewrite to eloquent

* replace column remove with page reload (refresh everything)

* change access verification check method

* .

* Update PollerGroups.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-20 10:16:49 +01:00
Tony Murray
0658b56c77 Fix get_rrd_dir() function (#11310)
Thanks to @n0cturnal and @doGus on Discord for fixing this!
2020-03-19 22:08:42 -05:00
pobradovic08
8fb902e4d3 Fix RRD DS name (#11304) 2020-03-19 20:16:29 -05:00
Tony Murray
6c4d53d5e5 Fix previous with rrdgraph_real_percentile (#11306)
start and end only work with DEF (and are already devined for inoctetsX and outoctetsX.
2020-03-19 20:12:29 -05:00