Commit Graph

489 Commits

Author SHA1 Message Date
Misha Komarovskiy
e670097bf6 API: Add api call to list OSPF ports (#12955)
Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
2021-06-16 20:31:05 +02:00
Kevin Zink
0489382768 Fix "Sub-directory Support" in small steps (#12910)
* Fix "Sub-directory Support" in small steps

This fixes small parts from #12205 part 3
fixes #12205

Even someone knows a better way, for example to fix js with the url() function. In my case it works.

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php
2021-06-15 08:11:18 -05:00
geg347
672fe61b5e New module add juniper rpm support + reimplementation of cisco-sla module (#12799)
* Definition of a new SLA module to migrate from old cisco-sla and support other devices : Juniper RPM and Huawei

* Change wrong description name of module SLA

* Re implementing Juniper RPM support in a new module Slas (Cisco SLA to be added)

* Added Graphs for Juniper RPM types

* Tried to make discover and poller generic : to handle Cisco SLA and Juniper RPM and others

* Reimplementing Cisco SLA in the new Sla module and adding condition to manage both SLA and RPM

* Definition of a new SLA module to migrate from old cisco-sla and support other devices : Juniper RPM and Huawei

* Change wrong description name of module SLA

* Re implementing Juniper RPM support in a new module Slas (Cisco SLA to be added)

* Added Graphs for Juniper RPM types

* Tried to make discover and poller generic : to handle Cisco SLA and Juniper RPM and others

* Reimplementing Cisco SLA in the new Sla module and adding condition to manage both SLA and RPM

* Fix some error due to Elequent object replacing SQL request

* Fixing indentation

* Fixed continuous integrations errors

* Fixed continuous integrations errors part 2

* Fixed continuous integrations errors part 3 : missing last new lines

* Fixed PHP Static Analysis checks

* Fixed continuous integrations errors part 4

* Fixed PHP Static Analysis checks part 2

* Trying to convert existing cisco-sla to new slas one

* Trying to add slas to fix test failure (I am pretty sure this is not enough but I don't know how to do it)

* Switching old cisco-sla module declaration to new slas module in concerned OS files

* Fixing wrong sla module name instead of slas in concerned OS files

* Fixing wrong module name sla changed to slas (as is it in power-supplies reimplementation)

* Fixing some warnings shown in the Inspection CI but skipping some that are already present

* Adding tests files from virtual Juniper VMX and adding slas modules in /tests/module_tables

* Adding missing SNMP data files

* Module Slas modifications to use inheritance

* Fix CI errors

* Fix CI errors part 2

* Fix CI errors part 3

* Fixing no value on RTT graphs

* Fixing only last SLA to be polled : problem with loops

* Fix CI errors part 4

* Optimizing a little the Juniper RPM poller part

I wanted to query only the required values but it is complicated to query a specific OID
as Cisco-SLA does because the owner and tag are hardcoded in ASCII decimal with strange values.
So I use the function snmp_walk which gets the whole OID values in text.
And I index the Juniper MIB (because we want multiple values). But I changed the DISMAN MIB
requests to get only what we want.

* Fix CI errors

* Fix CI errors part 2

* Fix CI errors part 3

* Fixing PHP Static Analysis error 2/4

* Fix CI errors

* Implementing Interfaces to fix some errors that occurs with inheritance

* Adding missing Interfaces files

* Moving generic Sla discovery code into Junos Class

* Fix CI errors

* Fix CI errors part 2

* Fixing missing definition of SlaDiscovery in Cisco shared Class

* Fixing missing import for Illuminate\Database\Eloquent\Collection

* Fix CI errors part 3

* Fix PHP Static Analysis error

* change type strings to use translations instead of config

* IOSXR test data

* remove test data garbage

* simplify discovery

* Fix style

* Updating test files to adapt mock sla_nr ID starting from 0 and not 1 : CI tests should pass

* clean up polling
add rtt field in the db
cisco icmpjitter seems to have confused a lot of values

* rtt on discovery

* use crc32 for consistent sla_nr values

* revert snmprec

* Fix style

* correct schema

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-06-11 13:48:33 -05:00
ottorei
69397ea70f ISIS-adjacency polling support (#12461)
* init

* Add adjacency polling support

* Format messages

* Fix prints

* Apply fixes from StyleCI

* Fix schema

* Schema fix

* Alert rule example

* Remove display format

* Change option order

* Add test data

* Add test data

* Test data

* Review fixes

* Remove duplicate MIB-file

* Add cleanup

* Fix

* Print fix

* Remove extra cleanup

* Revert "Remove duplicate MIB-file"

This reverts commit 4b3cf8127c.

* Remove unneeded MIB-files

* Add check for empty array

* Apply fixes from StyleCI

* Review fixes

* StyleCI

* StyleCI

* Apply fixes from StyleCI

* typo

* Update function calls on pages

* Linting fixes

* Apply fixes from StyleCI

* Discovery module

* Add discovery module

* Apply fixes from StyleCI

* Update example alert rule

Co-authored-by: ottorei <ottorei@users.noreply.github.com>
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2021-06-10 19:42:34 -05:00
PipoCanaja
96479ab9b9 Filter unwanted data in Routes Ajax reply (#12847)
* filter unwanted data in AJAX reply

filter unwanted data in AJAX reply

filter unwanted data in AJAX reply

filter unwanted data in AJAX reply

cleaner fix now

* add tooltips, except when text contains 'overlib' calls

* readability

DestType lost in the game

DestType lost in the game
2021-05-25 15:39:20 +02:00
Kevin Zink
32cddb979f Fix "Sub-directory Support" in small steps (#12911)
This fixes small parts from #12205 part 4
fixes #12205

BTW: This file is a very good candidate for Laravel blade. But I have no idea what to look for in LMNS.
2021-05-25 09:30:24 +02:00
Kevin Zink
21a5f756f4 Fix "Sub-directory Support" in small steps (#12905)
* Fix "Sub-directory Support" in small steps

This fixes small parts from #12205 part 2

* Update print-alert-rules.php

fix stryle

* Update print-alert-rules.php

Fix typo
2021-05-22 15:38:53 +02:00
resq
a880643ba4 updated load data (#12897) 2021-05-19 07:27:26 -05:00
Tony Murray
cb739fa2ce Fix port down alert toggle (#12884)
* Fix port down alert toggle

* Further JS fixes.
2021-05-18 07:42:15 -05:00
PipoCanaja
0a23844cd8 Revert "Additional Fix - escaped chars for graph legends (#12846)" (#12875)
This reverts commit be54aa3e6d.
2021-05-13 13:16:26 -05:00
Tony Murray
730ea3b008 Revert "Fix escaped chars for graphs legends (#12841)" (#12874)
This reverts commit 9ae652a15c.
2021-05-13 13:13:10 -05:00
Tony Murray
1bf9afb744 Fix graph argument issues (#12868)
* Fix top devices widget storage graphs
referenced the wrong graph, caused it to not work because device was not set.

* Handle feedback from rrdtool properly
2021-05-13 11:27:05 -05:00
PipoCanaja
2c8576ea79 fix arp-search remote_interface display (#12871) 2021-05-13 17:14:27 +02:00
PipoCanaja
6b18ee6dfa Fix empty label in generate_port_link (#12870) 2021-05-13 17:03:10 +02:00
Tony Murray
2d752925b0 Oxidized improvements (#12773)
* Oxidized API cleanup
Import more settings to the UI
use lnms config:set

* validate os and type exist

* map settings WIP

* oops

* editing working.  Needed to add new property to pass update state to child

* implement deleting and handle text overflow a little better.

* Update app/Models/Device.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* Update app/Models/Device.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* revert change

* fix style

* add return

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2021-05-11 08:08:59 -05:00
Tony Murray
3d62be5003 Jquery upgrade (#12802)
* WIP js upgrades

* trying 3.0

* Event handler changes

* fix alert rule collection loading

* blur fix

* jQuery 3.5
homescreen no warnings

* actually 3.6 include js

* Update bootstrap to 3.4.1

* missed file

* Update and test install process

* cleanup

* attempt to version js files that were updated.
2021-05-11 08:08:06 -05:00
PipoCanaja
fff8b8e832 Collect OUI Database and do OUI lookups (#12842)
* first draft

refresh time

refresh time

* return codes

style

style

* presentation

* Exception details

more

fix

fix

* add tooltips

fixes for dns display

* create WebUI config option

languages

* refresh data every 7 to 11 days, keep it 15 days max

* 'Ports' and 'Port' ARP table

* Stp page support

style

style

* fix dnsname column finding when vendor is added/removed

fix dnsname column finding when vendor is added/removed

* nac vendor column

nac

* filter fields to reduce size of AJAX reply

filter fields to reduce size of AJAX reply

* fix typo on dns column detection

* default enabled
2021-05-10 14:56:48 -05:00
TheGracens
be54aa3e6d Additional Fix - escaped chars for graph legends (#12846)
fix for Toner graph
2021-05-10 10:26:49 +02:00
PipoCanaja
9ae652a15c Fix escaped chars for graphs legends (#12841)
* Fix escaped chars

* more, for mempools

And more again

* overfix

* and the sensors

and more

and more

style

more

more

* wireless

* ntp

more

more wireless

And more

more

* fix mempool once more

* filesystems
2021-05-09 20:10:32 -05:00
Patrik Forsberg
e40e1069d5 Fixes to Export CSV (#12830)
* fixes to port CSV Export

Signed-off-by: Patrik Forsberg <git@paddyonline.net>

* fix code-style issues

Signed-off-by: Patrik Forsberg <git@paddyonline.net>

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-05-04 21:51:19 -05:00
Denny Friebe
1734e3af04 Fix allow_unauth_graphs (#12829) 2021-05-04 07:49:16 -05:00
Tony Murray
bb39b4ad83 Rrd graph optimizations (#12806)
* RRD Graph optimization
Do not use temporary files to generate graphs
Don't start up a process to pipe commands to, just run the command
Error image improvements

* fix style issues

* run the rrdgraph command in the rrd directory
2021-05-03 09:48:15 -05:00
Jellyfrog
4821c2b377 Prevent error when no alert rules (#12815) 2021-04-29 22:45:06 -05:00
Jellyfrog
49ec6aabd6 Bump tecnickcom/tcpdf dependency to support php 8 (#12816)
Also fix undefined variable error
2021-04-29 22:43:47 -05:00
Tony Murray
61c89794e4 Remove debug globals (#12811)
* Remove $debug global
and $vdebug global
makes these variables more accessible and protects from collisions.

* the on boot set sends application as the first parameter, just handle that

* Relocate other debug related functions

* Log debug to stdout

* Wrong output

* remove stupid constants

* Fix lint and style issues
2021-04-29 22:42:18 -05:00
Jellyfrog
76803c2acc Make applications work with rrdcached (#12807) 2021-04-28 22:00:32 -05:00
Tony Murray
7de808a4e8 Revert "RRD Graph optimization (#12735)" (#12805)
This reverts commit 2833d935e0.
2021-04-28 09:07:31 -05:00
Tony Murray
2833d935e0 RRD Graph optimization (#12735)
* RRD Graph optimization
Do not use temporary files to generate graphs
Don't start up a process to pipe commands to, just run the command
Error image improvements

* fix style issues
2021-04-28 05:28:07 -05:00
martinberg
33c7151763 Additional data collection for GAIA (#12713)
* Added support for GAIA logserver/firewall lograte, raid state and type, logserver state and testdata, firewall packet stats and connections stats

* Fixed typo

* Added testdata

* Fixed typo

* Changed some faulty strings to integers

* Added more sensors. License, HA states and Updates checks

* Added testdata

* Using snmp_get_multi. Cleaner code

* Fix rrd function usage

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-04-28 05:19:17 -05:00
Bennet Gallein
5576847c26 fix: fixing consistency accross api endpoints (#12795) 2021-04-26 21:30:30 +02:00
Simon Smith
5453163331 change printer-supplies rrd name to include the supply_type (#12792)
* Update PrinterSupplies.php

* Update toner.inc.php

* Update auth.inc.php
2021-04-25 09:16:21 -05:00
PipoCanaja
eab63ea220 webui - Services bootstrap enable + status (#12736)
* Services bootstrap enable + status

* style

* copyright

* generic create-service.inc.php to allow updates of some fields only

* generic create-service.inc.php to allow updates of some fields only
2021-04-22 19:13:39 +02:00
djamp42
97d20dd09a Make docker app work with rrdcached (#12746)
* docker app rrdcached

* offset fix and formatting fix

* more fixes

* Update Rrd.php

* Update Rrd.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2021-04-21 07:40:48 -05:00
Rob Schultz
7c157c1577 Fix auth and crypto select options (#12769)
* Fix auth and crypto select options

Output no string vs the value of $snmpv3_sha2 and $snmpv3_aes256 as this would result in <option selected1> resulting in the proper option not being selected.

* Fix style issue
2021-04-20 23:26:01 +02:00
Tony Murray
3a29198238 Fix mempool tags (#12745)
Does not affect rrd, only external tsdb
2021-04-13 21:33:07 +02:00
Tony Murray
0b617db7f5 Fix alert rules display when creating new alert template (#12731)
Doesn't clear rules from default template...
2021-04-12 02:47:08 +02:00
Tony Murray
c36fe928e4 Fix mini graphs (#12738)
Remove the polyfill, if the noscript tag isn't removed it breaks graphs
Ajax tables should not use lazy loading anyway...
2021-04-12 02:40:47 +02:00
Tony Murray
0e79413a5b escape user editable field (#12739) 2021-04-11 15:08:41 +02:00
Tony Murray
6d40871395 Fix mempools divide by 0 (#12734) 2021-04-09 11:10:02 +02:00
Tony Murray
78dd6f305c Fix bug in component table (#12730)
* Fix bug in component table

* use !empty
2021-04-08 10:27:20 -05:00
Jellyfrog
edb36fd69d More cleanups (#12715)
* PHPDoc

* Replace Auth > Illuminate\Support\Facades\Auth

* Return inside when()

* use str_replace correct

* Misc

* dead code

* use int $port

* styleci
2021-04-08 08:14:49 -05:00
Tony Murray
d34cd0a1b8 Fix ports table when unpolled ports exist (#12722)
* Fix ports table when unpolled ports exist

* fix another divide by 0
2021-04-08 11:17:53 +02:00
Rob Schultz
40517f695a Cisco AES256 support (#12717)
* Add support for net-snmp AES-256-C option

* Add AES-256-C to tests and config definition
2021-04-06 22:07:41 -05:00
Jellyfrog
dedc46b548 Fix SQL injection in rediscover-device (#12716)
Closes #12697
2021-04-06 21:57:50 -05:00
SourceDoctor
4b9e480118 Define Port Groups (#12402)
* Define Port Groups

* .

* .

* .

* API Calls

* .

* .

* .

* minor changes

* .

* update forms

* remove link

* .

* change column settings

* change migration

* change update position

* db migration fix

* .

* .

* .

* add missing doc reference

* update test data

* update test data

* update test data

* .

* .

* .

* .

* .

* .

* .

* .

* port group association in seperate table

* .

* .

* show all found groups on port

* select multiple Portgroups per Port

* change on migration file

* change query to eloquent

* Code changes

* move port group menu to ports main menu

* port group update to eloquent

* .

* .

* update to new setting way

* add missing merge parameter

* Use select2 and port some things to Laravel
some fixes, hopefully no new added bugs

* schema

* don't use on update restrict unfortunately

* remove unused import and revert changes

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-04-06 17:25:08 -05:00
Antonio Almeida
d80c19d0dd WebUI - Display interface errors per second instead of accumulated (#12613)
* Display delta errors instead of accumulated
* Interface errors rate based on polling time and with units
* After some googling changed Eps to EPS to represent errors per second

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2021-04-06 20:40:23 +02:00
PipoCanaja
422d1195c6 fix BGP tab Exception (#12672) 2021-03-29 17:44:12 -05:00
Tony Murray
1c379dcd05 Remove legacy function calls (#12651)
* massive inlines

* fix style and wtf

* remove rrdtool.inc.php include

* fix CommonFunctions namespace issues

* looking for missing class space, fix undefined class issues

* style fixes
2021-03-29 00:25:30 +02:00
Jellyfrog
e00eba327d Re-implement Printer as a class based module (#12605)
* Re-implement Printer as a class based module

* Rename toner table

* wip

* wip

* Rename to printersupplies

* Fixes

* Rename

* wip

* wip
2021-03-27 10:09:14 -05:00
Tony Murray
5e7c58aa1a Fix double escaping sysContact on device overview (#12653) 2021-03-26 16:11:29 -05:00