7 Commits

Author SHA1 Message Date
683a10e723 fix: Improve authentication load time and security (#6615)
* fix: minimize session open time
page/graphs speedup part 2

Write close the session as soon as we no longer need to write to it. Prevents the session from blocking other requests.
Do not run through full authentication functions if the session is already authenticated.
Removes password from the session as well as some items to prevent session fixation from #4608.

WARNING: This will cause issues for ad/ldap users who do not have a bind user configured!

* Do no erase username when using cookie auth.
Properly close the session in ajax_setresolution.php

* write close the session as soon as possible in ajax_setresolution.php

* Remove session regeneration. It is not compatible with the current code and would require more changes.

* Totally refactor authentication.  Extract code to functions for re-use and improved readability

* Use exceptions for authentication and error logging
Tested: mysql, ad_auth with and without bind user

* fix a couple scrutinizer issues

* fix reauthenticate in radius
2017-05-15 22:18:23 -05:00
8c639aa5a4 PSR2 Cleanup: /html edition
Travis tests for code conformance. Ignore warnings for now.
Fixed all errors, left most warnings.
2016-08-18 21:29:30 -05:00
c53e4de20c Update ajax_setresolution.php 2016-02-10 13:22:22 -08:00
2a98a2825f Update ajax_setresolution.php 2016-02-08 16:29:53 -08:00
4d6e194a52 Add reload on resize event to regenerate the graphs correctly 2015-11-26 17:35:16 +00:00
4731e8621b Correct code to match code standards 2015-11-26 17:12:38 +00:00
fc9f7eade8 Store browser height and width in session using ajax call
Modify html/includes/print-graphrow.inc.php to make use of the new Session variable
2015-11-26 17:08:39 +00:00